[GitHub] [qpid-dispatch] kgiusti opened a new pull request #474: NO-JIRA: prevent python system paths from leaking into the test envir…
kgiusti opened a new pull request #474: NO-JIRA: prevent python system paths from leaking into the test envir… URL: https://github.com/apache/qpid-dispatch/pull/474 …onment This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1280) http against https enabled listener causes segfault
[
https://issues.apache.org/jira/browse/DISPATCH-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797619#comment-16797619
]
michael goulish commented on DISPATCH-1280:
---
reproduced with simple example.
What I did:
1. from the lws code tree for 3.0.1 (7 Sep 2018,
fb31602ff9aeb88267fb8132d48df31195782ae5) use the example
minimal-examples/http-server/minimal-http-server-tls.
2. Alter the .c file this way:
info.options = LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
{color:#FF}LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT{color} ;
3. build and run it. It listens on
[https://localhost:7681|https://localhost:7681/]
4. In browser, do this request: [http://localhost:7681/index.html]
big bada boom.
#0 0x7f63281fff60 in SSL_get0_alpn_selected () from /lib64/libssl.so.1.1
#1 0x7f632880ea17 in lws_tls_server_conn_alpn () from
/usr/local/lib/libwebsockets.so.13
#2 0x7f632880ee98 in lws_server_socket_service_ssl () from
/usr/local/lib/libwebsockets.so.13
#3 0x7f632880d1ad in rops_handle_POLLIN_listen () from
/usr/local/lib/libwebsockets.so.13
#4 0x7f6328800389 in lws_service_fd_tsi () from
/usr/local/lib/libwebsockets.so.13
#5 0x7f6328816ce7 in _lws_plat_service_tsi.part.1 () from
/usr/local/lib/libwebsockets.so.13
#6 0x7f6328800455 in lws_service () from /usr/local/lib/libwebsockets.so.13
#7 0x00400965 in main (argc=1, argv=0x7fff71638b68) at
minimal-http-server-tls.c:87
Next I will see if this still happens with latest code.
> http against https enabled listener causes segfault
> ---
>
> Key: DISPATCH-1280
> URL: https://issues.apache.org/jira/browse/DISPATCH-1280
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: michael goulish
>Priority: Major
>
> If you have a listener with http enabled, an ssl profile referenced, but
> requireSsl set to false, and then try to access it over plain http, you get a
> segfault in libwebsockets if using version 3.0.1-2. Downgrading to 2.4.2 of
> libwebsockets fixes this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1280) http against https enabled listener causes segfault
[ https://issues.apache.org/jira/browse/DISPATCH-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797575#comment-16797575 ] michael goulish commented on DISPATCH-1280: --- Looked at closed issues back to release date of v2.4.2 (8 March 2018). Nothing looks like the issue we are seeing. Closed issues are here: https://github.com/warmcat/libwebsockets/issues?page=11=is%3Aissue+is%3Aclosed > http against https enabled listener causes segfault > --- > > Key: DISPATCH-1280 > URL: https://issues.apache.org/jira/browse/DISPATCH-1280 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: michael goulish >Priority: Major > > If you have a listener with http enabled, an ssl profile referenced, but > requireSsl set to false, and then try to access it over plain http, you get a > segfault in libwebsockets if using version 3.0.1-2. Downgrading to 2.4.2 of > libwebsockets fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1297) Fix buffer reference counting for multiframe fanout messages
[ https://issues.apache.org/jira/browse/DISPATCH-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797574#comment-16797574 ] ASF GitHub Bot commented on DISPATCH-1297: -- kgiusti commented on pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting URL: https://github.com/apache/qpid-dispatch/pull/473 The older code did not correctly account for the loss of a multicast consumer. It could end up releasing a buffer before it was sent to all consumers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix buffer reference counting for multiframe fanout messages > > > Key: DISPATCH-1297 > URL: https://issues.apache.org/jira/browse/DISPATCH-1297 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.6.0 > > > The current reference counting implementation doesn't take into account the > loss of a fanout consumer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting
kgiusti opened a new pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting URL: https://github.com/apache/qpid-dispatch/pull/473 The older code did not correctly account for the loss of a multicast consumer. It could end up releasing a buffer before it was sent to all consumers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1285) Router crashes occasionally on system_tests_delivery_abort
[
https://issues.apache.org/jira/browse/DISPATCH-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797567#comment-16797567
]
ASF GitHub Bot commented on DISPATCH-1285:
--
ganeshmurthy commented on pull request #471: DISPATCH-1285 - Added a deferred
call count and detached flag on qd_l…
URL: https://github.com/apache/qpid-dispatch/pull/471
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Router crashes occasionally on system_tests_delivery_abort
> --
>
> Key: DISPATCH-1285
> URL: https://issues.apache.org/jira/browse/DISPATCH-1285
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> The router occasionally crashes with the following backtrace when running
> system_tests_delivery_abort. Dont run the test independently, run it as part
> of the test suite using ctest -VV
>
> {noformat}
> (gdb) bt
> #0 0x7f3f763d8aaf in qd_link_get_node_context (link=0x7f3f580b40e8) at
> /home/gmurthy/opensource/qpid-dispatch/src/container.c:1053
> #1 0x7f3f7642595f in deferred_AMQP_rx_handler (context=0x7f3f580b40e8,
> discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/router_node.c:640
> #2 0x7f3f7642bf02 in invoke_deferred_calls (conn=0x1b5a568,
> discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/server.c:728
> #3 0x7f3f7642c9c2 in handle (qd_server=0x1a0f5b0, e=0x7f3f58093520,
> pn_conn=0x1bf4e40, ctx=0x1b5a568) at
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:961
> #4 0x7f3f7642cd2a in thread_run (arg=0x1a0f5b0) at
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:1017
> #5 0x7f3f7632258e in start_thread () from /lib64/libpthread.so.0
> #6 0x7f3f75dca6a3 in clone () from /lib64/libc.so.6
> (gdb){noformat}
>
> Here is the output from the test -
> {noformat}
> 40: Test command: /usr/bin/python
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "unit2" "-v"
> "system_tests_delivery_abort"
> 40: Test timeout computed to be: 1500
> 40: test_01_message_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok
> 40: test_02_message_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok
> 40: test_03_link_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok
> 40: test_04_link_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: test_06_message_route_abort_two_routers
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: ERROR
> 40:
> 40: ==
> 40: ERROR: test_04_link_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest)
> 40: --
> 40: Traceback (most recent call last):
> 40: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py",
> line 101, in test_04_link_route_truncated_two_routers
> 40: test.run()
> 40: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py",
> line 390, in run
> 40: container.run()
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py",
> line 181, in run
> 40: while self.process(): pass
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py",
> line 240, in process
> 40: event.dispatch(self._global_handler)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 135, in dispatch
> 40: _dispatch(handler, type.method, self)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 117, in _dispatch
> 40: handler.on_unhandled(method, *args)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py",
> line 665, in on_unhandled
> 40: event.dispatch(self.base)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 135, in dispatch
> 40: _dispatch(handler, type.method, self)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
>
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #471: DISPATCH-1285 - Added a deferred call count and detached flag on qd_l…
ganeshmurthy closed pull request #471: DISPATCH-1285 - Added a deferred call count and detached flag on qd_l… URL: https://github.com/apache/qpid-dispatch/pull/471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1280) http against https enabled listener causes segfault
[ https://issues.apache.org/jira/browse/DISPATCH-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797474#comment-16797474 ] Gordon Sim commented on DISPATCH-1280: -- Yes, on 3.0.1-2 it happened every time for me. There is also a test that hits it and again on that version it always fails for me. ctest -V -R http > http against https enabled listener causes segfault > --- > > Key: DISPATCH-1280 > URL: https://issues.apache.org/jira/browse/DISPATCH-1280 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: michael goulish >Priority: Major > > If you have a listener with http enabled, an ssl profile referenced, but > requireSsl set to false, and then try to access it over plain http, you get a > segfault in libwebsockets if using version 3.0.1-2. Downgrading to 2.4.2 of > libwebsockets fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1275) Enable deletion of connections based on connection id
[
https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-1275:
Description:
Sometimes there is a need to delete/kill certain connections on which there are
slow consumers or consumers that won't acknowledge messages.
Add functionality to the router server side code that will allow users to
delete connections based on the connection id. The connection id can be
obtained from the output of--
{noformat}
qdstat -c{noformat}
or
{noformat}
qdmanage QUERY --type=connection{noformat}
This JIRA involves the following tasks
# Add two fields, adminStatus and operStatus to the *connection* entity in the
router schema. Possible connection adminStatues are *enabled* and *deleted.*
Possible operStatuses are *up*
# Modify the router's c-management agent to respond to a UPDATE management
request. A connection id must be provided to update a connection
(adminStatus=deleted). When a client deletes a connection object, the
connection to the peer is terminated by the router. Client will not be allowed
to terminate inter-router connections.
# Add policy control over who is permitted to write adminStatus (add a new
flag at the policy group level called allowAdminStatusUpdate)
was:
Sometimes there is a need to delete/kill certain connections on which there are
slow consumers or consumers that won't acknowledge messages.
Add functionality to the router server side code that will allow users to
delete connections based on the connection id. The connection id can be
obtained from the output of--
{noformat}
qdstat -c{noformat}
or
{noformat}
qdmanage QUERY --type=connection{noformat}
This JIRA involves the following tasks
# Add two fields, adminStatus and operStatus to the *connection* entity in the
router schema. Possible connection adminStatues are *enabled* and *deleted.*
Possible operStatuses are *up*
# Modify the router's c-management agent to respond to a DELETE management
request. A connection id must be provided to delete a connection. When a client
deletes a connection object, the connection to the peer is terminated by the
router. Client will not be allowed to terminate inter-router connections.
# Add policy control over who is permitted to write adminStatus (add a new
flag at the policy group level called allowAdminStatusUpdate)
> Enable deletion of connections based on connection id
> -
>
> Key: DISPATCH-1275
> URL: https://issues.apache.org/jira/browse/DISPATCH-1275
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> Sometimes there is a need to delete/kill certain connections on which there
> are slow consumers or consumers that won't acknowledge messages.
> Add functionality to the router server side code that will allow users to
> delete connections based on the connection id. The connection id can be
> obtained from the output of--
> {noformat}
> qdstat -c{noformat}
> or
> {noformat}
> qdmanage QUERY --type=connection{noformat}
> This JIRA involves the following tasks
> # Add two fields, adminStatus and operStatus to the *connection* entity in
> the router schema. Possible connection adminStatues are *enabled* and
> *deleted.* Possible operStatuses are *up*
> # Modify the router's c-management agent to respond to a UPDATE management
> request. A connection id must be provided to update a connection
> (adminStatus=deleted). When a client deletes a connection object, the
> connection to the peer is terminated by the router. Client will not be
> allowed to terminate inter-router connections.
> # Add policy control over who is permitted to write adminStatus (add a new
> flag at the policy group level called allowAdminStatusUpdate)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[
https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797436#comment-16797436
]
ASF GitHub Bot commented on DISPATCH-1275:
--
codecov-io commented on issue #467: DISPATCH-1275 - Enabled deletion of
connections based on connection i…
URL: https://github.com/apache/qpid-dispatch/pull/467#issuecomment-474978648
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=h1)
Report
> Merging
[#467](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/136940b55a6c0d269726f27e3c0087deafa492e5?src=pr=desc)
will **increase** coverage by `0.19%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=tree)
```diff
@@Coverage Diff @@
## master #467 +/- ##
==
+ Coverage 86.69% 86.88% +0.19%
==
Files 86 86
Lines 1908619175 +89
==
+ Hits1654616660 +114
+ Misses 2540 2515 -25
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL2FtcXAuYw==)
| `0% <ø> (ø)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.26% <100%> (+0.07%)` | :arrow_up: |
|
[src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3BvbGljeS5j)
| `85.31% <100%> (+0.02%)` | :arrow_up: |
|
[src/router\_core/agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50LmM=)
| `87.5% <100%> (+8.59%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `79.03% <100%> (-0.6%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.6% <100%> (+0.05%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=)
| `87.9% <50%> (-0.39%)` | :arrow_down: |
|
[src/router\_core/agent\_connection.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2Nvbm5lY3Rpb24uYw==)
| `82.88% <73.77%> (+5.86%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `91.25% <0%> (-0.29%)` | :arrow_down: |
| ... and [7
more](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree-more)
| |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=footer).
Last update
[136940b...f517868](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable deletion of connections based on connection id
> -
>
> Key: DISPATCH-1275
> URL: https://issues.apache.org/jira/browse/DISPATCH-1275
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> Sometimes there is a need to delete/kill certain connections on which there
> are slow consumers or consumers that won't acknowledge messages.
> Add functionality to the router server side code that will allow users to
> delete connections based on the connection id. The connection id can be
> obtained from the output of--
> {noformat}
> qdstat
[GitHub] [qpid-dispatch] codecov-io commented on issue #467: DISPATCH-1275 - Enabled deletion of connections based on connection i…
codecov-io commented on issue #467: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/467#issuecomment-474978648 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=h1) Report > Merging [#467](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/136940b55a6c0d269726f27e3c0087deafa492e5?src=pr=desc) will **increase** coverage by `0.19%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=tree) ```diff @@Coverage Diff @@ ## master #467 +/- ## == + Coverage 86.69% 86.88% +0.19% == Files 86 86 Lines 1908619175 +89 == + Hits1654616660 +114 + Misses 2540 2515 -25 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL2FtcXAuYw==) | `0% <ø> (ø)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.26% <100%> (+0.07%)` | :arrow_up: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3BvbGljeS5j) | `85.31% <100%> (+0.02%)` | :arrow_up: | | [src/router\_core/agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50LmM=) | `87.5% <100%> (+8.59%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `79.03% <100%> (-0.6%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.6% <100%> (+0.05%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.9% <50%> (-0.39%)` | :arrow_down: | | [src/router\_core/agent\_connection.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2Nvbm5lY3Rpb24uYw==) | `82.88% <73.77%> (+5.86%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.25% <0%> (-0.29%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=footer). Last update [136940b...f517868](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1280) http against https enabled listener causes segfault
[ https://issues.apache.org/jira/browse/DISPATCH-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797391#comment-16797391 ] michael goulish commented on DISPATCH-1280: --- It sounds like this happens all the time. Is that true? Not a rare occurrence? > http against https enabled listener causes segfault > --- > > Key: DISPATCH-1280 > URL: https://issues.apache.org/jira/browse/DISPATCH-1280 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: michael goulish >Priority: Major > > If you have a listener with http enabled, an ssl profile referenced, but > requireSsl set to false, and then try to access it over plain http, you get a > segfault in libwebsockets if using version 3.0.1-2. Downgrading to 2.4.2 of > libwebsockets fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-447) Make Source.setDurable available
[
https://issues.apache.org/jira/browse/QPIDJMS-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797379#comment-16797379
]
ASF GitHub Bot commented on QPIDJMS-447:
motmot80 commented on pull request #28: QPIDJMS-447 MessageProducer support for
target.durable
URL: https://github.com/apache/qpid-jms/pull/28
If it does not fulfil quality requirements it maybe will help to understand
the issue.
Best regards
Thomas
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make Source.setDurable available
> -
>
> Key: QPIDJMS-447
> URL: https://issues.apache.org/jira/browse/QPIDJMS-447
> Project: Qpid JMS
> Issue Type: Improvement
> Components: qpid-jms-client
>Affects Versions: 0.39.0, 0.40.0
> Environment: Broker: RabbitMQ 3.7.5 with amqpv1 plugin
> Client: QPID-JMS 0.39, 0.40
>
>Reporter: Thomas Stollenwerk
>Priority: Major
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Right now it is not possible to set the "durable" field of an amqp "target"
> by QPID-JMS
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-terminus-durability]
> We are using RabbitMQ 3.7.5 with it's amqp v1.0 plugin. Without this option
> it's not possible to produce messages to a durable queue using QPID-JMS.
> Attaching to a durable queue results in:
> {{
> {'v1_0.error',\\{symbol,<<"amqp:precondition-failed">>}
> ,{utf8,<<"PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'HOST'
> in vhost '/': {color:#ff}received 'false' but current is
> 'true'{color}">>},undefined}}}
> {{Using qpid or amqpnetlite with durable = *TerminusDurability.CONFIGURATION*
> (1) works fine.}}
>
> *AmqpProducerBuilder.createEndpoint* should set the *Source.setDurable*
> option like
> *AmqpConsumerBuilder.configureSource* does. Maybe by adding *setDurable* to
> *JmsDestination* passed to *JmsProducerInfo*.
>
> Setting it to "false" by default should not break any existing
> implementations.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-jms] motmot80 opened a new pull request #28: QPIDJMS-447 MessageProducer support for target.durable
motmot80 opened a new pull request #28: QPIDJMS-447 MessageProducer support for target.durable URL: https://github.com/apache/qpid-jms/pull/28 If it does not fulfil quality requirements it maybe will help to understand the issue. Best regards Thomas This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1296) Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption()
[ https://issues.apache.org/jira/browse/DISPATCH-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1296. Resolution: Fixed > Change use of pn_ssl_domain_allow_unsecured_client() to > pn_transport_require_encryption() > - > > Key: DISPATCH-1296 > URL: https://issues.apache.org/jira/browse/DISPATCH-1296 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ted Ross >Assignee: Andrew Stitcher >Priority: Major > Fix For: 1.6.0 > > > Remove use of the deprecated pn_ssl_domain_allow_unsecured_client() API. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-447) Make Source.setDurable available
Thomas Stollenwerk created QPIDJMS-447:
--
Summary: Make Source.setDurable available
Key: QPIDJMS-447
URL: https://issues.apache.org/jira/browse/QPIDJMS-447
Project: Qpid JMS
Issue Type: Improvement
Components: qpid-jms-client
Affects Versions: 0.40.0, 0.39.0
Environment: Broker: RabbitMQ 3.7.5 with amqpv1 plugin
Client: QPID-JMS 0.39, 0.40
Reporter: Thomas Stollenwerk
Right now it is not possible to set the "durable" field of an amqp "target" by
QPID-JMS
[http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-terminus-durability]
We are using RabbitMQ 3.7.5 with it's amqp v1.0 plugin. Without this option
it's not possible to produce messages with to a durable queue using QPID-JMS.
Attaching to a durable queue results in:
{{{'v1_0.error',\{symbol,<<"amqp:precondition-failed">>},{utf8,<<"PRECONDITION_FAILED
- inequivalent arg 'durable' for queue 'HOST' in vhost '/':
{color:#FF}received 'false' but current is 'true'{color}">>},undefined}}}
{{Using qpid or amqpnetlite with durable = *TerminusDurability.CONFIGURATION*
(1) works fine.}}
*AmqpProducerBuilder.createEndpoint* should set the *Source.setDurable* option
like
*AmqpConsumerBuilder.configureSource* does. Maybe by adding *setDurable* to
*JmsDestination* passed to *JmsProducerInfo*.
Setting it to "false" by default should not break any existing implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPIDJMS-447) Make Source.setDurable available
[
https://issues.apache.org/jira/browse/QPIDJMS-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Stollenwerk updated QPIDJMS-447:
---
Description:
Right now it is not possible to set the "durable" field of an amqp "target" by
QPID-JMS
[http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-terminus-durability]
We are using RabbitMQ 3.7.5 with it's amqp v1.0 plugin. Without this option
it's not possible to produce messages to a durable queue using QPID-JMS.
Attaching to a durable queue results in:
{{
{'v1_0.error',\\{symbol,<<"amqp:precondition-failed">>}
,{utf8,<<"PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'HOST' in
vhost '/': {color:#ff}received 'false' but current is
'true'{color}">>},undefined}}}
{{Using qpid or amqpnetlite with durable = *TerminusDurability.CONFIGURATION*
(1) works fine.}}
*AmqpProducerBuilder.createEndpoint* should set the *Source.setDurable* option
like
*AmqpConsumerBuilder.configureSource* does. Maybe by adding *setDurable* to
*JmsDestination* passed to *JmsProducerInfo*.
Setting it to "false" by default should not break any existing implementations.
was:
Right now it is not possible to set the "durable" field of an amqp "target" by
QPID-JMS
[http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-terminus-durability]
We are using RabbitMQ 3.7.5 with it's amqp v1.0 plugin. Without this option
it's not possible to produce messages with to a durable queue using QPID-JMS.
Attaching to a durable queue results in:
{{{'v1_0.error',\{symbol,<<"amqp:precondition-failed">>},{utf8,<<"PRECONDITION_FAILED
- inequivalent arg 'durable' for queue 'HOST' in vhost '/':
{color:#FF}received 'false' but current is 'true'{color}">>},undefined}}}
{{Using qpid or amqpnetlite with durable = *TerminusDurability.CONFIGURATION*
(1) works fine.}}
*AmqpProducerBuilder.createEndpoint* should set the *Source.setDurable* option
like
*AmqpConsumerBuilder.configureSource* does. Maybe by adding *setDurable* to
*JmsDestination* passed to *JmsProducerInfo*.
Setting it to "false" by default should not break any existing implementations.
> Make Source.setDurable available
> -
>
> Key: QPIDJMS-447
> URL: https://issues.apache.org/jira/browse/QPIDJMS-447
> Project: Qpid JMS
> Issue Type: Improvement
> Components: qpid-jms-client
>Affects Versions: 0.39.0, 0.40.0
> Environment: Broker: RabbitMQ 3.7.5 with amqpv1 plugin
> Client: QPID-JMS 0.39, 0.40
>
>Reporter: Thomas Stollenwerk
>Priority: Major
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Right now it is not possible to set the "durable" field of an amqp "target"
> by QPID-JMS
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-terminus-durability]
> We are using RabbitMQ 3.7.5 with it's amqp v1.0 plugin. Without this option
> it's not possible to produce messages to a durable queue using QPID-JMS.
> Attaching to a durable queue results in:
> {{
> {'v1_0.error',\\{symbol,<<"amqp:precondition-failed">>}
> ,{utf8,<<"PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'HOST'
> in vhost '/': {color:#ff}received 'false' but current is
> 'true'{color}">>},undefined}}}
> {{Using qpid or amqpnetlite with durable = *TerminusDurability.CONFIGURATION*
> (1) works fine.}}
>
> *AmqpProducerBuilder.createEndpoint* should set the *Source.setDurable*
> option like
> *AmqpConsumerBuilder.configureSource* does. Maybe by adding *setDurable* to
> *JmsDestination* passed to *JmsProducerInfo*.
>
> Setting it to "false" by default should not break any existing
> implementations.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #472: Dispatch 1288 1 - policy for outbound connectors
codecov-io edited a comment on issue #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#issuecomment-474588568 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=h1) Report > Merging [#472](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/bdafbbe02f2762ec3c38bc254e59c3efa9b23c9e?src=pr=desc) will **increase** coverage by `0.18%`. > The diff coverage is `97.4%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=tree) ```diff @@Coverage Diff @@ ## master #472 +/- ## == + Coverage 86.68% 86.87% +0.18% == Files 86 86 Lines 1908819128 +40 == + Hits1654716618 +71 + Misses 2541 2510 -31 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `79.43% <100%> (+0.56%)` | :arrow_up: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `89.36% <100%> (+0.04%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.87% <100%> (+0.17%)` | :arrow_up: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3BvbGljeS5j) | `85.75% <97.14%> (+0.46%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `88.29% <0%> (-0.26%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.88% <0%> (-0.22%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.45% <0%> (-0.22%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.52% <0%> (+0.51%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=footer). Last update [bdafbbe...8146cb3](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1296) Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption()
[ https://issues.apache.org/jira/browse/DISPATCH-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797340#comment-16797340 ] ASF subversion and git services commented on DISPATCH-1296: --- Commit 136940b55a6c0d269726f27e3c0087deafa492e5 in qpid-dispatch's branch refs/heads/master from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=136940b ] DISPATCH-1296 - Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption() This closes #469 - pn_ssl_domain_unsecured_client() is deprecated and may be removed. > Change use of pn_ssl_domain_allow_unsecured_client() to > pn_transport_require_encryption() > - > > Key: DISPATCH-1296 > URL: https://issues.apache.org/jira/browse/DISPATCH-1296 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ted Ross >Assignee: Andrew Stitcher >Priority: Major > Fix For: 1.6.0 > > > Remove use of the deprecated pn_ssl_domain_allow_unsecured_client() API. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #469: Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption()
asfgit closed pull request #469: Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption() URL: https://github.com/apache/qpid-dispatch/pull/469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1296) Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption()
Ted Ross created DISPATCH-1296: -- Summary: Change use of pn_ssl_domain_allow_unsecured_client() to pn_transport_require_encryption() Key: DISPATCH-1296 URL: https://issues.apache.org/jira/browse/DISPATCH-1296 Project: Qpid Dispatch Issue Type: Improvement Components: Container Reporter: Ted Ross Assignee: Andrew Stitcher Fix For: 1.6.0 Remove use of the deprecated pn_ssl_domain_allow_unsecured_client() API. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
