[jira] [Commented] (DISPATCH-1407) Memory leak on link policy denial
[
https://issues.apache.org/jira/browse/DISPATCH-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924677#comment-16924677
]
Gordon Sim commented on DISPATCH-1407:
--
When link attach fails on policy, the pn_link_t does not have a corresponding
qd_link_t created. This means the link is not freed when the peer responds to
the detach. Possible fix:
{noformat}
diff --git a/src/container.c b/src/container.c
index 22a42867..303beab9 100644
--- a/src/container.c
+++ b/src/container.c
@@ -617,6 +617,8 @@ void qd_container_handle_event(qd_container_t *container,
pn_event_t *event,
if (node) {
node->ntype->link_detach_handler(node->context, qd_link,
dt);
}
+} else {
+pn_link_free(pn_link);
}
}
break;
{noformat}
> Memory leak on link policy denial
> -
>
> Key: DISPATCH-1407
> URL: https://issues.apache.org/jira/browse/DISPATCH-1407
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
> Attachments: A.conf, default.json
>
>
> A router with a simple policy that denies most addresses starts and uses 10M
> bytes of memory. A test client loops 25k times opening a link to a denied
> address over a single connection and session. Now the router uses 276 Mbytes.
> An example policy is
> ```
> [
>["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
>"$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "$management, examples, q1",
> "targets": "$management, examples, q1"
>}
> }
>}]
> ]
> ```
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1410) attach of auto-links not logged
[
https://issues.apache.org/jira/browse/DISPATCH-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1410.
-
Fix Version/s: 1.9.0
Resolution: Fixed
> attach of auto-links not logged
> ---
>
> Key: DISPATCH-1410
> URL: https://issues.apache.org/jira/browse/DISPATCH-1410
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.9.0
>
>
> The router logs have helpful lines for link attach and detach. However for
> autolinks, there is no attach only detach. You can see this in the log below
> where [C3][L6] and [C3][L7] show the start and end of the link, but [C1][L5]
> and [C2][L4] show only the end of the link. Would be helpful to have both
> even for autolinks.
> {noformat}
> 2019-09-06 21:31:47.039735 +0100 ROUTER (info) In-process subscription
> L/qdhello
> 2019-09-06 21:31:47.048500 +0100 AGENT (info) Activating management agent on
> $_management_internal
> 2019-09-06 21:31:47.048551 +0100 ROUTER (info) In-process subscription
> L/$_management_internal
> 2019-09-06 21:31:47.048798 +0100 POLICY (info) Policy configured
> maxConnections: 65535, policyDir: '',access rules enabled: 'false', use
> hostname patterns: 'false'
> 2019-09-06 21:31:47.049394 +0100 POLICY (info) Policy fallback defaultVhost
> is defined: '$default'
> 2019-09-06 21:31:47.049625 +0100 CONN_MGR (info) Configured Listener:
> 0.0.0.0:amqp proto=any, role=normal
> 2019-09-06 21:31:47.050443 +0100 CONN_MGR (info) Configured Listener:
> 0.0.0.0:55672 proto=any, role=inter-router
> 2019-09-06 21:31:47.051275 +0100 CONN_MGR (info) Configured Connector:
> 0.0.0.0: proto=any, role=route-container
> 2019-09-06 21:31:47.051954 +0100 CONN_MGR (info) Configured Connector:
> 0.0.0.0: proto=any, role=route-container
> 2019-09-06 21:31:47.054214 +0100 SERVER (notice) Operational, 4 Threads
> Running (process ID 32593)
> 2019-09-06 21:31:47.054407 +0100 SERVER (notice) Listening on 0.0.0.0:55672
> 2019-09-06 21:31:47.054486 +0100 SERVER (notice) Listening on 0.0.0.0:amqp
> 2019-09-06 21:31:47.058441 +0100 ROUTER (info) [C2] Connection Opened:
> dir=out host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
> container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
> :version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
> 2019-09-06 21:31:47.058490 +0100 ROUTER (info) Auto Link Activated
> 'autoLink/0' on connection broker-in
> 2019-09-06 21:31:47.058603 +0100 ROUTER (info) [C1] Connection Opened:
> dir=out host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
> container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
> :version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
> 2019-09-06 21:31:47.058702 +0100 ROUTER (info) Auto Link Activated
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:31:58.142937 +0100 SERVER (info) [C3] Accepted connection to
> 0.0.0.0:amqp from 127.0.0.1:38032
> 2019-09-06 21:31:58.145620 +0100 ROUTER (info) [C3] Connection Opened: dir=in
> host=127.0.0.1:38032 vhost= encrypted=no auth=ANONYMOUS user=anonymous
> container_id=80a6aa13-40c4-437c-8c78-37a838d5afb5 props=
> 2019-09-06 21:31:58.145806 +0100 ROUTER (info) [C3][L6] Link attached:
> dir=out source={examples expire:sess} target={ expire:sess}
> 2019-09-06 21:31:58.145841 +0100 ROUTER (info) [C3][L7] Link attached: dir=in
> source={ expire:sess} target={examples expire:sess}
> 2019-09-06 21:31:58.146791 +0100 ROUTER (info) [C3][L7] Link detached: del=1
> presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:31:58.147801 +0100 ROUTER (info) [C3][L6] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:31:58.147820 +0100 ROUTER (info) [C3] Connection Closed
> 2019-09-06 21:32:08.201325 +0100 SERVER (info) [C1] Connection to
> 0.0.0.0: failed: amqp:connection:framing-error connection aborted
> 2019-09-06 21:32:08.201510 +0100 ROUTER (info) Auto Link Activation Failed.
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:32:08.201551 +0100 ROUTER (info) [C1][L5] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:32:08.201570 +0100 ROUTER (info) Auto Link Deactivated
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:32:08.201585 +0100 ROUTER (info) [C1] Connection Closed
> 2019-09-06 21:32:08.201879 +0100 SERVER (info) [C2] Connection to
> 0.0.0.0: failed: amqp:connection:framing-error connection aborted
> 2019-09-06 21:32:08.201961 +0100 ROUTER (info) Auto Link Activation Failed.
> 'autoLink/0' on connection broker-in
> 2019-09-06 21:32:08.201987 +0100 ROUTER (info) [C2][L4] Link lost: del=1
> presett=0
[jira] [Assigned] (DISPATCH-1410) attach of auto-links not logged
[
https://issues.apache.org/jira/browse/DISPATCH-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy reassigned DISPATCH-1410:
---
Assignee: Ganesh Murthy
> attach of auto-links not logged
> ---
>
> Key: DISPATCH-1410
> URL: https://issues.apache.org/jira/browse/DISPATCH-1410
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
>
> The router logs have helpful lines for link attach and detach. However for
> autolinks, there is no attach only detach. You can see this in the log below
> where [C3][L6] and [C3][L7] show the start and end of the link, but [C1][L5]
> and [C2][L4] show only the end of the link. Would be helpful to have both
> even for autolinks.
> {noformat}
> 2019-09-06 21:31:47.039735 +0100 ROUTER (info) In-process subscription
> L/qdhello
> 2019-09-06 21:31:47.048500 +0100 AGENT (info) Activating management agent on
> $_management_internal
> 2019-09-06 21:31:47.048551 +0100 ROUTER (info) In-process subscription
> L/$_management_internal
> 2019-09-06 21:31:47.048798 +0100 POLICY (info) Policy configured
> maxConnections: 65535, policyDir: '',access rules enabled: 'false', use
> hostname patterns: 'false'
> 2019-09-06 21:31:47.049394 +0100 POLICY (info) Policy fallback defaultVhost
> is defined: '$default'
> 2019-09-06 21:31:47.049625 +0100 CONN_MGR (info) Configured Listener:
> 0.0.0.0:amqp proto=any, role=normal
> 2019-09-06 21:31:47.050443 +0100 CONN_MGR (info) Configured Listener:
> 0.0.0.0:55672 proto=any, role=inter-router
> 2019-09-06 21:31:47.051275 +0100 CONN_MGR (info) Configured Connector:
> 0.0.0.0: proto=any, role=route-container
> 2019-09-06 21:31:47.051954 +0100 CONN_MGR (info) Configured Connector:
> 0.0.0.0: proto=any, role=route-container
> 2019-09-06 21:31:47.054214 +0100 SERVER (notice) Operational, 4 Threads
> Running (process ID 32593)
> 2019-09-06 21:31:47.054407 +0100 SERVER (notice) Listening on 0.0.0.0:55672
> 2019-09-06 21:31:47.054486 +0100 SERVER (notice) Listening on 0.0.0.0:amqp
> 2019-09-06 21:31:47.058441 +0100 ROUTER (info) [C2] Connection Opened:
> dir=out host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
> container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
> :version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
> 2019-09-06 21:31:47.058490 +0100 ROUTER (info) Auto Link Activated
> 'autoLink/0' on connection broker-in
> 2019-09-06 21:31:47.058603 +0100 ROUTER (info) [C1] Connection Opened:
> dir=out host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
> container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
> :version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
> 2019-09-06 21:31:47.058702 +0100 ROUTER (info) Auto Link Activated
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:31:58.142937 +0100 SERVER (info) [C3] Accepted connection to
> 0.0.0.0:amqp from 127.0.0.1:38032
> 2019-09-06 21:31:58.145620 +0100 ROUTER (info) [C3] Connection Opened: dir=in
> host=127.0.0.1:38032 vhost= encrypted=no auth=ANONYMOUS user=anonymous
> container_id=80a6aa13-40c4-437c-8c78-37a838d5afb5 props=
> 2019-09-06 21:31:58.145806 +0100 ROUTER (info) [C3][L6] Link attached:
> dir=out source={examples expire:sess} target={ expire:sess}
> 2019-09-06 21:31:58.145841 +0100 ROUTER (info) [C3][L7] Link attached: dir=in
> source={ expire:sess} target={examples expire:sess}
> 2019-09-06 21:31:58.146791 +0100 ROUTER (info) [C3][L7] Link detached: del=1
> presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:31:58.147801 +0100 ROUTER (info) [C3][L6] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:31:58.147820 +0100 ROUTER (info) [C3] Connection Closed
> 2019-09-06 21:32:08.201325 +0100 SERVER (info) [C1] Connection to
> 0.0.0.0: failed: amqp:connection:framing-error connection aborted
> 2019-09-06 21:32:08.201510 +0100 ROUTER (info) Auto Link Activation Failed.
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:32:08.201551 +0100 ROUTER (info) [C1][L5] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:32:08.201570 +0100 ROUTER (info) Auto Link Deactivated
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:32:08.201585 +0100 ROUTER (info) [C1] Connection Closed
> 2019-09-06 21:32:08.201879 +0100 SERVER (info) [C2] Connection to
> 0.0.0.0: failed: amqp:connection:framing-error connection aborted
> 2019-09-06 21:32:08.201961 +0100 ROUTER (info) Auto Link Activation Failed.
> 'autoLink/0' on connection broker-in
> 2019-09-06 21:32:08.201987 +0100 ROUTER (info) [C2][L4] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
[jira] [Commented] (DISPATCH-1410) attach of auto-links not logged
[
https://issues.apache.org/jira/browse/DISPATCH-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924660#comment-16924660
]
ASF subversion and git services commented on DISPATCH-1410:
---
Commit 34a02c99234b4c082105e7123113ba062f6afbe2 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=34a02c9 ]
DISPATCH-1410 - Added INFO logging to links that the router creates like auto
links
> attach of auto-links not logged
> ---
>
> Key: DISPATCH-1410
> URL: https://issues.apache.org/jira/browse/DISPATCH-1410
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> The router logs have helpful lines for link attach and detach. However for
> autolinks, there is no attach only detach. You can see this in the log below
> where [C3][L6] and [C3][L7] show the start and end of the link, but [C1][L5]
> and [C2][L4] show only the end of the link. Would be helpful to have both
> even for autolinks.
> {noformat}
> 2019-09-06 21:31:47.039735 +0100 ROUTER (info) In-process subscription
> L/qdhello
> 2019-09-06 21:31:47.048500 +0100 AGENT (info) Activating management agent on
> $_management_internal
> 2019-09-06 21:31:47.048551 +0100 ROUTER (info) In-process subscription
> L/$_management_internal
> 2019-09-06 21:31:47.048798 +0100 POLICY (info) Policy configured
> maxConnections: 65535, policyDir: '',access rules enabled: 'false', use
> hostname patterns: 'false'
> 2019-09-06 21:31:47.049394 +0100 POLICY (info) Policy fallback defaultVhost
> is defined: '$default'
> 2019-09-06 21:31:47.049625 +0100 CONN_MGR (info) Configured Listener:
> 0.0.0.0:amqp proto=any, role=normal
> 2019-09-06 21:31:47.050443 +0100 CONN_MGR (info) Configured Listener:
> 0.0.0.0:55672 proto=any, role=inter-router
> 2019-09-06 21:31:47.051275 +0100 CONN_MGR (info) Configured Connector:
> 0.0.0.0: proto=any, role=route-container
> 2019-09-06 21:31:47.051954 +0100 CONN_MGR (info) Configured Connector:
> 0.0.0.0: proto=any, role=route-container
> 2019-09-06 21:31:47.054214 +0100 SERVER (notice) Operational, 4 Threads
> Running (process ID 32593)
> 2019-09-06 21:31:47.054407 +0100 SERVER (notice) Listening on 0.0.0.0:55672
> 2019-09-06 21:31:47.054486 +0100 SERVER (notice) Listening on 0.0.0.0:amqp
> 2019-09-06 21:31:47.058441 +0100 ROUTER (info) [C2] Connection Opened:
> dir=out host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
> container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
> :version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
> 2019-09-06 21:31:47.058490 +0100 ROUTER (info) Auto Link Activated
> 'autoLink/0' on connection broker-in
> 2019-09-06 21:31:47.058603 +0100 ROUTER (info) [C1] Connection Opened:
> dir=out host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
> container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
> :version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
> 2019-09-06 21:31:47.058702 +0100 ROUTER (info) Auto Link Activated
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:31:58.142937 +0100 SERVER (info) [C3] Accepted connection to
> 0.0.0.0:amqp from 127.0.0.1:38032
> 2019-09-06 21:31:58.145620 +0100 ROUTER (info) [C3] Connection Opened: dir=in
> host=127.0.0.1:38032 vhost= encrypted=no auth=ANONYMOUS user=anonymous
> container_id=80a6aa13-40c4-437c-8c78-37a838d5afb5 props=
> 2019-09-06 21:31:58.145806 +0100 ROUTER (info) [C3][L6] Link attached:
> dir=out source={examples expire:sess} target={ expire:sess}
> 2019-09-06 21:31:58.145841 +0100 ROUTER (info) [C3][L7] Link attached: dir=in
> source={ expire:sess} target={examples expire:sess}
> 2019-09-06 21:31:58.146791 +0100 ROUTER (info) [C3][L7] Link detached: del=1
> presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:31:58.147801 +0100 ROUTER (info) [C3][L6] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:31:58.147820 +0100 ROUTER (info) [C3] Connection Closed
> 2019-09-06 21:32:08.201325 +0100 SERVER (info) [C1] Connection to
> 0.0.0.0: failed: amqp:connection:framing-error connection aborted
> 2019-09-06 21:32:08.201510 +0100 ROUTER (info) Auto Link Activation Failed.
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:32:08.201551 +0100 ROUTER (info) [C1][L5] Link lost: del=1
> presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
> 2019-09-06 21:32:08.201570 +0100 ROUTER (info) Auto Link Deactivated
> 'autoLink/1' on connection broker-out
> 2019-09-06 21:32:08.201585 +0100 ROUTER (info) [C1] Connection Closed
> 2019-09-06 21:32:08.201879 +0100 SERVER (info) [C2] Connection to
> 0.0.0.0: failed: amqp:connection:framing-error
[jira] [Commented] (DISPATCH-1407) Memory leak on link policy denial
[
https://issues.apache.org/jira/browse/DISPATCH-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924651#comment-16924651
]
Chuck Rolke commented on DISPATCH-1407:
---
Analysis to date:
* Valgrind shows only python-related mallocs; this is inconclusive. Valgrind
shows no actionable C-language malloc leaks.
* The same problem is present in 1.7.0, 1.6.0, 1.5.0, and 1.4.x
* Policy code was modified not to include setting pn_condition to signal the
error - still has memory growth
* Container code was modified to call pn_condition_clear for local and remote
conditions when link is detached - no change
* Tried making a policy.c static python module load and not loading only when
needed - no change
> Memory leak on link policy denial
> -
>
> Key: DISPATCH-1407
> URL: https://issues.apache.org/jira/browse/DISPATCH-1407
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
> Attachments: A.conf, default.json
>
>
> A router with a simple policy that denies most addresses starts and uses 10M
> bytes of memory. A test client loops 25k times opening a link to a denied
> address over a single connection and session. Now the router uses 276 Mbytes.
> An example policy is
> ```
> [
>["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
>"$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "$management, examples, q1",
> "targets": "$management, examples, q1"
>}
> }
>}]
> ]
> ```
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1407) Memory leak on link policy denial
[
https://issues.apache.org/jira/browse/DISPATCH-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924642#comment-16924642
]
Chuck Rolke commented on DISPATCH-1407:
---
With A.conf and default.json in your cwd, run _qdrouterd -c A.conf_
Then open a disallowed source or target.
> Memory leak on link policy denial
> -
>
> Key: DISPATCH-1407
> URL: https://issues.apache.org/jira/browse/DISPATCH-1407
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
> Attachments: A.conf, default.json
>
>
> A router with a simple policy that denies most addresses starts and uses 10M
> bytes of memory. A test client loops 25k times opening a link to a denied
> address over a single connection and session. Now the router uses 276 Mbytes.
> An example policy is
> ```
> [
>["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
>"$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "$management, examples, q1",
> "targets": "$management, examples, q1"
>}
> }
>}]
> ]
> ```
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1407) Memory leak on link policy denial
[
https://issues.apache.org/jira/browse/DISPATCH-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chuck Rolke updated DISPATCH-1407:
--
Attachment: default.json
> Memory leak on link policy denial
> -
>
> Key: DISPATCH-1407
> URL: https://issues.apache.org/jira/browse/DISPATCH-1407
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
> Attachments: A.conf, default.json
>
>
> A router with a simple policy that denies most addresses starts and uses 10M
> bytes of memory. A test client loops 25k times opening a link to a denied
> address over a single connection and session. Now the router uses 276 Mbytes.
> An example policy is
> ```
> [
>["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
>"$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "$management, examples, q1",
> "targets": "$management, examples, q1"
>}
> }
>}]
> ]
> ```
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1407) Memory leak on link policy denial
[
https://issues.apache.org/jira/browse/DISPATCH-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chuck Rolke updated DISPATCH-1407:
--
Attachment: A.conf
> Memory leak on link policy denial
> -
>
> Key: DISPATCH-1407
> URL: https://issues.apache.org/jira/browse/DISPATCH-1407
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
> Attachments: A.conf, default.json
>
>
> A router with a simple policy that denies most addresses starts and uses 10M
> bytes of memory. A test client loops 25k times opening a link to a denied
> address over a single connection and session. Now the router uses 276 Mbytes.
> An example policy is
> ```
> [
>["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
>"$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "$management, examples, q1",
> "targets": "$management, examples, q1"
>}
> }
>}]
> ]
> ```
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
Ken Giusti created DISPATCH-1411: Summary: Add timestamp and router name to header of qdstat output Key: DISPATCH-1411 URL: https://issues.apache.org/jira/browse/DISPATCH-1411 Project: Qpid Dispatch Issue Type: Improvement Components: Tools Affects Versions: 1.8.0 Reporter: Ken Giusti Add a timestamp and the router's id to the header of the output of qdstat. This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1410) attach of auto-links not logged
Gordon Sim created DISPATCH-1410:
Summary: attach of auto-links not logged
Key: DISPATCH-1410
URL: https://issues.apache.org/jira/browse/DISPATCH-1410
Project: Qpid Dispatch
Issue Type: Bug
Reporter: Gordon Sim
The router logs have helpful lines for link attach and detach. However for
autolinks, there is no attach only detach. You can see this in the log below
where [C3][L6] and [C3][L7] show the start and end of the link, but [C1][L5]
and [C2][L4] show only the end of the link. Would be helpful to have both even
for autolinks.
{noformat}
2019-09-06 21:31:47.039735 +0100 ROUTER (info) In-process subscription L/qdhello
2019-09-06 21:31:47.048500 +0100 AGENT (info) Activating management agent on
$_management_internal
2019-09-06 21:31:47.048551 +0100 ROUTER (info) In-process subscription
L/$_management_internal
2019-09-06 21:31:47.048798 +0100 POLICY (info) Policy configured
maxConnections: 65535, policyDir: '',access rules enabled: 'false', use
hostname patterns: 'false'
2019-09-06 21:31:47.049394 +0100 POLICY (info) Policy fallback defaultVhost is
defined: '$default'
2019-09-06 21:31:47.049625 +0100 CONN_MGR (info) Configured Listener:
0.0.0.0:amqp proto=any, role=normal
2019-09-06 21:31:47.050443 +0100 CONN_MGR (info) Configured Listener:
0.0.0.0:55672 proto=any, role=inter-router
2019-09-06 21:31:47.051275 +0100 CONN_MGR (info) Configured Connector:
0.0.0.0: proto=any, role=route-container
2019-09-06 21:31:47.051954 +0100 CONN_MGR (info) Configured Connector:
0.0.0.0: proto=any, role=route-container
2019-09-06 21:31:47.054214 +0100 SERVER (notice) Operational, 4 Threads Running
(process ID 32593)
2019-09-06 21:31:47.054407 +0100 SERVER (notice) Listening on 0.0.0.0:55672
2019-09-06 21:31:47.054486 +0100 SERVER (notice) Listening on 0.0.0.0:amqp
2019-09-06 21:31:47.058441 +0100 ROUTER (info) [C2] Connection Opened: dir=out
host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
:version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
2019-09-06 21:31:47.058490 +0100 ROUTER (info) Auto Link Activated 'autoLink/0'
on connection broker-in
2019-09-06 21:31:47.058603 +0100 ROUTER (info) [C1] Connection Opened: dir=out
host=0.0.0.0: vhost= encrypted=no auth=ANONYMOUS user=(null)
container_id=a6022696-2483-49f5-8ea6-a6f50db0e7ae props={:product="qpid-cpp",
:version="1.40.0", :platform="Linux", :host="localhost.localdomain"}
2019-09-06 21:31:47.058702 +0100 ROUTER (info) Auto Link Activated 'autoLink/1'
on connection broker-out
2019-09-06 21:31:58.142937 +0100 SERVER (info) [C3] Accepted connection to
0.0.0.0:amqp from 127.0.0.1:38032
2019-09-06 21:31:58.145620 +0100 ROUTER (info) [C3] Connection Opened: dir=in
host=127.0.0.1:38032 vhost= encrypted=no auth=ANONYMOUS user=anonymous
container_id=80a6aa13-40c4-437c-8c78-37a838d5afb5 props=
2019-09-06 21:31:58.145806 +0100 ROUTER (info) [C3][L6] Link attached: dir=out
source={examples expire:sess} target={ expire:sess}
2019-09-06 21:31:58.145841 +0100 ROUTER (info) [C3][L7] Link attached: dir=in
source={ expire:sess} target={examples expire:sess}
2019-09-06 21:31:58.146791 +0100 ROUTER (info) [C3][L7] Link detached: del=1
presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
2019-09-06 21:31:58.147801 +0100 ROUTER (info) [C3][L6] Link lost: del=1
presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
2019-09-06 21:31:58.147820 +0100 ROUTER (info) [C3] Connection Closed
2019-09-06 21:32:08.201325 +0100 SERVER (info) [C1] Connection to 0.0.0.0:
failed: amqp:connection:framing-error connection aborted
2019-09-06 21:32:08.201510 +0100 ROUTER (info) Auto Link Activation Failed.
'autoLink/1' on connection broker-out
2019-09-06 21:32:08.201551 +0100 ROUTER (info) [C1][L5] Link lost: del=1
presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
2019-09-06 21:32:08.201570 +0100 ROUTER (info) Auto Link Deactivated
'autoLink/1' on connection broker-out
2019-09-06 21:32:08.201585 +0100 ROUTER (info) [C1] Connection Closed
2019-09-06 21:32:08.201879 +0100 SERVER (info) [C2] Connection to 0.0.0.0:
failed: amqp:connection:framing-error connection aborted
2019-09-06 21:32:08.201961 +0100 ROUTER (info) Auto Link Activation Failed.
'autoLink/0' on connection broker-in
2019-09-06 21:32:08.201987 +0100 ROUTER (info) [C2][L4] Link lost: del=1
presett=0 psdrop=0 acc=1 rej=0 rel=0 mod=0 delay1=0 delay10=0
2019-09-06 21:32:08.202003 +0100 ROUTER (info) Auto Link Deactivated
'autoLink/0' on connection broker-in
2019-09-06 21:32:08.202014 +0100 ROUTER (info) [C2] Connection Closed
2019-09-06 21:32:10.202120 +0100 SERVER (info) [C4] Connection to 0.0.0.0:
failed: proton:io Connection refused - disconnected 0.0.0.0:
2019-09-06 21:32:10.202240 +0100 SERVER (info) [C5] Connection to
[jira] [Resolved] (DISPATCH-1408) system_tests_distribution failing when running under valgrind
[
https://issues.apache.org/jira/browse/DISPATCH-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1408.
-
Resolution: Fixed
> system_tests_distribution failing when running under valgrind
> -
>
> Key: DISPATCH-1408
> URL: https://issues.apache.org/jira/browse/DISPATCH-1408
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.8.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.9.0
>
>
> System_tests_distribution failing when run under valgrind
>
> {noformat}
> 33:
> 33: ==
> 33: FAIL: test_10_closest_mesh (system_tests_distribution.DistributionTests)
> 33: --
> 33: Traceback (most recent call last):
> 33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
> 33: return f(*args, **kwargs)
> 33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 625,
> in test_10_closest_mesh
> 33: self.assertEqual ( None, test.error )
> 33: AssertionError: None != u'error: one of the receivers on router 1 got no
> messages.'
> 33:
> 33: --
> 33: Ran 25 tests in 21.785s {noformat}
>
> One more failure
> {noformat}
> 33: ==
> 33: FAIL: test_09_closest_linear (system_tests_distribution.DistributionTests)
> 33: --
> 33: Traceback (most recent call last):
> 33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
> 33: return f(*args, **kwargs)
> 33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 612,
> in test_09_closest_linear
> 33: self.assertEqual ( None, test.error )
> 33: AssertionError: None != u'error: one of the receivers on router 1 got no
> messages.'
> 33:
> 33: --
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1409) Update qdstat -l output to include the current credit
Ken Giusti created DISPATCH-1409: Summary: Update qdstat -l output to include the current credit Key: DISPATCH-1409 URL: https://issues.apache.org/jira/browse/DISPATCH-1409 Project: Qpid Dispatch Issue Type: Improvement Components: Router Node, Tools Affects Versions: 1.8.0 Reporter: Ken Giusti The (cap) field in the output of qdstat -l shows the configured capacity for the link, not the current credit available/outstanding. In order to easily detect credit stalls it would be useful to provide the current credit for the link. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1406) Inter-router link stall on receive client failover
[ https://issues.apache.org/jira/browse/DISPATCH-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924507#comment-16924507 ] ASF GitHub Bot commented on DISPATCH-1406: -- codecov-io commented on issue #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti… URL: https://github.com/apache/qpid-dispatch/pull/561#issuecomment-528967533 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=h1) Report > Merging [#561](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/bc06083a429e1a3032b5da6f665f1c2c6e5e9d59?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=tree) ```diff @@Coverage Diff @@ ## master #561 +/- ## == - Coverage 86.76% 86.75% -0.01% == Files 88 88 Lines 2002120036 +15 == + Hits1737117383 +12 - Misses 2650 2653 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.19% <66.66%> (-0.67%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.27% <88.88%> (-0.2%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.01% <0%> (-0.13%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.73% <0%> (+0.19%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.03% <0%> (+0.22%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=footer). Last update [bc06083...5489329](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Inter-router link stall on receive client failover > -- > > Key: DISPATCH-1406 > URL: https://issues.apache.org/jira/browse/DISPATCH-1406 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.7.0, 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > I have a test that simulates a receive client fail-over that results on an > inter-router link "stalling" - no longer able to forward over the link. > >From what it appears there is 250 (inter-router link capacity) messages that > are sent over the link but are not accounted for on the receiver end. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti…
codecov-io commented on issue #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti… URL: https://github.com/apache/qpid-dispatch/pull/561#issuecomment-528967533 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=h1) Report > Merging [#561](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/bc06083a429e1a3032b5da6f665f1c2c6e5e9d59?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=tree) ```diff @@Coverage Diff @@ ## master #561 +/- ## == - Coverage 86.76% 86.75% -0.01% == Files 88 88 Lines 2002120036 +15 == + Hits1737117383 +12 - Misses 2650 2653 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.19% <66.66%> (-0.67%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.27% <88.88%> (-0.2%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.01% <0%> (-0.13%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.73% <0%> (+0.19%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/561/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.03% <0%> (+0.22%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=footer). Last update [bc06083...5489329](https://codecov.io/gh/apache/qpid-dispatch/pull/561?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1406) Inter-router link stall on receive client failover
[ https://issues.apache.org/jira/browse/DISPATCH-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924487#comment-16924487 ] ASF GitHub Bot commented on DISPATCH-1406: -- kgiusti commented on issue #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti… URL: https://github.com/apache/qpid-dispatch/pull/561#issuecomment-528958370 Will follow up with new system tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Inter-router link stall on receive client failover > -- > > Key: DISPATCH-1406 > URL: https://issues.apache.org/jira/browse/DISPATCH-1406 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.7.0, 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > I have a test that simulates a receive client fail-over that results on an > inter-router link "stalling" - no longer able to forward over the link. > >From what it appears there is 250 (inter-router link capacity) messages that > are sent over the link but are not accounted for on the receiver end. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1406) Inter-router link stall on receive client failover
[ https://issues.apache.org/jira/browse/DISPATCH-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924486#comment-16924486 ] ASF GitHub Bot commented on DISPATCH-1406: -- kgiusti commented on pull request #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti… URL: https://github.com/apache/qpid-dispatch/pull/561 …nation unavailable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Inter-router link stall on receive client failover > -- > > Key: DISPATCH-1406 > URL: https://issues.apache.org/jira/browse/DISPATCH-1406 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.7.0, 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > I have a test that simulates a receive client fail-over that results on an > inter-router link "stalling" - no longer able to forward over the link. > >From what it appears there is 250 (inter-router link capacity) messages that > are sent over the link but are not accounted for on the receiver end. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on issue #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti…
kgiusti commented on issue #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti… URL: https://github.com/apache/qpid-dispatch/pull/561#issuecomment-528958370 Will follow up with new system tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti…
kgiusti opened a new pull request #561: DISPATCH-1406: resupply credit to non-endpoint links if address desti… URL: https://github.com/apache/qpid-dispatch/pull/561 …nation unavailable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1408) system_tests_distribution failing when running under valgrind
[
https://issues.apache.org/jira/browse/DISPATCH-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924423#comment-16924423
]
ASF subversion and git services commented on DISPATCH-1408:
---
Commit bc06083a429e1a3032b5da6f665f1c2c6e5e9d59 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=bc06083 ]
DISPATCH-1408 - Made sure that the correct sender and not the management sender
is used to send messages to the router. This will ensure that we are testing
the closest distribution correctly
> system_tests_distribution failing when running under valgrind
> -
>
> Key: DISPATCH-1408
> URL: https://issues.apache.org/jira/browse/DISPATCH-1408
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.8.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.9.0
>
>
> System_tests_distribution failing when run under valgrind
>
> {noformat}
> 33:
> 33: ==
> 33: FAIL: test_10_closest_mesh (system_tests_distribution.DistributionTests)
> 33: --
> 33: Traceback (most recent call last):
> 33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
> 33: return f(*args, **kwargs)
> 33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 625,
> in test_10_closest_mesh
> 33: self.assertEqual ( None, test.error )
> 33: AssertionError: None != u'error: one of the receivers on router 1 got no
> messages.'
> 33:
> 33: --
> 33: Ran 25 tests in 21.785s {noformat}
>
> One more failure
> {noformat}
> 33: ==
> 33: FAIL: test_09_closest_linear (system_tests_distribution.DistributionTests)
> 33: --
> 33: Traceback (most recent call last):
> 33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
> 33: return f(*args, **kwargs)
> 33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 612,
> in test_09_closest_linear
> 33: self.assertEqual ( None, test.error )
> 33: AssertionError: None != u'error: one of the receivers on router 1 got no
> messages.'
> 33:
> 33: --
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8360) [Broker-J] Add broker and virtual host loggers storing log records in database
[
https://issues.apache.org/jira/browse/QPID-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-8360:
Assignee: Alex Rudyy
> [Broker-J] Add broker and virtual host loggers storing log records in database
> --
>
> Key: QPID-8360
> URL: https://issues.apache.org/jira/browse/QPID-8360
> Project: Qpid
> Issue Type: New Feature
> Components: Broker-J
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> Some environments require audit logging to be stored in remote "off host"
> locations like RDBMS, splunk, etc. The logback logging already has a
> {{DBAppender}} to store logs in RDBMSs. Thus, Broker and VirtualHost
> {{Logger}} s can be added utilizing {{DBAppender}} to store logs remotely
> in RDBMS.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8360) [Broker-J] Add broker and virtual host loggers storing log records in database
[
https://issues.apache.org/jira/browse/QPID-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924406#comment-16924406
]
ASF subversion and git services commented on QPID-8360:
---
Commit a33aca40bd224453ad8b0939b2f5af385017b946 in qpid-broker-j's branch
refs/heads/master from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=a33aca4 ]
QPID-8360: [Broker-J]Add broker and virtual host loggers storing log records in
database
> [Broker-J] Add broker and virtual host loggers storing log records in database
> --
>
> Key: QPID-8360
> URL: https://issues.apache.org/jira/browse/QPID-8360
> Project: Qpid
> Issue Type: New Feature
> Components: Broker-J
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> Some environments require audit logging to be stored in remote "off host"
> locations like RDBMS, splunk, etc. The logback logging already has a
> {{DBAppender}} to store logs in RDBMSs. Thus, Broker and VirtualHost
> {{Logger}} s can be added utilizing {{DBAppender}} to store logs remotely
> in RDBMS.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8360) [Broker-J] Add broker and virtual host loggers storing log records in database
[
https://issues.apache.org/jira/browse/QPID-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8360:
-
Description: Some environments require audit logging to be stored in remote
"off host" locations like RDBMS, splunk, etc. The logback logging already has
a {{DBAppender}} to store logs in RDBMSs. Thus, Broker and VirtualHost
{{Logger}} s can be added utilizing {{DBAppender}} to store logs remotely in
RDBMS. (was: Some environments require audit logging to be stored in remote
"off host" locations like RDBMS, splunk, etc. The logback logging already has a
{{DBAppender}} to store logs in RDBMSs. Thus, Broker and VirtualHost
{{Logger}}s can be added utilizing {{DBAppender}} to store logs remotely in
RDBMS.)
> [Broker-J] Add broker and virtual host loggers storing log records in database
> --
>
> Key: QPID-8360
> URL: https://issues.apache.org/jira/browse/QPID-8360
> Project: Qpid
> Issue Type: New Feature
> Components: Broker-J
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> Some environments require audit logging to be stored in remote "off host"
> locations like RDBMS, splunk, etc. The logback logging already has a
> {{DBAppender}} to store logs in RDBMSs. Thus, Broker and VirtualHost
> {{Logger}} s can be added utilizing {{DBAppender}} to store logs remotely
> in RDBMS.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8360) [Broker-J] Add broker and virtual host loggers storing log records in database
Alex Rudyy created QPID-8360:
Summary: [Broker-J] Add broker and virtual host loggers storing
log records in database
Key: QPID-8360
URL: https://issues.apache.org/jira/browse/QPID-8360
Project: Qpid
Issue Type: New Feature
Components: Broker-J
Reporter: Alex Rudyy
Fix For: qpid-java-broker-8.0.0
Some environments require audit logging to be stored in remote "off host"
locations like RDBMS, splunk, etc. The logback logging already has a
{{DBAppender}} to store logs in RDBMSs. Thus, Broker and VirtualHost
{{Logger}}s can be added utilizing {{DBAppender}} to store logs remotely in
RDBMS.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8355) BrokerAttributeInjector can't load HotSpotDiagnosticMXBean on Eclipse J9
[
https://issues.apache.org/jira/browse/QPID-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8355:
-
Component/s: Broker-J
> BrokerAttributeInjector can't load HotSpotDiagnosticMXBean on Eclipse J9
>
>
> Key: QPID-8355
> URL: https://issues.apache.org/jira/browse/QPID-8355
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.4
> Environment: openj9-0.15.1
>Reporter: Andrei Ivanov
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.0.8,
> qpid-java-broker-7.1.5
>
>
> Switching JVM to Eclipse J9 triggered this problem:
>
> {noformat}
> java.util.ServiceConfigurationError:
> org.apache.qpid.server.plugin.ConfiguredObjectAttributeInjector: Provider
> org.apache.qpid.server.model.BrokerAttributeInjector could not be instantiated
> at java.util.ServiceLoader.fail(ServiceLoader.java:232)
> at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
> at
> java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
> at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
> at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
> at
> org.apache.qpid.server.plugin.QpidServiceLoader.instancesOf(QpidServiceLoader.java:73)
> at
> org.apache.qpid.server.plugin.QpidServiceLoader.instancesOf(QpidServiceLoader.java:43)
> at
> org.apache.qpid.server.model.SystemConfigBootstrapModel.(SystemConfigBootstrapModel.java:49)
> at
> org.apache.qpid.server.model.SystemConfigBootstrapModel.(SystemConfigBootstrapModel.java:36)
> at
> org.apache.qpid.server.model.AbstractSystemConfig.(AbstractSystemConfig.java:128)
> at
> org.apache.qpid.server.store.MemorySystemConfigImpl.(MemorySystemConfigImpl.java:46)
> at
> org.apache.qpid.server.store.MemorySystemConfigImplFactory.newInstance(MemorySystemConfigImplFactory.java:51)
> at
> org.apache.qpid.server.store.MemorySystemConfigImplFactory.newInstance(MemorySystemConfigImplFactory.java:32)
> at
> org.apache.qpid.server.SystemLauncher.startupImpl(SystemLauncher.java:258)
> at
> org.apache.qpid.server.SystemLauncher.access$200(SystemLauncher.java:65)
> at org.apache.qpid.server.SystemLauncher$1.run(SystemLauncher.java:217)
> at java.security.AccessController.doPrivileged(AccessController.java:770)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at org.apache.qpid.server.SystemLauncher.startup(SystemLauncher.java:208)
> Caused by: java.lang.IllegalArgumentException:
> com.sun.management.HotSpotDiagnosticMXBean is not a valid MXBean interface.
> at
> com.ibm.java.lang.management.internal.ManagementUtils.checkSupported(ManagementUtils.java:647)
> at
> com.ibm.java.lang.management.internal.ManagementUtils.checkSupportedSingleton(ManagementUtils.java:652)
> at
> com.ibm.java.lang.management.internal.ManagementUtils.getPlatformMXBean(ManagementUtils.java:675)
> at
> java.lang.management.ManagementFactory.getPlatformMXBean(ManagementFactory.java:331)
> at
> org.apache.qpid.server.model.BrokerAttributeInjector.(BrokerAttributeInjector.java:71)
> at java.lang.J9VMInternals.newInstanceImpl(Native Method)
> at java.lang.Class.newInstance(Class.java:1848)
> at
> java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:380){noformat}
>
> I see it was almost fixed in QPID-7081, but, AFAIS,
> {{ManagementFactory.getPlatformMXBean}} can throw an
> {{IllegalArgumentException}} if the bean is not present.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1408) system_tests_distribution failing when running under valgrind
Ganesh Murthy created DISPATCH-1408:
---
Summary: system_tests_distribution failing when running under
valgrind
Key: DISPATCH-1408
URL: https://issues.apache.org/jira/browse/DISPATCH-1408
Project: Qpid Dispatch
Issue Type: Improvement
Components: Tests
Affects Versions: 1.8.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
Fix For: 1.9.0
System_tests_distribution failing when run under valgrind
{noformat}
33:
33: ==
33: FAIL: test_10_closest_mesh (system_tests_distribution.DistributionTests)
33: --
33: Traceback (most recent call last):
33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
33: return f(*args, **kwargs)
33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 625,
in test_10_closest_mesh
33: self.assertEqual ( None, test.error )
33: AssertionError: None != u'error: one of the receivers on router 1 got no
messages.'
33:
33: --
33: Ran 25 tests in 21.785s {noformat}
One more failure
{noformat}
33: ==
33: FAIL: test_09_closest_linear (system_tests_distribution.DistributionTests)
33: --
33: Traceback (most recent call last):
33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
33: return f(*args, **kwargs)
33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 612,
in test_09_closest_linear
33: self.assertEqual ( None, test.error )
33: AssertionError: None != u'error: one of the receivers on router 1 got no
messages.'
33:
33: --
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2100) Switch from CMake to Bazel?
[ https://issues.apache.org/jira/browse/PROTON-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924318#comment-16924318 ] Alan Conway commented on PROTON-2100: - I've hit bazel also in envoy. There are pros and cons, and I'm on record as hating Cmake (I never met a build system I didn't hate) but I think ultimately it would just be swapping one set of voodoo for another. CMake sucks but we've made it work. Bazel is better in some ways and sucks even worse in others. We could make it work, but after much painful and unproductive thrashing we'd just have Yet Another Over-Complex Build Framework that will be fashionable for a while, and then be sucky and out-dated compared to the next New Hotness. I don't see the gain. > Switch from CMake to Bazel? > --- > > Key: PROTON-2100 > URL: https://issues.apache.org/jira/browse/PROTON-2100 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Reporter: Omer Katz >Priority: Major > > Bazel is a modern build system for polygot repositories like qpid-proton. > Using it should simplify how we build and package our bindings and c library. > This issue is an opportunity to discuss if we want to switch and if so, how. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1402) Document unsettled multicast
[ https://issues.apache.org/jira/browse/DISPATCH-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1402. - Fix Version/s: 1.9.0 Resolution: Fixed > Document unsettled multicast > > > Key: DISPATCH-1402 > URL: https://issues.apache.org/jira/browse/DISPATCH-1402 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > Fix For: 1.9.0 > > > The documentation describes unsettled multicast as unreliable. It should > describe the possible reliability guarantees. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1402) Document unsettled multicast
[ https://issues.apache.org/jira/browse/DISPATCH-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924285#comment-16924285 ] ASF subversion and git services commented on DISPATCH-1402: --- Commit 5b07e2cfedc057aaccfa2eec41e02d22466cb7d2 in qpid-dispatch's branch refs/heads/master from Ben Hardesty [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5b07e2c ] DISPATCH-1402 - Doc unsettled multicast reliability guarantees. This closes #556 > Document unsettled multicast > > > Key: DISPATCH-1402 > URL: https://issues.apache.org/jira/browse/DISPATCH-1402 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > The documentation describes unsettled multicast as unreliable. It should > describe the possible reliability guarantees. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1402) Document unsettled multicast
[ https://issues.apache.org/jira/browse/DISPATCH-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924286#comment-16924286 ] ASF GitHub Bot commented on DISPATCH-1402: -- asfgit commented on pull request #556: DISPATCH-1402: Doc unsettled multicast URL: https://github.com/apache/qpid-dispatch/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Document unsettled multicast > > > Key: DISPATCH-1402 > URL: https://issues.apache.org/jira/browse/DISPATCH-1402 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > The documentation describes unsettled multicast as unreliable. It should > describe the possible reliability guarantees. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #556: DISPATCH-1402: Doc unsettled multicast
asfgit closed pull request #556: DISPATCH-1402: Doc unsettled multicast URL: https://github.com/apache/qpid-dispatch/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1394) qd_check_message() incorrectly validates partially received messages
[ https://issues.apache.org/jira/browse/DISPATCH-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1394. -- Resolution: Fixed > qd_check_message() incorrectly validates partially received messages > > > Key: DISPATCH-1394 > URL: https://issues.apache.org/jira/browse/DISPATCH-1394 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > Attachments: message_test.c.patch > > > qd_message_check(msg, QD_DEPTH_MESSAGE_ANNOTATIONS) will flag the message as > valid even if the annotation section is only partially present. > See attached patch to the message_test.c unit test -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1404) message annotation parsing incorrectly uses ->remainder for current buffer capacity
[ https://issues.apache.org/jira/browse/DISPATCH-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1404. -- Resolution: Fixed > message annotation parsing incorrectly uses ->remainder for current buffer > capacity > --- > > Key: DISPATCH-1404 > URL: https://issues.apache.org/jira/browse/DISPATCH-1404 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > The following code uses _qd_iterator_pointer_t->remaining_ when computing the > amount of data available in the current buffer: > [parse.c|https://github.com/apache/qpid-dispatch/blob/master/src/parse.c#L739] > _->remaining_ is the total amount of data remaining across the buffer chain. > This is likely larger than the amount of data in the current buffer. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1404) message annotation parsing incorrectly uses ->remainder for current buffer capacity
[ https://issues.apache.org/jira/browse/DISPATCH-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924241#comment-16924241 ] Robbie Gemmell commented on DISPATCH-1404: -- Random aside, description links to code on master aren't great as they can change by the time someone looks at them later :) > message annotation parsing incorrectly uses ->remainder for current buffer > capacity > --- > > Key: DISPATCH-1404 > URL: https://issues.apache.org/jira/browse/DISPATCH-1404 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > The following code uses _qd_iterator_pointer_t->remaining_ when computing the > amount of data available in the current buffer: > [parse.c|https://github.com/apache/qpid-dispatch/blob/master/src/parse.c#L739] > _->remaining_ is the total amount of data remaining across the buffer chain. > This is likely larger than the amount of data in the current buffer. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1394) qd_check_message() incorrectly validates partially received messages
[ https://issues.apache.org/jira/browse/DISPATCH-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924213#comment-16924213 ] ASF subversion and git services commented on DISPATCH-1394: --- Commit 2876ccd736da700d8d03739cd85e5c8d495f2391 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2876ccd ] DISPATCH-1394: Fix qd_message_check() to detect truncated message headers This closes #557 > qd_check_message() incorrectly validates partially received messages > > > Key: DISPATCH-1394 > URL: https://issues.apache.org/jira/browse/DISPATCH-1394 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > Attachments: message_test.c.patch > > > qd_message_check(msg, QD_DEPTH_MESSAGE_ANNOTATIONS) will flag the message as > valid even if the annotation section is only partially present. > See attached patch to the message_test.c unit test -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1404) message annotation parsing incorrectly uses ->remainder for current buffer capacity
[ https://issues.apache.org/jira/browse/DISPATCH-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924214#comment-16924214 ] ASF subversion and git services commented on DISPATCH-1404: --- Commit 60f53bf4c121f0c39d77869b3d71be9d9cb5b31f in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=60f53bf ] DISPATCH-1404: fix computation of message annotation field length > message annotation parsing incorrectly uses ->remainder for current buffer > capacity > --- > > Key: DISPATCH-1404 > URL: https://issues.apache.org/jira/browse/DISPATCH-1404 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > The following code uses _qd_iterator_pointer_t->remaining_ when computing the > amount of data available in the current buffer: > [parse.c|https://github.com/apache/qpid-dispatch/blob/master/src/parse.c#L739] > _->remaining_ is the total amount of data remaining across the buffer chain. > This is likely larger than the amount of data in the current buffer. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #557: Dispatch 1394 1404
asfgit closed pull request #557: Dispatch 1394 1404 URL: https://github.com/apache/qpid-dispatch/pull/557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1406) Inter-router link stall on receive client failover
[ https://issues.apache.org/jira/browse/DISPATCH-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924212#comment-16924212 ] Ken Giusti commented on DISPATCH-1406: -- The fix will be to replenish credit when this scenario occurs. However we need to determine whether or not credit should be replenished on non-inter router links. Also there may be reasons to set the terminal outcome to Released instead of Rejected in this case (currently the outcome is Rejected for all cases). When it comes to credit replenishment I propose we replenish credit unconditionally in all cases where the link is *not* the sending client's link (endpoint link), except when the client's link is anonymous - in that case we need to replenish credit as following messages may be sent to a different address. For terminal outcome we believe that the router should only Reject the message in the case where the link is the client's link to the router (an endpoint link). This is consistent with the definition of "unavailable" defaultTreatment. However in the case of inter-router links we propose Releasing the message instead because the message did have a subscriber at some point as the message was forwarded. In this case we assume the subscriber is temporarily unavailable and the message can be re-sent at a later time. Opinions? > Inter-router link stall on receive client failover > -- > > Key: DISPATCH-1406 > URL: https://issues.apache.org/jira/browse/DISPATCH-1406 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.7.0, 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > I have a test that simulates a receive client fail-over that results on an > inter-router link "stalling" - no longer able to forward over the link. From > what it appears there is 250 (inter-router link capacity) messages that are > sent over the link but are not accounted for on the receiver end. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1406) Inter-router link stall on receive client failover
[ https://issues.apache.org/jira/browse/DISPATCH-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924200#comment-16924200 ] Ken Giusti commented on DISPATCH-1406: -- The root cause has been identified: The problem occurs when a router's defaultTreatment is set to "unavailable", and a message traveling between routers (over the inter-router link) can no longer be forwarded (target address is removed from the routing table - think subscriber lost). In this situation the router incorrectly avoids replenishing credit on the inter-router link, which causes eventual credit starvation (after linkCapacity is exhausted). The router never recovers credit in this situation and forwarding between the affected routers stalls. > Inter-router link stall on receive client failover > -- > > Key: DISPATCH-1406 > URL: https://issues.apache.org/jira/browse/DISPATCH-1406 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.7.0, 1.8.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.9.0 > > > I have a test that simulates a receive client fail-over that results on an > inter-router link "stalling" - no longer able to forward over the link. From > what it appears there is 250 (inter-router link capacity) messages that are > sent over the link but are not accounted for on the receiver end. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
