[jira] [Commented] (PROTON-2158) Add 'Automatic-Module-Name' to MANIFEST.MF to support Java 9+ modules
[
https://issues.apache.org/jira/browse/PROTON-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068110#comment-17068110
]
ASF GitHub Bot commented on PROTON-2158:
conniey commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-604723979
> For future, please add the JIRA key reference to the PR title and commit
log as that way the JIRA
Thanks for letting me know. :) I'll do that in the future.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add 'Automatic-Module-Name' to MANIFEST.MF to support Java 9+ modules
> -
>
> Key: PROTON-2158
> URL: https://issues.apache.org/jira/browse/PROTON-2158
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
>Affects Versions: proton-j-0.33.2
>Reporter: Connie Yau
>Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Our team ships libraries that work on JDK 9+ with their module system. It
> would be nice to have an automatic-module-name in the JAR.
> [http://branchandbound.net/blog/java/2017/12/automatic-module-name/]
> Note: This is not about modularising qpid-proton-j; this is just adding an
> automatic module name. I think modularising the library is another task in
> itself.
> In our project, it shows warnings when building for JDK 11.
> {{[WARNING] * Required filename-based automodules detected:
> [proton-j-0.33.2.jar]. Please don't publish this project to a public artifact
> repository! *}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton-j] conniey commented on issue #37: PROTON-2158 Adding automatic module name entry.
conniey commented on issue #37: PROTON-2158 Adding automatic module name entry. URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-604723979 > For future, please add the JIRA key reference to the PR title and commit log as that way the JIRA Thanks for letting me know. :) I'll do that in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2187) Python client leak on early Connection.close
Clifford Jansen created PROTON-2187: --- Summary: Python client leak on early Connection.close Key: PROTON-2187 URL: https://issues.apache.org/jira/browse/PROTON-2187 Project: Qpid Proton Issue Type: Bug Components: python-binding Affects Versions: proton-c-0.28.0 Reporter: Clifford Jansen Assignee: Clifford Jansen Fix For: proton-c-0.31.0 The Python client waits for completion of the outgoing TCP connection handshake before it fully configures its internal IO structures for the connection to do normal two way communication with the server. If a Connection.close() happens before the TCP handshake is complete, the incomplete nature of the IO setup is not properly taken into account on close and cleanup, resulting in leaked memory related to the Container and the Connection. The window for this problem is usually small, but not insignificant on some networks. It is trivial to reproduce if firewall tables are set up to drop packets. See reproducer https://bugzilla.redhat.com/show_bug.cgi?id=1810549#c3 The bug also reproduces against the Proton example brokers. qpidd is not required. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] d98762625 opened a new pull request #232: WIP: update incorrect variable lengths in proton generator code
d98762625 opened a new pull request #232: WIP: update incorrect variable lengths in proton generator code URL: https://github.com/apache/qpid-proton/pull/232 Some of the mappings from C types to Go types were incorrect. This fixes those mappings and updates the generated wrapper. Also update the error message to use the compiled version, rather than a hard coded value. (Not sure that I needed to bump the proton-c header version) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on issue #37: Adding automatic module name entry.
gemmellr commented on issue #37: Adding automatic module name entry. URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-604578237 For future, please add the JIRA key reference to the PR title and commit log as that way the JIRA gets updated when PRs are opened, commented on, commits are pushed, etc. See prior PRs or commits for examples. > @gemmellr Who is best placed to review this and consider merging it? Thanks. Someone not off on holiday or sick, or more annoyingly both together as happened :) I'll try to look soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (QPID-8430) [qpid-cpp] Excessive memory use when rerouting messages
[ https://issues.apache.org/jira/browse/QPID-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet reopened QPID-8430: If a message contains a non-empty-string trace (key "x-qpid.trace"), this fix does not prevent each reroute from re-copying the message as a part of rerouting, and thus for the memory to grow as before the patch. Each reroute is supposed to set the value of this key to the empty string, and subsequent reroutes should not need to recopy the message. However, testing has shown that the test for the presence of the key and its value (using *Message.getPropertyAsString()*) always returns the value of the original message trace annotation, and is thus allowing the trace annotation to be unset over and over, each time with a message deep copy for each reroute. > [qpid-cpp] Excessive memory use when rerouting messages > --- > > Key: QPID-8430 > URL: https://issues.apache.org/jira/browse/QPID-8430 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > > When a message is rerouted several times, the broker's used memory increases > rapidly. This is counter-intuitive, considering that the messages themselves > are only passing from one queue to another. There is no evidence of a leak, > however, only a large growth in consumed memory. > An investigation has shown that the process of clearing traces from the > message when rerouting (whether they exist or not) causes the message and its > frames to be copied (for reasons of avoiding locks on the message, which can > affect performance). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on issue #231: WIP: Fix memory leak in go message unmarshal
astitcher commented on issue #231: WIP: Fix memory leak in go message unmarshal URL: https://github.com/apache/qpid-proton/pull/231#issuecomment-604530501 This fix looks good to me @alanconway what do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] d98762625 opened a new pull request #231: WIP: Fix memory leak in go message unmarshal
d98762625 opened a new pull request #231: WIP: Fix memory leak in go message unmarshal URL: https://github.com/apache/qpid-proton/pull/231 When using this library in an application to receive messages from QPID, we found our containers were getting OOM killed in kubernetes. This fixes the memory leak we uncovered. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
