[jira] [Commented] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread Ulf Lilleengen (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154032#comment-17154032
 ] 

Ulf Lilleengen commented on DISPATCH-1585:
--

[~chug] I think i can see the issue then. I used aliases as a json array, 
whereas it is just a comma-separated string. If I add multiple aliases this 
way, I'm able to send to internal.example.com and receive from 
external.example.com, as I wanted. Thanks!

 
{code:java}
[
["router", { "defaultDistribution": "unavailable"}],
["listener", { "host": "0.0.0.0", "port": 5672, "authenticatePeer": false, 
"saslMechanisms": "ANONYMOUS", "multiTenant": true }],
["policy", {"enableVhostPolicy": true, "defaultVhost": "$default" }],
["vhost", { "hostname": "myprefix", "aliases":"internal.example.com, 
external.example.com", "allowUnknownUser": true, 
"groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}],
["address", { "prefix": "myprefix/foo" }],
["log", {"module": "POLICY", "enable": "trace+"}]
]

{code}

> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread Charles E. Rolke (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154016#comment-17154016
 ] 

Charles E. Rolke commented on DISPATCH-1585:


What do you get if you enable trace logging for the POLICY module in the router?

I translated the config into this. I've substituted hostname 'unused' that will 
work with my setup.
{code:java}
router {
defaultDistribution: unavailable
}

listener {
host: 0.0.0.0
port: 5672
authenticatePeer: false
saslMechanisms: ANONYMOUS
multiTenant: true
}

policy {
enableVhostPolicy: true
defaultVhost: $default
}

vhost {
hostname: myprefix
aliases: unused
allowUnknownUser: true
groups: {
"$default": {
"remoteHosts":"*",
"sources":"*",
"targets":"*",
"allowDynamicSource":true,
"allowAnonymousSender":true}
}
}

log {
module: POLICY
enable: trace+
}

address {
prefix: myprefix/foo
}
{code}
and it seems to work. Router log shows amqp Open hostname 'unused'. Policy 
translates that to use the 'myprefix' ruleset.
{code:java}
[0x7faf28013610]: AMQP:FRAME:  <- AMQP
[0x7faf28013610]: AMQP:FRAME:0 <- @open(16) 
[container-id="7c4e2d07-d355-4764-abb0-872eabadc913", hostname="unused", 
channel-max=32767]
[0x7faf28013610]: AMQP:FRAME:0 <- @begin(17) [next-outgoing-id=0, 
incoming-window=2147483647, outgoing-window=2147483647]
[0x7faf28013610]: AMQP:FRAME:0 <- @attach(18) 
[name="83006374-5f74-4d5b-aa4c-af55ff9bbe0e", handle=0, role=false, 
snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [durable=0, timeout=0, 
dynamic=false], target=@target(41) [address="foo", durable=0, timeout=0, 
dynamic=false], initial-delivery-count=0, max-message-size=0]
2020-07-08 16:58:36.562192 -0400 POLICY (debug) AMQP Open for user 'anonymous', 
rhost '192.168.1.17', vhost 'unused': proceeds using vhost 'myprefix' ruleset
2020-07-08 16:58:36.562296 -0400 POLICY (trace) [C1] ALLOW AMQP Open 
lookup_user: anonymous, rhost: 192.168.1.17, vhost: unused, connection: 
192.168.1.17:41378. Usergroup: '$default'
2020-07-08 16:58:36.562366 -0400 POLICY (debug) AMQP Open lookup settings for 
vhost 'unused': proceeds using vhost 'myprefix' ruleset
2020-07-08 16:58:36.562636 -0400 ROUTER (info) [C1] Connection Opened: dir=in 
host=192.168.1.17:41378 vhost=myprefix encrypted=no auth=ANONYMOUS 
user=anonymous container_id=7c4e2d07-d355-4764-abb0-872eabadc913 props=
2020-07-08 16:58:36.562692 -0400 POLICY (trace) [C1] ALLOW AMQP Begin Session. 
user: anonymous, rhost: 192.168.1.17, vhost: unused
2020-07-08 16:58:36.562720 -0400 POLICY (trace) [C1] ALLOW AMQP Attach sender 
link 'foo' for user 'anonymous', rhost '192.168.1.17', vhost 'unused' based on 
link target name
{code}
Simple send and receive go to _*-a amqp://unused:amqp/foo*_  and exchange 
messages. I don't know that clients operating like this are supposed to 
interact with the multitenant prefix.

> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread Ulf Lilleengen (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153870#comment-17153870
 ] 

Ulf Lilleengen edited comment on DISPATCH-1585 at 7/8/20, 7:26 PM:
---

[~chug] I just tried a fresh build of master, and I'm not able to get it 
working. I have the following config:

 
{code:java}
[
["router", { "defaultDistribution": "unavailable"}],
["listener", { "host": "0.0.0.0", "port": 5672, "authenticatePeer": false, 
"saslMechanisms": "ANONYMOUS", "multiTenant": true }],
["policy", {"enableVhostPolicy": true, "defaultVhost": "$default" }],
["vhost", { "hostname": "myprefix", "aliases":["internal.example.com"], 
"allowUnknownUser": true, 
"groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}],
["address", { "prefix": "myprefix/foo" }]
]

 {code}
 

I then try to connect the sender as follows:

 
{code:java}
PN_TRACE_FRM=1 python /usr/share/proton/examples/python/simple_recv.py -a 
amqp://internal.example.com:5672/foo {code}
 

And I'm getting this in the router log
{code:java}
 2020-07-08 19:20:11.292964 + POLICY (info) DENY AMQP Open for user 
'anonymous', rhost '127.0.0.1', vhost 'internal.example.com': No policy defined 
for vhost{code}
 

Is there something wrong in my config, or is there some additional change 
needed in the router?

 


was (Author: lulf):
[~chug] I just tried a fresh build of master, and I'm not able to get it 
working. I have the following config:

 
{code:java}
[
["router", { "defaultDistribution": "unavailable"}],
["listener", { "host": "0.0.0.0", "port": 5672, "authenticatePeer": false, 
"saslMechanisms": "ANONYMOUS", "multiTenant": true }],
["policy", {"enableVhostPolicy": true, "defaultVhost": "$default" }],
["vhost", { "hostname": "myprefix", "aliases":["internal.example.com"], 
"allowUnknownUser": true, 
"groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}],
["address", { "prefix": "myprefix/foo" }]
]

 {code}
 

I then try to connect the sender as follows:

 
{code:java}
PN_TRACE_FRM=1 python /usr/share/proton/examples/python/simple_recv.py -a 
amqp://internal.example.com:5672/foo {code}
 

And I'm getting this in the router log
{code:java}
 2020-07-08 19:20:11.292964 + POLICY (info) DENY AMQP Open for user 
'anonymous', rhost '127.0.0.1', vhost 'internal.example.com': No policy defined 
for vhost{code}
 

 

> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread Ulf Lilleengen (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153870#comment-17153870
 ] 

Ulf Lilleengen commented on DISPATCH-1585:
--

[~chug] I just tried a fresh build of master, and I'm not able to get it 
working. I have the following config:

 
{code:java}
[
["router", { "defaultDistribution": "unavailable"}],
["listener", { "host": "0.0.0.0", "port": 5672, "authenticatePeer": false, 
"saslMechanisms": "ANONYMOUS", "multiTenant": true }],
["policy", {"enableVhostPolicy": true, "defaultVhost": "$default" }],
["vhost", { "hostname": "myprefix", "aliases":["internal.example.com"], 
"allowUnknownUser": true, 
"groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}],
["address", { "prefix": "myprefix/foo" }]
]

 {code}
 

I then try to connect the sender as follows:

 
{code:java}
PN_TRACE_FRM=1 python /usr/share/proton/examples/python/simple_recv.py -a 
amqp://internal.example.com:5672/foo {code}
 

And I'm getting this in the router log
{code:java}
 2020-07-08 19:20:11.292964 + POLICY (info) DENY AMQP Open for user 
'anonymous', rhost '127.0.0.1', vhost 'internal.example.com': No policy defined 
for vhost{code}
 

 

> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153863#comment-17153863
 ] 

ASF subversion and git services commented on DISPATCH-1585:
---

Commit 84a1123fa68ce8a8051d6bac6ac5c20f13bb5b0a in qpid-dispatch's branch 
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=84a1123 ]

DISPATCH-1585: Repair mistaken commit of config.sh

This happened in commit 5f3eb3f and affects bb89cc7 and 12334ed.


> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1684) [test] fallback_dest SwitchoverTest opens fallback receiver on wrong connection

2020-07-08 Thread Charles E. Rolke (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles E. Rolke resolved DISPATCH-1684.

Fix Version/s: 1.13.0
 Assignee: Charles E. Rolke
   Resolution: Fixed

Fixed at commit 12334ed0

> [test] fallback_dest SwitchoverTest opens fallback receiver on wrong 
> connection
> ---
>
> Key: DISPATCH-1684
> URL: https://issues.apache.org/jira/browse/DISPATCH-1684
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: DISPATCH-1684-test.29.svg
>
>
> system_tests_fallback_dest test class SwitchoverTest has an error where it 
> opens the fallback receiver on the primary receiver connection and not on the 
> fallback receiver connection.
> Fixing that test code mistake reveals a hard failure on test_29 and test_30 
> with a time out. All phase 1 messages released since the sender on the edge 
> has no path to the fallback receiver.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1684) [test] fallback_dest SwitchoverTest opens fallback receiver on wrong connection

2020-07-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153842#comment-17153842
 ] 

ASF GitHub Bot commented on DISPATCH-1684:
--

asfgit closed pull request #772:
URL: https://github.com/apache/qpid-dispatch/pull/772


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [test] fallback_dest SwitchoverTest opens fallback receiver on wrong 
> connection
> ---
>
> Key: DISPATCH-1684
> URL: https://issues.apache.org/jira/browse/DISPATCH-1684
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1684-test.29.svg
>
>
> system_tests_fallback_dest test class SwitchoverTest has an error where it 
> opens the fallback receiver on the primary receiver connection and not on the 
> fallback receiver connection.
> Fixing that test code mistake reveals a hard failure on test_29 and test_30 
> with a time out. All phase 1 messages released since the sender on the edge 
> has no path to the fallback receiver.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] asfgit closed pull request #772: DISPATCH-1684: Test should open fallback receiver on fallback connection

2020-07-08 Thread GitBox


asfgit closed pull request #772:
URL: https://github.com/apache/qpid-dispatch/pull/772


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1684) [test] fallback_dest SwitchoverTest opens fallback receiver on wrong connection

2020-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153841#comment-17153841
 ] 

ASF subversion and git services commented on DISPATCH-1684:
---

Commit 12334ed01167954457152a0f536d8c7033ac77ec in qpid-dispatch's branch 
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=12334ed ]

DISPATCH-1684: Test should open fallback receiver on fallback connection

Fallback_dest test class SwitchoverTest mistakenly opens the fallback
receiver on the primary connection.

This closes #772


> [test] fallback_dest SwitchoverTest opens fallback receiver on wrong 
> connection
> ---
>
> Key: DISPATCH-1684
> URL: https://issues.apache.org/jira/browse/DISPATCH-1684
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1684-test.29.svg
>
>
> system_tests_fallback_dest test class SwitchoverTest has an error where it 
> opens the fallback receiver on the primary receiver connection and not on the 
> fallback receiver connection.
> Fixing that test code mistake reveals a hard failure on test_29 and test_30 
> with a time out. All phase 1 messages released since the sender on the edge 
> has no path to the fallback receiver.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1693) Edge router closes fallback receiver link when local primary receiver closes

2020-07-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153838#comment-17153838
 ] 

ASF GitHub Bot commented on DISPATCH-1693:
--

ChugR closed pull request #765:
URL: https://github.com/apache/qpid-dispatch/pull/765


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router closes fallback receiver link when local primary receiver closes
> 
>
> Key: DISPATCH-1693
> URL: https://issues.apache.org/jira/browse/DISPATCH-1693
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> This bug is exposed by the fix to tests/system_tests_fallback_dest.py. See 
> https://issues.apache.org/jira/browse/DISPATCH-1684
> The design goal configuration for test_29 is:
>  * sender EA1
>  * primary receiver EA1
>  * fallback receiver INT.A
> The fix for this issue must be committed before the fix for DISPATCH-1684. 
> Otherwise the change to the test will introduce a hard error and a guaranteed 
> self test failure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1693) Edge router closes fallback receiver link when local primary receiver closes

2020-07-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153839#comment-17153839
 ] 

ASF GitHub Bot commented on DISPATCH-1693:
--

ChugR commented on pull request #765:
URL: https://github.com/apache/qpid-dispatch/pull/765#issuecomment-655678972


   Fixed at commit bb89cc70



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router closes fallback receiver link when local primary receiver closes
> 
>
> Key: DISPATCH-1693
> URL: https://issues.apache.org/jira/browse/DISPATCH-1693
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> This bug is exposed by the fix to tests/system_tests_fallback_dest.py. See 
> https://issues.apache.org/jira/browse/DISPATCH-1684
> The design goal configuration for test_29 is:
>  * sender EA1
>  * primary receiver EA1
>  * fallback receiver INT.A
> The fix for this issue must be committed before the fix for DISPATCH-1684. 
> Otherwise the change to the test will introduce a hard error and a guaranteed 
> self test failure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ChugR closed pull request #765: DISPATCH-1693: Don't raise link event on fallback when primary closes

2020-07-08 Thread GitBox


ChugR closed pull request #765:
URL: https://github.com/apache/qpid-dispatch/pull/765


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ChugR commented on pull request #765: DISPATCH-1693: Don't raise link event on fallback when primary closes

2020-07-08 Thread GitBox


ChugR commented on pull request #765:
URL: https://github.com/apache/qpid-dispatch/pull/765#issuecomment-655678972


   Fixed at commit bb89cc70



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1693) Edge router closes fallback receiver link when local primary receiver closes

2020-07-08 Thread Charles E. Rolke (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles E. Rolke resolved DISPATCH-1693.

Fix Version/s: 1.13.0
   Resolution: Fixed

Fixed at commit bb89cc70

> Edge router closes fallback receiver link when local primary receiver closes
> 
>
> Key: DISPATCH-1693
> URL: https://issues.apache.org/jira/browse/DISPATCH-1693
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> This bug is exposed by the fix to tests/system_tests_fallback_dest.py. See 
> https://issues.apache.org/jira/browse/DISPATCH-1684
> The design goal configuration for test_29 is:
>  * sender EA1
>  * primary receiver EA1
>  * fallback receiver INT.A
> The fix for this issue must be committed before the fix for DISPATCH-1684. 
> Otherwise the change to the test will introduce a hard error and a guaranteed 
> self test failure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1693) Edge router closes fallback receiver link when local primary receiver closes

2020-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153833#comment-17153833
 ] 

ASF subversion and git services commented on DISPATCH-1693:
---

Commit bb89cc702d5c72fedd09c4043710a7abf91a6ea3 in qpid-dispatch's branch 
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=bb89cc7 ]

DISPATCH-1693: Fix calculation of when to raise QDRC_EVENTs

In qdr_core_bind_address_link_CT and qdr_core_unbind_address_link_CT
the events were raised at the wrong times for edge routers. This
effectively closed links to valid fallback receivers in the core network.


> Edge router closes fallback receiver link when local primary receiver closes
> 
>
> Key: DISPATCH-1693
> URL: https://issues.apache.org/jira/browse/DISPATCH-1693
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Priority: Major
>
> This bug is exposed by the fix to tests/system_tests_fallback_dest.py. See 
> https://issues.apache.org/jira/browse/DISPATCH-1684
> The design goal configuration for test_29 is:
>  * sender EA1
>  * primary receiver EA1
>  * fallback receiver INT.A
> The fix for this issue must be committed before the fix for DISPATCH-1684. 
> Otherwise the change to the test will introduce a hard error and a guaranteed 
> self test failure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread Charles E. Rolke (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles E. Rolke resolved DISPATCH-1585.

Fix Version/s: 1.13.0
 Assignee: Charles E. Rolke
   Resolution: Fixed

Fixed at commit 5f3eb3f

> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] asfgit closed pull request #770: Dispatch 1585 - Add vhost aliases for configuration sharing

2020-07-08 Thread GitBox


asfgit closed pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners

2020-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153807#comment-17153807
 ] 

ASF subversion and git services commented on DISPATCH-1585:
---

Commit 5f3eb3f8a7b004a6404d7afe1552fedac8340335 in qpid-dispatch's branch 
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5f3eb3f ]

DISPATCH-1585: Define vhost aliases for configuation sharing

Given a vhost definition:

  vhost {
 hostname: example.com
 aliases: example.org, example.net
 ... }

Vhost _aliases_ are alternative literal hostnames or patterns that direct
the router to use the settings in this vhost. Alias hostnames that match an
incoming connection will use the settings defined in the contained vhost.
In a multi-tenant configuration a connection to a vhost alias will use the
base vhost hostname for the tenant namespace. In this example if a connection
is directed to vhost `example.org` then the settings from the base vhost
hostname `example.com` will apply and `example.com` will be the tenant
namespace.

Vhost `hostname` and `aliases` settings from all vhosts are shared in a
single list and must be unique.

This closes #770


> Allow defining address prefix shared by different multitenant listeners
> ---
>
> Key: DISPATCH-1585
> URL: https://issues.apache.org/jira/browse/DISPATCH-1585
> Project: Qpid Dispatch
>  Issue Type: Wish
>Reporter: Ulf Lilleengen
>Priority: Major
>
> At present, a multitenant router listener will prefix addresses with the 
> hostname in the AMQP Open. However, given a configuration where it is 
> desirable to expose a router address space for multiple DNS names, any 
> address, linkRoute and autoLink configuration will need to be duplicated for 
> each DNS name. This complicates router configuration significantly.
>  
> Instead, having a way to specify which prefix to apply for a multitenant 
> listener would allow reusing the same address, autoLink and linkRoute 
> configuration for multiple listeners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1707) Policy config file fails with cryptic error if trailing brace on wrong line

2020-07-08 Thread Charles E. Rolke (Jira)
Charles E. Rolke created DISPATCH-1707:
--

 Summary: Policy config file fails with cryptic error if trailing 
brace on wrong line
 Key: DISPATCH-1707
 URL: https://issues.apache.org/jira/browse/DISPATCH-1707
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Management Agent, Policy Engine
Affects Versions: 1.12.0
Reporter: Charles E. Rolke


If a policy vhost in a config file is specified like this

{code:java}
vhost {
hostname: 0.0.0.0
allowUnknownUser: true
groups: {
"$default": {
"users": "*",
"remoteHosts": "*",
"allowDynamicSource": true,
"allowAnonymousSender": true,
"sources": "*",
"targets": "*"}
}
}
{code}

then it works fine. Buf if the trailing brace after _targets_ is on a line by 
itself

{code:java}
vhost {
hostname: 0.0.0.0
allowUnknownUser: true
groups: {
"$default": {
"users": "*",
"remoteHosts": "*",
"allowDynamicSource": true,
"allowAnonymousSender": true,
"sources": "*",
"targets": "*"
}
}
}
{code}
 
then it fails with a confusing message that does not pinpoint what is wrong.

{code:java}
> qdrouterd -c permissive-info.conf
2020-07-08 11:18:36.907041 -0400 ERROR (error) Python: Exception: Cannot load 
configuration file permissive-info.conf: Expecting ',' delimiter: line 46 
column 3 (char 723)
2020-07-08 11:18:36.907563 -0400 ERROR (error) Traceback (most recent call 
last):
  File 
"/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
 line 61, in __init__
self.load(filename, raw_json)
  File 
"/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
 line 221, in load
self.load(f, raw_json)
  File 
"/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
 line 223, in load
sections = self._parserawjson(source) if raw_json else self._parse(source)
  File 
"/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
 line 193, in _parse
sections = json.loads(js_text)
  File "/usr/lib64/python3.7/json/__init__.py", line 348, in loads
return _default_decoder.decode(s)
  File "/usr/lib64/python3.7/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python3.7/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 46 column 3 (char 
723)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File 
"/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
 line 251, in configure_dispatch
config = Config(filename)
  File 
"/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
 line 64, in __init__
% (filename, e))
Exception: Cannot load configuration file permissive-info.conf: Expecting ',' 
delimiter: line 46 column 3 (char 723)

2020-07-08 11:18:36.907599 -0400 MAIN (critical) Router start-up failed: 
Python: Exception: Cannot load configuration file permissive-info.conf: 
Expecting ',' delimiter: line 46 column 3 (char 723)
qdrouterd: Python: Exception: Cannot load configuration file 
permissive-info.conf: Expecting ',' delimiter: line 46 column 3 (char 723)
{code}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1706) Policy vhostUserGroupSettings not handled as a config Entity

2020-07-08 Thread Charles E. Rolke (Jira)
Charles E. Rolke created DISPATCH-1706:
--

 Summary: Policy vhostUserGroupSettings not handled as a config 
Entity
 Key: DISPATCH-1706
 URL: https://issues.apache.org/jira/browse/DISPATCH-1706
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Management Agent, Policy Engine
Affects Versions: 1.12.0
Reporter: Charles E. Rolke


Policy vhost object member *group* is type *map*. But nowhere in the 
configuration is the specification of what is in the map. In this particular 
case the map keys are vhost _names_ and the values are objects of type 
_vhostUserGroupSettings._

Policy gets no help from the configuration Entity system in dealing with these 
maps. That is, policy must implement the defaults with in-line code. The 
defaults specified in qdrouter.json are unused.

Recent work with policy and qdstat reveals another place where policy is 
disconnected from the Entity system: qdmanage queries return only a map's 
configured values and not all configured object's attributes with defaults. One 
cannot use qdmanage to see what a vhostUserGroupSetting value is used at 
run-time unless the value was specified in the config file. Since qdstat uses 
qdmanage then qdstat cannot display those values either.

As an illustration here is a simple config file with simple policy and one 
vhost:
{code:java}
policy {
enableVhostPolicy: True
}

vhost {
hostname: 0.0.0.0
allowUnknownUser: true
groups: {
"$default": {
"users": "*",
"remoteHosts": "*",
"allowDynamicSource": true,
"allowAnonymousSender": true,
"sources": "*",
"targets": "*"}
}
}
 {code}
And here are the results of querying the policy and vhost. Note that the policy 
and vhost objects include attributes that were not specified in the config. 
Also note that the vhost group has only the six configured settings and that 
the remainder of the 21 attributes are absent.
{code:java}
> qdmanage query --type policy
[
  {
"maxConnections": 65535,
"maxMessageSize": 0,
"enableVhostPolicy": true,
"enableVhostNamePatterns": false,
"policyDir": "",
"defaultVhost": "$default",
"connectionsProcessed": 1,
"connectionsDenied": 0,
"connectionsCurrent": 1,
"linksDenied": 0,
"maxMessageSizeDenied": 0,
"totalDenials": 0,
"name": "policy/None",
"identity": "policy/None",
"type": "org.apache.qpid.dispatch.policy"
  }
]

> qdmanage query --type vhost
[
  {
"hostname": "0.0.0.0",
"maxConnections": 65535,
"maxConnectionsPerUser": 65535,
"maxConnectionsPerHost": 65535,
"allowUnknownUser": true,
"groups": {
  "$default": {
"users": "*",
"remoteHosts": "*",
"allowDynamicSource": true,
"allowAnonymousSender": true,
"sources": "*",
"targets": "*"
  }
},
"name": "vhost/0.0.0.0",
"identity": "vhost/0.0.0.0",
"type": "org.apache.qpid.dispatch.vhost"
  }
]
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org