[jira] [Created] (DISPATCH-2143) race getting/setting qdr_delivery_t->disposition
Ken Giusti created DISPATCH-2143: Summary: race getting/setting qdr_delivery_t->disposition Key: DISPATCH-2143 URL: https://issues.apache.org/jira/browse/DISPATCH-2143 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.16.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.17.0 62: test_999_check_for_leaks (system_tests_multicast.MulticastLinearTest) ... ok 62: WARNING: ThreadSanitizer: data race (pid=16451) 62: Write of size 8 at 0x7b4400019568 by thread T1: 62: #0 qdr_delivery_mcast_outbound_disposition_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:989 (libqpid-dispatch.so+0xb59ef) 62: #1 qdr_delivery_mcast_outbound_update_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:1015 (libqpid-dispatch.so+0xb59ef) 62: #2 qdr_update_delivery_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:680 (libqpid-dispatch.so+0xb6475) 62: #3 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xca645) 62: #4 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 62: #5 (libtsan.so.0+0x2d1af) 62: Previous read of size 8 at 0x7b4400019568 by thread T2: 62: #0 qdr_connection_process /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:403 (libqpid-dispatch.so+0xa7fbd) 62: #1 AMQP_writable_conn_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:299 (libqpid-dispatch.so+0xe3e01) 62: #2 writable_handler /home/travis/build/apache/qpid-dispatch/src/container.c:395 (libqpid-dispatch.so+0x76264) 62: #3 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:747 (libqpid-dispatch.so+0x76264) 62: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1) 62: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a5c) 62: #6 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 62: #7 (libtsan.so.0+0x2d1af) 62: Location is heap block of size 320 at 0x7b4400019500 allocated by thread T2: 62: #0 posix_memalign (libtsan.so.0+0x3048d) 62: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 (libqpid-dispatch.so+0x614c4) 62: #2 new_qdr_delivery_t /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24 (libqpid-dispatch.so+0xb25e5) 62: #3 qdr_link_deliver_to /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:82 (libqpid-dispatch.so+0xd046d) 62: #4 AMQP_rx_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:818 (libqpid-dispatch.so+0xe62df) 62: #5 do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:227 (libqpid-dispatch.so+0x76574) 62: #6 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:737 (libqpid-dispatch.so+0x76574) 62: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1) 62: #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a5c) 62: #9 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 62: #10 (libtsan.so.0+0x2d1af) 62: Thread T1 (tid=16453, running) created by main thread at: 62: #0 pthread_create (libtsan.so.0+0x5ea99) 62: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2) 62: #2 qdr_core /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 (libqpid-dispatch.so+0xc4bee) 62: #3 qd_router_setup_late /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 (libqpid-dispatch.so+0xe865c) 62: #4 (libffi.so.7+0x6ff4) 62: #5 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2) 62: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882) 62: Thread T2 (tid=16454, running) created by main thread at: 62: #0 pthread_create (libtsan.so.0+0x5ea99) 62: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2) 62: #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf0cca) 62: #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27) 62: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882) 62: SUMMARY: ThreadSanitizer: data race /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:989 in qdr_delivery_mcast_outbound_disposition_CT -- This message was sent by Atlassian Jira (v8.3.4#803005) -
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1227: Tcp buffering main
codecov-commenter commented on pull request #1227: URL: https://github.com/apache/qpid-dispatch/pull/1227#issuecomment-844470443 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1227](https://codecov.io/gh/apache/qpid-dispatch/pull/1227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e53a053) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/81e4be87682a14ae120a3e8d9c2f83493b7b0453?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81e4be8) will **decrease** coverage by `0.16%`. > The diff coverage is `92.22%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1227 +/- ## == - Coverage 84.79% 84.62% -0.17% == Files 113 113 Lines 2800328020 +17 == - Hits2374423712 -32 - Misses 4259 4308 +49 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.07% <90.00%> (-0.13%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `76.04% <92.50%> (-1.21%)` | :arrow_down: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-3.88%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.73% <0.00%> (-1.09%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.70% <0.00%> (-0.19%)` | :arrow_down: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.15% <0.00%> (+0.12%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | --
[GitHub] [qpid-dispatch] grs opened a new pull request #1227: Tcp buffering main
grs opened a new pull request #1227: URL: https://github.com/apache/qpid-dispatch/pull/1227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2142) use dedicated buffers in tcp adaptor
Gordon Sim created DISPATCH-2142: Summary: use dedicated buffers in tcp adaptor Key: DISPATCH-2142 URL: https://issues.apache.org/jira/browse/DISPATCH-2142 Project: Qpid Dispatch Issue Type: Improvement Components: Protocol Adaptors Reporter: Gordon Sim Proton's raw connection support reads and writes each buffer with a separate read/write. As the routers buffers are very small, this is inefficient. The tcp adaptor could have dedicated buffers which could be larger and more efficient for use with proton, and then copy to/from these from the routers buffers. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2385) Update netty release to latest
[ https://issues.apache.org/jira/browse/PROTON-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish resolved PROTON-2385. - Resolution: Fixed > Update netty release to latest > -- > > Key: PROTON-2385 > URL: https://issues.apache.org/jira/browse/PROTON-2385 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M1 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M2 > > > Update Netty release to 4.1.65.Final and update some test dependencies to > latest -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2385) Update netty release to latest
[ https://issues.apache.org/jira/browse/PROTON-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347848#comment-17347848 ] ASF subversion and git services commented on PROTON-2385: - Commit f38358f14f3e01c15a15a0b4e42912898b7d7bd2 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=f38358f ] PROTON-2385 Update netty to latest 4.1.65.Final Update netty and bring Mockito to latest release as well. > Update netty release to latest > -- > > Key: PROTON-2385 > URL: https://issues.apache.org/jira/browse/PROTON-2385 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M1 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M2 > > > Update Netty release to 4.1.65.Final and update some test dependencies to > latest -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2385) Update netty release to latest
Timothy A. Bish created PROTON-2385: --- Summary: Update netty release to latest Key: PROTON-2385 URL: https://issues.apache.org/jira/browse/PROTON-2385 Project: Qpid Proton Issue Type: Task Components: protonj2 Affects Versions: protonj2-1.0.0-M1 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: protonj2-1.0.0-M2 Update Netty release to 4.1.65.Final and update some test dependencies to latest -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2140) race setting/reading qdr_connection_t context
[ https://issues.apache.org/jira/browse/DISPATCH-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2140: - Labels: race-condition tsan (was: ) > race setting/reading qdr_connection_t context > - > > Key: DISPATCH-2140 > URL: https://issues.apache.org/jira/browse/DISPATCH-2140 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: race-condition, tsan > Fix For: 1.17.0 > > > 69: test_008_put_10 (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest) > ... ok > 69: WARNING: ThreadSanitizer: data race (pid=17014) > 69: Read of size 8 at 0x7b5400089a10 by thread T1: > 69: #0 qdr_connection_get_context > /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:237 > (libqpid-dispatch.so+0xa7587) > 69: #1 qdr_tcp_activate > /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:1573 > (libqpid-dispatch.so+0x596f8) > 69: #2 qdr_activate_connections_CT > /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89 > (libqpid-dispatch.so+0xca7d4) > 69: #3 router_core_thread > /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247 > (libqpid-dispatch.so+0xca7d4) > 69: #4 _thread_init > /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0x96f16) > 69: #5 (libtsan.so.0+0x2d1af) > 69: Previous write of size 8 at 0x7b5400089a10 by thread T2: > 69: #0 qdr_connection_set_context > /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162 > (libqpid-dispatch.so+0xa72ea) > 69: #1 handle_disconnected > /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:499 > (libqpid-dispatch.so+0x5d2a8) > 69: #2 handle_connection_event > /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:804 > (libqpid-dispatch.so+0x5d2a8) > 69: #3 handle_event_with_context > /home/travis/build/apache/qpid-dispatch/src/server.c:802 > (libqpid-dispatch.so+0xed109) > 69: #4 do_handle_raw_connection_event > /home/travis/build/apache/qpid-dispatch/src/server.c:808 > (libqpid-dispatch.so+0xed109) > 69: #5 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 > (libqpid-dispatch.so+0xed109) > 69: #6 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0xf0ad7) > 69: #7 _thread_init > /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0x96f16) > 69: #8 (libtsan.so.0+0x2d1af) > 69: Location is heap block of size 640 at 0x7b5400089800 allocated by thread > T4: > 69: #0 posix_memalign (libtsan.so.0+0x3048d) > 69: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 > (libqpid-dispatch.so+0x614c4) > 69: #2 new_qdr_connection_t > /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44 > (libqpid-dispatch.so+0xa6895) > 69: #3 qdr_connection_opened > /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89 > (libqpid-dispatch.so+0xa6ca6) > 69: #4 qdr_tcp_connection_ingress_accept > /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:701 > (libqpid-dispatch.so+0x5cb8a) > 69: #5 handle_connection_event > /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:759 > (libqpid-dispatch.so+0x5cb8a) > 69: #6 handle_event_with_context > /home/travis/build/apache/qpid-dispatch/src/server.c:802 > (libqpid-dispatch.so+0xed109) > 69: #7 do_handle_raw_connection_event > /home/travis/build/apache/qpid-dispatch/src/server.c:808 > (libqpid-dispatch.so+0xed109) > 69: #8 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 > (libqpid-dispatch.so+0xed109) > 69: #9 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0xf0ad7) > 69: #10 _thread_init > /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0x96f16) > 69: #11 (libtsan.so.0+0x2d1af) > 69: Thread T1 (tid=17016, running) created by main thread at: > 69: #0 pthread_create (libtsan.so.0+0x5ea99) > 69: #1 sys_thread > /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 > (libqpid-dispatch.so+0x974d2) > 69: #2 qdr_core > /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 > (libqpid-dispatch.so+0xc4bee) > 69: #3 qd_router_setup_late > /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 > (libqpid-dispatch.so+0xe865c) > 69: #4 (libffi.so.7+0x6ff4) > 69: #5 main_process > /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 > (qdrouterd+0x2bb2) > 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 > (qdrouterd+0x2882) > 69: T
[jira] [Created] (DISPATCH-2141) race moving qdr_delivery_state_t
Ken Giusti created DISPATCH-2141: Summary: race moving qdr_delivery_state_t Key: DISPATCH-2141 URL: https://issues.apache.org/jira/browse/DISPATCH-2141 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.16.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.17.0 Start 70: system_tests_tcp_adaptor 70: Test command: /usr/bin/python3.8 "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v" "system_tests_tcp_adaptor" 70: WARNING: ThreadSanitizer: data race (pid=17034) 70: Write of size 8 at 0x7b4400031f28 by thread T1 (mutexes: write M2555): 70: #0 qdr_delivery_move_delivery_state_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:1263 (libqpid-dispatch.so+0xb60a8) 70: #1 qdr_delivery_anycast_update_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:728 (libqpid-dispatch.so+0xb6228) 70: #2 qdr_update_delivery_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:688 (libqpid-dispatch.so+0xb6228) 70: #3 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xca645) 70: #4 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 70: #5 (libtsan.so.0+0x2d1af) 70: Previous read of size 8 at 0x7b4400031f28 by thread T4: 70: #0 qdr_connection_process /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:403 (libqpid-dispatch.so+0xa7fbd) 70: #1 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:855 (libqpid-dispatch.so+0x5d621) 70: #2 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:802 (libqpid-dispatch.so+0xed109) 70: #3 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:808 (libqpid-dispatch.so+0xed109) 70: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 (libqpid-dispatch.so+0xed109) 70: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0ad7) 70: #6 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 70: #7 (libtsan.so.0+0x2d1af) 70: Location is heap block of size 320 at 0x7b4400031ec0 allocated by thread T3: 70: #0 posix_memalign (libtsan.so.0+0x3048d) 70: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 (libqpid-dispatch.so+0x614c4) 70: #2 new_qdr_delivery_t /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24 (libqpid-dispatch.so+0xb25e5) 70: #3 qdr_link_deliver /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:47 (libqpid-dispatch.so+0xd013d) 70: #4 AMQP_rx_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:868 (libqpid-dispatch.so+0xe6571) 70: #5 do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:227 (libqpid-dispatch.so+0x76574) 70: #6 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:737 (libqpid-dispatch.so+0x76574) 70: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1) 70: #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf09d8) 70: #9 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 70: #10 (libtsan.so.0+0x2d1af) 70: Mutex M2555 (0x7b158600) created at: 70: #0 pthread_mutex_init (libtsan.so.0+0x4a636) 70: #1 sys_mutex /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x96f7f) 70: #2 qdr_link_deliver /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:62 (libqpid-dispatch.so+0xd02b1) 70: #3 handle_incoming /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:360 (libqpid-dispatch.so+0x5c38e) 70: #4 qdr_tcp_flow /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:1325 (libqpid-dispatch.so+0x5de0d) 70: #5 qdr_connection_process /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:422 (libqpid-dispatch.so+0xa8493) 70: #6 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:840 (libqpid-dispatch.so+0x5c9a9) 70: #7 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:802 (libqpid-dispatch.so+0xed109) 70: #8 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:808 (libqpid-dispatch.so+0xed109) 70: #9 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 (libqpid-dispatch.so+0xed109) 70: #10 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0ad7) 70: #11 _thread_init /home/travis/build/apache/qpid-dispatch
[jira] [Updated] (DISPATCH-2077) Replace usage of `clock_gettime` in `qd_timer_now` with `pn_proactor_now_64` from Proton
[
https://issues.apache.org/jira/browse/DISPATCH-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2077:
-
Description:
*Assignee: Ankit Aggarwal*
If you take a look into Proton how {{pn_proactor_now_64}} is implemented, you
will see there are actually three implementations that are used depending on
platform. One of the implementations is a Windows one, btw ;P
This is part of solving the issue "[Qpid-dispatch] timespec not defined on
Windows" described at
http://qpid.2158936.n2.nabble.com/Qpid-dispatch-timespec-not-defined-on-Windows-td7642532.html
See discussion "C types for timestamps and durations" for more background
http://qpid.2158936.n2.nabble.com/C-types-for-timestamps-and-durations-td7682395.html
was:
If you take a look into Proton how {{pn_proactor_now_64}} is implemented, you
will see there are actually three implementations that are used depending on
platform. One of the implementations is a Windows one, btw ;P
This is part of solving the issue "[Qpid-dispatch] timespec not defined on
Windows" described at
http://qpid.2158936.n2.nabble.com/Qpid-dispatch-timespec-not-defined-on-Windows-td7642532.html
See discussion "C types for timestamps and durations" for more background
http://qpid.2158936.n2.nabble.com/C-types-for-timestamps-and-durations-td7682395.html
> Replace usage of `clock_gettime` in `qd_timer_now` with `pn_proactor_now_64`
> from Proton
>
>
> Key: DISPATCH-2077
> URL: https://issues.apache.org/jira/browse/DISPATCH-2077
> Project: Qpid Dispatch
> Issue Type: Sub-task
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.17.0
>
>
> *Assignee: Ankit Aggarwal*
> If you take a look into Proton how {{pn_proactor_now_64}} is implemented, you
> will see there are actually three implementations that are used depending on
> platform. One of the implementations is a Windows one, btw ;P
> This is part of solving the issue "[Qpid-dispatch] timespec not defined on
> Windows" described at
> http://qpid.2158936.n2.nabble.com/Qpid-dispatch-timespec-not-defined-on-Windows-td7642532.html
> See discussion "C types for timestamps and durations" for more background
> http://qpid.2158936.n2.nabble.com/C-types-for-timestamps-and-durations-td7682395.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2140) race setting/reading qdr_connection_t context
Ken Giusti created DISPATCH-2140: Summary: race setting/reading qdr_connection_t context Key: DISPATCH-2140 URL: https://issues.apache.org/jira/browse/DISPATCH-2140 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.16.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.17.0 69: test_008_put_10 (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest) ... ok 69: WARNING: ThreadSanitizer: data race (pid=17014) 69: Read of size 8 at 0x7b5400089a10 by thread T1: 69: #0 qdr_connection_get_context /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:237 (libqpid-dispatch.so+0xa7587) 69: #1 qdr_tcp_activate /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:1573 (libqpid-dispatch.so+0x596f8) 69: #2 qdr_activate_connections_CT /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89 (libqpid-dispatch.so+0xca7d4) 69: #3 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247 (libqpid-dispatch.so+0xca7d4) 69: #4 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 69: #5 (libtsan.so.0+0x2d1af) 69: Previous write of size 8 at 0x7b5400089a10 by thread T2: 69: #0 qdr_connection_set_context /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162 (libqpid-dispatch.so+0xa72ea) 69: #1 handle_disconnected /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:499 (libqpid-dispatch.so+0x5d2a8) 69: #2 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:804 (libqpid-dispatch.so+0x5d2a8) 69: #3 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:802 (libqpid-dispatch.so+0xed109) 69: #4 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:808 (libqpid-dispatch.so+0xed109) 69: #5 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 (libqpid-dispatch.so+0xed109) 69: #6 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0ad7) 69: #7 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 69: #8 (libtsan.so.0+0x2d1af) 69: Location is heap block of size 640 at 0x7b5400089800 allocated by thread T4: 69: #0 posix_memalign (libtsan.so.0+0x3048d) 69: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 (libqpid-dispatch.so+0x614c4) 69: #2 new_qdr_connection_t /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44 (libqpid-dispatch.so+0xa6895) 69: #3 qdr_connection_opened /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89 (libqpid-dispatch.so+0xa6ca6) 69: #4 qdr_tcp_connection_ingress_accept /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:701 (libqpid-dispatch.so+0x5cb8a) 69: #5 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:759 (libqpid-dispatch.so+0x5cb8a) 69: #6 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:802 (libqpid-dispatch.so+0xed109) 69: #7 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:808 (libqpid-dispatch.so+0xed109) 69: #8 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 (libqpid-dispatch.so+0xed109) 69: #9 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0ad7) 69: #10 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 69: #11 (libtsan.so.0+0x2d1af) 69: Thread T1 (tid=17016, running) created by main thread at: 69: #0 pthread_create (libtsan.so.0+0x5ea99) 69: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2) 69: #2 qdr_core /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 (libqpid-dispatch.so+0xc4bee) 69: #3 qd_router_setup_late /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 (libqpid-dispatch.so+0xe865c) 69: #4 (libffi.so.7+0x6ff4) 69: #5 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2) 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882) 69: Thread T2 (tid=17017, running) created by main thread at: 69: #0 pthread_create (libtsan.so.0+0x5ea99) 69: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2) 69: #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf0cca) 69: #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27) 69: #4 main /home/travis/build/apac
[jira] [Commented] (DISPATCH-2126) qdr_delivery_t->settled flag race
[ https://issues.apache.org/jira/browse/DISPATCH-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347830#comment-17347830 ] Ken Giusti commented on DISPATCH-2126: -- Same race when propagating anycast messages: 27: test_90_block_link_route_EB1_INTB (system_tests_policy_oversize_compound.MaxMessageSizeLinkRouteOversize) ... ok 27: WARNING: ThreadSanitizer: data race (pid=14467) 27: Read of size 1 at 0x7b4400014314 by thread T2 (mutexes: write M691): 27: #0 qdr_link_process_deliveries /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:166 (libqpid-dispatch.so+0xd0b7a) 27: #1 CORE_link_push /home/travis/build/apache/qpid-dispatch/src/router_node.c:1920 (libqpid-dispatch.so+0xe47b7) 27: #2 qdr_connection_process /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:414 (libqpid-dispatch.so+0xa80e2) 27: #3 AMQP_writable_conn_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:299 (libqpid-dispatch.so+0xe3e01) 27: #4 writable_handler /home/travis/build/apache/qpid-dispatch/src/container.c:395 (libqpid-dispatch.so+0x76264) 27: #5 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:747 (libqpid-dispatch.so+0x76264) 27: #6 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1) 27: #7 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a5c) 27: #8 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 27: #9 (libtsan.so.0+0x2d1af) 27: Previous write of size 1 at 0x7b4400014314 by thread T1: 27: #0 qdr_delivery_anycast_update_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:733 (libqpid-dispatch.so+0xb6244) 27: #1 qdr_update_delivery_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:688 (libqpid-dispatch.so+0xb6244) 27: #2 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xca645) 27: #3 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 27: #4 (libtsan.so.0+0x2d1af) 27: Location is heap block of size 320 at 0x7b4400014280 allocated by thread T2: 27: #0 posix_memalign (libtsan.so.0+0x3048d) 27: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 (libqpid-dispatch.so+0x614c4) 27: #2 new_qdr_delivery_t /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24 (libqpid-dispatch.so+0xb25e5) 27: #3 qdr_link_deliver_to /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:82 (libqpid-dispatch.so+0xd046d) 27: #4 AMQP_rx_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:818 (libqpid-dispatch.so+0xe62df) 27: #5 do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:227 (libqpid-dispatch.so+0x76574) 27: #6 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:737 (libqpid-dispatch.so+0x76574) 27: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1) 27: #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a5c) 27: #9 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16) 27: #10 (libtsan.so.0+0x2d1af) > qdr_delivery_t->settled flag race > - > > Key: DISPATCH-2126 > URL: https://issues.apache.org/jira/browse/DISPATCH-2126 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: race-condition, tsan > Fix For: 1.17.0 > > > I/O thread reads the qdr_delivery_t->settled flag while calling the > delivery_update_handler, while core thread is updating it while processing > multicast. > > 5: WARNING: ThreadSanitizer: data race (pid=568299) > 65: Read of size 1 at 0x7b58131c by thread T4: > 65: #0 qdr_connection_process > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:403 > (libqpid-dispatch.so+0xc4a30) > 65: #1 AMQP_writable_conn_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 > (libqpid-dispatch.so+0x122d42) > 65: #2 writable_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 > (libqpid-dispatch.so+0x7b2e2) > 65: #3 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 > (libqpid-dispatch.so+0x7cfd5) > 65: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x130537) > 65: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121
[jira] [Resolved] (DISPATCH-1986) [http1] system_tests_http1_adaptor failure due to Address already in use issue
[
https://issues.apache.org/jira/browse/DISPATCH-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1986.
-
Resolution: Fixed
> [http1] system_tests_http1_adaptor failure due to Address already in use issue
> --
>
> Key: DISPATCH-1986
> URL: https://issues.apache.org/jira/browse/DISPATCH-1986
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 68: test_01_mgmt (system_tests_http1_adaptor.Http1AdaptorManagementTest) ...
> ok
> 68: test_000_stats (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_001_get (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ... ok
> 68: test_002_head (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_003_post (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_004_put (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ... ok
> 68: test_005_get_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ERROR
> 68: test_006_head_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68: test_007_post_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68: test_008_put_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68:
> 68: Router INT.A debug dump file:
> 68:
> 68: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 16
> (SUPPRESSED)
> 68:
> 68:
> 68: test_01_backpressure_client
> (system_tests_http1_adaptor.Http1AdaptorQ2Standalone) ... ok
> 68: test_02_backpressure_server
> (system_tests_http1_adaptor.Http1AdaptorQ2Standalone) ... ok
> 68:
> 68: ==
> 68: ERROR: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: --
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1238, in test_02_credit_replenish
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ==
> 68: ERROR: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: --
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1270, in test_03_server_reconnect
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ==
> 68: ERROR: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: --
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1321, in t
[jira] [Commented] (DISPATCH-2139) system_tests_http1_over_tcp failing with HTTP resp code 503
[
https://issues.apache.org/jira/browse/DISPATCH-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347826#comment-17347826
]
Ganesh Murthy commented on DISPATCH-2139:
-
https://travis-ci.com/github/apache/qpid-dispatch/jobs/506390789#L9136
> system_tests_http1_over_tcp failing with HTTP resp code 503
> ---
>
> Key: DISPATCH-2139
> URL: https://issues.apache.org/jira/browse/DISPATCH-2139
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> test 69
> Start 69: system_tests_http1_over_tcp
> 69: Test command: /opt/python/3.6.8/bin/python3.6
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_http1_over_tcp"
> 69: Test timeout computed to be: 1200
> 69: test_01_concurrent_requests
> (system_tests_http1_over_tcp.Http1OverTcpEdge2EdgeTest) ... TestClient:
> c470bf97aa5847beabbb59ee1c61e526
> 69: 2021-05-19 15:51:29.424833 TestClient connecting on 127.0.0.1:24777
> 69: 2021-05-19 15:51:29.424874 TestClient connected
> 69: 2021-05-19 15:51:29.424879 TestClient start request 0
> 69: 2021-05-19 15:51:29.424883 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:29.425373 TestClient getting PUT response
> 69: 2021-05-19 15:51:30.282139 TestClient response PUT received
> 69: 2021-05-19 15:51:30.282171 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:30.282176 TestClient sending GET
> /GET/test_01_concurrent_requests_11_small request
> 69: 2021-05-19 15:51:30.282246 TestClient getting GET response
> 69: 2021-05-19 15:51:30.519709 TestClient response GET received
> 69: 2021-05-19 15:51:30.519810 TestClient request GET
> /GET/test_01_concurrent_requests_11_small completed!
> 69: 2021-05-19 15:51:30.519816 TestClient sending GET
> /GET/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:30.519905 TestClient getting GET response
> 69: 2021-05-19 15:51:31.219387 TestClient response GET received
> 69: 2021-05-19 15:51:31.690291 TestClient request GET
> /GET/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:31.690308 TestClient start request 1
> 69: 2021-05-19 15:51:31.690316 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:31.690553 TestClient getting PUT response
> 69: 2021-05-19 15:51:32.307847 TestClient response PUT received
> 69: 2021-05-19 15:51:32.307931 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:32.307938 TestClient sending GET
> /GET/test_01_concurrent_requests_11_small request
> 69: 2021-05-19 15:51:32.308040 TestClient getting GET response
> 69: 2021-05-19 15:51:32.637675 TestClient response GET received
> 69: 2021-05-19 15:51:32.637710 TestClient request GET
> /GET/test_01_concurrent_requests_11_small completed!
> 69: 2021-05-19 15:51:32.637714 TestClient sending GET
> /GET/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:32.637780 TestClient getting GET response
> 69: 2021-05-19 15:51:33.067768 TestClient response GET received
> 69: 2021-05-19 15:51:33.740987 TestClient request GET
> /GET/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:33.740998 TestClient start request 2
> 69: 2021-05-19 15:51:33.741004 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:33.741220 TestClient getting PUT response
> 69: 2021-05-19 15:51:34.523878 TestClient response PUT received
> 69: 2021-05-19 15:51:34.523955 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:34.523960 TestClient sending GET
> /GET/test_01_concurrent_requests_11_small request
> 69: 2021-05-19 15:51:34.524036 TestClient getting GET response
> 69: 2021-05-19 15:51:34.977493 TestClient response GET received
> 69: 2021-05-19 15:51:34.977546 TestClient request GET
> /GET/test_01_concurrent_requests_11_small completed!
> 69: 2021-05-19 15:51:34.977551 TestClient sending GET
> /GET/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:34.977662 TestClient getting GET response
> 69: 2021-05-19 15:51:35.886808 TestClient response GET received
> 69: 2021-05-19 15:51:36.406301 TestClient request GET
> /GET/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:36.406315 TestClient start request 3
> 69: 2021-05-19 15:51:36.406321 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:36.406545 TestClient getting PUT response
> 69: 2021-05-19 15:51:37.316868 TestClient response PUT received
> 69: 2021-05-19 15:51:37.316961 TestClient request PUT
> /PUT/t
[jira] [Assigned] (DISPATCH-2137) multiple data races in the SASL plugin
[ https://issues.apache.org/jira/browse/DISPATCH-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-2137: --- Assignee: Ganesh Murthy (was: Ken Giusti) > multiple data races in the SASL plugin > -- > > Key: DISPATCH-2137 > URL: https://issues.apache.org/jira/browse/DISPATCH-2137 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: race-condition, tsan > Fix For: 1.17.0 > > > 44: WARNING: ThreadSanitizer: data race (pid=652787) > 44: Read of size 1 at 0x7b32ddc0 by main thread: > 44: #0 remote_sasl_prepare > /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:344 > (libqpid-dispatch.so+0xab480) > 44: #1 pni_sasl_impl_prepare_write > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:219 > (libqpid-proton-core.so.10+0x2895b) > 44: #2 pn_output_write_sasl > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:691 > (libqpid-proton-core.so.10+0x2895b) > 44: #3 qd_server_run > /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 > (libqpid-dispatch.so+0x132935) > 44: #4 main_process > /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 > (qdrouterd+0x40271a) > 44: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 > (qdrouterd+0x403557) > 44: > 44: Previous write of size 1 at 0x7b32ddc0 by thread T4: > 44: #0 notify_downstream > /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:276 > (libqpid-dispatch.so+0xaaf79) > 44: #1 remote_sasl_process_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:445 > (libqpid-dispatch.so+0xabb75) > 44: #2 pni_sasl_impl_process_init > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:224 > (libqpid-proton-core.so.10+0x297b5) > 44: #3 pn_do_init /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:903 > (libqpid-proton-core.so.10+0x297b5) > 44: #4 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad38a) > 44: #5 (libtsan.so.0+0x2d33f) > > > 44: Read of size 8 at 0x7b32dda8 by main thread: > 44: #0 remote_sasl_prepare > /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:345 > (libqpid-dispatch.so+0xab4a5) > 44: #1 pni_sasl_impl_prepare_write > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:219 > (libqpid-proton-core.so.10+0x2895b) > 44: #2 pn_output_write_sasl > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:691 > (libqpid-proton-core.so.10+0x2895b) > 44: #3 qd_server_run > /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 > (libqpid-dispatch.so+0x132935) > 44: #4 main_process > /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 > (qdrouterd+0x40271a) > 44: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 > (qdrouterd+0x403557) > 44: > 44: Previous write of size 8 at 0x7b32dda8 by thread T4: > 44: #0 remote_sasl_process_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:443 > (libqpid-dispatch.so+0xabb40) > 44: #1 pni_sasl_impl_process_init > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:224 > (libqpid-proton-core.so.10+0x297b5) > 44: #2 pn_do_init /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:903 > (libqpid-proton-core.so.10+0x297b5) > 44: #3 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad38a) > 44: #4 (libtsan.so.0+0x2d33f) > > -- > 44: Read of size 8 at 0x7b0418b0 by main thread: > 44: #0 strlen (libtsan.so.0+0x32c4f) > 44: #1 pn_strdup /home/kgiusti/work/proton/qpid-proton/c/src/core/util.c:122 > (libqpid-proton-core.so.10+0x26b3c) > 44: #2 pnx_sasl_set_selected_mechanism > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:147 > (libqpid-proton-core.so.10+0x26b3c) > 44: #3 pni_sasl_impl_prepare_write > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:219 > (libqpid-proton-core.so.10+0x2895b) > 44: #4 pn_output_write_sasl > /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:691 > (libqpid-proton-core.so.10+0x2895b) > 44: #5 qd_server_run > /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 > (libqpid-dispatch.so+0x132935) > 44: #6 main_process > /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 > (qdrouterd+0x40271a) > 44: #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 > (qdrouterd+0x403557) > 44: > 44: Previous write of size 8 at 0x7b0418b0 by thread T4: > 44: #0 malloc (libtsan.so.0+0x304d3) > 44: #1 __GI___strdup > /usr/src/debug/glibc-2.31-74
[jira] [Assigned] (DISPATCH-2139) system_tests_http1_over_tcp failing with HTTP resp code 503
[
https://issues.apache.org/jira/browse/DISPATCH-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy reassigned DISPATCH-2139:
---
Assignee: Ken Giusti
> system_tests_http1_over_tcp failing with HTTP resp code 503
> ---
>
> Key: DISPATCH-2139
> URL: https://issues.apache.org/jira/browse/DISPATCH-2139
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> test 69
> Start 69: system_tests_http1_over_tcp
> 69: Test command: /opt/python/3.6.8/bin/python3.6
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_http1_over_tcp"
> 69: Test timeout computed to be: 1200
> 69: test_01_concurrent_requests
> (system_tests_http1_over_tcp.Http1OverTcpEdge2EdgeTest) ... TestClient:
> c470bf97aa5847beabbb59ee1c61e526
> 69: 2021-05-19 15:51:29.424833 TestClient connecting on 127.0.0.1:24777
> 69: 2021-05-19 15:51:29.424874 TestClient connected
> 69: 2021-05-19 15:51:29.424879 TestClient start request 0
> 69: 2021-05-19 15:51:29.424883 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:29.425373 TestClient getting PUT response
> 69: 2021-05-19 15:51:30.282139 TestClient response PUT received
> 69: 2021-05-19 15:51:30.282171 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:30.282176 TestClient sending GET
> /GET/test_01_concurrent_requests_11_small request
> 69: 2021-05-19 15:51:30.282246 TestClient getting GET response
> 69: 2021-05-19 15:51:30.519709 TestClient response GET received
> 69: 2021-05-19 15:51:30.519810 TestClient request GET
> /GET/test_01_concurrent_requests_11_small completed!
> 69: 2021-05-19 15:51:30.519816 TestClient sending GET
> /GET/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:30.519905 TestClient getting GET response
> 69: 2021-05-19 15:51:31.219387 TestClient response GET received
> 69: 2021-05-19 15:51:31.690291 TestClient request GET
> /GET/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:31.690308 TestClient start request 1
> 69: 2021-05-19 15:51:31.690316 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:31.690553 TestClient getting PUT response
> 69: 2021-05-19 15:51:32.307847 TestClient response PUT received
> 69: 2021-05-19 15:51:32.307931 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:32.307938 TestClient sending GET
> /GET/test_01_concurrent_requests_11_small request
> 69: 2021-05-19 15:51:32.308040 TestClient getting GET response
> 69: 2021-05-19 15:51:32.637675 TestClient response GET received
> 69: 2021-05-19 15:51:32.637710 TestClient request GET
> /GET/test_01_concurrent_requests_11_small completed!
> 69: 2021-05-19 15:51:32.637714 TestClient sending GET
> /GET/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:32.637780 TestClient getting GET response
> 69: 2021-05-19 15:51:33.067768 TestClient response GET received
> 69: 2021-05-19 15:51:33.740987 TestClient request GET
> /GET/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:33.740998 TestClient start request 2
> 69: 2021-05-19 15:51:33.741004 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:33.741220 TestClient getting PUT response
> 69: 2021-05-19 15:51:34.523878 TestClient response PUT received
> 69: 2021-05-19 15:51:34.523955 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:34.523960 TestClient sending GET
> /GET/test_01_concurrent_requests_11_small request
> 69: 2021-05-19 15:51:34.524036 TestClient getting GET response
> 69: 2021-05-19 15:51:34.977493 TestClient response GET received
> 69: 2021-05-19 15:51:34.977546 TestClient request GET
> /GET/test_01_concurrent_requests_11_small completed!
> 69: 2021-05-19 15:51:34.977551 TestClient sending GET
> /GET/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:34.977662 TestClient getting GET response
> 69: 2021-05-19 15:51:35.886808 TestClient response GET received
> 69: 2021-05-19 15:51:36.406301 TestClient request GET
> /GET/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:36.406315 TestClient start request 3
> 69: 2021-05-19 15:51:36.406321 TestClient sending PUT
> /PUT/test_01_concurrent_requests_11 request
> 69: 2021-05-19 15:51:36.406545 TestClient getting PUT response
> 69: 2021-05-19 15:51:37.316868 TestClient response PUT received
> 69: 2021-05-19 15:51:37.316961 TestClient request PUT
> /PUT/test_01_concurrent_requests_11 completed!
> 69: 2021-05-19 15:51:37.316969 TestClient sending GET
[jira] [Created] (DISPATCH-2139) system_tests_http1_over_tcp failing with HTTP resp code 503
Ganesh Murthy created DISPATCH-2139:
---
Summary: system_tests_http1_over_tcp failing with HTTP resp code
503
Key: DISPATCH-2139
URL: https://issues.apache.org/jira/browse/DISPATCH-2139
Project: Qpid Dispatch
Issue Type: Test
Components: Protocol Adaptors
Affects Versions: 1.16.0
Reporter: Ganesh Murthy
{noformat}
test 69
Start 69: system_tests_http1_over_tcp
69: Test command: /opt/python/3.6.8/bin/python3.6
"/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
"-v" "system_tests_http1_over_tcp"
69: Test timeout computed to be: 1200
69: test_01_concurrent_requests
(system_tests_http1_over_tcp.Http1OverTcpEdge2EdgeTest) ... TestClient:
c470bf97aa5847beabbb59ee1c61e526
69: 2021-05-19 15:51:29.424833 TestClient connecting on 127.0.0.1:24777
69: 2021-05-19 15:51:29.424874 TestClient connected
69: 2021-05-19 15:51:29.424879 TestClient start request 0
69: 2021-05-19 15:51:29.424883 TestClient sending PUT
/PUT/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:29.425373 TestClient getting PUT response
69: 2021-05-19 15:51:30.282139 TestClient response PUT received
69: 2021-05-19 15:51:30.282171 TestClient request PUT
/PUT/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:30.282176 TestClient sending GET
/GET/test_01_concurrent_requests_11_small request
69: 2021-05-19 15:51:30.282246 TestClient getting GET response
69: 2021-05-19 15:51:30.519709 TestClient response GET received
69: 2021-05-19 15:51:30.519810 TestClient request GET
/GET/test_01_concurrent_requests_11_small completed!
69: 2021-05-19 15:51:30.519816 TestClient sending GET
/GET/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:30.519905 TestClient getting GET response
69: 2021-05-19 15:51:31.219387 TestClient response GET received
69: 2021-05-19 15:51:31.690291 TestClient request GET
/GET/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:31.690308 TestClient start request 1
69: 2021-05-19 15:51:31.690316 TestClient sending PUT
/PUT/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:31.690553 TestClient getting PUT response
69: 2021-05-19 15:51:32.307847 TestClient response PUT received
69: 2021-05-19 15:51:32.307931 TestClient request PUT
/PUT/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:32.307938 TestClient sending GET
/GET/test_01_concurrent_requests_11_small request
69: 2021-05-19 15:51:32.308040 TestClient getting GET response
69: 2021-05-19 15:51:32.637675 TestClient response GET received
69: 2021-05-19 15:51:32.637710 TestClient request GET
/GET/test_01_concurrent_requests_11_small completed!
69: 2021-05-19 15:51:32.637714 TestClient sending GET
/GET/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:32.637780 TestClient getting GET response
69: 2021-05-19 15:51:33.067768 TestClient response GET received
69: 2021-05-19 15:51:33.740987 TestClient request GET
/GET/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:33.740998 TestClient start request 2
69: 2021-05-19 15:51:33.741004 TestClient sending PUT
/PUT/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:33.741220 TestClient getting PUT response
69: 2021-05-19 15:51:34.523878 TestClient response PUT received
69: 2021-05-19 15:51:34.523955 TestClient request PUT
/PUT/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:34.523960 TestClient sending GET
/GET/test_01_concurrent_requests_11_small request
69: 2021-05-19 15:51:34.524036 TestClient getting GET response
69: 2021-05-19 15:51:34.977493 TestClient response GET received
69: 2021-05-19 15:51:34.977546 TestClient request GET
/GET/test_01_concurrent_requests_11_small completed!
69: 2021-05-19 15:51:34.977551 TestClient sending GET
/GET/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:34.977662 TestClient getting GET response
69: 2021-05-19 15:51:35.886808 TestClient response GET received
69: 2021-05-19 15:51:36.406301 TestClient request GET
/GET/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:36.406315 TestClient start request 3
69: 2021-05-19 15:51:36.406321 TestClient sending PUT
/PUT/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:36.406545 TestClient getting PUT response
69: 2021-05-19 15:51:37.316868 TestClient response PUT received
69: 2021-05-19 15:51:37.316961 TestClient request PUT
/PUT/test_01_concurrent_requests_11 completed!
69: 2021-05-19 15:51:37.316969 TestClient sending GET
/GET/test_01_concurrent_requests_11_small request
69: 2021-05-19 15:51:37.317073 TestClient getting GET response
69: 2021-05-19 15:51:38.007026 TestClient response GET received
69: 2021-05-19 15:51:38.008632 TestClient request GET
/GET/test_01_concurrent_requests_11_small completed!
69: 2021-05-19 15:51:38.008641 TestClient sending GET
/GET/test_01_concurrent_requests_11 request
69: 2021-05-19 15:51:38.008743 TestClient g
[jira] [Assigned] (DISPATCH-2136) race accessing the aborted message flag
[ https://issues.apache.org/jira/browse/DISPATCH-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke reassigned DISPATCH-2136: -- Assignee: Charles E. Rolke (was: Ken Giusti) > race accessing the aborted message flag > --- > > Key: DISPATCH-2136 > URL: https://issues.apache.org/jira/browse/DISPATCH-2136 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Charles E. Rolke >Priority: Major > Labels: race-condition, tsan > Fix For: 1.17.0 > > > Asynchronous read/write of the aborted flag in the message content: > > 45: WARNING: ThreadSanitizer: data race (pid=652672) > 45: Write of size 1 at 0x7b64000928b4 by thread T1 (mutexes: write M374): > 45: #0 qd_message_set_aborted > /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:2911 > (libqpid-dispatch.so+0x9a4e4) > 45: #1 qdr_delivery_set_aborted > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c:123 > (libqpid-dispatch.so+0xd6453) > 45: #2 qdr_link_abort_undelivered_CT > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:980 > (libqpid-dispatch.so+0xc7fa1) > 45: #3 qdr_link_inbound_detach_CT > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:2008 > (libqpid-dispatch.so+0xce691) > 45: #4 router_core_thread > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 > (libqpid-dispatch.so+0xfb305) > 45: #5 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad38a) > 45: #6 (libtsan.so.0+0x2d33f) > 45: > 45: Previous read of size 1 at 0x7b64000928b4 by thread T3: > 45: #0 qd_message_send > /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1885 > (libqpid-dispatch.so+0x95b6d) > 45: #1 CORE_link_deliver > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1985 > (libqpid-dispatch.so+0x127ff6) > 45: #2 qdr_link_process_deliveries > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 > (libqpid-dispatch.so+0x10461d) > 45: #3 CORE_link_push > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 > (libqpid-dispatch.so+0x127d57) > 45: #4 qdr_connection_process > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 > (libqpid-dispatch.so+0xc4bfc) > 45: #5 AMQP_writable_conn_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 > (libqpid-dispatch.so+0x122d99) > 45: #6 writable_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 > (libqpid-dispatch.so+0x7b2f2) > 45: #7 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 > (libqpid-dispatch.so+0x7cfe5) > 45: #8 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x13058e) > 45: #9 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x130691) > 45: #10 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad38a) > 45: #11 (libtsan.so.0+0x2d33f) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1223: Tsan fixes - do not merge!
codecov-commenter edited a comment on pull request #1223: URL: https://github.com/apache/qpid-dispatch/pull/1223#issuecomment-843595423 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1223](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7625bb4) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/561306a4a9ae5952418713c497036f62156a90f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (561306a) will **increase** coverage by `0.07%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1223 +/- ## == + Coverage 84.60% 84.68% +0.07% == Files 113 113 Lines 2800828005 -3 == + Hits2369723716 +19 + Misses 4311 4289 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.83% <100.00%> (+1.30%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.53% <0.00%> (-0.44%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `87.96% <0.00%> (-0.20%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-0.19%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.20% <0.00%> (-0.06%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `75.49% <0.00%> (+0.46%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.88% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.23% <0.00%> (+0.96%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comme
[jira] [Updated] (DISPATCH-2083) [s390x] container.c:700: qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-2083:
Priority: Minor (was: Major)
> [s390x] container.c:700: qd_container_handle_event: Assertion
> `qd_conn->n_senders >= 0' failed
> --
>
> Key: DISPATCH-2083
> URL: https://issues.apache.org/jira/browse/DISPATCH-2083
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
> Environment: Travis CI Focal on s390x
>Reporter: Jiri Daněk
>Priority: Minor
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211930#L5514
> PR build, but IMO very unlikely the PR caused the issue.
> {noformat}
> 38: test_32_two_router_waypoint
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_33_one_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_34_one_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_35_two_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_36_two_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ...
> WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B command file:
> 38:
> 38: qdrouterd -c B.conf -I /home/travis/build/apache/qpid-dispatch/python
> 38: pid=13121
> 38:
> 38:
> 38:
> 38: Router B log file tail:
> 38:
> 38: 2021-04-26 19:50:34.632813 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.633027 + POLICY (debug) [C23] Connection
> '127.0.0.1:55896' closed with resources n_sessions=0, n_senders=0,
> n_receivers=0, sessions_denied=0, senders_denied=0, receivers_denied=0,
> max_message_size_denied:0, nConnections= 3.
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:318)
> 38: 2021-04-26 19:50:34.633247 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633525 + ROUTER_CORE (trace) [C23][L67][D395] :in
> qdr_delivery_unlink_peers_CT out: [C1][L22][D397]
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:542)
> 38: 2021-04-26 19:50:34.633711 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633893 + ROUTER_CORE (debug) [C1][L22][D397]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634098 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.634283 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634579 + ROUTER_CORE (info) [C23][L67] Link lost:
> del=10 presett=0 psdrop=0 acc=7 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 38: 2021-04-26 19:50:34.634768 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 38: 2021-04-26 19:50:34.635004 + ROUTER_CORE (info) Auto Link Activation
> Failed. 'autoLink/1' on container ALC
> (/ho
[jira] [Updated] (DISPATCH-2083) [s390x] container.c:700: qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-2083:
Fix Version/s: (was: 1.17.0)
> [s390x] container.c:700: qd_container_handle_event: Assertion
> `qd_conn->n_senders >= 0' failed
> --
>
> Key: DISPATCH-2083
> URL: https://issues.apache.org/jira/browse/DISPATCH-2083
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
> Environment: Travis CI Focal on s390x
>Reporter: Jiri Daněk
>Priority: Major
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211930#L5514
> PR build, but IMO very unlikely the PR caused the issue.
> {noformat}
> 38: test_32_two_router_waypoint
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_33_one_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_34_one_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_35_two_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_36_two_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ...
> WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B command file:
> 38:
> 38: qdrouterd -c B.conf -I /home/travis/build/apache/qpid-dispatch/python
> 38: pid=13121
> 38:
> 38:
> 38:
> 38: Router B log file tail:
> 38:
> 38: 2021-04-26 19:50:34.632813 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.633027 + POLICY (debug) [C23] Connection
> '127.0.0.1:55896' closed with resources n_sessions=0, n_senders=0,
> n_receivers=0, sessions_denied=0, senders_denied=0, receivers_denied=0,
> max_message_size_denied:0, nConnections= 3.
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:318)
> 38: 2021-04-26 19:50:34.633247 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633525 + ROUTER_CORE (trace) [C23][L67][D395] :in
> qdr_delivery_unlink_peers_CT out: [C1][L22][D397]
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:542)
> 38: 2021-04-26 19:50:34.633711 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633893 + ROUTER_CORE (debug) [C1][L22][D397]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634098 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.634283 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634579 + ROUTER_CORE (info) [C23][L67] Link lost:
> del=10 presett=0 psdrop=0 acc=7 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 38: 2021-04-26 19:50:34.634768 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 38: 2021-04-26 19:50:34.635004 + ROUTER_CORE (info) Auto Link Activation
> Failed. 'autoLink/1' on container ALC
> (
[jira] [Commented] (DISPATCH-2083) [s390x] container.c:700: qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347776#comment-17347776
]
Ganesh Murthy commented on DISPATCH-2083:
-
I still have been unable to reproduce the problem but the following is a
possibility
{noformat}
1. First attach sent
2. Second attach sent
3. First detach sent
4. Second detach sent
5. Response to first attach (increments n_senders to 1)
6. Response to first detach arrives (decrements n_senders to 0)
7. Response to second detach arrives (decrements n_senders to -1 - BOOM)
8. Response to second attach arrives.
the above is not what the log is showing but it could have very well happened
Again without reproducing this error, there is no chance of predicting that the
above were the exact sequence of events but since the attaches and detaches are
so close to each other, the above is a possibility {noformat}
After running the test repeatedly on an s390x system with RHEL 8, I have been
unable to reproduce it and hence hesitant to fix it. I am downgrading the
priority on this to Minor
> [s390x] container.c:700: qd_container_handle_event: Assertion
> `qd_conn->n_senders >= 0' failed
> --
>
> Key: DISPATCH-2083
> URL: https://issues.apache.org/jira/browse/DISPATCH-2083
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
> Environment: Travis CI Focal on s390x
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211930#L5514
> PR build, but IMO very unlikely the PR caused the issue.
> {noformat}
> 38: test_32_two_router_waypoint
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_33_one_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_34_one_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_35_two_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_36_two_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ...
> WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B command file:
> 38:
> 38: qdrouterd -c B.conf -I /home/travis/build/apache/qpid-dispatch/python
> 38: pid=13121
> 38:
> 38:
> 38:
> 38: Router B log file tail:
> 38:
> 38: 2021-04-26 19:50:34.632813 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.633027 + POLICY (debug) [C23] Connection
> '127.0.0.1:55896' closed with resources n_sessions=0, n_senders=0,
> n_receivers=0, sessions_denied=0, senders_denied=0, receivers_denied=0,
> max_message_size_denied:0, nConnections= 3.
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:318)
> 38: 2021-04-26 19:50:34.633247 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633525 + ROUTER_CORE (trace) [C23][L67][D395] :in
> qdr_delivery_unlink_peers_CT out: [C1][L22][D397]
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:542)
> 38: 2021-04-26 19:50:34.633711 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633893 + ROUTER_CORE (debug) [C1][L22][D397]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:
[jira] [Reopened] (DISPATCH-1986) [http1] system_tests_http1_adaptor failure due to Address already in use issue
[
https://issues.apache.org/jira/browse/DISPATCH-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy reopened DISPATCH-1986:
-
> [http1] system_tests_http1_adaptor failure due to Address already in use issue
> --
>
> Key: DISPATCH-1986
> URL: https://issues.apache.org/jira/browse/DISPATCH-1986
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 68: test_01_mgmt (system_tests_http1_adaptor.Http1AdaptorManagementTest) ...
> ok
> 68: test_000_stats (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_001_get (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ... ok
> 68: test_002_head (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_003_post (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_004_put (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ... ok
> 68: test_005_get_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ERROR
> 68: test_006_head_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68: test_007_post_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68: test_008_put_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68:
> 68: Router INT.A debug dump file:
> 68:
> 68: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 16
> (SUPPRESSED)
> 68:
> 68:
> 68: test_01_backpressure_client
> (system_tests_http1_adaptor.Http1AdaptorQ2Standalone) ... ok
> 68: test_02_backpressure_server
> (system_tests_http1_adaptor.Http1AdaptorQ2Standalone) ... ok
> 68:
> 68: ==
> 68: ERROR: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: --
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1238, in test_02_credit_replenish
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ==
> 68: ERROR: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: --
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1270, in test_03_server_reconnect
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ==
> 68: ERROR: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: --
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1321, in test_04_server_pining_f
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1223: Tsan fixes - do not merge!
codecov-commenter edited a comment on pull request #1223: URL: https://github.com/apache/qpid-dispatch/pull/1223#issuecomment-843595423 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1223](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5adc22c) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/561306a4a9ae5952418713c497036f62156a90f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (561306a) will **increase** coverage by `0.05%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1223 +/- ## == + Coverage 84.60% 84.66% +0.05% == Files 113 113 Lines 2800828005 -3 == + Hits2369723711 +14 + Misses 4311 4294 -17 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.65% <100.00%> (+0.11%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.10% <0.00%> (-0.87%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.57% <0.00%> (-0.30%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `87.96% <0.00%> (-0.20%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.20% <0.00%> (-0.06%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2R
[jira] [Commented] (QPID-8515) Improve operational logging and log every change to the broker state
[
https://issues.apache.org/jira/browse/QPID-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347749#comment-17347749
]
ASF GitHub Bot commented on QPID-8515:
--
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635374032
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -313,6 +313,7 @@ public String getPath()
public GroupAdapter(Map attributes)
{
super(FileBasedGroupProviderImpl.this, attributes);
+createOperationalLog(attributes);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve operational logging and log every change to the broker state
>
>
> Key: QPID-8515
> URL: https://issues.apache.org/jira/browse/QPID-8515
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Dedeepya
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Currently there is a gap in operational logging, where the deletion of access
> control groups is not logged. We need to identify any other such gaps and fix
> it to log every change happening to the broker state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #85: QPID-8515:[Broker-J]Add missing operational logs
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635374032
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -313,6 +313,7 @@ public String getPath()
public GroupAdapter(Map attributes)
{
super(FileBasedGroupProviderImpl.this, attributes);
+createOperationalLog(attributes);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8515) Improve operational logging and log every change to the broker state
[
https://issues.apache.org/jira/browse/QPID-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347748#comment-17347748
]
ASF GitHub Bot commented on QPID-8515:
--
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635373347
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/group/GroupMemberImpl.java
##
@@ -43,6 +43,7 @@
public GroupMemberImpl(Map attributes, Group group)
{
super((ConfiguredObject) group, attributes);
+createOperationalLog(attributes);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve operational logging and log every change to the broker state
>
>
> Key: QPID-8515
> URL: https://issues.apache.org/jira/browse/QPID-8515
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Dedeepya
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Currently there is a gap in operational logging, where the deletion of access
> control groups is not logged. We need to identify any other such gaps and fix
> it to log every change happening to the broker state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #85: QPID-8515:[Broker-J]Add missing operational logs
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635373347
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/group/GroupMemberImpl.java
##
@@ -43,6 +43,7 @@
public GroupMemberImpl(Map attributes, Group group)
{
super((ConfiguredObject) group, attributes);
+createOperationalLog(attributes);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDJMS-540) Target Java 11+ , i.e. drop support for Java 8 [/9/10]
[ https://issues.apache.org/jira/browse/QPIDJMS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPIDJMS-540. Resolution: Fixed > Target Java 11+ , i.e. drop support for Java 8 [/9/10] > -- > > Key: QPIDJMS-540 > URL: https://issues.apache.org/jira/browse/QPIDJMS-540 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 1.0.0 > > > Begin targeting Java 11 from the 1.0.0 release off the main branch, i.e start > requiring Java 11+ to build or use the client and drop support for Java 8 > [/9/10] for 1.0.0+. > The 0.x stream can be used for Java 8 support, with occasional releases for > important issues possible for a period of time, e.g a year. A 0.59.0 release > will be performed alongside the 1.0.0 release. > As discussed on the mailing list last month: > > [https://lists.apache.org/thread.html/r1558d5f402ac1cecd0785be72c441d1a034e3c49f72dbfdcd02d5f8c%40%3Cusers.qpid.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8515) Improve operational logging and log every change to the broker state
[
https://issues.apache.org/jira/browse/QPID-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347726#comment-17347726
]
ASF GitHub Bot commented on QPID-8515:
--
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635338646
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -391,6 +392,7 @@ public GroupMemberAdapter(Map attrMap)
{
// TODO - need to relate to the User object
super(GroupAdapter.this, attrMap);
+createOperationalLog(attrMap);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve operational logging and log every change to the broker state
>
>
> Key: QPID-8515
> URL: https://issues.apache.org/jira/browse/QPID-8515
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Dedeepya
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Currently there is a gap in operational logging, where the deletion of access
> control groups is not logged. We need to identify any other such gaps and fix
> it to log every change happening to the broker state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #85: QPID-8515:[Broker-J]Add missing operational logs
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635338646
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -391,6 +392,7 @@ public GroupMemberAdapter(Map attrMap)
{
// TODO - need to relate to the User object
super(GroupAdapter.this, attrMap);
+createOperationalLog(attrMap);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8515) Improve operational logging and log every change to the broker state
[
https://issues.apache.org/jira/browse/QPID-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347725#comment-17347725
]
ASF GitHub Bot commented on QPID-8515:
--
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635336922
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/group/GroupImpl.java
##
@@ -44,6 +44,7 @@ public GroupImpl(Map attributes,
GroupProvider provider)
{
super(provider, attributes);
+createOperationalLog(attributes);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve operational logging and log every change to the broker state
>
>
> Key: QPID-8515
> URL: https://issues.apache.org/jira/browse/QPID-8515
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Dedeepya
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Currently there is a gap in operational logging, where the deletion of access
> control groups is not logged. We need to identify any other such gaps and fix
> it to log every change happening to the broker state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #85: QPID-8515:[Broker-J]Add missing operational logs
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635336922
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/group/GroupImpl.java
##
@@ -44,6 +44,7 @@ public GroupImpl(Map attributes,
GroupProvider provider)
{
super(provider, attributes);
+createOperationalLog(attributes);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2138) qdr_link_t->detach_received flag race
Ken Giusti created DISPATCH-2138: Summary: qdr_link_t->detach_received flag race Key: DISPATCH-2138 URL: https://issues.apache.org/jira/browse/DISPATCH-2138 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.16.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.17.0 Race between I/O thread and Core over reading/writing the qdr_link_t->detach_received flag: -DCMAKE_BUILD_TYPE=RelWithDebInfo -DRUNTIME_CHECK=tsan ctest -V -R system_tests_one_router: 21: WARNING: ThreadSanitizer: data race (pid=14179) 21: Read of size 1 at 0x7b540012c172 by thread T3 (mutexes: write M548167088305615232): 21: #0 qdr_connection_process /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:441 (libqpid-dispatch.so+0xa81a7) 21: #1 AMQP_writable_conn_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:299 (libqpid-dispatch.so+0xe3e41) 21: #2 writable_handler /home/travis/build/apache/qpid-dispatch/src/container.c:395 (libqpid-dispatch.so+0x76264) 21: #3 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:747 (libqpid-dispatch.so+0x76264) 21: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0f1) 21: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a9c) 21: #6 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f56) 21: #7 (libtsan.so.0+0x2d1af) 21: Previous write of size 1 at 0x7b540012c172 by thread T1: 21: #0 qdr_link_inbound_detach_CT /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1980 (libqpid-dispatch.so+0xad1eb) 21: #1 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xca685) 21: #2 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f56) 21: #3 (libtsan.so.0+0x2d1af) 21: Mutex M548167088305615232 is already destroyed. 21: SUMMARY: ThreadSanitizer: data race /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:441 in qdr_connection_process -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8515) Improve operational logging and log every change to the broker state
[
https://issues.apache.org/jira/browse/QPID-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347721#comment-17347721
]
ASF GitHub Bot commented on QPID-8515:
--
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635322455
##
File path:
broker-core/src/main/java/org/apache/qpid/server/logging/messages/Management_logmessages.properties
##
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Default File used for all non-defined locales.
+#
+
+# 0 - category
+# 1 - type
+# 2 - name
+# 3 - attributes
+CREATE = MNG-2001 : Created : {0} : {1} : {2} {3}
+
+# 0 - category
+# 1 - type
+# 2 - name
+# 3 - attributes
+UPDATE = MNG-2002 : Updated : {0} : {1} : {2} {3}
+
+# 0 - category
+# 1 - type
+# 2 - name
+DELETE = MNG-2003 : Deleted : {0} : {1} : {2}
+
+# 0 - category
+# 1 - type
+# 2 - name
+# 3 - parameters
+OPERATION = MNG-2003 : Deleted : {0} : {1} : {2} {3}
Review comment:
Added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve operational logging and log every change to the broker state
>
>
> Key: QPID-8515
> URL: https://issues.apache.org/jira/browse/QPID-8515
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Dedeepya
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Currently there is a gap in operational logging, where the deletion of access
> control groups is not logged. We need to identify any other such gaps and fix
> it to log every change happening to the broker state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #85: QPID-8515:[Broker-J]Add missing operational logs
deepyaraj commented on a change in pull request #85:
URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635322455
##
File path:
broker-core/src/main/java/org/apache/qpid/server/logging/messages/Management_logmessages.properties
##
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Default File used for all non-defined locales.
+#
+
+# 0 - category
+# 1 - type
+# 2 - name
+# 3 - attributes
+CREATE = MNG-2001 : Created : {0} : {1} : {2} {3}
+
+# 0 - category
+# 1 - type
+# 2 - name
+# 3 - attributes
+UPDATE = MNG-2002 : Updated : {0} : {1} : {2} {3}
+
+# 0 - category
+# 1 - type
+# 2 - name
+DELETE = MNG-2003 : Deleted : {0} : {1} : {2}
+
+# 0 - category
+# 1 - type
+# 2 - name
+# 3 - parameters
+OPERATION = MNG-2003 : Deleted : {0} : {1} : {2} {3}
Review comment:
Added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8515) Improve operational logging and log every change to the broker state
[ https://issues.apache.org/jira/browse/QPID-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347720#comment-17347720 ] ASF GitHub Bot commented on QPID-8515: -- deepyaraj commented on a change in pull request #85: URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635321703 ## File path: broker-core/src/main/java/org/apache/qpid/server/model/AbstractConfiguredObject.java ## @@ -722,7 +728,7 @@ public void onFailure(final Throwable t) childCloseFutures.add(childCloseFuture); } }); - +//deleteOperationalLog(); Review comment: Removed ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve operational logging and log every change to the broker state > > > Key: QPID-8515 > URL: https://issues.apache.org/jira/browse/QPID-8515 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.4 >Reporter: Dedeepya >Priority: Major > Fix For: qpid-java-broker-8.0.5 > > > Currently there is a gap in operational logging, where the deletion of access > control groups is not logged. We need to identify any other such gaps and fix > it to log every change happening to the broker state. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #85: QPID-8515:[Broker-J]Add missing operational logs
deepyaraj commented on a change in pull request #85: URL: https://github.com/apache/qpid-broker-j/pull/85#discussion_r635321703 ## File path: broker-core/src/main/java/org/apache/qpid/server/model/AbstractConfiguredObject.java ## @@ -722,7 +728,7 @@ public void onFailure(final Throwable t) childCloseFutures.add(childCloseFuture); } }); - +//deleteOperationalLog(); Review comment: Removed ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347716#comment-17347716
]
michael goulish commented on DISPATCH-1956:
---
Thanks, Ken, that works!
I was commenting out this:
#deadlock:qd_vlog_impl
I can see it now.
Tally ho!
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2068) [s390x] system_tests_log_message_components self.assertIn('creation-time="2017-02-22', log[2])
[
https://issues.apache.org/jira/browse/DISPATCH-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347711#comment-17347711
]
ASF GitHub Bot commented on DISPATCH-2068:
--
asfgit closed pull request #1222:
URL: https://github.com/apache/qpid-dispatch/pull/1222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [s390x] system_tests_log_message_components
> self.assertIn('creation-time="2017-02-22', log[2])
> --
>
> Key: DISPATCH-2068
> URL: https://issues.apache.org/jira/browse/DISPATCH-2068
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/499516080#L5482
> {noformat}
> 40: ==
> 40: FAIL: test_log_message_all
> (system_tests_log_message_components.RouterMessageLogTestAll)
> 40: --
> 40: Traceback (most recent call last):
> 40: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_log_message_components.py",
> line 98, in test_log_message_all
> 40: self.assertIn('creation-time="2017-02-22', log[2])
> 40: AssertionError: 'creation-time="2017-02-22' not found in '[C2]: Received
> Message{message-id="123455", user-id=b"testuser", to="amqp://0.0.0.0:26575",
> subject="test-subject", reply-to="hello_world", correlation-id=89,
> content-type=:"text/html; charset=utf-8", content-encoding=:"gzip, deflate",
> creation-time="26583746-09-04 19:39:05.088 +", group-id="group1",
> group-sequence=0, reply-to-group-id="group0",
> app-properties={"app-property"=[10, 20, 30], "some-other"=:"O_one"}} on link
> \'fb786832-7305-4d36-8b0f-a5c912444705-logMessageTest\' ( -> logMessageTest)'
> 40:
> 40: --
> 40: Ran 3 tests in 0.824s
> 40:
> 40: FAILED (failures=1)
> 40/74 Test #40: system_tests_log_message_components ...***Failed
> 0.92 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2068) [s390x] system_tests_log_message_components self.assertIn('creation-time="2017-02-22', log[2])
[
https://issues.apache.org/jira/browse/DISPATCH-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2068.
-
Resolution: Fixed
> [s390x] system_tests_log_message_components
> self.assertIn('creation-time="2017-02-22', log[2])
> --
>
> Key: DISPATCH-2068
> URL: https://issues.apache.org/jira/browse/DISPATCH-2068
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/499516080#L5482
> {noformat}
> 40: ==
> 40: FAIL: test_log_message_all
> (system_tests_log_message_components.RouterMessageLogTestAll)
> 40: --
> 40: Traceback (most recent call last):
> 40: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_log_message_components.py",
> line 98, in test_log_message_all
> 40: self.assertIn('creation-time="2017-02-22', log[2])
> 40: AssertionError: 'creation-time="2017-02-22' not found in '[C2]: Received
> Message{message-id="123455", user-id=b"testuser", to="amqp://0.0.0.0:26575",
> subject="test-subject", reply-to="hello_world", correlation-id=89,
> content-type=:"text/html; charset=utf-8", content-encoding=:"gzip, deflate",
> creation-time="26583746-09-04 19:39:05.088 +", group-id="group1",
> group-sequence=0, reply-to-group-id="group0",
> app-properties={"app-property"=[10, 20, 30], "some-other"=:"O_one"}} on link
> \'fb786832-7305-4d36-8b0f-a5c912444705-logMessageTest\' ( -> logMessageTest)'
> 40:
> 40: --
> 40: Ran 3 tests in 0.824s
> 40:
> 40: FAILED (failures=1)
> 40/74 Test #40: system_tests_log_message_components ...***Failed
> 0.92 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2068) [s390x] system_tests_log_message_components self.assertIn('creation-time="2017-02-22', log[2])
[
https://issues.apache.org/jira/browse/DISPATCH-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347710#comment-17347710
]
ASF subversion and git services commented on DISPATCH-2068:
---
Commit 81e4be87682a14ae120a3e8d9c2f83493b7b0453 in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=81e4be8 ]
DISPATCH-2068: Used qd_parse_as_ulong to obtain the uint64_t value instead of
tedious byte manipulation. This closes #1222.
> [s390x] system_tests_log_message_components
> self.assertIn('creation-time="2017-02-22', log[2])
> --
>
> Key: DISPATCH-2068
> URL: https://issues.apache.org/jira/browse/DISPATCH-2068
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/499516080#L5482
> {noformat}
> 40: ==
> 40: FAIL: test_log_message_all
> (system_tests_log_message_components.RouterMessageLogTestAll)
> 40: --
> 40: Traceback (most recent call last):
> 40: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_log_message_components.py",
> line 98, in test_log_message_all
> 40: self.assertIn('creation-time="2017-02-22', log[2])
> 40: AssertionError: 'creation-time="2017-02-22' not found in '[C2]: Received
> Message{message-id="123455", user-id=b"testuser", to="amqp://0.0.0.0:26575",
> subject="test-subject", reply-to="hello_world", correlation-id=89,
> content-type=:"text/html; charset=utf-8", content-encoding=:"gzip, deflate",
> creation-time="26583746-09-04 19:39:05.088 +", group-id="group1",
> group-sequence=0, reply-to-group-id="group0",
> app-properties={"app-property"=[10, 20, 30], "some-other"=:"O_one"}} on link
> \'fb786832-7305-4d36-8b0f-a5c912444705-logMessageTest\' ( -> logMessageTest)'
> 40:
> 40: --
> 40: Ran 3 tests in 0.824s
> 40:
> 40: FAILED (failures=1)
> 40/74 Test #40: system_tests_log_message_components ...***Failed
> 0.92 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1222: DISPATCH-2068: Used qd_parse_as_ulong to obtain the uint64_t value in…
asfgit closed pull request #1222: URL: https://github.com/apache/qpid-dispatch/pull/1222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347701#comment-17347701
]
Ken Giusti commented on DISPATCH-1956:
--
[^tsan.supp]
I'm using current main HEAD. I built the qdrouter using
-DCMAKE_BUILD_TYPE=RelWithDebInfo and -DRUNTIME_CHECK=tsan
I can trigger it when running the system_tests_router_mesh:
$ ctest -V -R mesh
Try using the attached tsan.supp file. I've been updating this file by testing
against the main branch, and will eventually check it in. It already has the
proper deadlock suppression for DISPATCH-1956 commented out.
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-1956:
-
Attachment: tsan.supp
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2083) [s390x] container.c:700: qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347699#comment-17347699
]
Ganesh Murthy commented on DISPATCH-2083:
-
[~jdanek] I am running (on an s390x machine with rhel8) with the build settings
from here -
[https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211930#L5514]
{noformat}
PROTON_VERSION=main BUILD_TYPE=RelWithDebInfo
DISPATCH_CMAKE_ARGS='-DRUNTIME_CHECK=asan -DCMAKE_C_FLAGS=-DQD_MEMORY_DEBUG
-DQD_ENABLE_ASSERTIONS=ON -DDISPATCH_TEST_TIMEOUT=500 {noformat}
> [s390x] container.c:700: qd_container_handle_event: Assertion
> `qd_conn->n_senders >= 0' failed
> --
>
> Key: DISPATCH-2083
> URL: https://issues.apache.org/jira/browse/DISPATCH-2083
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
> Environment: Travis CI Focal on s390x
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211930#L5514
> PR build, but IMO very unlikely the PR caused the issue.
> {noformat}
> 38: test_32_two_router_waypoint
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_33_one_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_34_one_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_35_two_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_36_two_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ...
> WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B command file:
> 38:
> 38: qdrouterd -c B.conf -I /home/travis/build/apache/qpid-dispatch/python
> 38: pid=13121
> 38:
> 38:
> 38:
> 38: Router B log file tail:
> 38:
> 38: 2021-04-26 19:50:34.632813 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.633027 + POLICY (debug) [C23] Connection
> '127.0.0.1:55896' closed with resources n_sessions=0, n_senders=0,
> n_receivers=0, sessions_denied=0, senders_denied=0, receivers_denied=0,
> max_message_size_denied:0, nConnections= 3.
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:318)
> 38: 2021-04-26 19:50:34.633247 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633525 + ROUTER_CORE (trace) [C23][L67][D395] :in
> qdr_delivery_unlink_peers_CT out: [C1][L22][D397]
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:542)
> 38: 2021-04-26 19:50:34.633711 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633893 + ROUTER_CORE (debug) [C1][L22][D397]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634098 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.634283 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634579 + ROUTER_CORE (info) [C23][L67] Link lost:
> del=10 presett=0 psdrop=0 acc=7 rej=0 re
[jira] [Commented] (DISPATCH-2083) [s390x] container.c:700: qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347695#comment-17347695
]
Jiri Daněk commented on DISPATCH-2083:
--
[~gmurthy] One guess. Are you running a Debug build or a RelWithDebInfo build
with enabled assertions? Because the Travis CI was running the latter. And btw,
this is the only time I saw the assertion failure. As far as I know it never
repeated in the CI.
> [s390x] container.c:700: qd_container_handle_event: Assertion
> `qd_conn->n_senders >= 0' failed
> --
>
> Key: DISPATCH-2083
> URL: https://issues.apache.org/jira/browse/DISPATCH-2083
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
> Environment: Travis CI Focal on s390x
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211930#L5514
> PR build, but IMO very unlikely the PR caused the issue.
> {noformat}
> 38: test_32_two_router_waypoint
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_33_one_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_34_one_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... ok
> 38: test_35_two_router_waypoint_no_tenant_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ... n_sent=10
> n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: n_sent=10 n_rcvd=10 n_thru=10 n_waypoint_rcvd=10
> 38: WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38: test_36_two_router_waypoint_external_addr
> (system_tests_multi_tenancy_policy.RouterMultitenantPolicyTest) ...
> WaypointTest
> 38: WaypointTest
> 38: FAIL
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B output file:
> 38:
> 38: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/container.c:700:
> qd_container_handle_event: Assertion `qd_conn->n_senders >= 0' failed.
> 38:
> 38:
> 38:
> 38: Router B command file:
> 38:
> 38: qdrouterd -c B.conf -I /home/travis/build/apache/qpid-dispatch/python
> 38: pid=13121
> 38:
> 38:
> 38:
> 38: Router B log file tail:
> 38:
> 38: 2021-04-26 19:50:34.632813 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.633027 + POLICY (debug) [C23] Connection
> '127.0.0.1:55896' closed with resources n_sessions=0, n_senders=0,
> n_receivers=0, sessions_denied=0, senders_denied=0, receivers_denied=0,
> max_message_size_denied:0, nConnections= 3.
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:318)
> 38: 2021-04-26 19:50:34.633247 + ROUTER_CORE (debug) [C23][L67][D394]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633525 + ROUTER_CORE (trace) [C23][L67][D395] :in
> qdr_delivery_unlink_peers_CT out: [C1][L22][D397]
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:542)
> 38: 2021-04-26 19:50:34.633711 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.633893 + ROUTER_CORE (debug) [C1][L22][D397]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634098 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery outcome : is unknown (0x0)
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:392)
> 38: 2021-04-26 19:50:34.634283 + ROUTER_CORE (debug) [C23][L67][D395]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:640)
> 38: 2021-04-26 19:50:34.634579 + ROUTER_CORE (info) [C23][L67] Link lost:
> del=10 presett=0 psdrop=0 acc=7 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:
[jira] [Commented] (DISPATCH-2035) [build] CMake often fails to configure project if I have multiple build directories and run CMake in every one of them simultaneously
[
https://issues.apache.org/jira/browse/DISPATCH-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347677#comment-17347677
]
ASF subversion and git services commented on DISPATCH-2035:
---
Commit e4977ae3ea9f289879415c87c057d933e6bc7246 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e4977ae ]
DISPATCH-2035 Reduce number of configure_file calls in CMake build (#1225)
This is possible thanks to supporting only Python 3 now.
> [build] CMake often fails to configure project if I have multiple build
> directories and run CMake in every one of them simultaneously
> -
>
> Key: DISPATCH-2035
> URL: https://issues.apache.org/jira/browse/DISPATCH-2035
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 1.17.0
>
>
> My IDE supports setting up multiple CMake build configurations at the same
> time. If I click to reconfigure the build configurations, some of them often
> fail with issue like the following
> {noformat}
> CMake Error at CMakeLists.txt:294 (configure_file):
> configure_file Problem configuring file
> {noformat}
> This appears to be caused by commands such as
> {code}
> configure_file(${CMAKE_CURRENT_SOURCE_DIR}/tests/authservice.py.in
> ${CMAKE_CURRENT_SOURCE_DIR}/tests/authservice.py)
> {code}
> that attempt to write their output into the sources directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2035) [build] CMake often fails to configure project if I have multiple build directories and run CMake in every one of them simultaneously
[
https://issues.apache.org/jira/browse/DISPATCH-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347675#comment-17347675
]
ASF GitHub Bot commented on DISPATCH-2035:
--
jiridanek merged pull request #1225:
URL: https://github.com/apache/qpid-dispatch/pull/1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [build] CMake often fails to configure project if I have multiple build
> directories and run CMake in every one of them simultaneously
> -
>
> Key: DISPATCH-2035
> URL: https://issues.apache.org/jira/browse/DISPATCH-2035
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 1.17.0
>
>
> My IDE supports setting up multiple CMake build configurations at the same
> time. If I click to reconfigure the build configurations, some of them often
> fail with issue like the following
> {noformat}
> CMake Error at CMakeLists.txt:294 (configure_file):
> configure_file Problem configuring file
> {noformat}
> This appears to be caused by commands such as
> {code}
> configure_file(${CMAKE_CURRENT_SOURCE_DIR}/tests/authservice.py.in
> ${CMAKE_CURRENT_SOURCE_DIR}/tests/authservice.py)
> {code}
> that attempt to write their output into the sources directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1225: DISPATCH-2035 Reduce number of configure_file calls in CMake build
jiridanek merged pull request #1225: URL: https://github.com/apache/qpid-dispatch/pull/1225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2112) AssertionError: 9999 != 5000 in test_yy_query_many_links of system_tests_qdmanage
[
https://issues.apache.org/jira/browse/DISPATCH-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347670#comment-17347670
]
ASF GitHub Bot commented on DISPATCH-2112:
--
asfgit closed pull request #1220:
URL: https://github.com/apache/qpid-dispatch/pull/1220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AssertionError: != 5000 in test_yy_query_many_links of
> system_tests_qdmanage
> -
>
> Key: DISPATCH-2112
> URL: https://issues.apache.org/jira/browse/DISPATCH-2112
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.17.0
>
>
> This failure is fairly frequent in CI and affects AMD64 as well as s390x.
> Both mainline branch and 1.16.x branches show this failure.
>
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504342161#L4496
> {noformat}
> 30: ==
> 30: FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdmanage.py",
> line 557, in test_yy_query_many_links
> 30: self.assertEqual(sender_addresses, COUNT)
> 30: AssertionError: 4999 != 5000
> 30:
> 30: --
> 30: Ran 34 tests in 179.082s
> 30:
> 30: FAILED (failures=1)
> 30/72 Test #30: system_tests_qdmanage .***Failed
> 179.19 sec
> {noformat}
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504349804#L4516
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504374566#L4891
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504379787#L4900
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504374566#L4891
> {noformat}
> 30: ==
> 30: FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdmanage.py",
> line 593, in test_yy_query_many_links
> 30: self.assertEqual(out_links, COUNT)
> 30: AssertionError: != 5000
> 30:
> 30: --
> 30: Ran 34 tests in 158.600s
> 30:
> 30: FAILED (failures=1)
> 30/72 Test #30: system_tests_qdmanage .***Failed
> 158.74 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2112) AssertionError: 9999 != 5000 in test_yy_query_many_links of system_tests_qdmanage
[
https://issues.apache.org/jira/browse/DISPATCH-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2112.
-
Assignee: Ganesh Murthy
Resolution: Fixed
> AssertionError: != 5000 in test_yy_query_many_links of
> system_tests_qdmanage
> -
>
> Key: DISPATCH-2112
> URL: https://issues.apache.org/jira/browse/DISPATCH-2112
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> This failure is fairly frequent in CI and affects AMD64 as well as s390x.
> Both mainline branch and 1.16.x branches show this failure.
>
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504342161#L4496
> {noformat}
> 30: ==
> 30: FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdmanage.py",
> line 557, in test_yy_query_many_links
> 30: self.assertEqual(sender_addresses, COUNT)
> 30: AssertionError: 4999 != 5000
> 30:
> 30: --
> 30: Ran 34 tests in 179.082s
> 30:
> 30: FAILED (failures=1)
> 30/72 Test #30: system_tests_qdmanage .***Failed
> 179.19 sec
> {noformat}
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504349804#L4516
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504374566#L4891
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504379787#L4900
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504374566#L4891
> {noformat}
> 30: ==
> 30: FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdmanage.py",
> line 593, in test_yy_query_many_links
> 30: self.assertEqual(out_links, COUNT)
> 30: AssertionError: != 5000
> 30:
> 30: --
> 30: Ran 34 tests in 158.600s
> 30:
> 30: FAILED (failures=1)
> 30/72 Test #30: system_tests_qdmanage .***Failed
> 158.74 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2112) AssertionError: 9999 != 5000 in test_yy_query_many_links of system_tests_qdmanage
[
https://issues.apache.org/jira/browse/DISPATCH-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347669#comment-17347669
]
ASF subversion and git services commented on DISPATCH-2112:
---
Commit e69576d71494be3e46be14ea1018fe86b4bc599f in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e69576d ]
DISPATCH-2112: Reset in_links and out_links on each iteration. This closes #1220
> AssertionError: != 5000 in test_yy_query_many_links of
> system_tests_qdmanage
> -
>
> Key: DISPATCH-2112
> URL: https://issues.apache.org/jira/browse/DISPATCH-2112
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.17.0
>
>
> This failure is fairly frequent in CI and affects AMD64 as well as s390x.
> Both mainline branch and 1.16.x branches show this failure.
>
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504342161#L4496
> {noformat}
> 30: ==
> 30: FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdmanage.py",
> line 557, in test_yy_query_many_links
> 30: self.assertEqual(sender_addresses, COUNT)
> 30: AssertionError: 4999 != 5000
> 30:
> 30: --
> 30: Ran 34 tests in 179.082s
> 30:
> 30: FAILED (failures=1)
> 30/72 Test #30: system_tests_qdmanage .***Failed
> 179.19 sec
> {noformat}
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504349804#L4516
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504374566#L4891
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504379787#L4900
> * https://travis-ci.com/github/apache/qpid-dispatch/jobs/504374566#L4891
> {noformat}
> 30: ==
> 30: FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdmanage.py",
> line 593, in test_yy_query_many_links
> 30: self.assertEqual(out_links, COUNT)
> 30: AssertionError: != 5000
> 30:
> 30: --
> 30: Ran 34 tests in 158.600s
> 30:
> 30: FAILED (failures=1)
> 30/72 Test #30: system_tests_qdmanage .***Failed
> 158.74 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1220: DISPATCH-2112: Reset in_links and out_links on each iteration
asfgit closed pull request #1220: URL: https://github.com/apache/qpid-dispatch/pull/1220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8526) Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
[
https://issues.apache.org/jira/browse/QPID-8526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347652#comment-17347652
]
ASF GitHub Bot commented on QPID-8526:
--
dakirily opened a new pull request #87:
URL: https://github.com/apache/qpid-broker-j/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
>
>
> Key: QPID-8526
> URL: https://issues.apache.org/jira/browse/QPID-8526
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Daniil Kirilyuk
>Priority: Minor
>
> Issue is similar to QPID-8489: on certain conditions SSL connection thread
> falls into an infinite loop consuming CPU.
> Stacktrace from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43504522.88ms
> elapsed=330519.20s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> sun.security.ssl.TransportContext.getHandshakeStatus(java.base@11.0.7/TransportContext.java:571)
> at
> sun.security.ssl.SSLEngineImpl.getHandshakeStatus(java.base@11.0.7/SSLEngineImpl.java:801)
> - locked <0x7f4b721e7340> (a sun.security.ssl.SSLEngineImpl)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:239)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:575)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:366)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:533)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.7/ThreadPoolExecutor.java:1128)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.7/ThreadPoolExecutor.java:628)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory$$Lambda$64/0x7f47d52bcc40.run(Unknown
> Source)
> at java.lang.Thread.run(java.base@11.0.7/Thread.java:834)
> {noformat}
> Stacktrace 2 from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43536330.84ms
> elapsed=330555.26s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.encryptSSL(QpidByteBufferFactory.java:178)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.encryptSSL(QpidByteBuffer.java:62)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:255)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:575)
> at
> org.apache.qpid.server.transport.Sel
[jira] [Commented] (QPID-8526) Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
[
https://issues.apache.org/jira/browse/QPID-8526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347651#comment-17347651
]
Daniil Kirilyuk commented on QPID-8526:
---
Hi [~orudyy],
Our broker runs without the changes implemented in QPID-8484 (Reimplementation
of the limit number of connections per user) / pull request #76.
> Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
>
>
> Key: QPID-8526
> URL: https://issues.apache.org/jira/browse/QPID-8526
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Daniil Kirilyuk
>Priority: Minor
>
> Issue is similar to QPID-8489: on certain conditions SSL connection thread
> falls into an infinite loop consuming CPU.
> Stacktrace from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43504522.88ms
> elapsed=330519.20s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> sun.security.ssl.TransportContext.getHandshakeStatus(java.base@11.0.7/TransportContext.java:571)
> at
> sun.security.ssl.SSLEngineImpl.getHandshakeStatus(java.base@11.0.7/SSLEngineImpl.java:801)
> - locked <0x7f4b721e7340> (a sun.security.ssl.SSLEngineImpl)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:239)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:575)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:366)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:533)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.7/ThreadPoolExecutor.java:1128)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.7/ThreadPoolExecutor.java:628)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory$$Lambda$64/0x7f47d52bcc40.run(Unknown
> Source)
> at java.lang.Thread.run(java.base@11.0.7/Thread.java:834)
> {noformat}
> Stacktrace 2 from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43536330.84ms
> elapsed=330555.26s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.encryptSSL(QpidByteBufferFactory.java:178)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.encryptSSL(QpidByteBuffer.java:62)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:255)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:575)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:366)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qp
[GitHub] [qpid-broker-j] dakirily opened a new pull request #87: QPID-8526:[Broker-J] Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
dakirily opened a new pull request #87: URL: https://github.com/apache/qpid-broker-j/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #805: Proposal for run-time lock validation
jiridanek commented on a change in pull request #805: URL: https://github.com/apache/qpid-dispatch/pull/805#discussion_r635139016 ## File path: docs/notes/RIPs/lock-validation.adoc ## @@ -0,0 +1,101 @@ + +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License + + += Mutex Locking Validation + +== Summary + +This RIP proposes a compile-time debug mechanism to ensure that thread +locking is well behaved. + +== Introduction + +The Qpid Dispatch Router is a multi-threaded application. These +threads share state and use locks to ensure the consistency of that +state. The locking API is defined in +include/qpid/dispatch/threading.h + +In general lock nesting (e.g. taking a lock while holding another) is +not permitted. + +However in a few instances locks will nest. One example of permitted lock +nesting is the Python lock (qd_python_lock()). This lock must be held +while a thread is running within the Python interpreter. Occasionally +the Python interpreter will invoke native C functions. These +functions may take addional locks, such as the global logging lock +(log_lock). Review comment: I meant something like http://logging.apache.org/log4j/2.x/manual/async.html, this keeps a queue of in-flight log messages and adding to the queue does not require holding a lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347593#comment-17347593
]
Jiri Daněk commented on DISPATCH-1956:
--
Forgot to mention, there is also Ken's techinque,
https://github.com/apache/qpid-dispatch/pull/805
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-843984058 That Python test I added last time (the one using asyncio websocket lib) can actually be added upstream now, since Python 3.6 supports async. I looked a bit into simplifying multithreaded programming in C++, but there does not seem to be much. There are the regular primitives in C++11 std lib (https://freecontent.manning.com/synchronizing-concurrent-operations-in-c/), everything else has to be built on top; there are some async/await features coming in C++20 or maybe in the version after that. As an off-topic, there is a person building immutable tree-based lists and other datastructures for C++, this is quite interesting, but it would be hard to use from C https://github.com/arximboldi/immer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8526) Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
[
https://issues.apache.org/jira/browse/QPID-8526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347440#comment-17347440
]
Alex Rudyy commented on QPID-8526:
--
Hi [~daniel.kirilyuk],
As per JDK documentation for the {{SSLEngineResult.Status.CLOSED}}
{quote}
The operation just closed this side of the SSLEngine, or the operation could
not be completed because it was already closed.
{quote}
we really have no other choice as to abandon a write operation. The
{{HandshakeStatus}} value does not really matter in this case. Thus, I would
definitely go with a condition:
{code}
if (_status.getStatus() == SSLEngineResult.Status.CLOSED)
{code}
As for another example of a "stucked" connection which occurred immediately
after open, I think it is a manifestation of the same issue. It seems we are
dealing here either with a Qpid or JDK defect.
Are you running broker with changes implemented in
[https://github.com/apache/qpid-broker-j/pull/76]?
> Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
>
>
> Key: QPID-8526
> URL: https://issues.apache.org/jira/browse/QPID-8526
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Daniil Kirilyuk
>Priority: Minor
>
> Issue is similar to QPID-8489: on certain conditions SSL connection thread
> falls into an infinite loop consuming CPU.
> Stacktrace from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43504522.88ms
> elapsed=330519.20s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> sun.security.ssl.TransportContext.getHandshakeStatus(java.base@11.0.7/TransportContext.java:571)
> at
> sun.security.ssl.SSLEngineImpl.getHandshakeStatus(java.base@11.0.7/SSLEngineImpl.java:801)
> - locked <0x7f4b721e7340> (a sun.security.ssl.SSLEngineImpl)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:239)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:575)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:366)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:533)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.7/ThreadPoolExecutor.java:1128)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.7/ThreadPoolExecutor.java:628)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory$$Lambda$64/0x7f47d52bcc40.run(Unknown
> Source)
> at java.lang.Thread.run(java.base@11.0.7/Thread.java:834)
> {noformat}
> Stacktrace 2 from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43536330.84ms
> elapsed=330555.26s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.encryptSSL(QpidByteBufferFactory.java:178)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.encryptSSL(QpidByteBuffer.java:62)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:255)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConn
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347377#comment-17347377
]
michael goulish commented on DISPATCH-1956:
---
I will try the QE technique, and something I haven't tried before ... running
multiple ctests at once! Yow!
Except we're never going to establish the original frequency. It is unknowable.
Imponderable. Ineffable.
SO I will run the test enough times to support a proof-by-vigorous-handwaving!
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347369#comment-17347369
]
Jiri Daněk commented on DISPATCH-1956:
--
On Wed, May 19, 2021 at 9:27 AM michael goulish (Jira)
This is my favorite reference about TSan false negatives, it's a mailing
list reply
https://mail.openjdk.java.net/pipermail/tsan-dev/2019-July/000263.html (the
sentence about "parasitic synchronization" ;)
I think one of these would work
The QE answer: establish what was the original frequency, then show (by
running test many times) that current frequency now is likely 0, with
reasonable confidence.
The Dev answer: go through the code and convince yourself that the locks
can only be taken in one of the orderings. ;P
--
Mit freundlichen Grüßen / Kind regards
Jiri Daněk
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347365#comment-17347365
]
michael goulish commented on DISPATCH-1956:
---
I am trying to restore my 'mgoulish' RH account, but I need help from someone
with magical powers.
I assumed that if I ran ctest, that would be sufficient. But now that you
inform me that TSan issues do not reliably manifest, I will run ctest more
times and see if I can get it to show itself.
But if we don't know how it was observed, nor with what frequency how will
we know when it is fixed?
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347354#comment-17347354
]
Jiri Daněk edited comment on DISPATCH-1956 at 5/19/21, 7:14 AM:
[~mgoulish], [~michaelgoulish] try the perms now, please (which of these two
accounts do you actually use?)
How did you test this? The issue does not say what to run to get the deadlock
report, so what test did you try? Edit: aha, all of them. Once? Well... we
don't know how easy this was to reproduce in the first place. TSan issues
usually manifest at random, it almost never is 100% reproducible.
was (Author: jdanek):
[~mgoulish], [~michaelgoulish] try the perms now, please (which of these two
accounts do you actually use?)
How did you test this? The issue does not say what to run to get the deadlock
report, so what test did you try?
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347354#comment-17347354
]
Jiri Daněk commented on DISPATCH-1956:
--
[~mgoulish], [~michaelgoulish] try the perms now, please (which of these two
accounts do you actually use?)
How did you test this? The issue does not say what to run to get the deadlock
report, so what test did you try?
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
