[jira] [Resolved] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread Alex Rudyy (Jira)


 [ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-8541.
--
Resolution: Fixed

> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
> Fix For: qpid-java-broker-8.0.6
>
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364525#comment-17364525
 ] 

ASF subversion and git services commented on QPID-8541:
---

Commit 7a064a475c1cea94a737d4dc4e8e8f0c99d61b2f in qpid-broker-j's branch 
refs/heads/8.0.x from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=7a064a4 ]

QPID-8541: [Broker-J] Restore API backward compatibility


> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
> Fix For: qpid-java-broker-8.0.6
>
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364524#comment-17364524
 ] 

ASF subversion and git services commented on QPID-8541:
---

Commit b64ca15d654fc188c55420e30d35dbdc77c8ca35 in qpid-broker-j's branch 
refs/heads/8.0.x from Marek Laca
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=b64ca15 ]

QPID-8541: [Broker-J] Enhance Broker Rest API to include certificate alias

This closes #95


> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
> Fix For: qpid-java-broker-8.0.6
>
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-2108) TCP adaptor should aggregate statistics for listener and connector

2021-06-16 Thread Charles E. Rolke (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles E. Rolke resolved DISPATCH-2108.

Resolution: Fixed

Fixed at commit e401cb19

> TCP adaptor should aggregate statistics for listener and connector
> --
>
> Key: DISPATCH-2108
> URL: https://issues.apache.org/jira/browse/DISPATCH-2108
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> For each tcpListener and tcpConnector provide a summary of traffic
>  * number of connections
>  * bytes in
>  * bytes out
> aggregated across all the to and from the listener/connector objects.
> Optionally provide rollup info from all the live connections
>  * last in seconds
>  * last out seconds
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-2108) TCP adaptor should aggregate statistics for listener and connector

2021-06-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364487#comment-17364487
 ] 

ASF subversion and git services commented on DISPATCH-2108:
---

Commit e401cb19bc243bd240eb61cae9a1bef9fdd2e549 in qpid-dispatch's branch 
refs/heads/main from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e401cb1 ]

DISPATCH-2108: Aggregate statistics for TCP listeners and connectors

This commit adds counters

  * bytesIn
  * bytesOut
  * connectionsOpened
  * connectionsClosed

to tcpListener and tcpConnector entities. Individual bytesIn and bytesOut
for tcpConnections are tracked in the connection entity. The new aggregated
statistics are running totals for all connections created through the
listener and connector entities.

Internally the tcp_bridge_config structure was renamed to tcp_bridge as
the struct is not just config any more. The qd_tcp_connection no longer
holds the actual structure in 'config'. Instead it holds a pointer to
the repurposed structure in 'bridge'.

qd_tcp_bridge_t is now a pooled object. Its lifetime is controlled by
a ref count. A bridge is created synchronously with a listener or a
connector and those entities hold the first reference. Tcp connections
hold a reference to the bridge and target that bridge for ongoing
statistics accumulation.

With the ref counting a connection may be created, say, through a listener.
Then before the connection is closed the listener may be deleted. The
ref count keeps the bridge object alive so that the connection statistics
are still aggregated. Only when the bridge object loses all of its
references is the bridge finally disposed. Bridge objects dump their final
statistics to the TCP_ADAPTOR log at INFO level.

This commit also creates LOCK and UNLOCK macros to aid developers trying
to read the code.

A self test is added to make sure the entity attributes are present and
hold reasonable values.

This closes #2144


> TCP adaptor should aggregate statistics for listener and connector
> --
>
> Key: DISPATCH-2108
> URL: https://issues.apache.org/jira/browse/DISPATCH-2108
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> For each tcpListener and tcpConnector provide a summary of traffic
>  * number of connections
>  * bytes in
>  * bytes out
> aggregated across all the to and from the listener/connector objects.
> Optionally provide rollup info from all the live connections
>  * last in seconds
>  * last out seconds
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-2176) Update version of d3 in console

2021-06-16 Thread Ernest Allen (Jira)
Ernest Allen created DISPATCH-2176:
--

 Summary: Update version of d3 in console 
 Key: DISPATCH-2176
 URL: https://issues.apache.org/jira/browse/DISPATCH-2176
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Console
Affects Versions: 1.16.0
Reporter: Ernest Allen


The console uses version 3 of the d3 library. The latest is version 7.
For development support and bug fixes, we should update the code to use the 
latest version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread Alex Rudyy (Jira)


 [ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8541:
-
Fix Version/s: qpid-java-broker-8.0.6

> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
> Fix For: qpid-java-broker-8.0.6
>
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (DISPATCH-2155) Race reported from Proton between listener_final_free and pn_listener_close during qd_connection_manager_delete_listener

2021-06-16 Thread Jira


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk closed DISPATCH-2155.

Resolution: Duplicate

> Race reported from Proton between listener_final_free and pn_listener_close 
> during qd_connection_manager_delete_listener
> 
>
> Key: DISPATCH-2155
> URL: https://issues.apache.org/jira/browse/DISPATCH-2155
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>  Labels: race-condition, tsan
>
> TSan error from Proton
> https://github.com/jiridanek/qpid-dispatch/runs/2675411039?check_suite_focus=true#step:25:800
> {noformat}
> 20: E   ==
> 20: E   WARNING: ThreadSanitizer: data race (pid=2545)
> 20: E Write of size 8 at 0x7b68fc28 by thread T4:
> 20: E   #0 free  (libtsan.so.0+0x37a28)
> 20: E   #1 listener_final_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1584
>  (libqpid-proton-proactor.so.1+0x8650)
> 20: E   #2 pn_listener_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1602
>  (libqpid-proton-proactor.so.1+0x8650)
> 20: E   #3 listener_done 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1804
>  (libqpid-proton-proactor.so.1+0xc31f)
> 20: E   #4 pn_proactor_done 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2684
>  (libqpid-proton-proactor.so.1+0xc31f)
> 20: E   #5 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1139 
> (libqpid-dispatch.so+0xf56c4)
> 20: E   #6 _thread_init 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>  (libqpid-dispatch.so+0x95fa2)
> 20: E   
> 20: E Previous read of size 8 at 0x7b68fc28 by main thread 
> (mutexes: write M13):
> 20: E   #0 pn_listener_close 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1651
>  (libqpid-proton-proactor.so.1+0x9404)
> 20: E   #1 qd_connection_manager_delete_listener 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/connection_manager.c:1041
>  (libqpid-dispatch.so+0x702fb)
> 20: E   #2 ffi_call_unix64  (libffi.so.6+0x6c03)
> 20: E   #3 qdr_forward_on_message 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/forwarder.c:336
>  (libqpid-dispatch.so+0xbcc9c)
> 20: E   #4 qdr_general_handler 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:934
>  (libqpid-dispatch.so+0xc62db)
> 20: E   #5 qd_timer_visit 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/timer.c:317 
> (libqpid-dispatch.so+0xf71cd)
> 20: E   #6 handle 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1006 
> (libqpid-dispatch.so+0xf11de)
> 20: E   #7 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf56f5)
> 20: E   #8 qd_server_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0xf5958)
> 20: E   #9 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
>  (qdrouterd+0x40287c)
> 20: E   #10 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
>  (qdrouterd+0x4024fc)
> 20: E   
> 20: E Mutex M13 (0x7b100300) created at:
> 20: E   #0 pthread_mutex_init  (libtsan.so.0+0x49603)
> 20: E   #1 sys_mutex 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:43
>  (libqpid-dispatch.so+0x95ffc)
> 20: E   #2 qd_python_initialize 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/python_embedded.c:54
>  (libqpid-dispatch.so+0x9858c)
> 20: E   #3 qd_dispatch 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:111
>  (libqpid-dispatch.so+0x763c5)
> 20: E   #4 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92
>  (qdrouterd+0x4027b9)
> 20: E   #5 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
>  (qdrouterd+0x4024fc)
> 20: E   
> 20: E Thread T4 (tid=2568, running) created by main thread at:
> 20: E   #0 pthread_create  (libtsan.so.0+0x5bf45)
>

[jira] [Commented] (DISPATCH-2175) Data race in system_tests_tcp_adaptor involving listener_final_free, qd_dispatch_delete_tcp_listener, pn_listener_close

2021-06-16 Thread Jira


[ 
https://issues.apache.org/jira/browse/DISPATCH-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364307#comment-17364307
 ] 

Jiri Daněk commented on DISPATCH-2175:
--

[~gsim] You are probably right. This race is suppressed in Proton already, 
https://github.com/apache/qpid-proton/blob/8ddf5399013b02f1fd13bda3fee7886bd48a98be/tests/tsan.supp#L30-L31

> Data race in system_tests_tcp_adaptor involving listener_final_free, 
> qd_dispatch_delete_tcp_listener, pn_listener_close
> ---
>
> Key: DISPATCH-2175
> URL: https://issues.apache.org/jira/browse/DISPATCH-2175
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>  Labels: race-condition, tsan
>
> https://github.com/jiridanek/qpid-dispatch/runs/2838892781?check_suite_focus=true#step:25:3147
> {noformat}
> 71: WARNING: ThreadSanitizer: data race (pid=4187)
> 71:   Write of size 8 at 0x7b68fc28 by thread T4:
> 71: #0 free  (libtsan.so.0+0x37a28)
> 71: #1 listener_final_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1584
>  (libqpid-proton-proactor.so.1+0x8650)
> 71: #2 pn_listener_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1602
>  (libqpid-proton-proactor.so.1+0x8650)
> 71: #3 listener_done 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1804
>  (libqpid-proton-proactor.so.1+0xc31f)
> 71: #4 pn_proactor_done 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2684
>  (libqpid-proton-proactor.so.1+0xc31f)
> 71: #5 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1139 
> (libqpid-dispatch.so+0xf6094)
> 71: #6 _thread_init 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>  (libqpid-dispatch.so+0x968c2)
> 71: 
> 71:   Previous read of size 8 at 0x7b68fc28 by thread T3 (mutexes: write 
> M13):
> 71: #0 pn_listener_close 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1651
>  (libqpid-proton-proactor.so.1+0x9404)
> 71: #1 qd_dispatch_delete_tcp_listener 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1204
>  (libqpid-dispatch.so+0x5af7e)
> 71: #2 ffi_call_unix64  (libffi.so.6+0x6c03)
> 71: #3 qdr_forward_on_message 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/forwarder.c:336
>  (libqpid-dispatch.so+0xbd5bc)
> 71: #4 qdr_general_handler 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:942
>  (libqpid-dispatch.so+0xc6c2b)
> 71: #5 qd_timer_visit 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/timer.c:317 
> (libqpid-dispatch.so+0xf7b9d)
> 71: #6 handle 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1006 
> (libqpid-dispatch.so+0xf1bae)
> 71: #7 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf60c5)
> 71: #8 _thread_init 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>  (libqpid-dispatch.so+0x968c2)
> 71: 
> 71:   Mutex M13 (0x7b100300) created at:
> 71: #0 pthread_mutex_init  (libtsan.so.0+0x49603)
> 71: #1 sys_mutex 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:43
>  (libqpid-dispatch.so+0x9691c)
> 71: #2 qd_python_initialize 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/python_embedded.c:54
>  (libqpid-dispatch.so+0x98eac)
> 71: #3 qd_dispatch 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:111
>  (libqpid-dispatch.so+0x76af5)
> 71: #4 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92
>  (qdrouterd+0x4027b9)
> 71: #5 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
>  (qdrouterd+0x4024fc)
> 71: 
> 71:   Thread T4 (tid=4192, running) created by main thread at:
> 71: #0 pthread_create  (libtsan.so.0+0x5bf45)
> 71: #1 sys_thread 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
>  (libqpid-dispatch.so+0x96d5e)
> 71: #2 qd_server_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1499 
> (libqpid-dispatch.so+0xf6302)
> 71: #3 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
>  (qdrouterd+0x40287c)
> 71: #4 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/r

[jira] [Commented] (DISPATCH-2175) Data race in system_tests_tcp_adaptor involving listener_final_free, qd_dispatch_delete_tcp_listener, pn_listener_close

2021-06-16 Thread Gordon Sim (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364305#comment-17364305
 ] 

Gordon Sim commented on DISPATCH-2175:
--

This looks like it might be a proton issue?

> Data race in system_tests_tcp_adaptor involving listener_final_free, 
> qd_dispatch_delete_tcp_listener, pn_listener_close
> ---
>
> Key: DISPATCH-2175
> URL: https://issues.apache.org/jira/browse/DISPATCH-2175
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>  Labels: race-condition, tsan
>
> https://github.com/jiridanek/qpid-dispatch/runs/2838892781?check_suite_focus=true#step:25:3147
> {noformat}
> 71: WARNING: ThreadSanitizer: data race (pid=4187)
> 71:   Write of size 8 at 0x7b68fc28 by thread T4:
> 71: #0 free  (libtsan.so.0+0x37a28)
> 71: #1 listener_final_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1584
>  (libqpid-proton-proactor.so.1+0x8650)
> 71: #2 pn_listener_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1602
>  (libqpid-proton-proactor.so.1+0x8650)
> 71: #3 listener_done 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1804
>  (libqpid-proton-proactor.so.1+0xc31f)
> 71: #4 pn_proactor_done 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2684
>  (libqpid-proton-proactor.so.1+0xc31f)
> 71: #5 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1139 
> (libqpid-dispatch.so+0xf6094)
> 71: #6 _thread_init 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>  (libqpid-dispatch.so+0x968c2)
> 71: 
> 71:   Previous read of size 8 at 0x7b68fc28 by thread T3 (mutexes: write 
> M13):
> 71: #0 pn_listener_close 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1651
>  (libqpid-proton-proactor.so.1+0x9404)
> 71: #1 qd_dispatch_delete_tcp_listener 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1204
>  (libqpid-dispatch.so+0x5af7e)
> 71: #2 ffi_call_unix64  (libffi.so.6+0x6c03)
> 71: #3 qdr_forward_on_message 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/forwarder.c:336
>  (libqpid-dispatch.so+0xbd5bc)
> 71: #4 qdr_general_handler 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:942
>  (libqpid-dispatch.so+0xc6c2b)
> 71: #5 qd_timer_visit 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/timer.c:317 
> (libqpid-dispatch.so+0xf7b9d)
> 71: #6 handle 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1006 
> (libqpid-dispatch.so+0xf1bae)
> 71: #7 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf60c5)
> 71: #8 _thread_init 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>  (libqpid-dispatch.so+0x968c2)
> 71: 
> 71:   Mutex M13 (0x7b100300) created at:
> 71: #0 pthread_mutex_init  (libtsan.so.0+0x49603)
> 71: #1 sys_mutex 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:43
>  (libqpid-dispatch.so+0x9691c)
> 71: #2 qd_python_initialize 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/python_embedded.c:54
>  (libqpid-dispatch.so+0x98eac)
> 71: #3 qd_dispatch 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:111
>  (libqpid-dispatch.so+0x76af5)
> 71: #4 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92
>  (qdrouterd+0x4027b9)
> 71: #5 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
>  (qdrouterd+0x4024fc)
> 71: 
> 71:   Thread T4 (tid=4192, running) created by main thread at:
> 71: #0 pthread_create  (libtsan.so.0+0x5bf45)
> 71: #1 sys_thread 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
>  (libqpid-dispatch.so+0x96d5e)
> 71: #2 qd_server_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1499 
> (libqpid-dispatch.so+0xf6302)
> 71: #3 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
>  (qdrouterd+0x40287c)
> 71: #4 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
>  (qdrouterd+0x4024fc)
> 71: 
> 71:   Thread T3 (tid=4191, running) created by main thread at:
> 71: #0 pthread_cr

[jira] [Created] (DISPATCH-2175) Data race in system_tests_tcp_adaptor involving listener_final_free, qd_dispatch_delete_tcp_listener, pn_listener_close

2021-06-16 Thread Jira
Jiri Daněk created DISPATCH-2175:


 Summary: Data race in system_tests_tcp_adaptor involving 
listener_final_free, qd_dispatch_delete_tcp_listener, pn_listener_close
 Key: DISPATCH-2175
 URL: https://issues.apache.org/jira/browse/DISPATCH-2175
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 1.17.0
Reporter: Jiri Daněk


https://github.com/jiridanek/qpid-dispatch/runs/2838892781?check_suite_focus=true#step:25:3147

{noformat}
71: WARNING: ThreadSanitizer: data race (pid=4187)
71:   Write of size 8 at 0x7b68fc28 by thread T4:
71: #0 free  (libtsan.so.0+0x37a28)
71: #1 listener_final_free 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1584
 (libqpid-proton-proactor.so.1+0x8650)
71: #2 pn_listener_free 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1602
 (libqpid-proton-proactor.so.1+0x8650)
71: #3 listener_done 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1804
 (libqpid-proton-proactor.so.1+0xc31f)
71: #4 pn_proactor_done 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2684
 (libqpid-proton-proactor.so.1+0xc31f)
71: #5 thread_run 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1139 
(libqpid-dispatch.so+0xf6094)
71: #6 _thread_init 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
 (libqpid-dispatch.so+0x968c2)
71: 
71:   Previous read of size 8 at 0x7b68fc28 by thread T3 (mutexes: write 
M13):
71: #0 pn_listener_close 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1651
 (libqpid-proton-proactor.so.1+0x9404)
71: #1 qd_dispatch_delete_tcp_listener 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1204
 (libqpid-dispatch.so+0x5af7e)
71: #2 ffi_call_unix64  (libffi.so.6+0x6c03)
71: #3 qdr_forward_on_message 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/forwarder.c:336
 (libqpid-dispatch.so+0xbd5bc)
71: #4 qdr_general_handler 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:942
 (libqpid-dispatch.so+0xc6c2b)
71: #5 qd_timer_visit 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/timer.c:317 
(libqpid-dispatch.so+0xf7b9d)
71: #6 handle 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1006 
(libqpid-dispatch.so+0xf1bae)
71: #7 thread_run 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 
(libqpid-dispatch.so+0xf60c5)
71: #8 _thread_init 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
 (libqpid-dispatch.so+0x968c2)
71: 
71:   Mutex M13 (0x7b100300) created at:
71: #0 pthread_mutex_init  (libtsan.so.0+0x49603)
71: #1 sys_mutex 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:43
 (libqpid-dispatch.so+0x9691c)
71: #2 qd_python_initialize 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/python_embedded.c:54
 (libqpid-dispatch.so+0x98eac)
71: #3 qd_dispatch 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:111 
(libqpid-dispatch.so+0x76af5)
71: #4 main_process 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92
 (qdrouterd+0x4027b9)
71: #5 main 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
 (qdrouterd+0x4024fc)
71: 
71:   Thread T4 (tid=4192, running) created by main thread at:
71: #0 pthread_create  (libtsan.so.0+0x5bf45)
71: #1 sys_thread 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
 (libqpid-dispatch.so+0x96d5e)
71: #2 qd_server_run 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1499 
(libqpid-dispatch.so+0xf6302)
71: #3 main_process 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
 (qdrouterd+0x40287c)
71: #4 main 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
 (qdrouterd+0x4024fc)
71: 
71:   Thread T3 (tid=4191, running) created by main thread at:
71: #0 pthread_create  (libtsan.so.0+0x5bf45)
71: #1 sys_thread 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
 (libqpid-dispatch.so+0x96d5e)
71: #2 qd_server_run 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1499 
(libqpid-dispatch.so+0xf6302)
71: #3 main_process 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
 (qdrouterd+0x40287c)
71: #4 main 
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
 (qdrouterd+0x4024fc)
71: 
71: SUMMARY: ThreadSanitizer: 

[jira] [Commented] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364184#comment-17364184
 ] 

ASF GitHub Bot commented on QPID-8541:
--

asfgit closed pull request #95:
URL: https://github.com/apache/qpid-broker-j/pull/95


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-broker-j] asfgit closed pull request #95: QPID-8541: [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread GitBox


asfgit closed pull request #95:
URL: https://github.com/apache/qpid-broker-j/pull/95


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364183#comment-17364183
 ] 

ASF subversion and git services commented on QPID-8541:
---

Commit dca5e9b810f4e3eb72088044d624c72516f1f35d in qpid-broker-j's branch 
refs/heads/main from Marek Laca
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=dca5e9b ]

QPID-8541: [Broker-J] Enhance Broker Rest API to include certificate alias

This closes #95


> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread Marek Laca (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364175#comment-17364175
 ] 

Marek Laca commented on QPID-8541:
--

Yes [~orudyy], we would like to have the changes in 8.0.x branch.

> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8541) [Broker-J] Enhance Broker Rest API to include certificate alias

2021-06-16 Thread Alex Rudyy (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364165#comment-17364165
 ] 

Alex Rudyy commented on QPID-8541:
--

Hi [~lacam],
Would you like to merge the corresponding changes into 8.0.x branch to include 
in one of upcoming 8.0.x releases? It is a bit late for 8.0.5, but I can add 
the changes into 8.0.6 release...

> [Broker-J] Enhance Broker Rest API to include certificate alias
> ---
>
> Key: QPID-8541
> URL: https://issues.apache.org/jira/browse/QPID-8541
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
>  Labels: Alias, Broker, Certificate, Java
>
> Java broker can publish the list of details about certificates that are hold 
> in the broker trust store via rest API.
>  Broker has 4 types of trust store:
>  * FileTrustStore
>  * NonJavaTrustStore
>  * ManagedPeerCertificateTrustStore
>  * SiteSpecificTrustStore
> FileTrustStore is based on the Java KeyStore, but the certificate alias is 
> not published in the certificate details. But the certificate alias is very 
> useful for managing the underlying Java KeyStore. The task is to enhance the 
> FileTrustStore and include the alias from underlying KeyStore in certificate 
> details. The alias should be accessible via Rest API and the broker GUI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-2060) use-after free in qd_alloc_deref_safe_ptr if a pool item has been freed due to global_free_list size limit

2021-06-16 Thread Robbie Gemmell (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated DISPATCH-2060:
-
Fix Version/s: (was: 1.17.0)

> use-after free in qd_alloc_deref_safe_ptr if a pool item has been freed due 
> to global_free_list size limit
> --
>
> Key: DISPATCH-2060
> URL: https://issues.apache.org/jira/browse/DISPATCH-2060
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Trivial
>
> This is something that is unlikely to occur because the global_free_list size 
> limit is unset by default and as far as I can tell, nobody sets it (except of 
> one small unittest). But if it is set, then it may happen that an item gets 
> freed while there is still a {{safe pointer}} pointing to it. The check in 
> {{qd_alloc_deref_safe_ptr}} to see if safe pointer is still valid involves 
> accessing the item memory. Since that's been freed, the operation is a 
> use-after-free.
> {code}
> static char *test_safe_references(void *context)
> {
> object_t*obj = new_object_t();
> object_t_sp  safe_obj;
> set_safe_ptr_object_t(obj, &safe_obj);
> object_t *alias = safe_deref_object_t(safe_obj);
> if (obj != alias)
> return "Safe alias was not equal to the original pointer";
> free_object_t(obj);
> alias = safe_deref_object_t(safe_obj);  // HERE is 
> ../tests/alloc_test.c:90
> if (alias != 0)
> return "Safe dereference of a freed object was not null";
> return 0;
> }
> {code}
> {noformat}
> ==21009==ERROR: AddressSanitizer: heap-use-after-free on address 
> 0x61103f48 at pc 0x7fcf829bb060 bp 0x7ffc752e1780 sp 0x7ffc752e1778
> READ of size 4 at 0x61103f48 thread T0
> #0 0x7fcf829bb05f in qd_alloc_sequence ../src/alloc_pool.c:523
> #1 0x4161f2 in qd_alloc_deref_safe_ptr 
> ../include/qpid/dispatch/alloc_pool.h:102
> #2 0x4161f2 in safe_deref_object_t ../tests/alloc_test.c:35
> #3 0x41638c in test_safe_references ../tests/alloc_test.c:90
> #4 0x4163dc in alloc_tests ../tests/alloc_test.c:105
> #5 0x406c30 in main ../tests/run_unit_tests.c:65
> #6 0x7fcf81545cbc in __libc_start_main 
> (/nix/store/q53f5birhik4dxg3q3r2g5f324n7r5mc-glibc-2.31-74/lib/libc.so.6+0x23cbc)
> #7 0x404959 in _start 
> (/home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/tests/unit_tests+0x404959)
> 0x61103f48 is located 136 bytes inside of 192-byte region 
> [0x61103ec0,0x61103f80)
> freed by thread T0 here:
> #0 0x7fcf8318eb6f in __interceptor_free 
> (/nix/store/g40sl3zh3nv52vj0mrl4iki5iphh5ika-gcc-10.2.0-lib/lib/libasan.so.6+0xacb6f)
> #1 0x7fcf829badae in qd_dealloc ../src/alloc_pool.c:503
> #2 0x41609d in free_object_t ../tests/alloc_test.c:35
> #3 0x41636a in test_safe_references ../tests/alloc_test.c:89
> #4 0x4163dc in alloc_tests ../tests/alloc_test.c:105
> #5 0x406c30 in main ../tests/run_unit_tests.c:65
> #6 0x7fcf81545cbc in __libc_start_main 
> (/nix/store/q53f5birhik4dxg3q3r2g5f324n7r5mc-glibc-2.31-74/lib/libc.so.6+0x23cbc)
> previously allocated by thread T0 here:
> #0 0x7fcf8318fa3c in __interceptor_posix_memalign 
> (/nix/store/g40sl3zh3nv52vj0mrl4iki5iphh5ika-gcc-10.2.0-lib/lib/libasan.so.6+0xada3c)
> #1 0x7fcf829b78ea in qd_alloc ../src/alloc_pool.c:398
> #2 0x41607a in new_object_t ../tests/alloc_test.c:35
> #3 0x4162e8 in test_safe_references ../tests/alloc_test.c:80
> #4 0x4163dc in alloc_tests ../tests/alloc_test.c:105
> #5 0x406c30 in main ../tests/run_unit_tests.c:65
> #6 0x7fcf81545cbc in __libc_start_main 
> (/nix/store/q53f5birhik4dxg3q3r2g5f324n7r5mc-glibc-2.31-74/lib/libc.so.6+0x23cbc)
> SUMMARY: AddressSanitizer: heap-use-after-free ../src/alloc_pool.c:523 in 
> qd_alloc_sequence
> Shadow bytes around the buggy address:
>   0x0c227fff8790: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c227fff87a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c227fff87b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c227fff87c0: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
>   0x0c227fff87d0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
> =>0x0c227fff87e0: fd fd fd fd fd fd fd fd fd[fd]fd fd fd fd fd fd
>   0x0c227fff87f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c227fff8800: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c227fff8810: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c227fff8820: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c227fff8830: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> Shadow byte legend (one shadow byte represents 8 application bytes):
>   Addressable:   00
>   Partially a

[jira] [Updated] (DISPATCH-2149) qdmanage update on listeners not supported NotImplementedStatus

2021-06-16 Thread Robbie Gemmell (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated DISPATCH-2149:
-
Fix Version/s: (was: 1.17.0)

> qdmanage update on listeners not supported NotImplementedStatus
> ---
>
> Key: DISPATCH-2149
> URL: https://issues.apache.org/jira/browse/DISPATCH-2149
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
> Environment: Installed Packages
> qpid-dispatch-console.noarch 1.15.0-1.fc33 @updates
> qpid-dispatch-router.x86_64 1.15.0-1.fc33 @updates
> qpid-dispatch-tools.noarch 1.15.0-1.fc33 @updates
> FROM fedora:latest
> # Install QPID
> RUN yum install -y qpid-dispatch-router-1.15.0
> RUN yum install -y qpid-dispatch-console-1.15.0
> RUN yum install -y qpid-dispatch-tools-1.15.0
> #RUN yum install -y qpid-dispatch-tools-1.16.0
> ...
>Reporter: Roland Roos
>Assignee: Ganesh Murthy
>Priority: Minor
>
> The specs here :
> [https://qpid.apache.org/releases/qpid-dispatch-1.10.0/user-guide/index.html#managing_security]
> suggest that in par 7.5.4
> qdmanage update --name=LISTENER_NAME  --requireSsl=yes
> is possible.
> However, I get a 
> [root@7d50244025b8 /]# qdmanage -d EdgeRouter.producer update 
> --name=listener1 --authenticatePeer=yes
> *NotImplementedStatus: Operation 'UPDATE' not implemented for 
> 'org.apache.qpid.dispatch.listener' ['CREATE', 'DELETE', 'READ']*
> My listener is there:
>  {
>  "metrics": true,
>  "idleTimeoutSeconds": 16,
>  "type": "org.apache.qpid.dispatch.listener",
>  "role": "normal",
>  "requireEncryption": false,
>  "policyVhost": "public",
>  "websockets": true,
>  "messageLoggingComponents": "none",
>  "port": "5672",
>  "maxFrameSize": 16384,
>  "http": false,
>  "multiTenant": false,
>  "initialHandshakeTimeoutSeconds": 0,
>  "identity": "listener/0.0.0.0:5672:listener1",
>  "cost": 1,
>  "healthz": true,
>  "host": "0.0.0.0",
>  "stripAnnotations": "both",
>  "name": "listener1",
>  "maxSessions": 32768,
>  "requireSsl": false,
>  "authenticatePeer": false
>  }
> And the config is :
> listener {
>  name: listener1
>  host: 0.0.0.0
>  port: 5672
>  authenticatePeer: no
> }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-06-16 Thread Robbie Gemmell (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated DISPATCH-1878:
-
Affects Version/s: (was: 2.0.0)
   1.15.0
   1.16.0

Not sure how this can affect 2.0.0 if it was resolved against 1.16.0 and later 
1.17.0 (or perhaps 1.16.1), so updating fix-versions. Adjust if the assumed 
versions are incorrect.

 

JIRAs really shoudlnt be reused like this after they have changes that have 
been released - create a new Jira and link them / comment to make clear what 
changed when and why.

> Client app not getting a response through tcpListener
> -
>
> Key: DISPATCH-1878
> URL: https://issues.apache.org/jira/browse/DISPATCH-1878
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Fernando Giorgetti
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
> Attachments: D-1878 @e148c.svg, 
> DISPATCH-1878_fail-pn-raw-closed-before-ingress-stream-set-up.svg, 
> dispatch-1878-trace.html
>
>
> I have a tcp-echo server running locally through:
> podman run -d --rm --name tcpecho -p 9090:9090 quay.io/skupper/tcp-go-echo
> And I have a router configured with a tcpConnector to localhost at port 9090 
> and a tcpListener at port .
> I am able to use nc (netcat) to send data to the tcp-echo directly (port 
> 9090) or through
> the router (port ), if I run "nc 127.0.0.1 " and the send the data.
> But if I run it as:  "echo abcd | nc 127.0.0.1 " I am not seeing a 
> response, but if 
> I use port 9090 (original port) instead of  (router tcpListener), then I 
> get the
> response correctly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org