[jira] [Commented] (DISPATCH-2179) Some system tests relating to TLS are failing due to changes in proton master
[ https://issues.apache.org/jira/browse/DISPATCH-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366358#comment-17366358 ] ASF GitHub Bot commented on DISPATCH-2179: -- codecov-commenter commented on pull request #1268: URL: https://github.com/apache/qpid-dispatch/pull/1268#issuecomment-864695042 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1268](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2d3a3be) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/b757bf502e2442442dae8c7be239edd12e4256bb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b757bf5) will **increase** coverage by `0.02%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1268 +/- ## == + Coverage 84.73% 84.76% +0.02% == Files 113 113 Lines 2815728176 +19 == + Hits2385923882 +23 + Misses 4298 4294 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `86.58% <100.00%> (+0.01%)` | :arrow_up: | | [tests/test-sender.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1zZW5kZXIuYw==) | `57.20% <0.00%> (-0.67%)` | :arrow_down: | | [tests/test-receiver.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1yZWNlaXZlci5j) | `69.15% <0.00%> (-0.32%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.28% <0.00%> (-0.30%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.99% <0.00%> (+0.14%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.73% <0.00%> (+0.29%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.39% <0.00%> (+0.43%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.04% <0.00%> (+0.96%)` | :arrow_up: | | [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `83.81% <0.00%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1268: DISPATCH-2179: Set SSLDomain.ANONYMOUS_PEER wherever necessary. Also …
codecov-commenter commented on pull request #1268: URL: https://github.com/apache/qpid-dispatch/pull/1268#issuecomment-864695042 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1268](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2d3a3be) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/b757bf502e2442442dae8c7be239edd12e4256bb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b757bf5) will **increase** coverage by `0.02%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1268 +/- ## == + Coverage 84.73% 84.76% +0.02% == Files 113 113 Lines 2815728176 +19 == + Hits2385923882 +23 + Misses 4298 4294 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `86.58% <100.00%> (+0.01%)` | :arrow_up: | | [tests/test-sender.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1zZW5kZXIuYw==) | `57.20% <0.00%> (-0.67%)` | :arrow_down: | | [tests/test-receiver.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1yZWNlaXZlci5j) | `69.15% <0.00%> (-0.32%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.28% <0.00%> (-0.30%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.99% <0.00%> (+0.14%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.73% <0.00%> (+0.29%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.39% <0.00%> (+0.43%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.04% <0.00%> (+0.96%)` | :arrow_up: | | [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1268/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `83.81% <0.00%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1268?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn
[jira] [Commented] (DISPATCH-2179) Some system tests relating to TLS are failing due to changes in proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366344#comment-17366344
]
ASF GitHub Bot commented on DISPATCH-2179:
--
ganeshmurthy opened a new pull request #1268:
URL: https://github.com/apache/qpid-dispatch/pull/1268
…fixed python code to set correct scheme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Some system tests relating to TLS are failing due to changes in proton master
> -
>
> Key: DISPATCH-2179
> URL: https://issues.apache.org/jira/browse/DISPATCH-2179
> Project: Qpid Dispatch
> Issue Type: Test
>Reporter: Ganesh Murthy
>Priority: Major
>
> Steps to reproduce -
> Check out to commit 605bc58009549dff2678961455a7ec86b0acede4 on proton master
> and compile.
> Compile dispatch using the above proton and run the dispatch test suite. You
> will see 4 tests that fail -
> {noformat}
> 31 - system_tests_qdstat (Failed)
> 33 - system_tests_user_id (Failed)
> 44 - system_tests_authz_service_plugin (Timeout)
> 54 - system_tests_ssl (Failed) {noformat}
>
> {noformat}
> 54: Test command: /usr/bin/python3.9
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_ssl"
> 54: Test timeout computed to be: 600
> 54: test_ssl_invalid (system_tests_ssl.RouterTestSslClient)
> 54: Expects connection is rejected as SSL is no longer supported ... ok
> 54: test_ssl_sasl_client_invalid (system_tests_ssl.RouterTestSslClient)
> 54: Attempts to connect a Proton client using a valid SASL authentication
> info ... ok
> 54: test_ssl_sasl_client_valid (system_tests_ssl.RouterTestSslClient)
> 54: Attempts to connect a Proton client using a valid SASL authentication
> info ... FAIL
> 54: test_tls11_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1.1 only is allowed ... ok
> 54: test_tls11_tls12_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1.1 and TLSv1.2 only are allowed ... FAIL
> 54: test_tls12_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1.2 only is allowed ... FAIL
> 54: test_tls13_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1.3 only is allowed ... FAIL
> 54: test_tls1_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1 only is allowed ... ok
> 54: test_tls1_tls11_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1 and TLSv1.1 only are allowed ... ok
> 54: test_tls1_tls12_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1 and TLSv1.2 only are allowed ... FAIL
> 54: test_tls_all (system_tests_ssl.RouterTestSslClient)
> 54: Expects all supported versions: TLSv1, TLSv1.1, TLSv1.2 and TLSv1.3 to be
> allowed ... FAIL
> 54: test_connected_tls_sasl_routers
> (system_tests_ssl.RouterTestSslInterRouter)
> 54: Validates if all expected routers are connected in the network ... ok
> 54: test_invalid_ca_path
> (system_tests_ssl.RouterTestSslInterRouterWithInvalidPathToCA)
> 54: Prove sslProfile with invalid path to CA prevents the router from joining
> the network ... ok
> 54: test_mismatched_ca_and_no_hostname_verification
> (system_tests_ssl.RouterTestSslInterRouterWithoutHostnameVerificationAndMismatchedCA)
> 54: Prove that improperly configured ssl-enabled connector prevents the
> router ... ok
> 54:
> 54: ==
> 54: FAIL: test_ssl_sasl_client_valid (system_tests_ssl.RouterTestSslClient)
> 54: Attempts to connect a Proton client using a valid SASL authentication info
> 54: --
> 54: Traceback (most recent call last):
> 54: File "/home/gmurthy/opensource/qpid-dispatch/tests/system_test.py",
> line 924, in wrap
> 54: return f(*args, **kwargs)
> 54: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_ssl.py", line 539,
> in test_ssl_sasl_client_valid
> 54: self.assertEqual(exp_tls_results[2],
> self.is_ssl_sasl_client_accepted(self.PORT_TLS_SASL, "TLSv1.2"))
> 54: AssertionError: True != False
> 54:
> 54: ==
> 54: FAIL: test_tls11_tls12_only (system_tests_ssl.RouterTestSslClient)
> 54: Expects TLSv1.1 and TLSv1.2 only are allowed
> 54: --
> 54: Traceback (most recent call last):
> 54: File "/home/gmurthy/opensource/qpid-dispatch/tests/system_test.py",
> line 924, in wrap
> 54: return f(*args, **kwargs)
> 54: File
>
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1268: DISPATCH-2179: Set SSLDomain.ANONYMOUS_PEER wherever necessary. Also …
ganeshmurthy opened a new pull request #1268: URL: https://github.com/apache/qpid-dispatch/pull/1268 …fixed python code to set correct scheme -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2178) Do not build separate libqpid-dispatch.so
[
https://issues.apache.org/jira/browse/DISPATCH-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366184#comment-17366184
]
ASF GitHub Bot commented on DISPATCH-2178:
--
jiridanek commented on a change in pull request #1267:
URL: https://github.com/apache/qpid-dispatch/pull/1267#discussion_r654937669
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -22,8 +22,8 @@ file(GLOB unittest_SOURCES
)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS}
${SANITIZE_FLAGS}")
-add_executable(c_unittests ${unittest_SOURCES})
-target_link_libraries(c_unittests pthread qpid-dispatch)
+add_executable(c_unittests ${unittest_SOURCES}
$)
Review comment:
```suggestion
add_executable(c_unittests ${unittest_SOURCES}
$)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Do not build separate libqpid-dispatch.so
> -
>
> Key: DISPATCH-2178
> URL: https://issues.apache.org/jira/browse/DISPATCH-2178
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>
> h3. Motivation
> The split into a binary and a library is not unprecedented (e.g. CPython does
> exactly the same thing), but in Dispatch it is avoidable with minimal code
> changes (an executable can {{dlopen(NULL, ...)}} itself.
> Getting rid of libqpid-dispatch.so will mean one less file that we need to
> install (and since it is not a published API, finding a good place for the so
> has been tricky in the past (see DISPATCH-194).
> Furthermore, avoiding the indirection of a library call will likely give some
> performance benefit at a low level (individual function calls) similar to
> (again) Python in https://fedoraproject.org/wiki/Changes/PythonStaticSpeedup.
> The gains can be best utilized after doing LTO (see DISPATCH-2121).
> h3. Expected issues
> The problem with this is that we lose semantic interposition
> (https://fedoraproject.org/wiki/Changes/PythonNoSemanticInterpositionSpeedup),
> meaning we won't be able to simply override symbols from libqpid-dispatch.so
> at runtime. This is an issue because Dispatch unittests depend on this. (See
> DISPATCH-1783)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1267: DISPATCH-2178: Do not build separate libqpid-dispatch.so
jiridanek commented on a change in pull request #1267:
URL: https://github.com/apache/qpid-dispatch/pull/1267#discussion_r654937669
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -22,8 +22,8 @@ file(GLOB unittest_SOURCES
)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS}
${SANITIZE_FLAGS}")
-add_executable(c_unittests ${unittest_SOURCES})
-target_link_libraries(c_unittests pthread qpid-dispatch)
+add_executable(c_unittests ${unittest_SOURCES}
$)
Review comment:
```suggestion
add_executable(c_unittests ${unittest_SOURCES}
$)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2178) Do not build separate libqpid-dispatch.so
[
https://issues.apache.org/jira/browse/DISPATCH-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366182#comment-17366182
]
ASF GitHub Bot commented on DISPATCH-2178:
--
jiridanek opened a new pull request #1267:
URL: https://github.com/apache/qpid-dispatch/pull/1267
The change would've been nice and easy in CMake 3.12+. Without support for
using OBJECT library in `target_link_libraries`, it is necessary to 1) use a
STATIC library and then handle the `-Wl,--whole-archive` flag (so that symbols
used only from Python are not eliminated by linker) or 2) propagate the
dependent libraries through the build some other way. I choose option 2) here.
@astitcher Is this what you had in mind, or are there some improvements that
I've missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Do not build separate libqpid-dispatch.so
> -
>
> Key: DISPATCH-2178
> URL: https://issues.apache.org/jira/browse/DISPATCH-2178
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>
> h3. Motivation
> The split into a binary and a library is not unprecedented (e.g. CPython does
> exactly the same thing), but in Dispatch it is avoidable with minimal code
> changes (an executable can {{dlopen(NULL, ...)}} itself.
> Getting rid of libqpid-dispatch.so will mean one less file that we need to
> install (and since it is not a published API, finding a good place for the so
> has been tricky in the past (see DISPATCH-194).
> Furthermore, avoiding the indirection of a library call will likely give some
> performance benefit at a low level (individual function calls) similar to
> (again) Python in https://fedoraproject.org/wiki/Changes/PythonStaticSpeedup.
> The gains can be best utilized after doing LTO (see DISPATCH-2121).
> h3. Expected issues
> The problem with this is that we lose semantic interposition
> (https://fedoraproject.org/wiki/Changes/PythonNoSemanticInterpositionSpeedup),
> meaning we won't be able to simply override symbols from libqpid-dispatch.so
> at runtime. This is an issue because Dispatch unittests depend on this. (See
> DISPATCH-1783)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1267: DISPATCH-2178: Do not build separate libqpid-dispatch.so
jiridanek opened a new pull request #1267: URL: https://github.com/apache/qpid-dispatch/pull/1267 The change would've been nice and easy in CMake 3.12+. Without support for using OBJECT library in `target_link_libraries`, it is necessary to 1) use a STATIC library and then handle the `-Wl,--whole-archive` flag (so that symbols used only from Python are not eliminated by linker) or 2) propagate the dependent libraries through the build some other way. I choose option 2) here. @astitcher Is this what you had in mind, or are there some improvements that I've missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Feature 'publish is enabled in site .asf.yaml
Hi folks, As part of site changes for the Qpid Broker-J 8.0.5 release I added the section 'publish' into .asf.yaml in order to switch to new site publishing functionality. If required we can revert back to gitwcsub for publishing by removing the publish feature in .asf.yaml file. Kind Regards, Alex - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[ANNOUNCE] Apache Qpid Broker-J 8.0.5 released
The Apache Qpid (http://qpid.apache.org) community is pleased to announce the immediate availability of Apache Qpid Broker-J 8.0.5. This is the latest release of pure java implementation of messaging broker supporting the Advanced Message Queuing Protocol 1.0 (AMQP 1.0, ISO/IEC 19464, http://www.amqp.org) and legacy AMQP protocols 0-10, 0-91, 0-9 and 0-8. Please visit Qpid project site for more details: http://qpid.apache.org/components/broker-j/index.html The release is available now from our website: http://qpid.apache.org/download.html The release brings bug fixes and improvements. The release notes can be found at: http://qpid.apache.org/releases/qpid-broker-j-8.0.5/release-notes.html Thanks to all involved, Qpid Team - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8510) [Broker-J] [AMQP 1.0] Connection transaction management is not thread-safe
[
https://issues.apache.org/jira/browse/QPID-8510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8510:
-
Summary: [Broker-J] [AMQP 1.0] Connection transaction management is not
thread-safe (was: [Broker-J] Connection transaction management is not
thread-safe)
> [Broker-J] [AMQP 1.0] Connection transaction management is not thread-safe
> --
>
> Key: QPID-8510
> URL: https://issues.apache.org/jira/browse/QPID-8510
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0, qpid-java-broker-7.0.1,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6, qpid-java-broker-7.0.7, qpid-java-broker-8.0.0,
> qpid-java-broker-7.1.1, qpid-java-broker-7.1.2, qpid-java-broker-7.0.8,
> qpid-java-broker-7.1.3, qpid-java-broker-7.1.4, qpid-java-broker-7.0.9,
> qpid-java-broker-7.1.5, qpid-java-broker-7.1.6, qpid-java-broker-7.1.7,
> qpid-java-broker-7.1.8, qpid-java-broker-8.0.1, qpid-java-broker-7.1.9,
> qpid-java-broker-8.0.2, qpid-java-broker-7.1.10, qpid-java-broker-8.0.3,
> qpid-java-broker-7.1.11, qpid-java-broker-8.0.4, qpid-java-broker-7.1.12
>Reporter: Marek Laca
>Priority: Minor
> Labels: Broker, Java
> Fix For: qpid-java-broker-8.0.5
>
>
> Based on Java documentation a change of volatile variable is always visible
> to other threads. Hence, assignment a new array to the volatile variable
> guarantees the visibility of the new array to another threads, but there is
> not any guarantee of the visibility of a new element of the array. Because
> the insertion of a new element into the volatile array is a change of the
> internal state of the array.
> For example there is the method AMQPConnection_1_0Impl::removeTransaction:
> {code:java}
> private volatile ServerTransaction[] _openTransactions = new
> ServerTransaction[16];
> @Override
> public void removeTransaction(final int txnId)
> {
> try
> {
> _openTransactions[txnId] = null; // There is not any guarantee
> of the visibility, when the change is propagated to another threads.
> }
> catch (ArrayIndexOutOfBoundsException e)
> {
> throw new UnknownTransactionException(txnId);
> }
> }
> {code}
> The same issue is in other methods of AMQPConnection_1_0Impl class.
> A concurrent collection can be used instead of the volatile array.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8510) [Broker-J] Connection transaction management is not thread-safe
[
https://issues.apache.org/jira/browse/QPID-8510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8510:
-
Summary: [Broker-J] Connection transaction management is not thread-safe
(was: [Broker-J] Incorect use of volatile modifier for array)
> [Broker-J] Connection transaction management is not thread-safe
> ---
>
> Key: QPID-8510
> URL: https://issues.apache.org/jira/browse/QPID-8510
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0, qpid-java-broker-7.0.1,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6, qpid-java-broker-7.0.7, qpid-java-broker-8.0.0,
> qpid-java-broker-7.1.1, qpid-java-broker-7.1.2, qpid-java-broker-7.0.8,
> qpid-java-broker-7.1.3, qpid-java-broker-7.1.4, qpid-java-broker-7.0.9,
> qpid-java-broker-7.1.5, qpid-java-broker-7.1.6, qpid-java-broker-7.1.7,
> qpid-java-broker-7.1.8, qpid-java-broker-8.0.1, qpid-java-broker-7.1.9,
> qpid-java-broker-8.0.2, qpid-java-broker-7.1.10, qpid-java-broker-8.0.3,
> qpid-java-broker-7.1.11, qpid-java-broker-8.0.4, qpid-java-broker-7.1.12
>Reporter: Marek Laca
>Priority: Minor
> Labels: Broker, Java
> Fix For: qpid-java-broker-8.0.5
>
>
> Based on Java documentation a change of volatile variable is always visible
> to other threads. Hence, assignment a new array to the volatile variable
> guarantees the visibility of the new array to another threads, but there is
> not any guarantee of the visibility of a new element of the array. Because
> the insertion of a new element into the volatile array is a change of the
> internal state of the array.
> For example there is the method AMQPConnection_1_0Impl::removeTransaction:
> {code:java}
> private volatile ServerTransaction[] _openTransactions = new
> ServerTransaction[16];
> @Override
> public void removeTransaction(final int txnId)
> {
> try
> {
> _openTransactions[txnId] = null; // There is not any guarantee
> of the visibility, when the change is propagated to another threads.
> }
> catch (ArrayIndexOutOfBoundsException e)
> {
> throw new UnknownTransactionException(txnId);
> }
> }
> {code}
> The same issue is in other methods of AMQPConnection_1_0Impl class.
> A concurrent collection can be used instead of the volatile array.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
