[jira] [Commented] (DISPATCH-2274) system_tests_router_mesh: ERROR: AddressSanitizer: use-after-poison in qd_link_pn container.c:1029

2021-11-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442472#comment-17442472
 ] 

ASF subversion and git services commented on DISPATCH-2274:
---

Commit ab16a59c50778e9c7c1692f89f562a411b106312 in qpid-dispatch's branch 
refs/heads/1.18.x from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ab16a59 ]

DISPATCH-2274: Fix use after free of qd_link_t by using safe pointer as context

(cherry picked from commit a2785d25e0ce2c0c9253fe26ab7d8470d6912b6d)


> system_tests_router_mesh: ERROR: AddressSanitizer: use-after-poison in 
> qd_link_pn container.c:1029
> --
>
> Key: DISPATCH-2274
> URL: https://issues.apache.org/jira/browse/DISPATCH-2274
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.18.0
> Environment: Aarch64 Linux, amd64 macOS
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/545969177
> {noformat}
> 66: Create 10 senders each with a different priority. ... ERROR
> 66: ERROR
> 66: 
> 66: Router RouterC output file:
> 66: 
> 66: =
> 66: ==21601==ERROR: AddressSanitizer: use-after-poison on address 
> 0x6137d828 at pc 0x0001064a6469 bp 0x7843bca0 sp 0x7843bc98
> 66: READ of size 8 at 0x6137d828 thread T4
> 66: #0 0x1064a6468 in qd_link_pn container.c:1029
> 66: #1 0x1066d0e37 in CORE_link_push router_node.c:1920
> 66: #2 0x106576df6 in qdr_connection_process connections.c:414
> 66: #3 0x1064956ce in writable_handler container.c:396
> 66: #4 0x1066edb36 in thread_run server.c:1149
> 66: #5 0x7fff5fa152ea in _pthread_body 
> (libsystem_pthread.dylib:x86_64+0x32ea)
> 66: #6 0x7fff5fa18248 in _pthread_start 
> (libsystem_pthread.dylib:x86_64+0x6248)
> 66: #7 0x7fff5fa1440c in thread_start 
> (libsystem_pthread.dylib:x86_64+0x240c)
> 66: 
> 66: 0x6137d828 is located 168 bytes inside of 320-byte region 
> [0x6137d780,0x6137d8c0)
> 66: allocated by thread T4 here:
> 66: #0 0x106f823a7 in wrap_posix_memalign 
> (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x5f3a7)
> 66: #1 0x1064555df in qd_alloc alloc_pool.c:396
> 66: #2 0x10649691a in qd_container_handle_event container.c:75
> 66: #3 0x1066f4366 in handle server.c:1108
> 66: #4 0x1066eda23 in thread_run server.c:1133
> 66: #5 0x7fff5fa152ea in _pthread_body 
> (libsystem_pthread.dylib:x86_64+0x32ea)
> 66: #6 0x7fff5fa18248 in _pthread_start 
> (libsystem_pthread.dylib:x86_64+0x6248)
> 66: #7 0x7fff5fa1440c in thread_start 
> (libsystem_pthread.dylib:x86_64+0x240c)
> 66: 
> 66: Thread T4 created by T0 here:
> 66: #0 0x106f79add in wrap_pthread_create 
> (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x56add)
> 66: #1 0x106535a6d in sys_thread threading.c:181
> 66: #2 0x1066ed1af in qd_server_run server.c:1525
> 66: #3 0x1063b081e in main_process main.c:115
> 66: #4 0x1063af12b in main main.c:369
> 66: #5 0x7fff5f8213d4 in start (libdyld.dylib:x86_64+0x163d4)
> 66: 
> 66: SUMMARY: AddressSanitizer: use-after-poison container.c:1029 in qd_link_pn
> 66: Shadow bytes around the buggy address:
> 66:   0x1c26fab0: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
> 66:   0x1c26fac0: 00 00 00 00 00 00 00 00 00 00 f7 f7 f7 f7 f7 f7
> 66:   0x1c26fad0: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 00 00 00 00
> 66:   0x1c26fae0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 66:   0x1c26faf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 66: =>0x1c26fb00: 00 00 f7 f7 f7[f7]f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 66:   0x1c26fb10: f7 f7 f7 f7 00 00 00 00 fa fa fa fa fa fa fa fa
> 66:   0x1c26fb20: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
> 66:   0x1c26fb30: 00 00 00 00 00 00 00 00 00 00 f7 f7 f7 f7 f7 f7
> 66:   0x1c26fb40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 00 00 00 00
> 66:   0x1c26fb50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 66: Shadow byte legend (one shadow byte represents 8 application bytes):
> 66:   Addressable:   00
> 66:   Partially addressable: 01 02 03 04 05 06 07 
> 66:   Heap left redzone:   fa
> 66:   Freed heap region:   fd
> 66:   Stack left redzone:  f1
> 66:   Stack mid redzone:   f2
> 66:   Stack right redzone: f3
> 66:   Stack after return:  f5
> 66:   Stack use after scope:   f8
> 66:   Global redzone:  f9
> 66:   Global init order:   f6
> 66:   Poisoned by user:f7
> 66:   Container overflow:  fc
> 66:   Array cookie:ac
> 66:   Intra object redzone:bb
> 66:   ASa

[jira] [Commented] (DISPATCH-2257) listener with http=true uses AF_INTE6 even when ipv6 is not supported

2021-11-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442471#comment-17442471
 ] 

ASF subversion and git services commented on DISPATCH-2257:
---

Commit 8cba3a7eda5fdab3dce0b1cd6bf391536411487d in qpid-dispatch's branch 
refs/heads/1.18.x from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8cba3a7 ]

NO-JIRA: bump proton stable release to 0.36.0 in CI
This needs to be done until DISPATCH-2257 is fixed.
This closes #1422

(cherry picked from commit df03efbacd97ea44ec8d636d10d0065cbccc4611)


> listener with http=true uses AF_INTE6 even when ipv6 is not supported
> -
>
> Key: DISPATCH-2257
> URL: https://issues.apache.org/jira/browse/DISPATCH-2257
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Gordon Sim
>Priority: Major
> Fix For: 1.17.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-2266) system_tests_edge_router stalls on Travis CI

2021-11-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442473#comment-17442473
 ] 

ASF subversion and git services commented on DISPATCH-2266:
---

Commit ab990ec23d2936ada1892c951cbc8912cf267a1f in qpid-dispatch's branch 
refs/heads/1.18.x from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ab990ec ]

DISPATCH-2266: Added more logging to see where the test stalls

(cherry picked from commit f14a4b8d14f9c1280461ee43c306b0866f09535d)


> system_tests_edge_router stalls on Travis CI
> 
>
> Key: DISPATCH-2266
> URL: https://issues.apache.org/jira/browse/DISPATCH-2266
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> The system_tests_edge_router stalls on Travis CI intermittently
> {noformat}
> 55: test_50_link_topology (system_tests_edge_router.LinkRouteProxyTest) ... ok
> No output has been received in the last 10m0s, this potentially indicates a 
> stalled build or something wrong with the build itself.
> Check the details on how to adjust your build configuration on: 
> https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
> The build has been terminated
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-2262) Edge/Interior connections can half-fail in real multi-cloud environments

2021-11-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442474#comment-17442474
 ] 

ASF subversion and git services commented on DISPATCH-2262:
---

Commit 8774905f6a1bdfc6b103fb934fcd36d2bfd2ebb1 in qpid-dispatch's branch 
refs/heads/1.18.x from Ted Ross
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8774905 ]

DISPATCH-2262 - Added missing handling for client-side link loss.

(cherry picked from commit 6769203991b20ecf0fdeb28bb8d84962b73c22fd)


> Edge/Interior connections can half-fail in real multi-cloud environments
> 
>
> Key: DISPATCH-2262
> URL: https://issues.apache.org/jira/browse/DISPATCH-2262
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.17.0
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.18.0
>
>
> See PROTON-2440 for context.
> The configured keepalive on edge-to-interior connections can fail to provide 
> protection from connection loss.  This results in half-failed connections 
> where the edge sees connection failure and re-connects and the interior sees 
> nothing and accumulates multiple connections from the same edge.
> This is a serious problem because the interior will attempt to forward 
> deliveries across these dead-but-seemingly-alive connections resulting in 
> lack of message delivery.
> The solution proposed in this issue is to work around the problem by 
> introducing an application-level keepalive for edge-to-interior connections.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] kgiusti merged pull request #1423: NO-JIRA: bump proton stable release to 0.36.0 in CI

2021-11-11 Thread GitBox


kgiusti merged pull request #1423:
URL: https://github.com/apache/qpid-dispatch/pull/1423


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] kgiusti commented on pull request #1423: NO-JIRA: bump proton stable release to 0.36.0 in CI

2021-11-11 Thread GitBox


kgiusti commented on pull request #1423:
URL: https://github.com/apache/qpid-dispatch/pull/1423#issuecomment-966674074


   > The PR title no longer matches the content (everything is bumped to 0.36, 
even jobs previously pulling main). This commit already looks to be merged, so 
how come PR is still open?
   
   There's actually 4 cherry-picked commits here that are already on main 
branch.  This PR is for merging them to 1.18.x.  Github apparently only uses 
the first commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-2262) Edge/Interior connections can half-fail in real multi-cloud environments

2021-11-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442371#comment-17442371
 ] 

ASF subversion and git services commented on DISPATCH-2262:
---

Commit 6769203991b20ecf0fdeb28bb8d84962b73c22fd in qpid-dispatch's branch 
refs/heads/main from Ted Ross
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6769203 ]

DISPATCH-2262 - Added missing handling for client-side link loss.


> Edge/Interior connections can half-fail in real multi-cloud environments
> 
>
> Key: DISPATCH-2262
> URL: https://issues.apache.org/jira/browse/DISPATCH-2262
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.17.0
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.18.0
>
>
> See PROTON-2440 for context.
> The configured keepalive on edge-to-interior connections can fail to provide 
> protection from connection loss.  This results in half-failed connections 
> where the edge sees connection failure and re-connects and the interior sees 
> nothing and accumulates multiple connections from the same edge.
> This is a serious problem because the interior will attempt to forward 
> deliveries across these dead-but-seemingly-alive connections resulting in 
> lack of message delivery.
> The solution proposed in this issue is to work around the problem by 
> introducing an application-level keepalive for edge-to-interior connections.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-2262) Edge/Interior connections can half-fail in real multi-cloud environments

2021-11-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442369#comment-17442369
 ] 

ASF GitHub Bot commented on DISPATCH-2262:
--

ted-ross merged pull request #1433:
URL: https://github.com/apache/qpid-dispatch/pull/1433


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge/Interior connections can half-fail in real multi-cloud environments
> 
>
> Key: DISPATCH-2262
> URL: https://issues.apache.org/jira/browse/DISPATCH-2262
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.17.0
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.18.0
>
>
> See PROTON-2440 for context.
> The configured keepalive on edge-to-interior connections can fail to provide 
> protection from connection loss.  This results in half-failed connections 
> where the edge sees connection failure and re-connects and the interior sees 
> nothing and accumulates multiple connections from the same edge.
> This is a serious problem because the interior will attempt to forward 
> deliveries across these dead-but-seemingly-alive connections resulting in 
> lack of message delivery.
> The solution proposed in this issue is to work around the problem by 
> introducing an application-level keepalive for edge-to-interior connections.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ted-ross merged pull request #1433: DISPATCH-2262 - Added missing handling for client-side link loss.

2021-11-11 Thread GitBox


ted-ross merged pull request #1433:
URL: https://github.com/apache/qpid-dispatch/pull/1433


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-2085) system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: Assertion `addr->edge_outlink == 0' failed

2021-11-11 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2085:

Fix Version/s: 1.19.0
   (was: 1.18.0)

> system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: 
> Assertion `addr->edge_outlink == 0' failed
> 
>
> Key: DISPATCH-2085
> URL: https://issues.apache.org/jira/browse/DISPATCH-2085
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> First spotted on s390x, 
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501153572#L6607
> {noformat}
> 62: Router EA2 output file:
> 62: 
> 62: 2021-04-26 16:56:05.615255 + AGENT (warning) Attribute 'dir' of 
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: 2021-04-26 16:56:05.615411 + AGENT (warning) Attribute 'dir' of 
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: qdrouterd: 
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:323:
>  on_conn_event: Assertion `addr->edge_outlink == 0' failed.
> 62: 
> 62: 
> 62: 
> 62: Router EA2 command file:
> 62: 
> 62: qdrouterd -c EA2.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62: pid=14036
> 62: 
> 62: 
> 62: 
> 62: Router EA2 log file tail:
> 62: 
> 62: 2021-04-26 16:58:05.686184 + ROUTER_CORE (trace) Core action 
> 'link_detach' 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686235 + ROUTER_CORE (info) [C4][L12] Link lost: 
> del=1 presett=1 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0 
> blocked=no 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 62: 2021-04-26 16:58:05.686281 + ROUTER_CORE (trace) Core action 
> 'connection_closed' 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686346 + ROUTER_CORE (info) [C4] Connection 
> Closed 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1557)
> 62: 2021-04-26 16:58:05.705484 + SERVER (trace) Accepting connection on 
> 0.0.0.0:23020 (/home/travis/build/apache/qpid-dispatch/src/server.c:852)
> 62: 2021-04-26 16:58:05.705577 + SERVER (trace) [C5]: Accepting incoming 
> connection to '0.0.0.0:23020' 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:606)
> 62: 2021-04-26 16:58:05.705691 + POLICY (trace) ALLOW Connection 
> '127.0.0.1' based on global connection count. nConnections= 1 
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:271)
> 62: 2021-04-26 16:58:05.705782 + SERVER (info) [C5] Accepted connection 
> to 0.0.0.0:23020 from 127.0.0.1:37922 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:750)
> 62: 2021-04-26 16:58:05.706152 + PROTOCOL (trace) [C5]:FRAME:   <- SASL 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706180 + PROTOCOL (trace) [C5]:FRAME:   -> SASL 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706590 + PROTOCOL (trace) [C5]:FRAME: 0 -> 
> @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706949 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@travis-job-apache-qpid-dispatch-501153572"] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707025 + PROTOCOL (trace) [C5]:FRAME: 0 -> 
> @sasl-outcome(68) [code=0] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707319 + PROTOCOL (trace) [C5]:FRAME:   <- AMQP 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707363 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @open(16) [container-id="ac3fab39-661e-44f4-8361-5866a600788d", 
> hostname="0.0.0.0", channel-max=32767] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707432 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @begin(17) [next-outgoing-id=0, incoming-window=2147483647, 
> outgoing-window=2147483647] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707500 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @attach(18) [name="dest.32_primary_receiver", handle=0, role=true, 
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="dest.32", 
> durable=0, timeout=0, dynamic=false], target=@target(41) [durable=0, 
> timeout=0, dynamic=false],

[jira] [Assigned] (DISPATCH-2283) heap-use-after-free in system_tests_policy_oversize_compound during qdrc_endpoint_delivery_CT

2021-11-11 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy reassigned DISPATCH-2283:
---

Assignee: Ted Ross

> heap-use-after-free in system_tests_policy_oversize_compound during 
> qdrc_endpoint_delivery_CT
> -
>
> Key: DISPATCH-2283
> URL: https://issues.apache.org/jira/browse/DISPATCH-2283
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.18.0
>
>
> https://github.com/jiridanek/qpid-dispatch/runs/4140877666?check_suite_focus=true#step:9:35786
> This comes from the "set memory pool max size to 0" memory poisoning 
> investigation. I haven't seen this fail with unmodified main branch (yet ;) 
> The only somewhat similar stacktrace I could find in Jira is for this leak 
> DISPATCH-1699.
> {noformat}
> 27: ==12548==ERROR: AddressSanitizer: heap-use-after-free on address 
> 0x611136e0 at pc 0x55f47830adb9 bp 0x7f1063183140 sp 0x7f1063183130
> 27: READ of size 8 at 0x611136e0 thread T1
> 27: #0 0x55f47830adb8 in qdrc_endpoint_delivery_CT 
> ../src/router_core/core_link_endpoint.c:136
> 27: #1 0x55f4783eea3b in on_timer 
> ../src/router_core/modules/heartbeat_edge/heartbeat_edge.c:157
> 27: #2 0x55f4783c0613 in qdr_process_tick_CT 
> ../src/router_core/core_timer.c:123
> 27: #3 0x55f47838fec7 in router_core_thread 
> ../src/router_core/router_core_thread.c:236
> 27: #4 0x55f4782a2964 in _thread_init ../src/posix/threading.c:172
> 27: #5 0x7f1069458608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 27: #6 0x7f106864e292 in __clone 
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 27: 
> 27: 0x611136e0 is located 160 bytes inside of 192-byte region 
> [0x61113640,0x61113700)
> 27: freed by thread T1 here:
> 27: #0 0x7f1069a167cf in __interceptor_free 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x10d7cf)
> 27: #1 0x55f4781e3b84 in qd_dealloc ../src/alloc_pool.c:497
> 27: #2 0x55f478308e1d in free_qdrc_endpoint_t 
> ../src/router_core/core_link_endpoint.c:35
> 27: #3 0x55f47830d34f in qdrc_endpoint_do_cleanup_CT 
> ../src/router_core/core_link_endpoint.c:245
> 27: #4 0x55f47830cb0f in qdrc_endpoint_do_detach_CT 
> ../src/router_core/core_link_endpoint.c:220
> 27: #5 0x55f478301824 in qdr_link_inbound_detach_CT 
> ../src/router_core/connections.c:2033
> 27: #6 0x55f47838fec7 in router_core_thread 
> ../src/router_core/router_core_thread.c:236
> 27: #7 0x55f4782a2964 in _thread_init ../src/posix/threading.c:172
> 27: #8 0x7f1069458608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 27: 
> 27: previously allocated by thread T1 here:
> 27: #0 0x7f1069a17aa5 in posix_memalign 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x10eaa5)
> 27: #1 0x55f4781df9cd in qd_alloc ../src/alloc_pool.c:393
> 27: #2 0x55f478308de5 in new_qdrc_endpoint_t 
> ../src/router_core/core_link_endpoint.c:35
> 27: #3 0x55f478309d28 in qdrc_endpoint_create_link_CT 
> ../src/router_core/core_link_endpoint.c:74
> 27: #4 0x55f4783eed7d in on_conn_event 
> ../src/router_core/modules/heartbeat_edge/heartbeat_edge.c:178
> 27: #5 0x55f47830823d in qdrc_event_conn_raise 
> ../src/router_core/core_events.c:101
> 27: #6 0x55f4783c5a14 in on_conn_event 
> ../src/router_core/modules/edge_router/connection_manager.c:59
> 27: #7 0x55f47830823d in qdrc_event_conn_raise 
> ../src/router_core/core_events.c:101
> 27: #8 0x55f4782f5fdc in qdr_connection_opened_CT 
> ../src/router_core/connections.c:1479
> 27: #9 0x55f47838fec7 in router_core_thread 
> ../src/router_core/router_core_thread.c:236
> 27: #10 0x55f4782a2964 in _thread_init ../src/posix/threading.c:172
> 27: #11 0x7f1069458608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 27: 
> 27: Thread T1 created by T0 here:
> 27: #0 0x7f1069943805 in pthread_create 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x3a805)
> 27: #1 0x55f4782a2ad3 in sys_thread ../src/posix/threading.c:181
> 27: #2 0x55f47836b817 in qdr_core ../src/router_core/router_core.c:124
> 27: #3 0x55f478411c5c in qd_router_setup_late ../src/router_node.c:2127
> 27: #4 0x7f1064308ff4  (/lib/x86_64-linux-gnu/libffi.so.7+0x6ff4)
> 27: #5 0x7ffdaab8945f  ([stack]+0x2145f)
> 27: 
> 27: SUMMARY: AddressSanitizer: heap-use-after-free 
> ../src/router_core/core_link_endpoint.c:136 in qdrc_endpoint_delivery_CT
> 27: Shadow bytes around the buggy address:
> 27:   0x0c227fffa680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 27:   0x0c227fffa690: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 27:   0x0c227fffa6a0: fd fd fd fd fd fd fd fd fd fd fd fd

[jira] [Updated] (DISPATCH-2283) heap-use-after-free in system_tests_policy_oversize_compound during qdrc_endpoint_delivery_CT

2021-11-11 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2283:

Fix Version/s: 1.18.0

> heap-use-after-free in system_tests_policy_oversize_compound during 
> qdrc_endpoint_delivery_CT
> -
>
> Key: DISPATCH-2283
> URL: https://issues.apache.org/jira/browse/DISPATCH-2283
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> https://github.com/jiridanek/qpid-dispatch/runs/4140877666?check_suite_focus=true#step:9:35786
> This comes from the "set memory pool max size to 0" memory poisoning 
> investigation. I haven't seen this fail with unmodified main branch (yet ;) 
> The only somewhat similar stacktrace I could find in Jira is for this leak 
> DISPATCH-1699.
> {noformat}
> 27: ==12548==ERROR: AddressSanitizer: heap-use-after-free on address 
> 0x611136e0 at pc 0x55f47830adb9 bp 0x7f1063183140 sp 0x7f1063183130
> 27: READ of size 8 at 0x611136e0 thread T1
> 27: #0 0x55f47830adb8 in qdrc_endpoint_delivery_CT 
> ../src/router_core/core_link_endpoint.c:136
> 27: #1 0x55f4783eea3b in on_timer 
> ../src/router_core/modules/heartbeat_edge/heartbeat_edge.c:157
> 27: #2 0x55f4783c0613 in qdr_process_tick_CT 
> ../src/router_core/core_timer.c:123
> 27: #3 0x55f47838fec7 in router_core_thread 
> ../src/router_core/router_core_thread.c:236
> 27: #4 0x55f4782a2964 in _thread_init ../src/posix/threading.c:172
> 27: #5 0x7f1069458608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 27: #6 0x7f106864e292 in __clone 
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 27: 
> 27: 0x611136e0 is located 160 bytes inside of 192-byte region 
> [0x61113640,0x61113700)
> 27: freed by thread T1 here:
> 27: #0 0x7f1069a167cf in __interceptor_free 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x10d7cf)
> 27: #1 0x55f4781e3b84 in qd_dealloc ../src/alloc_pool.c:497
> 27: #2 0x55f478308e1d in free_qdrc_endpoint_t 
> ../src/router_core/core_link_endpoint.c:35
> 27: #3 0x55f47830d34f in qdrc_endpoint_do_cleanup_CT 
> ../src/router_core/core_link_endpoint.c:245
> 27: #4 0x55f47830cb0f in qdrc_endpoint_do_detach_CT 
> ../src/router_core/core_link_endpoint.c:220
> 27: #5 0x55f478301824 in qdr_link_inbound_detach_CT 
> ../src/router_core/connections.c:2033
> 27: #6 0x55f47838fec7 in router_core_thread 
> ../src/router_core/router_core_thread.c:236
> 27: #7 0x55f4782a2964 in _thread_init ../src/posix/threading.c:172
> 27: #8 0x7f1069458608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 27: 
> 27: previously allocated by thread T1 here:
> 27: #0 0x7f1069a17aa5 in posix_memalign 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x10eaa5)
> 27: #1 0x55f4781df9cd in qd_alloc ../src/alloc_pool.c:393
> 27: #2 0x55f478308de5 in new_qdrc_endpoint_t 
> ../src/router_core/core_link_endpoint.c:35
> 27: #3 0x55f478309d28 in qdrc_endpoint_create_link_CT 
> ../src/router_core/core_link_endpoint.c:74
> 27: #4 0x55f4783eed7d in on_conn_event 
> ../src/router_core/modules/heartbeat_edge/heartbeat_edge.c:178
> 27: #5 0x55f47830823d in qdrc_event_conn_raise 
> ../src/router_core/core_events.c:101
> 27: #6 0x55f4783c5a14 in on_conn_event 
> ../src/router_core/modules/edge_router/connection_manager.c:59
> 27: #7 0x55f47830823d in qdrc_event_conn_raise 
> ../src/router_core/core_events.c:101
> 27: #8 0x55f4782f5fdc in qdr_connection_opened_CT 
> ../src/router_core/connections.c:1479
> 27: #9 0x55f47838fec7 in router_core_thread 
> ../src/router_core/router_core_thread.c:236
> 27: #10 0x55f4782a2964 in _thread_init ../src/posix/threading.c:172
> 27: #11 0x7f1069458608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 27: 
> 27: Thread T1 created by T0 here:
> 27: #0 0x7f1069943805 in pthread_create 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x3a805)
> 27: #1 0x55f4782a2ad3 in sys_thread ../src/posix/threading.c:181
> 27: #2 0x55f47836b817 in qdr_core ../src/router_core/router_core.c:124
> 27: #3 0x55f478411c5c in qd_router_setup_late ../src/router_node.c:2127
> 27: #4 0x7f1064308ff4  (/lib/x86_64-linux-gnu/libffi.so.7+0x6ff4)
> 27: #5 0x7ffdaab8945f  ([stack]+0x2145f)
> 27: 
> 27: SUMMARY: AddressSanitizer: heap-use-after-free 
> ../src/router_core/core_link_endpoint.c:136 in qdrc_endpoint_delivery_CT
> 27: Shadow bytes around the buggy address:
> 27:   0x0c227fffa680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 27:   0x0c227fffa690: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 27:   0x0c227fffa6a0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> 27:   0x0c227fffa6b0:

[jira] [Commented] (DISPATCH-2206) ASAN use-after-free of qdr_link_t by I/O thread

2021-11-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442312#comment-17442312
 ] 

ASF GitHub Bot commented on DISPATCH-2206:
--

ganeshmurthy closed pull request #1432:
URL: https://github.com/apache/qpid-dispatch/pull/1432


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ASAN use-after-free of qdr_link_t by I/O thread
> ---
>
> Key: DISPATCH-2206
> URL: https://issues.apache.org/jira/browse/DISPATCH-2206
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.1
>Reporter: Ken Giusti
>Priority: Major
>  Labels: asan
> Fix For: 1.19.0
>
>
> [https://github.com/apache/qpid-dispatch/blob/main/src/router_core/connections.c#L1344]
>  
> {{27: ==3859==ERROR: AddressSanitizer: use-after-poison on address 
> 0x61700017e030 at pc 0x56212343cdac bp 0x7f9d33c40c90 sp 0x7f9d33c40c80 }}
> {{ }}{{}}
> 27: READ of size 8 at 0x61700017e030 thread T2 
> {{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{ }}{{}}
> 27:  #0 0x56212343cdab in qdr_link_get_context 
> ../src/router_core/connections.c:498 
> {{}}{{ }}{{}}
> 27:  #1 0x56212352ec25 in CORE_link_second_attach ../src/router_node.c:1729 
> {{}}{{ }}{{}}
> 27:  #2 0x5621234388df in qdr_connection_process 
> ../src/router_core/connections.c:355 
> {{}}{{ }}{{}}
> 27:  #3 0x56212338eccf in writable_handler ../src/container.c:396 
> {{}}{{ }}{{}}
> 27:  #4 0x56212338eccf in qd_container_handle_event ../src/container.c:748 
> {{}}{{ }}{{}}
> 27:  #5 0x562123547289 in handle ../src/server.c:1108 
> {{}}{{ }}{{}}
> 27:  #6 0x562123554c9f in thread_run ../src/server.c:1133 
> {{}}{{ }}{{}}
> 27:  #7 0x7f9d3ba6c608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608) 
> {{}}{{ }}{{}}
> 27:  #8 0x7f9d3ac33292 in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x122292) 
> {{}}{{ }}{{}}
> 27:  
> {{}}{{ }}{{}}
> 27: 0x61700017e030 is located 176 bytes inside of 704-byte region 
> [0x61700017df80,0x61700017e240) 
> {{}}{{ }}{{}}
> 27: allocated by thread T2 here: 
> {{}}{{ }}{{}}
> 27:  #0 0x7f9d3bfd9aa5 in posix_memalign 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x10eaa5) 
> {{}}{{ }}{{}}
> 27:  #1 0x5621233247b0 in qd_alloc ../src/alloc_pool.c:396 
> {{}}{{ }}{{}}
> 27:  #2 0x56212343d4c9 in qdr_link_first_attach 
> ../src/router_core/connections.c:592 
> {{}}{{ }}{{}}
> 27:  #3 0x56212352dde9 in AMQP_outgoing_link_handler 
> ../src/router_node.c:1018 
> {{}}{{ }}{{}}
> 27:  #4 0x562123547289 in handle ../src/server.c:1108 
> {{}}{{ }}{{}}
> 27:  #5 0x562123554c9f in thread_run ../src/server.c:1133 
> {{}}{{ }}{{}}
> 27:  #6 0x7f9d3ba6c608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608) 
> {{}}{{ }}{{}}
> 27:  
> {{}}{{ }}{{}}
> 27: Thread T2 created by T0 here: 
> {{}}{{ }}{{}}
> 27:  #0 0x7f9d3bf05805 in pthread_create 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x3a805) 
> {{}}{{ }}{{}}
> 27:  #1 0x562123403bcf in sys_thread ../src/posix/threading.c:181 
> {{}}{{ }}{{}}
> 27:  #2 0x56212355541e in qd_server_run ../src/server.c:1522 
> {{}}{{ }}{{}}
> 27:  #3 0x56212359f46c in main_process ../router/src/main.c:115 
> {{}}{{ }}{{}}
> 27:  #4 0x56212329bc50 in main ../router/src/main.c:369 
> {{}}{{ }}{{}}
> 27:  #5 0x7f9d3ab380b2 in __libc_start_main 
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2) 
> {{}}{{ }}{{}}
> 27:  
> {{}}{{ }}{{}}
> 27: SUMMARY: AddressSanitizer: use-after-poison 
> ../src/router_core/connections.c:498 in qdr_link_get_context 
> {{}}{{ }}{{}}
> 27: Shadow bytes around the buggy address: 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bb0: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bc0: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bd0: f7 f7 f7 f7 f7 f7 f7 00 fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027be0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
> {{}}{{ }}{{}}
> 27: =>0x0c2e80027c00: 00 00 f7 f7 f7 f7[f7]f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c10: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c20: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c40: f7 f7 f7 f7 f7 f7 f7 00 fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 
> {{}}{

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1432: DISPATCH-2206: Remove second attach related work on the connection if…

2021-11-11 Thread GitBox


ganeshmurthy closed pull request #1432:
URL: https://github.com/apache/qpid-dispatch/pull/1432


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-2036) TCP adaptor deliveries reported as "stuck" by delayed delivery detection

2021-11-11 Thread Ken Giusti (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti reassigned DISPATCH-2036:


Assignee: Ken Giusti  (was: Charles E. Rolke)

> TCP adaptor deliveries reported as "stuck" by delayed delivery detection
> 
>
> Key: DISPATCH-2036
> URL: https://issues.apache.org/jira/browse/DISPATCH-2036
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> Since TCP adaptor uses long lived deliveries the delayed delivery detection 
> logic flags these deliveries as stuck.  This occurs on each intermediate 
> router as well.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-2094) System tests can freeze, observed especially on AArch64 or s390x

2021-11-11 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2094:

Fix Version/s: 1.19.0
   (was: 1.18.0)

> System tests can freeze, observed especially on AArch64 or s390x
> 
>
> Key: DISPATCH-2094
> URL: https://issues.apache.org/jira/browse/DISPATCH-2094
> Project: Qpid Dispatch
>  Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Minor
> Fix For: 1.19.0
>
>
> Sometimes the system tests freeze. This is especially frequent on AArch64. It 
> is possible this is caused by architecture-specific behavior regarding 
> threading. AMD64 is strongly memory consistent, while AArch64 is not. Maybe 
> some undefined behavior on AArch64 causes the races to be more serious than 
> elsewhere.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/502066462#L9193
> {noformat}
> 64: test_05_no_settlement_same_interior 
> (system_tests_stuck_deliveries.RouterTest) ... ok
> {noformat}
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/502066461#L7611
> {noformat}
> 70: test_01_concurrent_requests 
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates

2021-11-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442176#comment-17442176
 ] 

ASF GitHub Bot commented on PROTON-2396:


jiridanek commented on a change in pull request #340:
URL: https://github.com/apache/qpid-proton/pull/340#discussion_r747314538



##
File path: cpp/include/proton/uuid.hpp
##
@@ -35,13 +38,20 @@ namespace proton {
 
 /// A 16-byte universally unique identifier.
 class uuid : public byte_array<16> {
+
+  private:
+thread_local static std::independent_bits_engine [cpp] Seed in uuid.cpp can lead to duplicates
> -
>
> Key: PROTON-2396
> URL: https://issues.apache.org/jira/browse/PROTON-2396
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
> Environment: RHEL7 running in OpenStack
> docker-ce 19.03.5
> qpid-proton 0.28.0
> qpid-cpp 1.37.0
>Reporter: Ryan Herbert
>Assignee: Rakhi Kumari
>Priority: Major
>
> The random number seed used in qpid-proton/cpp/src/uuid.cpp is based on the 
> current time and the PID of the running process.  When starting multiple 
> proton instances simultaneously in Docker containers via automated 
> deployment, there is a high probability that multiple instances will get the 
> same seed since the PID within the Docker container is consistent and the 
> same across multiple copies of the same Docker container.
> This results in duplicate link names when binding to exchanges. When this 
> happens, the queue gets bound to two different exchanges, and requests sent 
> to one exchange will get responses from both services.
> To work around this error, we are specifying the link name via 
> sender_options/receiver_options every time we open a new sender/receiver, and 
> we also specify the container_id in connection_options.  We are using 
> std::mt19937_64 seeded with 
> std::chrono::system_clock::now().time_since_epoch().count() to generate the 
> random part of our link names, which seems to have enough randomness that it 
> has eliminated the problem for us.
> As pointed out in the Proton user forum, std::random_device is probably a 
> better choice for initializing the seed.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] jiridanek commented on a change in pull request #340: PROTON-2396: [WIP] Use random_device for seed initialization in uuid.cpp

2021-11-11 Thread GitBox


jiridanek commented on a change in pull request #340:
URL: https://github.com/apache/qpid-proton/pull/340#discussion_r747314538



##
File path: cpp/include/proton/uuid.hpp
##
@@ -35,13 +38,20 @@ namespace proton {
 
 /// A 16-byte universally unique identifier.
 class uuid : public byte_array<16> {
+
+  private:
+thread_local static std::independent_bits_engine