[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450784#comment-17450784 ] ASF GitHub Bot commented on PROTON-2396: astitcher commented on pull request #340: URL: https://github.com/apache/qpid-proton/pull/340#issuecomment-982155262 Commited with a minor change to simplify the initialization/use of the the random generator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] Seed in uuid.cpp can lead to duplicates > - > > Key: PROTON-2396 > URL: https://issues.apache.org/jira/browse/PROTON-2396 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding > Environment: RHEL7 running in OpenStack > docker-ce 19.03.5 > qpid-proton 0.28.0 > qpid-cpp 1.37.0 >Reporter: Ryan Herbert >Assignee: Rakhi Kumari >Priority: Major > > The random number seed used in qpid-proton/cpp/src/uuid.cpp is based on the > current time and the PID of the running process. When starting multiple > proton instances simultaneously in Docker containers via automated > deployment, there is a high probability that multiple instances will get the > same seed since the PID within the Docker container is consistent and the > same across multiple copies of the same Docker container. > This results in duplicate link names when binding to exchanges. When this > happens, the queue gets bound to two different exchanges, and requests sent > to one exchange will get responses from both services. > To work around this error, we are specifying the link name via > sender_options/receiver_options every time we open a new sender/receiver, and > we also specify the container_id in connection_options. We are using > std::mt19937_64 seeded with > std::chrono::system_clock::now().time_since_epoch().count() to generate the > random part of our link names, which seems to have enough randomness that it > has eliminated the problem for us. > As pointed out in the Proton user forum, std::random_device is probably a > better choice for initializing the seed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp
astitcher commented on pull request #340: URL: https://github.com/apache/qpid-proton/pull/340#issuecomment-982155262 Commited with a minor change to simplify the initialization/use of the the random generator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450783#comment-17450783 ] ASF GitHub Bot commented on PROTON-2396: asfgit closed pull request #340: URL: https://github.com/apache/qpid-proton/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] Seed in uuid.cpp can lead to duplicates > - > > Key: PROTON-2396 > URL: https://issues.apache.org/jira/browse/PROTON-2396 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding > Environment: RHEL7 running in OpenStack > docker-ce 19.03.5 > qpid-proton 0.28.0 > qpid-cpp 1.37.0 >Reporter: Ryan Herbert >Assignee: Rakhi Kumari >Priority: Major > > The random number seed used in qpid-proton/cpp/src/uuid.cpp is based on the > current time and the PID of the running process. When starting multiple > proton instances simultaneously in Docker containers via automated > deployment, there is a high probability that multiple instances will get the > same seed since the PID within the Docker container is consistent and the > same across multiple copies of the same Docker container. > This results in duplicate link names when binding to exchanges. When this > happens, the queue gets bound to two different exchanges, and requests sent > to one exchange will get responses from both services. > To work around this error, we are specifying the link name via > sender_options/receiver_options every time we open a new sender/receiver, and > we also specify the container_id in connection_options. We are using > std::mt19937_64 seeded with > std::chrono::system_clock::now().time_since_epoch().count() to generate the > random part of our link names, which seems to have enough randomness that it > has eliminated the problem for us. > As pointed out in the Proton user forum, std::random_device is probably a > better choice for initializing the seed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450782#comment-17450782 ] ASF subversion and git services commented on PROTON-2396: - Commit a58e66ce3e42937a1b22e0c741834bc6eb0a9797 in qpid-proton's branch refs/heads/main from Rakhi Kumari [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=a58e66c ] PROTON-2396: Use random_device for seed initialization in uuid.cpp Closes #340 > [cpp] Seed in uuid.cpp can lead to duplicates > - > > Key: PROTON-2396 > URL: https://issues.apache.org/jira/browse/PROTON-2396 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding > Environment: RHEL7 running in OpenStack > docker-ce 19.03.5 > qpid-proton 0.28.0 > qpid-cpp 1.37.0 >Reporter: Ryan Herbert >Assignee: Rakhi Kumari >Priority: Major > > The random number seed used in qpid-proton/cpp/src/uuid.cpp is based on the > current time and the PID of the running process. When starting multiple > proton instances simultaneously in Docker containers via automated > deployment, there is a high probability that multiple instances will get the > same seed since the PID within the Docker container is consistent and the > same across multiple copies of the same Docker container. > This results in duplicate link names when binding to exchanges. When this > happens, the queue gets bound to two different exchanges, and requests sent > to one exchange will get responses from both services. > To work around this error, we are specifying the link name via > sender_options/receiver_options every time we open a new sender/receiver, and > we also specify the container_id in connection_options. We are using > std::mt19937_64 seeded with > std::chrono::system_clock::now().time_since_epoch().count() to generate the > random part of our link names, which seems to have enough randomness that it > has eliminated the problem for us. > As pointed out in the Proton user forum, std::random_device is probably a > better choice for initializing the seed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] asfgit closed pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp
asfgit closed pull request #340: URL: https://github.com/apache/qpid-proton/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1450: Bump actions/cache from 2.1.6 to 2.1.7
codecov-commenter commented on pull request #1450: URL: https://github.com/apache/qpid-dispatch/pull/1450#issuecomment-982133868 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1450](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b33699) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/906b9314fc5e1d4f3286cc7de81a97cd18c56198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (906b931) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1450 +/- ## == + Coverage 84.75% 84.78% +0.03% == Files 116 116 Lines 2862028620 == + Hits2425624265 +9 + Misses 4364 4355 -9 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (-0.28%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.90% <0.00%> (-0.19%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.35% <0.00%> (-0.14%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0.00%> (+0.19%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.40% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.11% <0.00%> (+0.95%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [906b931...2b33699](https://codecov.io/gh/apache/qpid-dispatch/pull/1450?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read t
[jira] [Commented] (PROTON-2471) Run raw connection examples during proton-c examples test
[ https://issues.apache.org/jira/browse/PROTON-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450578#comment-17450578 ] ASF GitHub Bot commented on PROTON-2471: jiridanek commented on a change in pull request #345: URL: https://github.com/apache/qpid-proton/pull/345#discussion_r758534117 ## File path: c/examples/testme ## @@ -107,5 +112,41 @@ class ExampleTest(unittest.TestCase): else: raise +def test_raw_connect(self): +message = b"At thee! Have at thee!\n" + +with Server(["raw_echo", "", "0"], kill_me=True) as server: +client = subprocess.Popen(args=["raw_connect", "", server.port], + stdin=subprocess.PIPE, stdout=subprocess.PIPE) +client.stdin.write(message) +client.stdin.flush() +stdout, _ = client.communicate() + +expected_brief = b'**raw connection connected\n' + message + b'**raw connection disconnected\n' +expected_polite = b'**raw connection connected\n' + message + b'** Goodbye raw connection disconnected\n' + +expected = expected_polite if b'Goodbye' in stdout else expected_brief Review comment: I'm at a loss how to get deterministic output from the example. Sometimes it manages to receive and print that Goodbye, but oftentimes not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run raw connection examples during proton-c examples test > - > > Key: PROTON-2471 > URL: https://issues.apache.org/jira/browse/PROTON-2471 > Project: Qpid Proton > Issue Type: Test > Components: examples, proton-c >Affects Versions: proton-c-0.36.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #345: PROTON-2471 Run raw connection examples during proton-c examples test
jiridanek commented on a change in pull request #345: URL: https://github.com/apache/qpid-proton/pull/345#discussion_r758534117 ## File path: c/examples/testme ## @@ -107,5 +112,41 @@ class ExampleTest(unittest.TestCase): else: raise +def test_raw_connect(self): +message = b"At thee! Have at thee!\n" + +with Server(["raw_echo", "", "0"], kill_me=True) as server: +client = subprocess.Popen(args=["raw_connect", "", server.port], + stdin=subprocess.PIPE, stdout=subprocess.PIPE) +client.stdin.write(message) +client.stdin.flush() +stdout, _ = client.communicate() + +expected_brief = b'**raw connection connected\n' + message + b'**raw connection disconnected\n' +expected_polite = b'**raw connection connected\n' + message + b'** Goodbye raw connection disconnected\n' + +expected = expected_polite if b'Goodbye' in stdout else expected_brief Review comment: I'm at a loss how to get deterministic output from the example. Sometimes it manages to receive and print that Goodbye, but oftentimes not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2471) Run raw connection examples during proton-c examples test
Jiri Daněk created PROTON-2471: -- Summary: Run raw connection examples during proton-c examples test Key: PROTON-2471 URL: https://issues.apache.org/jira/browse/PROTON-2471 Project: Qpid Proton Issue Type: Test Components: examples, proton-c Affects Versions: proton-c-0.36.0 Reporter: Jiri Daněk Assignee: Jiri Daněk Fix For: proton-c-0.37.0 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2294) Enable TCP listeners and connectors to use TLS
[ https://issues.apache.org/jira/browse/DISPATCH-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2294: Component/s: Protocol Adaptors > Enable TCP listeners and connectors to use TLS > -- > > Key: DISPATCH-2294 > URL: https://issues.apache.org/jira/browse/DISPATCH-2294 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Priority: Major > > Qpid-Proton is developing a TLS library that works with raw connections. > Enable TCP adaptor's listeners and connectors to be configured with an > SSLProfile which will use proton's new raw connection TLS library to provide > encryption/decryption capabilities. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2294) Enable TCP listeners and connectors to use TLS
[ https://issues.apache.org/jira/browse/DISPATCH-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2294: Fix Version/s: 1.19.0 > Enable TCP listeners and connectors to use TLS > -- > > Key: DISPATCH-2294 > URL: https://issues.apache.org/jira/browse/DISPATCH-2294 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Priority: Major > Fix For: 1.19.0 > > > Qpid-Proton is developing a TLS library that works with raw connections. > Enable TCP adaptor's listeners and connectors to be configured with an > SSLProfile which will use proton's new raw connection TLS library to provide > encryption/decryption capabilities. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2294) Enable TCP listeners and connectors to use TLS
Ganesh Murthy created DISPATCH-2294: --- Summary: Enable TCP listeners and connectors to use TLS Key: DISPATCH-2294 URL: https://issues.apache.org/jira/browse/DISPATCH-2294 Project: Qpid Dispatch Issue Type: New Feature Reporter: Ganesh Murthy Qpid-Proton is developing a TLS library that works with raw connections. Enable TCP adaptor's listeners and connectors to be configured with an SSLProfile which will use proton's new raw connection TLS library to provide encryption/decryption capabilities. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2470) [cpp] Access to the local host and port for a connection
Rakhi Kumari created PROTON-2470: Summary: [cpp] Access to the local host and port for a connection Key: PROTON-2470 URL: https://issues.apache.org/jira/browse/PROTON-2470 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding Reporter: Rakhi Kumari Assignee: Rakhi Kumari -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
