[jira] [Commented] (PROTON-2112) segfault in epoll proactor shudown
[ https://issues.apache.org/jira/browse/PROTON-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479048#comment-17479048 ] ASF subversion and git services commented on PROTON-2112: - Commit 4eda877fdca73e38633a201103e57fc1d8525832 in qpid-proton's branch refs/heads/main from Clifford Jansen [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=4eda877 ] PROTON-2112: prevent fd overflow recovery during proactror shutdown > segfault in epoll proactor shudown > -- > > Key: PROTON-2112 > URL: https://issues.apache.org/jira/browse/PROTON-2112 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.29.0 > Environment: Linux >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > Attachments: bt.txt > > > If an epoll proactor is dealing with file descriptor resource starvation at > the time of shutdown, it can try to initiate new IO in conflict with other > shutting down activity. Specifically, when freeing a connection's socket, it > tries to resume any pause listeners. > I suspect there is a missing check somewhere to see if > proactor->shutting_down is set before attempting the resume. But it may > require a more thorough dismantling of the overflow listener list before > commencing to tear down straggling connections. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2255) Investigate enable_mask for removal of malloc
[ https://issues.apache.org/jira/browse/DISPATCH-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2255: Fix Version/s: Backlog > Investigate enable_mask for removal of malloc > - > > Key: DISPATCH-2255 > URL: https://issues.apache.org/jira/browse/DISPATCH-2255 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: Backlog > > > Find out how often enable_mask() is called in log.c > See if it would be practical to remove the malloc() and free() in it. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2256) edge router fallback links and addresses incorrect on interior failover
[ https://issues.apache.org/jira/browse/DISPATCH-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2256: Fix Version/s: Backlog (was: 1.19.0) > edge router fallback links and addresses incorrect on interior failover > --- > > Key: DISPATCH-2256 > URL: https://issues.apache.org/jira/browse/DISPATCH-2256 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.17.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: Backlog > > > Scenario: > Configure an edge router with two separate interior connectors - one for > router A and a standby for router B. > Configure a route-container listener for a broker on the edge router. Assign > two fallback destination autolinks (1 in, 1 out) to the route container for > address "foo". > Start just the edge router: > * no links are active (expected). > * mgmt query for addresses show two "foo" addresses present: > ** MFfoo - the fallback address (no subscribers) > ** M0foo - the primary address (no subscribers) > Now startup the broker and after the connection to the broker: > * On the edge router: > ** links: > *** id 5, out link to broker, owning address MFfoo > *** id 6, in link from broker, owning address M0foo > ** addresses: > *** MFfoo - one local subscriber > *** M0foo - no subscribers > Now start router A. Router A has been configured with an edge listener > connection. There is no inter-router connection configured for router B! > Once the connection is established: > * On the edge router: > ** links: > *** the two broker links (see above) > *** id 10, in link from router A, owning address MFfoo > *** id 11, out link to router A for M0foo > ** addresses: > *** MFfoo - one local subscriber > *** M0foo - no subscribers > * On Router A: > ** links: > *** id 6, out link to edge, owning address MFfoo > *** id 7, in link from edge, owning address M0foo > ** addresses: > *** MFfoo - one local subscriber > *** M0foo - no subscribers > Now start router B, wait for the edge to establish a connection to it. Since > B is a standby interior for the edge there are no 'foo' related links or > addresses on B as expected. Remember router A and B are not directly > connected. > > Fail router A. Wait for the edge to re-establish its proxy links to router > B. The following links/addresses related to foo are now: > * On the edge router: > ** links: > *** the two broker links > *** id 20, in link from router B, owning address MFfoo > ** addresses: > *** MFfoo - one local subscriber > *** M0foo - no subscribers > * On Router B: > ** links: > *** id 6, out link to edge, owning address MFfoo > ** addresses: > *** MFfoo - one local subscriber > From the above we can see that after the failover to router B the edge router > does not re-establish an outgoing link (subscription) for M0foo as it did > when connected to router A. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2292) [http2] system_tests_grpc failed with qd_http2_buffer_t leak
[
https://issues.apache.org/jira/browse/DISPATCH-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2292.
-
Fix Version/s: 1.19.0
Resolution: Cannot Reproduce
> [http2] system_tests_grpc failed with qd_http2_buffer_t leak
>
>
> Key: DISPATCH-2292
> URL: https://issues.apache.org/jira/browse/DISPATCH-2292
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/549003884#L10696
> {noformat}
> 70: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qd_http2_buffer_t'
> {noformat}
> {noformat}
> 70: alloc.c: Items of type 'qd_http2_buffer_t' remain allocated at shutdown: 1
> 70: Leak: 2021-11-20 21:14:56.179730 + type: qd_http2_buffer_t address:
> 0x629000163290
> 70: qdrouterd(backtrace+0x5b) [0x47884b]
> 70: qdrouterd(qd_alloc+0x918) [0x572738]
> 70: qdrouterd(qd_http2_buffer+0x24) [0x786874]
> 70: qdrouterd(qd_http2_buffer_list_append+0x81) [0x786a71]
> 70: qdrouterd() [0x7b9b21]
> 70: /lib/x86_64-linux-gnu/libnghttp2.so.14(nghttp2_session_send+0x49)
> [0x7f5f3a894c89]
> 70: qdrouterd() [0x7aa9f0]
> 70: qdrouterd() [0x791536]
> 70: qdrouterd() [0x777830]
> 70: qdrouterd() [0x771dd0]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2293) Review use of qd_parse()
[ https://issues.apache.org/jira/browse/DISPATCH-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2293: Fix Version/s: Backlog (was: 1.19.0) > Review use of qd_parse() > > > Key: DISPATCH-2293 > URL: https://issues.apache.org/jira/browse/DISPATCH-2293 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: Backlog > > > Review the use of qd_parse() to ensure callers _always_ verify the return > value before using it. > qd_parse() is used to parse amqp messages. Since these messages are coming > from an external entity all callers must check that there were no parse > errors. > > Use qd_parse_ok(return_value) to verify the return value. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2303) system_tests_http1_over_tcp Http1OverTcpEdge2EdgeTest::test_05_large_streaming_msg failure: invalid literal for int() with base 16: b''
[
https://issues.apache.org/jira/browse/DISPATCH-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2303.
-
Fix Version/s: 1.19.0
Resolution: Cannot Reproduce
> system_tests_http1_over_tcp
> Http1OverTcpEdge2EdgeTest::test_05_large_streaming_msg failure: invalid
> literal for int() with base 16: b''
> ---
>
> Key: DISPATCH-2303
> URL: https://issues.apache.org/jira/browse/DISPATCH-2303
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 1.19.0
>
>
> https://github.com/apache/qpid-dispatch/runs/4703076932?check_suite_focus=true#step:27:5543
> {noformat}
> 71: ::Http1OverTcpEdge2EdgeTest::test_05_large_streaming_msg Exception in
> thread Thread-26 (_run):
> 71: Traceback (most recent call last):
> 71: File "/usr/lib64/python3.10/threading.py", line 1009, in
> _bootstrap_inner
> 71: self.run()
> 71: File "/usr/lib64/python3.10/threading.py", line 946, in run
> 71: self._target(*self._args, **self._kwargs)
> 71: File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py",
> line 184, in _run
> 71: rsp = client.getresponse()
> 71: File "/usr/lib64/python3.10/http/client.py", line 1374, in getresponse
> 71: response.begin()
> 71: File "/usr/lib64/python3.10/http/client.py", line 318, in begin
> 71: version, status, reason = self._read_status()
> 71: File "/usr/lib64/python3.10/http/client.py", line 279, in _read_status
> 71: line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
> 71: File "/usr/lib64/python3.10/socket.py", line 705, in readinto
> 71: return self._sock.recv_into(b)
> 71: TimeoutError: timed out
> 71: FAILED
> 71: Exception occurred during processing of request from ('127.0.0.1', 34566)
> 71: Traceback (most recent call last):
> 71: File "/usr/lib64/python3.10/socketserver.py", line 316, in
> _handle_request_noblock
> 71: self.process_request(request, client_address)
> 71: File "/usr/lib64/python3.10/socketserver.py", line 347, in
> process_request
> 71: self.finish_request(request, client_address)
> 71: File "/usr/lib64/python3.10/socketserver.py", line 360, in
> finish_request
> 71: self.RequestHandlerClass(request, client_address, self)
> 71: File "/usr/lib64/python3.10/socketserver.py", line 747, in __init__
> 71: self.handle()
> 71: File "/usr/lib64/python3.10/http/server.py", line 429, in handle
> 71: self.handle_one_request()
> 71: File "/usr/lib64/python3.10/http/server.py", line 415, in
> handle_one_request
> 71: method()
> 71: File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py",
> line 86, in do_PUT
> 71: self._execute_request(self.server.system_tests["PUT"])
> 71: File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py",
> line 58, in _execute_request
> 71: self._consume_body()
> 71: File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py",
> line 113, in _consume_body
> 71: hlen = int(header, base=16)
> 71: ValueError: invalid literal for int() with base 16: b''
> 71:
> {noformat}
> {noformat}
> 71: === FAILURES
> ===
> 71: Http1OverTcpEdge2EdgeTest.test_05_large_streaming_msg
> _
> 71:
> 71: self = testMethod=test_05_large_streaming_msg>
> 71:
> 71: def test_05_large_streaming_msg(self):
> 71: """
> 71: Verify large streaming message transfer
> 71: """
> 71: TESTS_11 = {
> 71: "PUT": [
> 71: (RequestMsg("PUT", "/PUT/streaming_test_11",
> 71: headers={
> 71: "Transfer-encoding": "chunked",
> 71: "Content-Type": "text/plain;charset=utf-8"
> 71: },
> 71: # 4 chunks each ~= 600K
> 71: body=b'927C1\r\n' + b'0' * 0x927C0 + b'X\r\n'
> 71: + b'927C0\r\n' + b'1' * 0x927C0 + b'\r\n'
> 71: + b'927C1\r\n' + b'2' * 0x927C0 + b'X\r\n'
> 71: + b'927C0\r\n' + b'3' * 0x927C0 + b'\r\n'
> 71: + b'0\r\n\r\n'),
> 71:
> 71: ResponseMsg(201, reason="Created",
> 71: headers={"Response-Header": "data",
> 71:
[jira] [Updated] (DISPATCH-2293) Review use of qd_parse()
[ https://issues.apache.org/jira/browse/DISPATCH-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2293: - Fix Version/s: 1.19.0 > Review use of qd_parse() > > > Key: DISPATCH-2293 > URL: https://issues.apache.org/jira/browse/DISPATCH-2293 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Review the use of qd_parse() to ensure callers _always_ verify the return > value before using it. > qd_parse() is used to parse amqp messages. Since these messages are coming > from an external entity all callers must check that there were no parse > errors. > > Use qd_parse_ok(return_value) to verify the return value. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2293) Review use of qd_parse()
[ https://issues.apache.org/jira/browse/DISPATCH-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2293: Assignee: Ken Giusti > Review use of qd_parse() > > > Key: DISPATCH-2293 > URL: https://issues.apache.org/jira/browse/DISPATCH-2293 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Review the use of qd_parse() to ensure callers _always_ verify the return > value before using it. > qd_parse() is used to parse amqp messages. Since these messages are coming > from an external entity all callers must check that there were no parse > errors. > > Use qd_parse_ok(return_value) to verify the return value. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2302) Segfault in core_client_api.c on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2302: - Fix Version/s: 1.19.0 > Segfault in core_client_api.c on shutdown > - > > Key: DISPATCH-2302 > URL: https://issues.apache.org/jira/browse/DISPATCH-2302 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > Attachments: NEW_BUG.txt > > > Hard to reproduce - I hit this only due to a buggy patch I was working on but > seems legit: > During shutdown qdr_core_free() cleans up any outstanding endpoint clients. > This results in any outstanding core client RPC calls to be cancelled by > invoking the "free request" logic which invokes the "request done" client > handler with the error parameter set to "link detach". > In the case of the edge router client address lookup module, the error is > ignored and the client assumes the request was successful. At this point it > attempts to process the request which results in a segfault. > We need to audit all the core client "request done" callbacks to make sure > the error flag is being checked and properly handled. > See backtrace in attachment > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2308) temporary address generation infinite loop if router id > 200 characters
[ https://issues.apache.org/jira/browse/DISPATCH-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2308: - Fix Version/s: 1.19.0 > temporary address generation infinite loop if router id > 200 characters > > > Key: DISPATCH-2308 > URL: https://issues.apache.org/jira/browse/DISPATCH-2308 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > For your consideration... a router with and id > 200 characters: > https://github.com/kgiusti/dispatch/blob/main/src/router_core/modules/address_lookup_client/address_lookup_client.c#L194 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2310: - Fix Version/s: 1.19.0 > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2309) Message body validation can succeed without validating the actual message body
[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2309: - Fix Version/s: 1.19.0 > Message body validation can succeed without validating the actual message body > -- > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2302) Segfault in core_client_api.c on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2302: Assignee: Ken Giusti > Segfault in core_client_api.c on shutdown > - > > Key: DISPATCH-2302 > URL: https://issues.apache.org/jira/browse/DISPATCH-2302 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Attachments: NEW_BUG.txt > > > Hard to reproduce - I hit this only due to a buggy patch I was working on but > seems legit: > During shutdown qdr_core_free() cleans up any outstanding endpoint clients. > This results in any outstanding core client RPC calls to be cancelled by > invoking the "free request" logic which invokes the "request done" client > handler with the error parameter set to "link detach". > In the case of the edge router client address lookup module, the error is > ignored and the client assumes the request was successful. At this point it > attempts to process the request which results in a segfault. > We need to audit all the core client "request done" callbacks to make sure > the error flag is being checked and properly handled. > See backtrace in attachment > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2309) Message body validation can succeed without validating the actual message body
[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2309: Assignee: Ken Giusti > Message body validation can succeed without validating the actual message body > -- > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2308) temporary address generation infinite loop if router id > 200 characters
[ https://issues.apache.org/jira/browse/DISPATCH-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2308: Assignee: Ken Giusti > temporary address generation infinite loop if router id > 200 characters > > > Key: DISPATCH-2308 > URL: https://issues.apache.org/jira/browse/DISPATCH-2308 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > For your consideration... a router with and id > 200 characters: > https://github.com/kgiusti/dispatch/blob/main/src/router_core/modules/address_lookup_client/address_lookup_client.c#L194 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1450: Bump actions/cache from 2.1.6 to 2.1.7
dependabot[bot] commented on pull request #1450: URL: https://github.com/apache/qpid-dispatch/pull/1450#issuecomment-1016865252 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2267) Add a core-thread facility to allow IO modules to subscribe to address-reachability data
[ https://issues.apache.org/jira/browse/DISPATCH-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478985#comment-17478985 ] ASF GitHub Bot commented on DISPATCH-2267: -- ganeshmurthy closed pull request #1435: URL: https://github.com/apache/qpid-dispatch/pull/1435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a core-thread facility to allow IO modules to subscribe to > address-reachability data > > > Key: DISPATCH-2267 > URL: https://issues.apache.org/jira/browse/DISPATCH-2267 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.19.0 > > > Add a facility to the Core Thread that allows an IO-thread module to register > for updates about a particular address. Callbacks into the IO-thread (on an > IO thread) shall inform the module about changes to the reachability of an > address. > This can be used by a protocol listener to open or close the listening socket > for a protocol listener based on the availability of remote connectors. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1450: Bump actions/cache from 2.1.6 to 2.1.7
ganeshmurthy closed pull request #1450: URL: https://github.com/apache/qpid-dispatch/pull/1450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1435: DISPATCH-2267 - IO-thread facility to watch for changes to address reachability
ganeshmurthy closed pull request #1435: URL: https://github.com/apache/qpid-dispatch/pull/1435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2288) Network-centric logging facility for protocol adaptors
[ https://issues.apache.org/jira/browse/DISPATCH-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478984#comment-17478984 ] ASF GitHub Bot commented on DISPATCH-2288: -- ganeshmurthy closed pull request #1448: URL: https://github.com/apache/qpid-dispatch/pull/1448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Network-centric logging facility for protocol adaptors > -- > > Key: DISPATCH-2288 > URL: https://issues.apache.org/jira/browse/DISPATCH-2288 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Protocol Adaptors >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.19.0 > > > A separate logging/tracing facility is needed for the protocol adaptors to > serve users that are more accustomed to network/firewall/router logs and are > not concerned with AMQP/messaging/link-protocol details. > This feature will make the use of the protocol adaptors more observable and > debuggable to network-familiar developers and operators. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1386) qdr_action_list_t could be replaced by an array of struct q
[ https://issues.apache.org/jira/browse/DISPATCH-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478983#comment-17478983 ] ASF GitHub Bot commented on DISPATCH-1386: -- ganeshmurthy closed pull request #537: URL: https://github.com/apache/qpid-dispatch/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdr_action_list_t could be replaced by an array of struct q > --- > > Key: DISPATCH-1386 > URL: https://issues.apache.org/jira/browse/DISPATCH-1386 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Routing Engine >Reporter: Francesco Nigro >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1448: DISPATCH-2288 - Flow Logging for Protocol Adaptors
ganeshmurthy closed pull request #1448: URL: https://github.com/apache/qpid-dispatch/pull/1448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #537: DISPATCH-1386 qdr_action_list_t could be replaced by an array of struct q
ganeshmurthy closed pull request #537: URL: https://github.com/apache/qpid-dispatch/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1344) Relaxing C11 sys_atomic_init and get
[ https://issues.apache.org/jira/browse/DISPATCH-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478982#comment-17478982 ] ASF GitHub Bot commented on DISPATCH-1344: -- ganeshmurthy closed pull request #511: URL: https://github.com/apache/qpid-dispatch/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Relaxing C11 sys_atomic_init and get > > > Key: DISPATCH-1344 > URL: https://issues.apache.org/jira/browse/DISPATCH-1344 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Francesco Nigro >Priority: Minor > Labels: performance > > GCC version of the same primitives are using plain loads/stores while C11 > ones where using the default behavior of all atomic operations ie > sequentially consistent ordering. > Sequential consistent ordering is heavy-weight and should be relaxed if not > necessary. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-781) Tie end-to-end flow control of message-routed deliveries to outgoing capacity
[ https://issues.apache.org/jira/browse/DISPATCH-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478974#comment-17478974 ] ASF GitHub Bot commented on DISPATCH-781: - ganeshmurthy closed pull request #731: URL: https://github.com/apache/qpid-dispatch/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Tie end-to-end flow control of message-routed deliveries to outgoing capacity > - > > Key: DISPATCH-781 > URL: https://issues.apache.org/jira/browse/DISPATCH-781 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Routing Engine >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 2.0.0 > > > This feature reverses the management of incoming credit for message-routed > deliveries. > The current mechanism is based on the the capacity of the incoming > (sender-client) links. Each attached sender is given credit equal to the > configured link capacity regardless of the capacity of outgoing > (receiver-client) links for the same address. This means that even under > congestion, a newly attached sender will get full capacity credit to send. > The proposed mechanism is based not on incoming capacity but on outgoing > capacity. In this case, the senders are provided a share of the total > outgoing capacity for an address. As the number of incoming links (senders) > for an address changes and the total capacity for outgoing links changes, the > credit window of the senders shall be adjusted. > The proposal is a heuristic approach. It does not revoke credit from senders > (but will limit the number of credits that are replenished). It will also > not deny credit if there are more incoming links than outgoing capacity. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #511: DISPATCH-1344 Relaxing C11 sys_atomic_init and get
ganeshmurthy closed pull request #511: URL: https://github.com/apache/qpid-dispatch/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #731: DISPATCH-781 - Work in Progress - Do not merge.
ganeshmurthy closed pull request #731: URL: https://github.com/apache/qpid-dispatch/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1342) Replaced mutex with spin lock on qd_message content
[ https://issues.apache.org/jira/browse/DISPATCH-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478973#comment-17478973 ] ASF GitHub Bot commented on DISPATCH-1342: -- ganeshmurthy closed pull request #508: URL: https://github.com/apache/qpid-dispatch/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replaced mutex with spin lock on qd_message content > --- > > Key: DISPATCH-1342 > URL: https://issues.apache.org/jira/browse/DISPATCH-1342 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Routing Engine >Affects Versions: 1.7.0 >Reporter: Francesco Nigro >Priority: Minor > Labels: performance > > Given that qd_message creation and qd_message_free involves sys_mutex > allocation/free and they are OS resources too, using spin locks will reduce > the CPU/memory usage while performing such frequent operations. > In addition it would make the router more reactive and resilient to OS thread > scheduling while message->content is being concurrently accessed too, given > that such accesses are meant to not last long and there is no need to involve > OS arbitration to park/awake threads, -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #508: DISPATCH-1342 Replaced mutex with spin lock on qd_message content
ganeshmurthy closed pull request #508: URL: https://github.com/apache/qpid-dispatch/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #526: mercury initial checkin
ganeshmurthy closed pull request #526: URL: https://github.com/apache/qpid-dispatch/pull/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #560: NO-JIRA: add a document explaining the router's threading implementat…
ganeshmurthy closed pull request #560: URL: https://github.com/apache/qpid-dispatch/pull/560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #771: Add a short note about the multi-tenancy flag
ganeshmurthy closed pull request #771: URL: https://github.com/apache/qpid-dispatch/pull/771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #744: For review - Server code clean up
ganeshmurthy closed pull request #744: URL: https://github.com/apache/qpid-dispatch/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #805: Proposal for run-time lock validation
ganeshmurthy closed pull request #805: URL: https://github.com/apache/qpid-dispatch/pull/805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1477: Bump d3 from 3.5.17 to 7.3.0 in /console/react
dependabot[bot] commented on pull request #1477: URL: https://github.com/apache/qpid-dispatch/pull/1477#issuecomment-1016858874 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1477: Bump d3 from 3.5.17 to 7.3.0 in /console/react
ganeshmurthy closed pull request #1477: URL: https://github.com/apache/qpid-dispatch/pull/1477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1459: Bump @patternfly/react-styles from 4.11.8 to 4.31.1 in /console/react
ganeshmurthy closed pull request #1459: URL: https://github.com/apache/qpid-dispatch/pull/1459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1460: Bump @patternfly/react-icons from 4.11.8 to 4.32.1 in /console/react
ganeshmurthy closed pull request #1460: URL: https://github.com/apache/qpid-dispatch/pull/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1460: Bump @patternfly/react-icons from 4.11.8 to 4.32.1 in /console/react
dependabot[bot] commented on pull request #1460: URL: https://github.com/apache/qpid-dispatch/pull/1460#issuecomment-1016858654 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1459: Bump @patternfly/react-styles from 4.11.8 to 4.31.1 in /console/react
dependabot[bot] commented on pull request #1459: URL: https://github.com/apache/qpid-dispatch/pull/1459#issuecomment-1016858755 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1461: Bump @patternfly/react-topology from 4.9.42 to 4.28.1 in /console/react
dependabot[bot] commented on pull request #1461: URL: https://github.com/apache/qpid-dispatch/pull/1461#issuecomment-1016858481 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1461: Bump @patternfly/react-topology from 4.9.42 to 4.28.1 in /console/react
ganeshmurthy closed pull request #1461: URL: https://github.com/apache/qpid-dispatch/pull/1461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1462: Bump @patternfly/patternfly from 4.125.3 to 4.164.2 in /console/react
dependabot[bot] commented on pull request #1462: URL: https://github.com/apache/qpid-dispatch/pull/1462#issuecomment-1016858404 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1462: Bump @patternfly/patternfly from 4.125.3 to 4.164.2 in /console/react
ganeshmurthy closed pull request #1462: URL: https://github.com/apache/qpid-dispatch/pull/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1903) Remote upload of certificate files for new TLS configurations
[ https://issues.apache.org/jira/browse/DISPATCH-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478966#comment-17478966 ] ASF GitHub Bot commented on DISPATCH-1903: -- ganeshmurthy closed pull request #1025: URL: https://github.com/apache/qpid-dispatch/pull/1025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remote upload of certificate files for new TLS configurations > - > > Key: DISPATCH-1903 > URL: https://issues.apache.org/jira/browse/DISPATCH-1903 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Container >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: Backlog > > > Currently, when using the management protocol to create new SSL-profiles, > those profiles must access certificate files that are already placed in the > file system. In other words, in order to create an SSL-profile on a running > router, files must first be placed on the file system in a location > accessible by the router. This may be problematic in cases where the router > is remote from the managing agent, or when containerization limits access to > the router's underlying file system. > This new feature allows a managing agent to remotely inject files into a > running router to be stored in temporary file storage. These files are > usable in sslProfile management entities (by specifying the files without an > absolute path). The temporary files are removed from the file system on > router shutdown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1780) multicast support for http 1.1 adaptor
[ https://issues.apache.org/jira/browse/DISPATCH-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478965#comment-17478965 ] ASF GitHub Bot commented on DISPATCH-1780: -- ganeshmurthy closed pull request #909: URL: https://github.com/apache/qpid-dispatch/pull/909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multicast support for http 1.1 adaptor > -- > > Key: DISPATCH-1780 > URL: https://issues.apache.org/jira/browse/DISPATCH-1780 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1025: DISPATCH-1903 Added logic for storage of temporary files. Added use …
ganeshmurthy closed pull request #1025: URL: https://github.com/apache/qpid-dispatch/pull/1025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #909: DISPATCH-1780: first stab at aggregated multicast
ganeshmurthy closed pull request #909: URL: https://github.com/apache/qpid-dispatch/pull/909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1351: NO-JIRA: remove those travis test combinations that duplicate GHA tests
ganeshmurthy closed pull request #1351: URL: https://github.com/apache/qpid-dispatch/pull/1351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1381: Dispatch 2231 1
ganeshmurthy closed pull request #1381: URL: https://github.com/apache/qpid-dispatch/pull/1381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) log.c rewrite to reduce locking scope
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478961#comment-17478961
]
ASF GitHub Bot commented on DISPATCH-1956:
--
ganeshmurthy closed pull request #1391:
URL: https://github.com/apache/qpid-dispatch/pull/1391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> log.c rewrite to reduce locking scope
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: michael goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.19.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1391: DISPATCH-1956-B: lock protect changes to sinks
ganeshmurthy closed pull request #1391: URL: https://github.com/apache/qpid-dispatch/pull/1391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) log.c rewrite to reduce locking scope
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478959#comment-17478959
]
ASF GitHub Bot commented on DISPATCH-1956:
--
ganeshmurthy closed pull request #1243:
URL: https://github.com/apache/qpid-dispatch/pull/1243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> log.c rewrite to reduce locking scope
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: michael goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.19.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) log.c rewrite to reduce locking scope
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478960#comment-17478960
]
ASF GitHub Bot commented on DISPATCH-1956:
--
ganeshmurthy closed pull request #1383:
URL: https://github.com/apache/qpid-dispatch/pull/1383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> log.c rewrite to reduce locking scope
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: michael goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.19.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1383: DISPATCH-1956: log.c rewrite to reduce locking scope
ganeshmurthy closed pull request #1383: URL: https://github.com/apache/qpid-dispatch/pull/1383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1243: DISPATCH-1956: reduce locking around log src lookup
ganeshmurthy closed pull request #1243: URL: https://github.com/apache/qpid-dispatch/pull/1243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1200: NO-JIRA: Added info about the -j flag so tests can execute faster
ganeshmurthy closed pull request #1200: URL: https://github.com/apache/qpid-dispatch/pull/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1261: Thread debug cr4 - DO NOT MERGE
ganeshmurthy closed pull request #1261: URL: https://github.com/apache/qpid-dispatch/pull/1261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1342: Tls2 wip
ganeshmurthy closed pull request #1342: URL: https://github.com/apache/qpid-dispatch/pull/1342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2310: Assignee: Ken Giusti > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2310) Enforce a limit to the length of a router's id
Ken Giusti created DISPATCH-2310: Summary: Enforce a limit to the length of a router's id Key: DISPATCH-2310 URL: https://issues.apache.org/jira/browse/DISPATCH-2310 Project: Qpid Dispatch Issue Type: Improvement Components: Router Node Affects Versions: 1.18.0 Reporter: Ken Giusti Do not allow router id names of > 255 characters. 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2307) Router Ids > 64 characters can crash the router
[ https://issues.apache.org/jira/browse/DISPATCH-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2307. -- Resolution: Fixed > Router Ids > 64 characters can crash the router > --- > > Key: DISPATCH-2307 > URL: https://issues.apache.org/jira/browse/DISPATCH-2307 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > > Under some circumstances configuring a router id with a length > 64 > characters can cause heap corruption. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478859#comment-17478859 ] ASF GitHub Bot commented on DISPATCH-1487: -- codecov-commenter commented on pull request #1483: URL: https://github.com/apache/qpid-dispatch/pull/1483#issuecomment-1016725657 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1483](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (351a936) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **decrease** coverage by `0.21%`. > The diff coverage is `83.56%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1483 +/- ## == - Coverage 84.75% 84.54% -0.22% == Files 116 119 +3 Lines 2864429010 +366 == + Hits2427724526 +249 - Misses 4367 4484 +117 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/reference\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3JlZmVyZW5jZV9hZGFwdG9yLmM=) | `0.00% <0.00%> (ø)` | | | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [...ules/address\_lookup\_server/address\_lookup\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfc2VydmVyL2FkZHJlc3NfbG9va3VwX3NlcnZlci5j) | `92.10% <50.00%> (-0.76%)` | :arrow_down: | | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `69.00% <56.97%> (-0.11%)` | :arrow_down: | | [tests/run\_unit\_tests\_size.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcnVuX3VuaXRfdGVzdHNfc2l6ZS5j) | `67.44% <60.29%> (-27.30%)` | :arrow_down: | | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `93.10% <75.00%> (+1.31%)` | :arrow_up: | | [tests/message\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvbWVzc2FnZV90ZXN0LmM=) | `78.22% <82.48%> (-0.44%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `85.54% <86.98%> (-2.42%)` | :arrow_down: | |
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1483: DISPATCH-1487: MA rewrite [patch 5 of 5]
codecov-commenter commented on pull request #1483: URL: https://github.com/apache/qpid-dispatch/pull/1483#issuecomment-1016725657 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1483](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (351a936) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **decrease** coverage by `0.21%`. > The diff coverage is `83.56%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1483 +/- ## == - Coverage 84.75% 84.54% -0.22% == Files 116 119 +3 Lines 2864429010 +366 == + Hits2427724526 +249 - Misses 4367 4484 +117 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1483?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/reference\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3JlZmVyZW5jZV9hZGFwdG9yLmM=) | `0.00% <0.00%> (ø)` | | | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [...ules/address\_lookup\_server/address\_lookup\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfc2VydmVyL2FkZHJlc3NfbG9va3VwX3NlcnZlci5j) | `92.10% <50.00%> (-0.76%)` | :arrow_down: | | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `69.00% <56.97%> (-0.11%)` | :arrow_down: | | [tests/run\_unit\_tests\_size.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcnVuX3VuaXRfdGVzdHNfc2l6ZS5j) | `67.44% <60.29%> (-27.30%)` | :arrow_down: | | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `93.10% <75.00%> (+1.31%)` | :arrow_up: | | [tests/message\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvbWVzc2FnZV90ZXN0LmM=) | `78.22% <82.48%> (-0.44%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `85.54% <86.98%> (-2.42%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1483/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `88.37% <98.42%> (+1.02%)` | :arrow_up: | | ... and [27
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478855#comment-17478855 ] ASF GitHub Bot commented on DISPATCH-1487: -- codecov-commenter commented on pull request #1482: URL: https://github.com/apache/qpid-dispatch/pull/1482#issuecomment-1016719072 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1482](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0fabb9e) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **decrease** coverage by `0.17%`. > The diff coverage is `82.06%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1482 +/- ## == - Coverage 84.75% 84.58% -0.18% == Files 116 117 +1 Lines 2864428887 +243 == + Hits2427724433 +156 - Misses 4367 4454 +87 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/reference\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3JlZmVyZW5jZV9hZGFwdG9yLmM=) | `0.00% <0.00%> (ø)` | | | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [...ules/address\_lookup\_server/address\_lookup\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfc2VydmVyL2FkZHJlc3NfbG9va3VwX3NlcnZlci5j) | `92.10% <50.00%> (-0.76%)` | :arrow_down: | | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `69.00% <56.97%> (-0.11%)` | :arrow_down: | | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `93.10% <75.00%> (+1.31%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.67% <77.77%> (-0.88%)` | :arrow_down: | | [tests/message\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvbWVzc2FnZV90ZXN0LmM=) | `78.22% <82.48%> (-0.44%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `85.12% <86.34%> (-2.85%)` | :arrow_down: | |
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1482: DISPATCH-1487: MA processing rewrite [patch 4 of 5]
codecov-commenter commented on pull request #1482: URL: https://github.com/apache/qpid-dispatch/pull/1482#issuecomment-1016719072 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1482](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0fabb9e) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **decrease** coverage by `0.17%`. > The diff coverage is `82.06%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1482 +/- ## == - Coverage 84.75% 84.58% -0.18% == Files 116 117 +1 Lines 2864428887 +243 == + Hits2427724433 +156 - Misses 4367 4454 +87 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1482?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/reference\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3JlZmVyZW5jZV9hZGFwdG9yLmM=) | `0.00% <0.00%> (ø)` | | | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [...ules/address\_lookup\_server/address\_lookup\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfc2VydmVyL2FkZHJlc3NfbG9va3VwX3NlcnZlci5j) | `92.10% <50.00%> (-0.76%)` | :arrow_down: | | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `69.00% <56.97%> (-0.11%)` | :arrow_down: | | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `93.10% <75.00%> (+1.31%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.67% <77.77%> (-0.88%)` | :arrow_down: | | [tests/message\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvbWVzc2FnZV90ZXN0LmM=) | `78.22% <82.48%> (-0.44%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `85.12% <86.34%> (-2.85%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1482/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.88% <95.55%> (+0.53%)` | :arrow_up: | | ... and [25
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478754#comment-17478754 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti opened a new pull request #1483: URL: https://github.com/apache/qpid-dispatch/pull/1483 The patch hand-optimizes the creation of the message annotations section in an outgoing message. It implementes the following changes: o Pre-encode the map keys used by the router annotations. o Inline the encoding of related AMQP type and section headers o Pre-encode the local router ID for trace and ingress composition o minor tweaks to qd_message_send to reduce processing overhead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1483: DISPATCH-1487: MA rewrite [patch 5 of 5]
kgiusti opened a new pull request #1483: URL: https://github.com/apache/qpid-dispatch/pull/1483 The patch hand-optimizes the creation of the message annotations section in an outgoing message. It implementes the following changes: o Pre-encode the map keys used by the router annotations. o Inline the encoding of related AMQP type and section headers o Pre-encode the local router ID for trace and ingress composition o minor tweaks to qd_message_send to reduce processing overhead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478752#comment-17478752 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti opened a new pull request #1482: URL: https://github.com/apache/qpid-dispatch/pull/1482 Delay composing trace and ingress to the point where the message is actually being written out. Do it in one place rather than whenever a locally generated message is constructed. Note: with this patch it is no longer necessary to manually create the ma-trace and ma-ingress MA fields everywhere a locally generated message is constructed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1482: DISPATCH-1487: MA processing rewrite [patch 4 of 5]
kgiusti opened a new pull request #1482: URL: https://github.com/apache/qpid-dispatch/pull/1482 Delay composing trace and ingress to the point where the message is actually being written out. Do it in one place rather than whenever a locally generated message is constructed. Note: with this patch it is no longer necessary to manually create the ma-trace and ma-ingress MA fields everywhere a locally generated message is constructed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478749#comment-17478749 ] ASF GitHub Bot commented on PROTON-2487: codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3e276a) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head a3e276a differs from pull request most recent head 4c6bb82. Consider uploading reports for the commit 4c6bb82 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cpp/src/message.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdlLmNwcA==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [cpp/src/proactor\_work\_queue\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl93b3JrX3F1ZXVlX2ltcGwuaHBw) | | | | [c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9sb2cuYw==) | | | | [python/proton/\_url.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fdXJsLnB5) | | | | [c/src/core/object/map.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9vYmplY3QvbWFwLmM=) | | | | [c/tools/reactor-send.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90b29scy9yZWFjdG9yLXNlbmQuYw==) | | | | [cpp/src/duration.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kdXJhdGlvbi5jcHA=) | | | | [c/src/handlers/flowcontroller.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvaGFuZGxlcnMvZmxvd2NvbnRyb2xsZXIuYw==) | | | | ... and [310
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478748#comment-17478748 ] ASF GitHub Bot commented on PROTON-2487: codecov-commenter commented on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3e276a) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head a3e276a differs from pull request most recent head 4c6bb82. Consider uploading reports for the commit 4c6bb82 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cpp/src/message.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdlLmNwcA==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [cpp/src/proactor\_work\_queue\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl93b3JrX3F1ZXVlX2ltcGwuaHBw) | | | | [c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9sb2cuYw==) | | | | [python/proton/\_url.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fdXJsLnB5) | | | | [c/src/core/object/map.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9vYmplY3QvbWFwLmM=) | | | | [c/tools/reactor-send.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90b29scy9yZWFjdG9yLXNlbmQuYw==) | | | | [cpp/src/duration.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kdXJhdGlvbi5jcHA=) | | | | [c/src/handlers/flowcontroller.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvaGFuZGxlcnMvZmxvd2NvbnRyb2xsZXIuYw==) | | | | ... and [310
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3e276a) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head a3e276a differs from pull request most recent head 4c6bb82. Consider uploading reports for the commit 4c6bb82 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cpp/src/message.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdlLmNwcA==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [cpp/src/proactor\_work\_queue\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl93b3JrX3F1ZXVlX2ltcGwuaHBw) | | | | [c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9sb2cuYw==) | | | | [python/proton/\_url.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fdXJsLnB5) | | | | [c/src/core/object/map.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9vYmplY3QvbWFwLmM=) | | | | [c/tools/reactor-send.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90b29scy9yZWFjdG9yLXNlbmQuYw==) | | | | [cpp/src/duration.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kdXJhdGlvbi5jcHA=) | | | | [c/src/handlers/flowcontroller.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvaGFuZGxlcnMvZmxvd2NvbnRyb2xsZXIuYw==) | | | | ... and [310 more](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at
[GitHub] [qpid-proton] codecov-commenter commented on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
codecov-commenter commented on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3e276a) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head a3e276a differs from pull request most recent head 4c6bb82. Consider uploading reports for the commit 4c6bb82 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cpp/src/message.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdlLmNwcA==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [cpp/src/proactor\_work\_queue\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl93b3JrX3F1ZXVlX2ltcGwuaHBw) | | | | [c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9sb2cuYw==) | | | | [python/proton/\_url.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fdXJsLnB5) | | | | [c/src/core/object/map.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9vYmplY3QvbWFwLmM=) | | | | [c/tools/reactor-send.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90b29scy9yZWFjdG9yLXNlbmQuYw==) | | | | [cpp/src/duration.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kdXJhdGlvbi5jcHA=) | | | | [c/src/handlers/flowcontroller.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvaGFuZGxlcnMvZmxvd2NvbnRyb2xsZXIuYw==) | | | | ... and [310 more](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1481: DISPATCH-1487: MA processing rewrite [patch 3 of 5]
kgiusti opened a new pull request #1481: URL: https://github.com/apache/qpid-dispatch/pull/1481 This patch modifies how locally generated messages are initialized. The associated message context is now initialized with the proper locations of any message sections present. This will allow the router annotations to be composed on message send, rather than requiring the message creator to manually set the proper trace, ingress, etc. fields when the message is created. This patch also removes the plethora of "qd_message_compose_X()" functions and replaces them with a single general purpose message constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478740#comment-17478740 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti opened a new pull request #1481: URL: https://github.com/apache/qpid-dispatch/pull/1481 This patch modifies how locally generated messages are initialized. The associated message context is now initialized with the proper locations of any message sections present. This will allow the router annotations to be composed on message send, rather than requiring the message creator to manually set the proper trace, ingress, etc. fields when the message is created. This patch also removes the plethora of "qd_message_compose_X()" functions and replaces them with a single general purpose message constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478738#comment-17478738 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti opened a new pull request #1480: URL: https://github.com/apache/qpid-dispatch/pull/1480 Add the ability to completely skip all MA processing inbound and outbound for Link Routing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1480: DISPATCH-1487: rewrite of message annotations processing [patch 2 of 5]
kgiusti opened a new pull request #1480: URL: https://github.com/apache/qpid-dispatch/pull/1480 Add the ability to completely skip all MA processing inbound and outbound for Link Routing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478732#comment-17478732 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti opened a new pull request #1479: URL: https://github.com/apache/qpid-dispatch/pull/1479 Refactor parsing of incoming message annotations: - rewrite internal parse code to use inlined buffer operations where possible (removing parse_turbo) - add verification of MA contents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1479: DISPATCH-1487: MA processing rewrite [patch 1 of 5]
kgiusti opened a new pull request #1479: URL: https://github.com/apache/qpid-dispatch/pull/1479 Refactor parsing of incoming message annotations: - rewrite internal parse code to use inlined buffer operations where possible (removing parse_turbo) - add verification of MA contents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478725#comment-17478725 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti closed pull request #1466: URL: https://github.com/apache/qpid-dispatch/pull/1466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478726#comment-17478726 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti closed pull request #1467: URL: https://github.com/apache/qpid-dispatch/pull/1467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478724#comment-17478724 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti closed pull request #1382: URL: https://github.com/apache/qpid-dispatch/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1382: DISPATCH-1487: rewrite message annotation processing (DO NOT MERGE)
kgiusti closed pull request #1382: URL: https://github.com/apache/qpid-dispatch/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1466: DISPATCH-1487: remove parse turbo, refactor parsing to use buffer fields
kgiusti closed pull request #1466: URL: https://github.com/apache/qpid-dispatch/pull/1466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1467: DISPATCH-1487: optimize link routed messages to skip all message annotation processing
kgiusti closed pull request #1467: URL: https://github.com/apache/qpid-dispatch/pull/1467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on pull request #319: [DRAFT] [cpp] Add distributed tracing using OpenTelemetry
DreamPearl commented on pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#issuecomment-1016419339 Continuing the changes in the new PR: https://github.com/apache/qpid-proton/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478634#comment-17478634 ] ASF GitHub Bot commented on PROTON-2487: DreamPearl opened a new pull request #355: URL: https://github.com/apache/qpid-proton/pull/355 [PROTON-2487](https://issues.apache.org/jira/browse/PROTON-2487) - Add the opentelemetry-cpp library dependencies - Add opentelemetry-cpp install/build steps in GHA - Add tracing.cpp file - Add tracing spans for messaging operations - Add basic attributes[delivery_tag, delivery_state, source_address, destination_address] - Add a tracing demo file in examples - Add a test file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] Implement distributed tracing > --- > > Key: PROTON-2487 > URL: https://issues.apache.org/jira/browse/PROTON-2487 > Project: Qpid Proton > Issue Type: New Feature > Components: cpp-binding >Reporter: Rakhi Kumari >Assignee: Rakhi Kumari >Priority: Major > Fix For: proton-c-0.37.0 > > > Implement distributed tracing using opentelemetry. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl opened a new pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
DreamPearl opened a new pull request #355: URL: https://github.com/apache/qpid-proton/pull/355 [PROTON-2487](https://issues.apache.org/jira/browse/PROTON-2487) - Add the opentelemetry-cpp library dependencies - Add opentelemetry-cpp install/build steps in GHA - Add tracing.cpp file - Add tracing spans for messaging operations - Add basic attributes[delivery_tag, delivery_state, source_address, destination_address] - Add a tracing demo file in examples - Add a test file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
