[jira] [Created] (DISPATCH-2317) Router per-message annotations version negotiation
Ken Giusti created DISPATCH-2317: Summary: Router per-message annotations version negotiation Key: DISPATCH-2317 URL: https://issues.apache.org/jira/browse/DISPATCH-2317 Project: Qpid Dispatch Issue Type: New Feature Components: Router Node Affects Versions: 1.18.0 Reporter: Ken Giusti Fix For: 1.19.0 Directly connected routers (and edge routers) exchange per-message router annotations. In order to support the ability to modify these annotations in future releases, have a router advertise the format (version) of its message annotations. This can be done via a new connection properties value which is set to the version of annotations accepted by the router. Directly-connected routers would exchange these versions and agree to use the minimum version advertised. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2317) Router per-message annotations version negotiation
[ https://issues.apache.org/jira/browse/DISPATCH-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2317: Assignee: Ken Giusti > Router per-message annotations version negotiation > -- > > Key: DISPATCH-2317 > URL: https://issues.apache.org/jira/browse/DISPATCH-2317 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Directly connected routers (and edge routers) exchange per-message router > annotations. In order to support the ability to modify these annotations in > future releases, have a router advertise the format (version) of its message > annotations. > This can be done via a new connection properties value which is set to the > version of annotations accepted by the router. Directly-connected routers > would exchange these versions and agree to use the minimum version advertised. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481335#comment-17481335
]
ASF subversion and git services commented on DISPATCH-1913:
---
Commit 8f25156c636c2d35344d6b4b513615acec933da0 in qpid-dispatch's branch
refs/heads/main from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8f25156 ]
DISPATCH-1913: Tidy up qpid_dispatch.management.client.Node
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: 1.15.0
>
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2309) Message body validation can succeed without validating the actual message body
[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2309. -- Resolution: Fixed > Message body validation can succeed without validating the actual message body > -- > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2309) Message body validation can succeed without validating the actual message body
[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481312#comment-17481312 ] ASF GitHub Bot commented on DISPATCH-2309: -- kgiusti merged pull request #1493: URL: https://github.com/apache/qpid-dispatch/pull/1493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Message body validation can succeed without validating the actual message body > -- > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti merged pull request #1493: DISPATCH-2309: Ensure rx message validation succeeds before forwarding
kgiusti merged pull request #1493: URL: https://github.com/apache/qpid-dispatch/pull/1493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1490: DISPATCH-2310: limit router identifiers to 255 characters
kgiusti commented on pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490#issuecomment-1020399138 Closed in deference to tross' node id validation fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481307#comment-17481307 ] ASF GitHub Bot commented on DISPATCH-2310: -- kgiusti commented on pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490#issuecomment-1020399138 Closed in deference to tross' node id validation fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481306#comment-17481306 ] ASF GitHub Bot commented on DISPATCH-2310: -- kgiusti closed pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1490: DISPATCH-2310: limit router identifiers to 255 characters
kgiusti closed pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481258#comment-17481258
]
ASF GitHub Bot commented on DISPATCH-1913:
--
ganeshmurthy closed pull request #1007:
URL: https://github.com/apache/qpid-dispatch/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: 1.15.0
>
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481257#comment-17481257
]
ASF GitHub Bot commented on DISPATCH-1913:
--
ganeshmurthy commented on pull request #1007:
URL: https://github.com/apache/qpid-dispatch/pull/1007#issuecomment-1020341268
I rebased this commit and opened a new PR -
https://github.com/apache/qpid-dispatch/pull/1494
Closing this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: 1.15.0
>
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1007: DISPATCH-1913: Tidy up qpid_dispatch.management.client.Node
ganeshmurthy closed pull request #1007: URL: https://github.com/apache/qpid-dispatch/pull/1007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1007: DISPATCH-1913: Tidy up qpid_dispatch.management.client.Node
ganeshmurthy commented on pull request #1007: URL: https://github.com/apache/qpid-dispatch/pull/1007#issuecomment-1020341268 I rebased this commit and opened a new PR - https://github.com/apache/qpid-dispatch/pull/1494 Closing this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2489) [Python] tracing annotations should be aligned with the qpid-jms tracing annotations
[ https://issues.apache.org/jira/browse/PROTON-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481205#comment-17481205 ] ASF subversion and git services commented on PROTON-2489: - Commit 8e862575134dcd78f5b82d0a71f594e700d52fd9 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=8e86257 ] PROTON-2489: Use standardized tag for trace message creator > [Python] tracing annotations should be aligned with the qpid-jms tracing > annotations > > > Key: PROTON-2489 > URL: https://issues.apache.org/jira/browse/PROTON-2489 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > There are a couple of places where they disagree and should be aligned. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-2489) [Python] tracing annotations should be aligned with the qpid-jms tracing annotations
[ https://issues.apache.org/jira/browse/PROTON-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned PROTON-2489: --- Assignee: Andrew Stitcher > [Python] tracing annotations should be aligned with the qpid-jms tracing > annotations > > > Key: PROTON-2489 > URL: https://issues.apache.org/jira/browse/PROTON-2489 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > There are a couple of places where they disagree and should be aligned. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Moved] (PROTON-2489) [Python] tracing annotations should be aligned with the qpid-jms tracing annotations
[ https://issues.apache.org/jira/browse/PROTON-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher moved QPID-8574 to PROTON-2489: --- Key: PROTON-2489 (was: QPID-8574) Workflow: classic default workflow (was: QPid Workflow) Project: Qpid Proton (was: Qpid) > [Python] tracing annotations should be aligned with the qpid-jms tracing > annotations > > > Key: PROTON-2489 > URL: https://issues.apache.org/jira/browse/PROTON-2489 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Priority: Minor > > There are a couple of places where they disagree and should be aligned. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8574) [Python] tracing annotations should be aligned with the qpid-jms tracing annotations
Andrew Stitcher created QPID-8574: - Summary: [Python] tracing annotations should be aligned with the qpid-jms tracing annotations Key: QPID-8574 URL: https://issues.apache.org/jira/browse/QPID-8574 Project: Qpid Issue Type: Improvement Reporter: Andrew Stitcher There are a couple of places where they disagree and should be aligned. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2449) Remove unnecessary scratch string from pn_transport_t
[ https://issues.apache.org/jira/browse/PROTON-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2449. - Fix Version/s: proton-c-0.37.0 Resolution: Fixed > Remove unnecessary scratch string from pn_transport_t > - > > Key: PROTON-2449 > URL: https://issues.apache.org/jira/browse/PROTON-2449 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.37.0 > > > This si only ever used to construct strings for logging, but the logger has > its own scratch string so this is strictly unnecessary. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2448) Implement a dumping AMQP values without using pn_data_t
[ https://issues.apache.org/jira/browse/PROTON-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2448. - Fix Version/s: proton-c-0.37.0 Resolution: Fixed > Implement a dumping AMQP values without using pn_data_t > --- > > Key: PROTON-2448 > URL: https://issues.apache.org/jira/browse/PROTON-2448 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.37.0 > > > Printing AMQP values is widely used in proton especially for frame tracing. > It is massively inefficient because it relies on there being an existing > pn_data_t structure which represents the AMQP value. > In the upcoming work to remove pn_data_t use from (nearly all of ) the > critical path of proton-c there will no longer be such a pn_data_t that > represents the received or transmitted frame. So we need new code to dump the > AMQP values. Luckily the new AMQP consume code provides a simple skeleton > which makes this fairly straightforward. > This new code can now produce text dumps of AMQP frames/values direct form > the bytes encoding the frames with no intermediate step. This allows the use > if this code in th elowest level send and receive code of the AMQP engine. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2309) Message body validation can succeed without validating the actual message body
[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481137#comment-17481137 ] ASF GitHub Bot commented on DISPATCH-2309: -- kgiusti opened a new pull request #1493: URL: https://github.com/apache/qpid-dispatch/pull/1493 o Determine the proper validation depth if message logging used o move message logging calls to point of forwarding o Include link-routed messages in validation o Fail if attempting to validate after streaming buffers freed o Extra Credit: add message rejection errors and remove dead code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Message body validation can succeed without validating the actual message body > -- > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1493: DISPATCH-2309: Ensure rx message validation succeeds before forwarding
kgiusti opened a new pull request #1493: URL: https://github.com/apache/qpid-dispatch/pull/1493 o Determine the proper validation depth if message logging used o move message logging calls to point of forwarding o Include link-routed messages in validation o Fail if attempting to validate after streaming buffers freed o Extra Credit: add message rejection errors and remove dead code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481011#comment-17481011
]
Jiri Daněk commented on DISPATCH-2314:
--
As [~kgiusti] said, this happens when the flag gets operated upon from two
different threads, one running {{qdr_delivery_continue_CT}} and the other one
{{qdr_delivery_set_presettled}}.
What the warning means is that the update to the flag happening in the second
function may or may not be visible in the first, because the happens-before
relationship between the threads respective actions has not been established.
Another important function of thread synchronization is publishing: so that
updates that happen in one thread become visible to the other threads; this is
not of much concert on x86-64 (which is cache-coherent, so the change in flag
becomes visible the moment it leaves CPU registers), but is more significant on
other architectures. We do not have to worry about atomicity, (update being
only partially visible to the other threads) because updating a bool is always
atomic anyways.
The important question obviously is, "does it have any impact on
functionality?" and also "is it brittle in a way such is likely to have
negative impact later?". I think the latter is true; having two threads, one
concerned with sending, and other with receiving, operating on the same data at
the same time, without synchronization, seems to me risky and hard to reason
about regarding future modifications of the codebase.
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4
[jira] [Resolved] (DISPATCH-2181) Data race coming from Proton (pni_raw_connection_process/post_event) in system_tests_tcp_adaptor
[
https://issues.apache.org/jira/browse/DISPATCH-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved DISPATCH-2181.
--
Resolution: Resolved
Resolved by PROTON-2436.
> Data race coming from Proton (pni_raw_connection_process/post_event) in
> system_tests_tcp_adaptor
>
>
> Key: DISPATCH-2181
> URL: https://issues.apache.org/jira/browse/DISPATCH-2181
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0, 1.18.0
>Reporter: Jiri Daněk
>Assignee: Clifford Jansen
>Priority: Major
> Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> PR build, but containing only CMake changes, unlikely to have caused this.
> https://github.com/apache/qpid-dispatch/pull/1267/checks?check_run_id=2872865179#step:25:5231
> {noformat}
> 71: ::TcpAdaptor::test_80_stats 2021-06-21 07:43:37.568445 test_80 check
> stats in qdmanage START
> 71: 2021-06-21 07:43:37.872270 test_80 check stats in qdmanage SUCCESS
> 71: PASSED2021-06-21 07:43:37.874339 TCP_TEST Stopping echo server ES_INTA
> 71: 2021-06-21 07:43:37.975012 TCP_TEST Stopping echo server ES_INTB
> 71: 2021-06-21 07:43:38.075261 TCP_TEST Stopping echo server ES_INTC
> 71: 2021-06-21 07:43:38.131639 TCP_TEST Stopping echo server ES_EA1
> 71: 2021-06-21 07:43:38.183962 TCP_TEST Stopping echo server ES_EA2
> 71: 2021-06-21 07:43:38.275843 TCP_TEST Stopping echo server ES_EB1
> 71: 2021-06-21 07:43:38.376357 TCP_TEST Stopping echo server ES_EB2
> 71: 2021-06-21 07:43:38.476605 TCP_TEST Stopping echo server ES_EC1
> 71: 2021-06-21 07:43:38.569269 TCP_TEST Stopping echo server ES_EC2
> 71: 2021-06-21 07:43:38.655474 TCP_TEST Stopping echo server NS_EC2_CONN_STALL
> 71:
> 71: Router INTA output file:
> 71:
> 71: ==
> 71: WARNING: ThreadSanitizer: data race (pid=3231)
> 71: Write of size 4 at 0x7b6800032338 by thread T4 (mutexes: write M261):
> 71: #0 post_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2304
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #1 poller_do_epoll
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2534
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #2 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2438
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #3 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x14622)
> 71: #4 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1106
> (qdrouterd+0x4e3ebe)
> 71: #5 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x4868bd)
> 71:
> 71: Previous read of size 4 at 0x7b6800032338 by thread T2 (mutexes: write
> M2585):
> 71: #0 pni_raw_connection_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll_raw_connection.c:355
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #1 process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2230
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #2 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2419
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #3 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x14622)
> 71: #4 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1106
> (qdrouterd+0x4e3ebe)
> 71: #5 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x4868bd)
> 71:
> 71: Location is heap block of size 1536 at 0x7b6800031e00 allocated by
> thread T4:
> 71: #0 calloc (libtsan.so.0+0x32b3e)
> 71: #1 pn_raw_connection
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll_raw_connection.c:168
> (libqpid-proton-proactor.so.1+0xdf82)
> 71: #2 qdr_tcp_connection_egress
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1086
> (qdrouterd+0x448b52)
> 71: #3 qdr_tcp_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1531
> (qdrouterd+0x448e86)
> 71: #4 qdr_link_process_deliveries
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:178
> (qdrouterd+0x4c43d0)
> 71: #5 qdr_tcp_push
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1509
> (qdrouterd+0x44707c)
> 71:
[jira] [Assigned] (DISPATCH-2181) Data race coming from Proton (pni_raw_connection_process/post_event) in system_tests_tcp_adaptor
[
https://issues.apache.org/jira/browse/DISPATCH-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned DISPATCH-2181:
Assignee: Clifford Jansen
> Data race coming from Proton (pni_raw_connection_process/post_event) in
> system_tests_tcp_adaptor
>
>
> Key: DISPATCH-2181
> URL: https://issues.apache.org/jira/browse/DISPATCH-2181
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0, 1.18.0
>Reporter: Jiri Daněk
>Assignee: Clifford Jansen
>Priority: Major
> Labels: race-condition, tsan
>
> PR build, but containing only CMake changes, unlikely to have caused this.
> https://github.com/apache/qpid-dispatch/pull/1267/checks?check_run_id=2872865179#step:25:5231
> {noformat}
> 71: ::TcpAdaptor::test_80_stats 2021-06-21 07:43:37.568445 test_80 check
> stats in qdmanage START
> 71: 2021-06-21 07:43:37.872270 test_80 check stats in qdmanage SUCCESS
> 71: PASSED2021-06-21 07:43:37.874339 TCP_TEST Stopping echo server ES_INTA
> 71: 2021-06-21 07:43:37.975012 TCP_TEST Stopping echo server ES_INTB
> 71: 2021-06-21 07:43:38.075261 TCP_TEST Stopping echo server ES_INTC
> 71: 2021-06-21 07:43:38.131639 TCP_TEST Stopping echo server ES_EA1
> 71: 2021-06-21 07:43:38.183962 TCP_TEST Stopping echo server ES_EA2
> 71: 2021-06-21 07:43:38.275843 TCP_TEST Stopping echo server ES_EB1
> 71: 2021-06-21 07:43:38.376357 TCP_TEST Stopping echo server ES_EB2
> 71: 2021-06-21 07:43:38.476605 TCP_TEST Stopping echo server ES_EC1
> 71: 2021-06-21 07:43:38.569269 TCP_TEST Stopping echo server ES_EC2
> 71: 2021-06-21 07:43:38.655474 TCP_TEST Stopping echo server NS_EC2_CONN_STALL
> 71:
> 71: Router INTA output file:
> 71:
> 71: ==
> 71: WARNING: ThreadSanitizer: data race (pid=3231)
> 71: Write of size 4 at 0x7b6800032338 by thread T4 (mutexes: write M261):
> 71: #0 post_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2304
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #1 poller_do_epoll
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2534
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #2 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2438
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #3 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x14622)
> 71: #4 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1106
> (qdrouterd+0x4e3ebe)
> 71: #5 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x4868bd)
> 71:
> 71: Previous read of size 4 at 0x7b6800032338 by thread T2 (mutexes: write
> M2585):
> 71: #0 pni_raw_connection_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll_raw_connection.c:355
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #1 process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2230
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #2 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2419
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #3 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x14622)
> 71: #4 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1106
> (qdrouterd+0x4e3ebe)
> 71: #5 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x4868bd)
> 71:
> 71: Location is heap block of size 1536 at 0x7b6800031e00 allocated by
> thread T4:
> 71: #0 calloc (libtsan.so.0+0x32b3e)
> 71: #1 pn_raw_connection
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll_raw_connection.c:168
> (libqpid-proton-proactor.so.1+0xdf82)
> 71: #2 qdr_tcp_connection_egress
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1086
> (qdrouterd+0x448b52)
> 71: #3 qdr_tcp_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1531
> (qdrouterd+0x448e86)
> 71: #4 qdr_link_process_deliveries
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:178
> (qdrouterd+0x4c43d0)
> 71: #5 qdr_tcp_push
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1509
> (qdrouterd+0x44707c)
> 71: #6 qdr_connection_process
>
[jira] [Updated] (DISPATCH-2181) Data race coming from Proton (pni_raw_connection_process/post_event) in system_tests_tcp_adaptor
[
https://issues.apache.org/jira/browse/DISPATCH-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2181:
-
Fix Version/s: 1.19.0
> Data race coming from Proton (pni_raw_connection_process/post_event) in
> system_tests_tcp_adaptor
>
>
> Key: DISPATCH-2181
> URL: https://issues.apache.org/jira/browse/DISPATCH-2181
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0, 1.18.0
>Reporter: Jiri Daněk
>Assignee: Clifford Jansen
>Priority: Major
> Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> PR build, but containing only CMake changes, unlikely to have caused this.
> https://github.com/apache/qpid-dispatch/pull/1267/checks?check_run_id=2872865179#step:25:5231
> {noformat}
> 71: ::TcpAdaptor::test_80_stats 2021-06-21 07:43:37.568445 test_80 check
> stats in qdmanage START
> 71: 2021-06-21 07:43:37.872270 test_80 check stats in qdmanage SUCCESS
> 71: PASSED2021-06-21 07:43:37.874339 TCP_TEST Stopping echo server ES_INTA
> 71: 2021-06-21 07:43:37.975012 TCP_TEST Stopping echo server ES_INTB
> 71: 2021-06-21 07:43:38.075261 TCP_TEST Stopping echo server ES_INTC
> 71: 2021-06-21 07:43:38.131639 TCP_TEST Stopping echo server ES_EA1
> 71: 2021-06-21 07:43:38.183962 TCP_TEST Stopping echo server ES_EA2
> 71: 2021-06-21 07:43:38.275843 TCP_TEST Stopping echo server ES_EB1
> 71: 2021-06-21 07:43:38.376357 TCP_TEST Stopping echo server ES_EB2
> 71: 2021-06-21 07:43:38.476605 TCP_TEST Stopping echo server ES_EC1
> 71: 2021-06-21 07:43:38.569269 TCP_TEST Stopping echo server ES_EC2
> 71: 2021-06-21 07:43:38.655474 TCP_TEST Stopping echo server NS_EC2_CONN_STALL
> 71:
> 71: Router INTA output file:
> 71:
> 71: ==
> 71: WARNING: ThreadSanitizer: data race (pid=3231)
> 71: Write of size 4 at 0x7b6800032338 by thread T4 (mutexes: write M261):
> 71: #0 post_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2304
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #1 poller_do_epoll
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2534
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #2 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2438
> (libqpid-proton-proactor.so.1+0x14108)
> 71: #3 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x14622)
> 71: #4 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1106
> (qdrouterd+0x4e3ebe)
> 71: #5 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x4868bd)
> 71:
> 71: Previous read of size 4 at 0x7b6800032338 by thread T2 (mutexes: write
> M2585):
> 71: #0 pni_raw_connection_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll_raw_connection.c:355
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #1 process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2230
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #2 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2419
> (libqpid-proton-proactor.so.1+0x108ec)
> 71: #3 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x14622)
> 71: #4 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1106
> (qdrouterd+0x4e3ebe)
> 71: #5 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x4868bd)
> 71:
> 71: Location is heap block of size 1536 at 0x7b6800031e00 allocated by
> thread T4:
> 71: #0 calloc (libtsan.so.0+0x32b3e)
> 71: #1 pn_raw_connection
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll_raw_connection.c:168
> (libqpid-proton-proactor.so.1+0xdf82)
> 71: #2 qdr_tcp_connection_egress
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1086
> (qdrouterd+0x448b52)
> 71: #3 qdr_tcp_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1531
> (qdrouterd+0x448e86)
> 71: #4 qdr_link_process_deliveries
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:178
> (qdrouterd+0x4c43d0)
> 71: #5 qdr_tcp_push
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1509
> (qdrouterd+0x44707c)
> 71: #6
