[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482108#comment-17482108 ] ASF GitHub Bot commented on PROTON-2487: codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6d729df) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head 6d729df differs from pull request most recent head f567038. Consider uploading reports for the commit f567038 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [cpp/include/proton/sasl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3Nhc2wuaHBw) | | | | [cpp/examples/server.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NlcnZlci5jcHA=) | | | | [cpp/include/proton/symbol.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3N5bWJvbC5ocHA=) | | | | [c/src/core/message.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9tZXNzYWdlLmM=) | | | | [c/tests/pn\_test\_proactor.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wbl90ZXN0X3Byb2FjdG9yLmhwcA==) | | | | [python/tests/proton\_tests/url.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy91cmwucHk=) | | | | [cpp/include/proton/annotation\_key.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2Fubm90YXRpb25fa2V5LmhwcA==) | | | | ... and [310
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482107#comment-17482107 ] ASF GitHub Bot commented on PROTON-2487: codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6d729df) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head 6d729df differs from pull request most recent head f567038. Consider uploading reports for the commit f567038 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [c/tools/reactor-send.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90b29scy9yZWFjdG9yLXNlbmQuYw==) | | | | [cpp/examples/multithreaded\_client\_flow\_control.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL211bHRpdGhyZWFkZWRfY2xpZW50X2Zsb3dfY29udHJvbC5jcHA=) | | | | [cpp/examples/message\_properties.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL21lc3NhZ2VfcHJvcGVydGllcy5jcHA=) | | | | [cpp/src/ssl\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zc2xfb3B0aW9ucy5jcHA=) | | | | [python/proton/\_events.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fZXZlbnRzLnB5) | | | | [build/c/src/core/memory.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvY29yZS9tZW1vcnkuYw==) | | | | [cpp/include/proton/target\_options.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3RhcmdldF9vcHRpb25zLmhwcA==) | | | | ... and [310
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6d729df) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head 6d729df differs from pull request most recent head f567038. Consider uploading reports for the commit f567038 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [cpp/include/proton/sasl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3Nhc2wuaHBw) | | | | [cpp/examples/server.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NlcnZlci5jcHA=) | | | | [cpp/include/proton/symbol.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3N5bWJvbC5ocHA=) | | | | [c/src/core/message.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9tZXNzYWdlLmM=) | | | | [c/tests/pn\_test\_proactor.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wbl90ZXN0X3Byb2FjdG9yLmhwcA==) | | | | [python/tests/proton\_tests/url.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy91cmwucHk=) | | | | [cpp/include/proton/annotation\_key.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2Fubm90YXRpb25fa2V5LmhwcA==) | | | | ... and [310 more](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#355](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6d729df) into [main](https://codecov.io/gh/apache/qpid-proton/commit/f1b9ee0fc69d0836053f1f2c03a72861f787990a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f1b9ee0) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head 6d729df differs from pull request most recent head f567038. Consider uploading reports for the commit f567038 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #355 +/- ## === + Coverage 68.21% 88.34% +20.12% === Files 367 47 -320 Lines 73205 2394-70811 === - Hits49939 2115-47824 + Misses 23266 279-22987 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | | | | [cpp/src/messaging\_adapter.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9tZXNzYWdpbmdfYWRhcHRlci5jcHA=) | | | | [cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zZW5kZXIuY3Bw) | | | | [c/tools/reactor-send.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90b29scy9yZWFjdG9yLXNlbmQuYw==) | | | | [cpp/examples/multithreaded\_client\_flow\_control.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL211bHRpdGhyZWFkZWRfY2xpZW50X2Zsb3dfY29udHJvbC5jcHA=) | | | | [cpp/examples/message\_properties.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL21lc3NhZ2VfcHJvcGVydGllcy5jcHA=) | | | | [cpp/src/ssl\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zc2xfb3B0aW9ucy5jcHA=) | | | | [python/proton/\_events.py](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fZXZlbnRzLnB5) | | | | [build/c/src/core/memory.c](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvY29yZS9tZW1vcnkuYw==) | | | | [cpp/include/proton/target\_options.hpp](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3RhcmdldF9vcHRpb25zLmhwcA==) | | | | ... and [310 more](https://codecov.io/gh/apache/qpid-proton/pull/355/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report
[jira] [Updated] (DISPATCH-2123) qd_entity_refresh_allocator race in alloc_pool.c
[ https://issues.apache.org/jira/browse/DISPATCH-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2123: - Labels: race-condition tsan (was: ) > qd_entity_refresh_allocator race in alloc_pool.c > > > Key: DISPATCH-2123 > URL: https://issues.apache.org/jira/browse/DISPATCH-2123 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: race-condition, tsan > Fix For: 1.19.0 > > > qd_entity_refresh_allocator walks all the descriptors reading their contents. > This can happen while the descriptors are being written to during normal > pool operations. > > Example: > > 5: WARNING: ThreadSanitizer: data race (pid=566878) > 65: Read of size 8 at 0x7b0c0d10 by main thread (mutexes: write M13, > write M286, write M9): > 65: #0 qd_entity_refresh_allocator > /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:700 > (libqpid-dispatch.so+0x6cdec) > 65: #1 ffi_call_unix64 (libffi.so.6+0x6aef) > 65: #2 qdr_forward_on_message > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336 > (libqpid-dispatch.so+0xe4ff5) > 65: #3 qdr_general_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:929 > (libqpid-dispatch.so+0xf83f6) > 65: #4 qd_timer_visit > /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:317 > (libqpid-dispatch.so+0x135b52) > 65: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1006 > (libqpid-dispatch.so+0x12fc8d) > 65: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x13063a) > 65: #7 qd_server_run > /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 > (libqpid-dispatch.so+0x1328de) > 65: #8 main_process > /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 > (qdrouterd+0x40271a) > 65: #9 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 > (qdrouterd+0x403557) > 65: > 65: Previous write of size 8 at 0x7b0c0d10 by thread T1 (mutexes: write > M305): > 65: #0 qd_dealloc > /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:494 > (libqpid-dispatch.so+0x6bacd) > 65: #1 free_qdr_action_t > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:33 > (libqpid-dispatch.so+0xf9a35) > 65: #2 router_core_thread > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:240 > (libqpid-dispatch.so+0xfb2ba) > 65: #3 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 65: #4 (libtsan.so.0+0x2d33f) > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2203) Alloc_pool_item_t sequence number should be atomic
[
https://issues.apache.org/jira/browse/DISPATCH-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2203:
-
Labels: race-condition (was: )
> Alloc_pool_item_t sequence number should be atomic
> --
>
> Key: DISPATCH-2203
> URL: https://issues.apache.org/jira/browse/DISPATCH-2203
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Router Node
>Affects Versions: 1.16.1
>Reporter: Charles E. Rolke
>Priority: Major
> Labels: race-condition
>
> Alloc pool uses a sequence number for safe pointer dereferencing.
> {code:java}
> Definition
> Line 55: uintmax_t sequence; // uintmax_t ensures proper alignment of
> following data
> In qd_alloc:
> Line 406: item->sequence = 0;
> in qd_dealloc:
> Line 477: item->sequence++;
> In qd_alloc_sequence:
> Line 525: reuturn item->sequence;
> {code}
> It is reasonably certain that multiple threads will be referencing the same
> item at nearly the same time. The code as shown gets flagged by tsan.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2313) TSAN data race in remote_sasl.c
[
https://issues.apache.org/jira/browse/DISPATCH-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2313:
-
Labels: race-condition tsan (was: )
> TSAN data race in remote_sasl.c
> ---
>
> Key: DISPATCH-2313
> URL: https://issues.apache.org/jira/browse/DISPATCH-2313
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 43: E SUMMARY: ThreadSanitizer: data race
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/remote_sasl.c:425
> in remote_sasl_list_mechs
> 43: E ==
> 43: E ==
> 43: E WARNING: ThreadSanitizer: data race (pid=3109)
> 43: E Read of size 1 at 0x7b041900 by main thread:
> 43: E #0 strlen (libtsan.so.0+0x5c2eb)
> 43: E #1 pn_strdup
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/core/util.c:122
> (libqpid-proton-core.so.10+0x3e2c2)
> 43: E #2 pni_post_sasl_frame
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:495
> (libqpid-proton-core.so.10+0x3e2c2)
> 43: E #3 pn_output_write_sasl
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:693
> (libqpid-proton-core.so.10+0x3e819)
> 43: E #4 transport_produce
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/core/transport.c:2820
> (libqpid-proton-core.so.10+0x2f7a4)
> 43: E #5 pn_transport_pending
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/core/transport.c:3110
> (libqpid-proton-core.so.10+0x2f7a4)
> 43: E #6 pn_connection_driver_write_buffer
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/core/connection_driver.c:112
> (libqpid-proton-core.so.10+0x24d5d)
> 43: E #7 ensure_wbuf
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:827
> (libqpid-proton-proactor.so.1+0x8ece)
> 43: E #8 write_flush
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1074
> (libqpid-proton-proactor.so.1+0x8ece)
> 43: E #9 pconnection_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1243
> (libqpid-proton-proactor.so.1+0xaa8c)
> 43: E #10 process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2209
> (libqpid-proton-proactor.so.1+0x106a6)
> 43: E #11 next_event_batch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2419
> (libqpid-proton-proactor.so.1+0x106a6)
> 43: E #12 pn_proactor_wait
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2650
> (libqpid-proton-proactor.so.1+0x145b2)
> 43: E #13 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1118
> (qdrouterd+0x4dadb9)
> 43: E #14 qd_server_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1527
> (qdrouterd+0x4dba5c)
> 43: E #15 main_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x426e5c)
> 43: E #16 main
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x42626c)
> 43: E
> 43: E Previous write of size 8 at 0x7b041900 by thread T2:
> 43: E #0 malloc (libtsan.so.0+0x32919)
> 43: E #1 strdup (libc.so.6+0x9ffbe)
> 43: E #2 qd_strdup
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/include/qpid/dispatch/ctools.h:266
> (qdrouterd+0x480647)
> 43: E #3 remote_sasl_process_mechanisms
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/remote_sasl.c:378
> (qdrouterd+0x480647)
> 43: E #4 pni_sasl_impl_process_mechanisms
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:239
> (libqpid-proton-core.so.10+0x402eb)
> 43: E #5 pn_do_mechanisms
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:956
> (libqpid-proton-core.so.10+0x402eb)
> 43: E #6 pni_dispatch_action
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/core/dispatcher.c:75
> (libqpid-proton-core.so.10+0x221f8)
> 43: E #7 pni_dispatch_frame
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/core/dispatcher.c:116
> (libqpid-proton-core.so.10+0x221f8)
> 43: E #8 pn_dispatcher_input
>
[jira] [Updated] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2314:
-
Labels: race-condition tsan (was: )
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Thread T4 (tid=2385, running) created by main thread at:
> 21: E #0 pthread_create (libtsan.so.0+0x5bef5)
> 21: E #1 sys_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x481a9c)
> 21: E #2 qd_server_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1525
> (qdrouterd+0x4dba3c)
>
[jira] [Updated] (DISPATCH-2315) TSAN data race in qdr_connection_process
[
https://issues.apache.org/jira/browse/DISPATCH-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2315:
-
Labels: race-condition tsan (was: )
> TSAN data race in qdr_connection_process
>
>
> Key: DISPATCH-2315
> URL: https://issues.apache.org/jira/browse/DISPATCH-2315
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 62: ERROR
> 62:
> 62: ==
> 62: ERROR: tearDownClass (system_tests_multicast.MulticastLinearTest)
> 62: --
> 62: Traceback (most recent call last):
> 62: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 836, in tearDownClass
> 62: cls.tester.teardown()
> 62: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 779, in teardown
> 62: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 62: RuntimeError: Errors during teardown:
> 62:
> 62: Process 16478 error: exit code 66, expected 0
> 62: qdrouterd -c INT.B.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_multicast/MulticastLinearTest/setUpClass/INT.B-2.cmd
> 62:
> 62: ==
> 62: WARNING: ThreadSanitizer: data race (pid=16478)
> 62: Read of size 1 at 0x7b44000213d4 by thread T2:
> 62: #0 qdr_connection_process
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:405
> (qdrouterd+0x9d9c6)
> 62: #1 AMQP_writable_conn_handler
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:299
> (qdrouterd+0xdbb81)
> 62: #2 writable_handler
> /home/travis/build/apache/qpid-dispatch/src/container.c:388
> (qdrouterd+0x662eb)
> 62: #3 qd_conn_event_batch_complete
> /home/travis/build/apache/qpid-dispatch/src/container.c:478
> (qdrouterd+0x6769b)
> 62: #4 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1149 (qdrouterd+0xe733e)
> 62: #5 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8c441)
> 62:
> 62: Previous write of size 1 at 0x7b44000213d4 by thread T1:
> 62: #0 qdr_delivery_mcast_outbound_settled_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:889
> (qdrouterd+0xab913)
> 62: #1 qdr_delivery_mcast_outbound_update_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:1020
> (qdrouterd+0xab913)
> 62: #2 qdr_update_delivery_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:680
> (qdrouterd+0xac615)
> 62: #3 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0xc0fe0)
> 62: #4 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8c441)
> 62:
> 62: Location is heap block of size 320 at 0x7b4400021340 allocated by main
> thread:
> 62: #0 posix_memalign
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:835
> (libtsan.so.0+0x3046d)
> 62: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x54d24)
> 62: #2 new_qdr_delivery_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0xa8442)
> 62: #3 qdr_link_deliver_to
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:99
> (qdrouterd+0xc6ecd)
> 62: #4 AMQP_rx_handler
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:827
> (qdrouterd+0xdf0cf)
> 62: #5 do_receive
> /home/travis/build/apache/qpid-dispatch/src/container.c:219
> (qdrouterd+0x69b54)
> 62: #6 qd_container_handle_event
> /home/travis/build/apache/qpid-dispatch/src/container.c:734
> (qdrouterd+0x69b54)
> 62: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1108
> (qdrouterd+0xe57a9)
> 62: #8 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1133 (qdrouterd+0xe726c)
> 62: #9 qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1527 (qdrouterd+0xe7e6f)
> 62: #10 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x2dda7)
> 62: #11 main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2d092)
> 62:
> 62: Thread T2 (tid=16481, running) created by main thread at:
> 62: #0 pthread_create
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:962
> (libtsan.so.0+0x5ea79)
> 62: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
>
[jira] [Commented] (DISPATCH-2316) Py_True/Py_False is not increfed, causing crash in policy tests with libpythond (debug python library)
[ https://issues.apache.org/jira/browse/DISPATCH-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482021#comment-17482021 ] ASF GitHub Bot commented on DISPATCH-2316: -- codecov-commenter commented on pull request #1496: URL: https://github.com/apache/qpid-dispatch/pull/1496#issuecomment-1021469542 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1496](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1ada16b) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2d1a39e3dfaad5863bab11cfa2e1ac1bc69d75f2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2d1a39e) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1496 +/- ## == - Coverage 84.88% 84.87% -0.01% == Files 116 116 Lines 2860928610 +1 == Hits2428424284 - Misses 4325 4326 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.49% <100.00%> (+0.06%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.86% <0.00%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.86% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.14% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.42% <0.00%> (+0.21%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `86.01% <0.00%> (+0.27%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `94.45% <0.00%> (+0.73%)` | :arrow_up: | --
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1496: DISPATCH-2316 Py_INCREF usage of Py_True/Py_False to prevent crashes
codecov-commenter commented on pull request #1496: URL: https://github.com/apache/qpid-dispatch/pull/1496#issuecomment-1021469542 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1496](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1ada16b) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2d1a39e3dfaad5863bab11cfa2e1ac1bc69d75f2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2d1a39e) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1496 +/- ## == - Coverage 84.88% 84.87% -0.01% == Files 116 116 Lines 2860928610 +1 == Hits2428424284 - Misses 4325 4326 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.49% <100.00%> (+0.06%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.86% <0.00%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.86% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.14% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.42% <0.00%> (+0.21%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `86.01% <0.00%> (+0.27%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1496/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `94.45% <0.00%> (+0.73%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1496?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click
[jira] [Commented] (PROTON-1890) [c++] implement idle_timeout and heartbeats
[ https://issues.apache.org/jira/browse/PROTON-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482020#comment-17482020 ] Praveen Bodke commented on PROTON-1890: --- FYI, we are able to reproduce the issue with 0.36 version too. > [c++] implement idle_timeout and heartbeats > --- > > Key: PROTON-1890 > URL: https://issues.apache.org/jira/browse/PROTON-1890 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-0.16.0 >Reporter: Praveen Bodke >Assignee: Clifford Jansen >Priority: Major > Attachments: PROTON-1890.zip, examples.diff > > > This is similar issue reported in PROTON-1782 for ruby. > We are facing this issue in cpp binding and i am able to reproduce the issue > with scheduled_send_03.cpp example. The test scenario is to drop all the > packets from both the interfaces after the successful connection. The only > change i made to this example is to send messages continuously inside the > send() method. The other end is detecting the error as it is sending the > empty frames and no response is heard. > The proton is not sending the heartbeat messages (empty frames) as the sender > is busy in sending the data frames. Is it not necessary to send empty frames > even if the data frames are sent? > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2144) Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called without holding the GIL
[ https://issues.apache.org/jira/browse/DISPATCH-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482018#comment-17482018 ] ASF GitHub Bot commented on DISPATCH-2144: -- codecov-commenter commented on pull request #1495: URL: https://github.com/apache/qpid-dispatch/pull/1495#issuecomment-1021466128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1495](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8150ced) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main#1495 +/- ## === Coverage 84.86% 84.87% === Files 116 116 Lines 2864428612 -32 === - Hits2431024285 -25 + Misses 4334 4327-7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.55% <100.00%> (+0.12%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.40% <100.00%> (+0.02%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.86% <0.00%> (-0.85%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.18% <0.00%> (-0.84%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.74%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.14% <0.00%> (-0.29%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRhaW5lci5j) | `84.46% <0.00%> (-0.17%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.86% <0.00%> (+0.21%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `88.76% <0.00%> (+1.28%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). >
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1495: DISPATCH-2144 Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called without holding the GIL
codecov-commenter commented on pull request #1495: URL: https://github.com/apache/qpid-dispatch/pull/1495#issuecomment-1021466128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1495](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8150ced) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main#1495 +/- ## === Coverage 84.86% 84.87% === Files 116 116 Lines 2864428612 -32 === - Hits2431024285 -25 + Misses 4334 4327-7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.55% <100.00%> (+0.12%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.40% <100.00%> (+0.02%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.86% <0.00%> (-0.85%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.18% <0.00%> (-0.84%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.74%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.14% <0.00%> (-0.29%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRhaW5lci5j) | `84.46% <0.00%> (-0.17%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.86% <0.00%> (+0.21%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1495/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `88.76% <0.00%> (+1.28%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1495?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing
[GitHub] [qpid-dispatch] kgiusti merged pull request #1493: DISPATCH-2309: Ensure rx message validation succeeds before forwarding
kgiusti merged pull request #1493: URL: https://github.com/apache/qpid-dispatch/pull/1493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2309) Message body validation can succeed without validating the actual message body
[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481974#comment-17481974 ] ASF GitHub Bot commented on DISPATCH-2309: -- kgiusti merged pull request #1493: URL: https://github.com/apache/qpid-dispatch/pull/1493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Message body validation can succeed without validating the actual message body > -- > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481972#comment-17481972 ] ASF GitHub Bot commented on DISPATCH-2310: -- kgiusti closed pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1490: DISPATCH-2310: limit router identifiers to 255 characters
kgiusti closed pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481971#comment-17481971 ] ASF GitHub Bot commented on DISPATCH-848: - codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fe13407) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **increase** coverage by `0.01%`. > The diff coverage is `94.28%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1052 +/- ## == + Coverage 84.86% 84.88% +0.01% == Files 116 116 Lines 2864428635 -9 == - Hits2431024307 -3 + Misses 4334 4328 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `69.70% <90.47%> (+1.27%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `87.03% <100.00%> (+0.06%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.62% <100.00%> (-1.43%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.96% <100.00%> (+0.30%)` | :arrow_up: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `88.34% <100.00%> (+0.49%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.40% <100.00%> (+0.02%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.74%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.29% <0.00%> (-0.43%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.10% <0.00%> (-0.32%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | |
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fe13407) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **increase** coverage by `0.01%`. > The diff coverage is `94.28%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1052 +/- ## == + Coverage 84.86% 84.88% +0.01% == Files 116 116 Lines 2864428635 -9 == - Hits2431024307 -3 + Misses 4334 4328 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `69.70% <90.47%> (+1.27%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `87.03% <100.00%> (+0.06%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.62% <100.00%> (-1.43%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.96% <100.00%> (+0.30%)` | :arrow_up: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `88.34% <100.00%> (+0.49%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.40% <100.00%> (+0.02%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.74%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.29% <0.00%> (-0.43%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.10% <0.00%> (-0.32%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). >
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481945#comment-17481945 ] ASF GitHub Bot commented on PROTON-2487: codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] Implement distributed tracing > --- > > Key: PROTON-2487 > URL: https://issues.apache.org/jira/browse/PROTON-2487 > Project: Qpid Proton > Issue Type: New Feature > Components: cpp-binding >Reporter: Rakhi Kumari >Assignee: Rakhi Kumari >Priority: Major > Fix For: proton-c-0.37.0 > > > Implement distributed tracing using opentelemetry. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481942#comment-17481942 ] ASF GitHub Bot commented on DISPATCH-2310: -- kgiusti commented on pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490#issuecomment-1020399138 Closed in deference to tross' node id validation fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1490: DISPATCH-2310: limit router identifiers to 255 characters
kgiusti commented on pull request #1490: URL: https://github.com/apache/qpid-dispatch/pull/1490#issuecomment-1020399138 Closed in deference to tross' node id validation fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[
https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481941#comment-17481941
]
ASF GitHub Bot commented on DISPATCH-848:
-
jiridanek commented on pull request #1052:
URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1021306687
Created spinoff PRs https://github.com/apache/qpid-dispatch/pull/1495 and
https://github.com/apache/qpid-dispatch/pull/1496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in
> router_core/route_tables.c:149
>
>
> Key: DISPATCH-848
> URL: https://issues.apache.org/jira/browse/DISPATCH-848
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.1.0
> Environment: Git tip of Proton and Dtspatch, commit hashes follow
> {noformat}
> commit aece4ad2f4e4eb2d141020c59c393a30a79f53a9 (upstream/master)
> Author: Andrew Stitcher
> PROTON-1609: Fix C++ example flags
> {noformat}
> {noformat}
> commit 18c5f8d6293de4227c8c17ef08675cb4eaef689c (HEAD -> master,
> upstream/master)
> Author: Ganesh Murthy
> NO-JIRA - Removed accidental printf inclusion
> {noformat}
>Reporter: Jiri Daněk
>Priority: Minor
> Labels: memory-bug
> Fix For: Backlog
>
> Attachments: LSan.supp
>
>
> Compile Proton and Dispatch with the Address Sanitizer option (c.f.
> DISPATCH-809) and run ctest
> {noformat}
> # proton
> cmake .. -DBUILD_GO=OFF -DENABLE_SANITIZERS=ON
> -DCMAKE_INSTALL_PREFIX=../install_asan -DCMAKE_BUILD_TYPE=Release -GNinja
> {noformat}
> {noformat}
> # dispatch
> cmake .. -DUSE_SANITIZERS=ON
> -DProton_DIR=`pwd`/../../qpid-proton/install_asan/lib64/cmake/Proton/
> -DCMAKE_BUILD_TYPE=Release -GNinja
> LD_PRELOAD=/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so
> ASAN_OPTIONS=symbolize=1,color=always
> LSAN_OPTIONS=suppressions=`pwd`/../../qpid-proton/LSan.supp
> PYTHONPATH=`pwd`/../../qpid-proton/install_asan/lib64/proton/bindings/python
> LD_LIBRARY_PATH=`pwd`/../../qpid-proton/install_asan/lib64 ctest -VV
> {noformat}
> {noformat}
> [...]
> 9: Test Case parse_tree_tests.test_matches: PASS
> 9: Test Case parse_tree_tests.test_multiple_matches: PASS
> 9:
> 9: =
> 9: ==25904==ERROR: LeakSanitizer: detected memory leaks
> 9:
> 9: Direct leak of 48 byte(s) in 1 object(s) allocated from:
> 9: #0 0x7fb5442cb050 in __interceptor_malloc
> (/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so+0xd9050)
> 9: #1 0x7fb543dd94fe in qdr_core_subscribe
> ../src/router_core/route_tables.c:149
> 9: #2 0x7fb543d89ff0 in IoAdapter_init ../src/python_embedded.c:548
> 9: #3 0x7fb542ba8ecd in type_call
> (/nix/store/1snk2wkpv97an87pk1842fgskl1vqhkr-python-2.7.14/lib/libpython2.7.so.1.0+0x9fecd)
> 9:
> 9: -
> 9: Suppressions used:
> 9: count bytes template
> 9:13102021760 dictresize
> 9: 204 188272 _PyObject_GC_Malloc
> 9: 45 39369 PyString_FromStringAndSize
> 9: 308 15056 list_resize
> 9: 11 9784 PyString_FromString
> 9: 2 1280 _PyObject_GC_Resize
> 9:1035 24104 PyList_New
> 9: 14672 s_init
> 9: 1 32 PyThread_allocate_lock
> 9: 11 11097 type_new
> 9: 3 3984 unicode_resize
> 9: 179 204712 _PyUnicode_New.part.8
> 9: 11 8028 PyObject_Realloc
> 9: 37120 _ctypes_alloc_format_string
> 9: 3 24576 set_table_resize
> 9: -
> 9:
> 9: SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s).
> 9/36 Test #9: unit_tests ***Failed0.21
> sec
> {noformat}
> The relevant functions are
> {code}
> static int IoAdapter_init(IoAdapter *self, PyObject *args, PyObject *kwds)
> {
> PyObject *addr;
> char aclass= 'L';
> char phase = '0';
> int treatment = QD_TREATMENT_ANYCAST_CLOSEST;
> if (!PyArg_ParseTuple(args, "OO|cci", >handler, , ,
> , ))
> return -1;
> if (!PyCallable_Check(self->handler)) {
> PyErr_SetString(PyExc_TypeError, "IoAdapter.__init__ handler is not
> callable");
> return -1;
> }
> if (treatment == QD_TREATMENT_ANYCAST_BALANCED) {
>
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
jiridanek commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1021306687 Created spinoff PRs https://github.com/apache/qpid-dispatch/pull/1495 and https://github.com/apache/qpid-dispatch/pull/1496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481916#comment-17481916 ] ASF GitHub Bot commented on DISPATCH-848: - codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fe13407) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **increase** coverage by `0.01%`. > The diff coverage is `94.28%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1052 +/- ## == + Coverage 84.86% 84.88% +0.01% == Files 116 116 Lines 2864428635 -9 == - Hits2431024307 -3 + Misses 4334 4328 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `69.70% <90.47%> (+1.27%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `87.03% <100.00%> (+0.06%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.62% <100.00%> (-1.43%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.96% <100.00%> (+0.30%)` | :arrow_up: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `88.34% <100.00%> (+0.49%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.40% <100.00%> (+0.02%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.74%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.29% <0.00%> (-0.43%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.10% <0.00%> (-0.32%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | |
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fe13407) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/8147b62df40a0167af489750b7f6d6bd3f135696?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8147b62) will **increase** coverage by `0.01%`. > The diff coverage is `94.28%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1052 +/- ## == + Coverage 84.86% 84.88% +0.01% == Files 116 116 Lines 2864428635 -9 == - Hits2431024307 -3 + Misses 4334 4328 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `69.70% <90.47%> (+1.27%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `87.03% <100.00%> (+0.06%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.62% <100.00%> (-1.43%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.96% <100.00%> (+0.30%)` | :arrow_up: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `88.34% <100.00%> (+0.49%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.40% <100.00%> (+0.02%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.74%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.29% <0.00%> (-0.43%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.10% <0.00%> (-0.32%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). >
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[
https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481897#comment-17481897
]
ASF GitHub Bot commented on DISPATCH-848:
-
jiridanek commented on pull request #1052:
URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1021306687
Created spinoff PRs https://github.com/apache/qpid-dispatch/pull/1495 and
https://github.com/apache/qpid-dispatch/pull/1496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in
> router_core/route_tables.c:149
>
>
> Key: DISPATCH-848
> URL: https://issues.apache.org/jira/browse/DISPATCH-848
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.1.0
> Environment: Git tip of Proton and Dtspatch, commit hashes follow
> {noformat}
> commit aece4ad2f4e4eb2d141020c59c393a30a79f53a9 (upstream/master)
> Author: Andrew Stitcher
> PROTON-1609: Fix C++ example flags
> {noformat}
> {noformat}
> commit 18c5f8d6293de4227c8c17ef08675cb4eaef689c (HEAD -> master,
> upstream/master)
> Author: Ganesh Murthy
> NO-JIRA - Removed accidental printf inclusion
> {noformat}
>Reporter: Jiri Daněk
>Priority: Minor
> Labels: memory-bug
> Fix For: Backlog
>
> Attachments: LSan.supp
>
>
> Compile Proton and Dispatch with the Address Sanitizer option (c.f.
> DISPATCH-809) and run ctest
> {noformat}
> # proton
> cmake .. -DBUILD_GO=OFF -DENABLE_SANITIZERS=ON
> -DCMAKE_INSTALL_PREFIX=../install_asan -DCMAKE_BUILD_TYPE=Release -GNinja
> {noformat}
> {noformat}
> # dispatch
> cmake .. -DUSE_SANITIZERS=ON
> -DProton_DIR=`pwd`/../../qpid-proton/install_asan/lib64/cmake/Proton/
> -DCMAKE_BUILD_TYPE=Release -GNinja
> LD_PRELOAD=/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so
> ASAN_OPTIONS=symbolize=1,color=always
> LSAN_OPTIONS=suppressions=`pwd`/../../qpid-proton/LSan.supp
> PYTHONPATH=`pwd`/../../qpid-proton/install_asan/lib64/proton/bindings/python
> LD_LIBRARY_PATH=`pwd`/../../qpid-proton/install_asan/lib64 ctest -VV
> {noformat}
> {noformat}
> [...]
> 9: Test Case parse_tree_tests.test_matches: PASS
> 9: Test Case parse_tree_tests.test_multiple_matches: PASS
> 9:
> 9: =
> 9: ==25904==ERROR: LeakSanitizer: detected memory leaks
> 9:
> 9: Direct leak of 48 byte(s) in 1 object(s) allocated from:
> 9: #0 0x7fb5442cb050 in __interceptor_malloc
> (/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so+0xd9050)
> 9: #1 0x7fb543dd94fe in qdr_core_subscribe
> ../src/router_core/route_tables.c:149
> 9: #2 0x7fb543d89ff0 in IoAdapter_init ../src/python_embedded.c:548
> 9: #3 0x7fb542ba8ecd in type_call
> (/nix/store/1snk2wkpv97an87pk1842fgskl1vqhkr-python-2.7.14/lib/libpython2.7.so.1.0+0x9fecd)
> 9:
> 9: -
> 9: Suppressions used:
> 9: count bytes template
> 9:13102021760 dictresize
> 9: 204 188272 _PyObject_GC_Malloc
> 9: 45 39369 PyString_FromStringAndSize
> 9: 308 15056 list_resize
> 9: 11 9784 PyString_FromString
> 9: 2 1280 _PyObject_GC_Resize
> 9:1035 24104 PyList_New
> 9: 14672 s_init
> 9: 1 32 PyThread_allocate_lock
> 9: 11 11097 type_new
> 9: 3 3984 unicode_resize
> 9: 179 204712 _PyUnicode_New.part.8
> 9: 11 8028 PyObject_Realloc
> 9: 37120 _ctypes_alloc_format_string
> 9: 3 24576 set_table_resize
> 9: -
> 9:
> 9: SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s).
> 9/36 Test #9: unit_tests ***Failed0.21
> sec
> {noformat}
> The relevant functions are
> {code}
> static int IoAdapter_init(IoAdapter *self, PyObject *args, PyObject *kwds)
> {
> PyObject *addr;
> char aclass= 'L';
> char phase = '0';
> int treatment = QD_TREATMENT_ANYCAST_CLOSEST;
> if (!PyArg_ParseTuple(args, "OO|cci", >handler, , ,
> , ))
> return -1;
> if (!PyCallable_Check(self->handler)) {
> PyErr_SetString(PyExc_TypeError, "IoAdapter.__init__ handler is not
> callable");
> return -1;
> }
> if (treatment == QD_TREATMENT_ANYCAST_BALANCED) {
>
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
jiridanek commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1021306687 Created spinoff PRs https://github.com/apache/qpid-dispatch/pull/1495 and https://github.com/apache/qpid-dispatch/pull/1496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[ https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481847#comment-17481847 ] ASF GitHub Bot commented on PROTON-2487: codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] Implement distributed tracing > --- > > Key: PROTON-2487 > URL: https://issues.apache.org/jira/browse/PROTON-2487 > Project: Qpid Proton > Issue Type: New Feature > Components: cpp-binding >Reporter: Rakhi Kumari >Assignee: Rakhi Kumari >Priority: Major > Fix For: proton-c-0.37.0 > > > Implement distributed tracing using opentelemetry. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2316) Py_True/Py_False is not increfed, causing crash in policy tests with libpythond (debug python library)
[
https://issues.apache.org/jira/browse/DISPATCH-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481794#comment-17481794
]
Jiri Daněk commented on DISPATCH-2316:
--
Fixed as part of https://github.com/apache/qpid-dispatch/pull/1052. I probably
should try to merge just the specific fix without trying to fix all the issues
I am touching there.
> Py_True/Py_False is not increfed, causing crash in policy tests with
> libpythond (debug python library)
> --
>
> Key: DISPATCH-2316
> URL: https://issues.apache.org/jira/browse/DISPATCH-2316
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> Debug memory block at address p=0x8a6e80: API ''
> 0 bytes originally requested
> The 7 pad bytes at p-7 are not all FORBIDDENBYTE (0xfd):
> at p-7: 0x00 *** OUCH
> at p-6: 0x00 *** OUCH
> at p-5: 0x00 *** OUCH
> at p-4: 0x00 *** OUCH
> at p-3: 0x00 *** OUCH
> at p-2: 0x00 *** OUCH
> at p-1: 0x00 *** OUCH
> Because memory is corrupted at the start, the count of bytes requested
>may be bogus, and checking the trailing pad bytes may segfault.
> The 8 pad bytes at tail=0x8a6e80 are not all FORBIDDENBYTE (0xfd):
> at tail+0: 0x00 *** OUCH
> at tail+1: 0x00 *** OUCH
> at tail+2: 0x00 *** OUCH
> at tail+3: 0x00 *** OUCH
> at tail+4: 0x00 *** OUCH
> at tail+5: 0x00 *** OUCH
> at tail+6: 0x00 *** OUCH
> at tail+7: 0x00 *** OUCH
> Enable tracemalloc to get the memory block allocation traceback
> Fatal Python error: _PyMem_DebugRawFree: bad ID: Allocated using API '',
> verified using API 'o'
> Python runtime state: finalizing (tstate=0x01f43c50)
> Current thread 0x7f3f562fa740 (most recent call first):
> Garbage-collecting
>
> Abandon (core dumped)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2144) Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called without holding the GIL
[
https://issues.apache.org/jira/browse/DISPATCH-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481793#comment-17481793
]
Jiri Daněk commented on DISPATCH-2144:
--
I think I have the fix as a subset of
https://github.com/apache/qpid-dispatch/pull/1052. It should be possible to
merge only that. As long as I don't try to fix the leaks, I am not introducing
shutdown crashes.
The idea of the fix is to scrupulously acquire the GIL; the current code has
its own Python lock; that is a good start but using the Python one seems more
sensible, also because Python can check for you that you hold it.
> Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called
> without holding the GIL
> --
>
> Key: DISPATCH-2144
> URL: https://issues.apache.org/jira/browse/DISPATCH-2144
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> To reproduce, install python3-debug on Fedora, then use it to build and run
> Dispatch
> https://github.com/jiridanek/qpid-dispatch/runs/2629007367?check_suite_focus=true#step:25:7044
> {noformat}
> 25: Router QDR.Policy output file:
> 25:
> 25:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python/qpid_dispatch_internal/policy/policy_util.py:65:
> ResourceWarning: unclosed family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
> laddr=('::', 0, 0, 0)>
> 25: if is_ipv6_enabled():
> 25: ResourceWarning: Enable tracemalloc to get the object allocation traceback
> 25: Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called
> without holding the GIL
> 25: Python runtime state: initialized
> 25:
> 25: Thread 0x7f0e8fffcec0 (most recent call first):
> 25:
> {noformat}
> Unrelated error in the same log that I noticed at random
> {noformat}
> 23: E /builddir/build/BUILD/Python-3.9.5/Modules/gcmodule.c:114:
> gc_decref: Assertion "gc_get_refs(g) > 0" failed: refcount is too small
> 23: E Enable tracemalloc to get the memory block allocation
> traceback
> 23: E
> 23: E object address : 0x7fd3e1b90cd0
> 23: E object refcount : 117
> 23: E object type : 0x7b695c30
> 23: E object type name: Agent
> 23: E object repr :
>
> 23: E
> 23: E Fatal Python error: _PyObject_AssertFailed:
> _PyObject_AssertFailed
> 23: E Python runtime state: initialized
> 23: E
> 23: E Current thread 0x7fd3e39e3ec0 (most recent call first):
> 23: E
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
