[jira] [Commented] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487819#comment-17487819 ] ASF GitHub Bot commented on DISPATCH-2310: -- codecov-commenter commented on pull request #1511: URL: https://github.com/apache/qpid-dispatch/pull/1511#issuecomment-1030988941 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1511](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fd911d3) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/f9a1639edef75d15a6ef5d8e4b466fda900a6a8a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f9a1639) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1511 +/- ## == + Coverage 84.86% 84.89% +0.03% == Files 117 117 Lines 2864328642 -1 == + Hits2430724316 +9 + Misses 4336 4326 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `81.84% <0.00%> (-0.56%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.56%)` | :arrow_down: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `79.53% <0.00%> (-0.47%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.94% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.42% <0.00%> (+0.21%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.14% <0.00%> (+1.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1511: DISPATCH-2310: limit router identifiers to 255 characters
codecov-commenter commented on pull request #1511: URL: https://github.com/apache/qpid-dispatch/pull/1511#issuecomment-1030988941 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1511](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fd911d3) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/f9a1639edef75d15a6ef5d8e4b466fda900a6a8a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f9a1639) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1511 +/- ## == + Coverage 84.86% 84.89% +0.03% == Files 117 117 Lines 2864328642 -1 == + Hits2430724316 +9 + Misses 4336 4326 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `81.84% <0.00%> (-0.56%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.56%)` | :arrow_down: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `79.53% <0.00%> (-0.47%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.94% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.42% <0.00%> (+0.21%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1511/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.14% <0.00%> (+1.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f9a1639...fd911d3](https://codecov.io/gh/apache/qpid-dispatch/pull/1511?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment
[jira] [Commented] (DISPATCH-2310) Enforce a limit to the length of a router's id
[ https://issues.apache.org/jira/browse/DISPATCH-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487815#comment-17487815 ] ASF GitHub Bot commented on DISPATCH-2310: -- kgiusti opened a new pull request #1511: URL: https://github.com/apache/qpid-dispatch/pull/1511 This pulls over Ted's router name fix from skupper-router -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce a limit to the length of a router's id > -- > > Key: DISPATCH-2310 > URL: https://issues.apache.org/jira/browse/DISPATCH-2310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Do not allow router id names of > 255 characters. > 255 characters should be enough for everybody. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1511: DISPATCH-2310: limit router identifiers to 255 characters
kgiusti opened a new pull request #1511: URL: https://github.com/apache/qpid-dispatch/pull/1511 This pulls over Ted's router name fix from skupper-router -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1510: NO-JIRA: Travis CI update:
codecov-commenter commented on pull request #1510: URL: https://github.com/apache/qpid-dispatch/pull/1510#issuecomment-1030957190 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1510?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1510](https://codecov.io/gh/apache/qpid-dispatch/pull/1510?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94b3671) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/6d03790f6a47032bff4f751d57b2035349056b7c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6d03790) will **decrease** coverage by `1.51%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1510?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1510 +/- ## == - Coverage 84.94% 83.42% -1.52% == Files 116 118 +2 Lines 2864030084+1444 == + Hits2432725097 +770 - Misses 4313 4987 +674 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1510?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [include/qpid/dispatch/ctools.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2N0b29scy5o) | `61.11% <0.00%> (-8.89%)` | :arrow_down: | | [tests/tool\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvdG9vbF90ZXN0LmM=) | `77.14% <0.00%> (-7.70%)` | :arrow_down: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `75.41% <0.00%> (-7.43%)` | :arrow_down: | | [include/qpid/dispatch/buffer.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2J1ZmZlci5o) | `94.73% <0.00%> (-5.27%)` | :arrow_down: | | [src/python\_utils.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl91dGlscy5j) | `83.33% <0.00%> (-3.04%)` | :arrow_down: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `86.04% <0.00%> (-3.01%)` | :arrow_down: | | [router/src/main.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cm91dGVyL3NyYy9tYWluLmM=) | `67.30% <0.00%> (-2.70%)` | :arrow_down: | | [...uter\_core/modules/edge\_router/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvY29ubmVjdGlvbl9tYW5hZ2VyLmM=) | `94.28% <0.00%> (-2.59%)` | :arrow_down: | | [src/entity.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2VudGl0eS5j) | `58.01% <0.00%> (-2.42%)` | :arrow_down: | | [tests/proton\_utils\_tests.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1510/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdHMvcHJvdG9uX3V0aWxzX3Rlc3RzLmM=) | `72.72% <0.00%> (-2.28%)` | :arrow_down: | | ... and [99
[jira] [Resolved] (DISPATCH-2132) core->uptime_ticks races
[ https://issues.apache.org/jira/browse/DISPATCH-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2132. -- Resolution: Fixed > core->uptime_ticks races > > > Key: DISPATCH-2132 > URL: https://issues.apache.org/jira/browse/DISPATCH-2132 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: race-condition, tsan > Fix For: 1.19.0 > > > TSAN flags many races while accessing core->uptime_ticks. Likely harmless. > Replace core->uptime_ticks with atomic integer. > > Example: > 30: WARNING: ThreadSanitizer: data race (pid=632294) > 30: Read of size 4 at 0x7b64000352c8 by thread T3: > 30: #0 qdr_link_first_attach > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:608 > (libqpid-dispatch.so+0xc5ee8) > 30: #1 AMQP_incoming_link_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:985 > (libqpid-dispatch.so+0x1247f4) > 30: #2 setup_incoming_link > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:205 > (libqpid-dispatch.so+0x7a7f8) > 30: #3 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:670 > (libqpid-dispatch.so+0x7c935) > 30: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x130537) > 30: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x13063a) > 30: #6 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 30: #7 (libtsan.so.0+0x2d33f) > 30: > 30: Previous write of size 4 at 0x7b64000352c8 by thread T1: > 30: #0 qdr_process_tick_CT > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_timer.c:111 > (libqpid-dispatch.so+0x10a860) > 30: #1 router_core_thread > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 > (libqpid-dispatch.so+0xfb2ae) > 30: #2 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 30: #3 (libtsan.so.0+0x2d33f) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2132) core->uptime_ticks races
[ https://issues.apache.org/jira/browse/DISPATCH-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487805#comment-17487805 ] ASF GitHub Bot commented on DISPATCH-2132: -- asfgit closed pull request #1501: URL: https://github.com/apache/qpid-dispatch/pull/1501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > core->uptime_ticks races > > > Key: DISPATCH-2132 > URL: https://issues.apache.org/jira/browse/DISPATCH-2132 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: race-condition, tsan > Fix For: 1.19.0 > > > TSAN flags many races while accessing core->uptime_ticks. Likely harmless. > Replace core->uptime_ticks with atomic integer. > > Example: > 30: WARNING: ThreadSanitizer: data race (pid=632294) > 30: Read of size 4 at 0x7b64000352c8 by thread T3: > 30: #0 qdr_link_first_attach > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:608 > (libqpid-dispatch.so+0xc5ee8) > 30: #1 AMQP_incoming_link_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:985 > (libqpid-dispatch.so+0x1247f4) > 30: #2 setup_incoming_link > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:205 > (libqpid-dispatch.so+0x7a7f8) > 30: #3 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:670 > (libqpid-dispatch.so+0x7c935) > 30: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x130537) > 30: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x13063a) > 30: #6 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 30: #7 (libtsan.so.0+0x2d33f) > 30: > 30: Previous write of size 4 at 0x7b64000352c8 by thread T1: > 30: #0 qdr_process_tick_CT > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_timer.c:111 > (libqpid-dispatch.so+0x10a860) > 30: #1 router_core_thread > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 > (libqpid-dispatch.so+0xfb2ae) > 30: #2 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 30: #3 (libtsan.so.0+0x2d33f) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1501: DISPATCH-2132: atomic access to core uptime counter
asfgit closed pull request #1501: URL: https://github.com/apache/qpid-dispatch/pull/1501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2132) core->uptime_ticks races
[ https://issues.apache.org/jira/browse/DISPATCH-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487804#comment-17487804 ] ASF subversion and git services commented on DISPATCH-2132: --- Commit f9a1639edef75d15a6ef5d8e4b466fda900a6a8a in qpid-dispatch's branch refs/heads/main from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f9a1639 ] DISPATCH-2132: atomic access to core uptime counter This closes #1501 > core->uptime_ticks races > > > Key: DISPATCH-2132 > URL: https://issues.apache.org/jira/browse/DISPATCH-2132 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: race-condition, tsan > Fix For: 1.19.0 > > > TSAN flags many races while accessing core->uptime_ticks. Likely harmless. > Replace core->uptime_ticks with atomic integer. > > Example: > 30: WARNING: ThreadSanitizer: data race (pid=632294) > 30: Read of size 4 at 0x7b64000352c8 by thread T3: > 30: #0 qdr_link_first_attach > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:608 > (libqpid-dispatch.so+0xc5ee8) > 30: #1 AMQP_incoming_link_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:985 > (libqpid-dispatch.so+0x1247f4) > 30: #2 setup_incoming_link > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:205 > (libqpid-dispatch.so+0x7a7f8) > 30: #3 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:670 > (libqpid-dispatch.so+0x7c935) > 30: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x130537) > 30: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x13063a) > 30: #6 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 30: #7 (libtsan.so.0+0x2d33f) > 30: > 30: Previous write of size 4 at 0x7b64000352c8 by thread T1: > 30: #0 qdr_process_tick_CT > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_timer.c:111 > (libqpid-dispatch.so+0x10a860) > 30: #1 router_core_thread > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 > (libqpid-dispatch.so+0xfb2ae) > 30: #2 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 30: #3 (libtsan.so.0+0x2d33f) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
