[jira] [Updated] (PROTON-2508) Visual Studio 2017 seems to optimise proton-core library wrongly
[ https://issues.apache.org/jira/browse/PROTON-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2508: Labels: release-notes (was: ) > Visual Studio 2017 seems to optimise proton-core library wrongly > > > Key: PROTON-2508 > URL: https://issues.apache.org/jira/browse/PROTON-2508 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.36.0, proton-c-0.37.0 > Environment: Windows; Visual Studio 2017 with RelWithDebInfo, Release > build configurations >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Labels: release-notes > > It appears that if you build proton with VS2017 in the RelWithDebInfo or > Release configure then a number of the tests fail specifically the > cpp-container_test fails and also hangs. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2508) Visual Studio 2017 seems to optimise proton-core library wrongly
[ https://issues.apache.org/jira/browse/PROTON-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2508. - Resolution: Workaround This bug is worked around, but needs to be release noted so that users can also workaround the Visual Studio bug > Visual Studio 2017 seems to optimise proton-core library wrongly > > > Key: PROTON-2508 > URL: https://issues.apache.org/jira/browse/PROTON-2508 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.36.0, proton-c-0.37.0 > Environment: Windows; Visual Studio 2017 with RelWithDebInfo, Release > build configurations >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > It appears that if you build proton with VS2017 in the RelWithDebInfo or > Release configure then a number of the tests fail specifically the > cpp-container_test fails and also hangs. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2508) Visual Studio 2017 seems to optimise proton-core library wrongly
[ https://issues.apache.org/jira/browse/PROTON-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497893#comment-17497893 ] ASF subversion and git services commented on PROTON-2508: - Commit 38b1d89031322410a42ed17876021ef6bda78ccc in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=38b1d89 ] PROTON-2508: Workaround Visual Studio 2017 optimizer bug It seems that the bug does not occur in MinSizeRel (or Debug) build configurations. > Visual Studio 2017 seems to optimise proton-core library wrongly > > > Key: PROTON-2508 > URL: https://issues.apache.org/jira/browse/PROTON-2508 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.36.0, proton-c-0.37.0 > Environment: Windows; Visual Studio 2017 with RelWithDebInfo, Release > build configurations >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > It appears that if you build proton with VS2017 in the RelWithDebInfo or > Release configure then a number of the tests fail specifically the > cpp-container_test fails and also hangs. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2508) Visual Studio 2017 seems to optimise proton-core library wrongly
[ https://issues.apache.org/jira/browse/PROTON-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497787#comment-17497787 ] Andrew Stitcher commented on PROTON-2508: - The compiler bug doesn't seem to happen using Debug or MinSizeRel build configuration so these can be used as workarounds to the bug. We should set up our VS2017 CI instances to use one of these flags for as long as we support this compiler. We should also disable the python tox test as it will use this compiler with the Release build setting when it compiles the python extension. This will also means that we can't support the python extension on any windows machine that will install the extension using the VS2017 compiler. > Visual Studio 2017 seems to optimise proton-core library wrongly > > > Key: PROTON-2508 > URL: https://issues.apache.org/jira/browse/PROTON-2508 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.36.0, proton-c-0.37.0 > Environment: Windows; Visual Studio 2017 with RelWithDebInfo, Release > build configurations >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > It appears that if you build proton with VS2017 in the RelWithDebInfo or > Release configure then a number of the tests fail specifically the > cpp-container_test fails and also hangs. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-2508) Visual Studio 2017 seems to optimise proton-core library wrongly
[ https://issues.apache.org/jira/browse/PROTON-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned PROTON-2508: --- Assignee: Andrew Stitcher > Visual Studio 2017 seems to optimise proton-core library wrongly > > > Key: PROTON-2508 > URL: https://issues.apache.org/jira/browse/PROTON-2508 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.36.0, proton-c-0.37.0 > Environment: Windows; Visual Studio 2017 with RelWithDebInfo, Release > build configurations >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > It appears that if you build proton with VS2017 in the RelWithDebInfo or > Release configure then a number of the tests fail specifically the > cpp-container_test fails and also hangs. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2508) Visual Studio 2017 seems to optimise proton-core library wrongly
Andrew Stitcher created PROTON-2508: --- Summary: Visual Studio 2017 seems to optimise proton-core library wrongly Key: PROTON-2508 URL: https://issues.apache.org/jira/browse/PROTON-2508 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: proton-c-0.36.0, proton-c-0.37.0 Environment: Windows; Visual Studio 2017 with RelWithDebInfo, Release build configurations Reporter: Andrew Stitcher It appears that if you build proton with VS2017 in the RelWithDebInfo or Release configure then a number of the tests fail specifically the cpp-container_test fails and also hangs. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2507) AMQP Test Peer can select the wrong handle for attach response
[ https://issues.apache.org/jira/browse/PROTON-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497600#comment-17497600 ] ASF subversion and git services commented on PROTON-2507: - Commit c78787c0283db0a189a2c8ddcb568d33ef0ec779 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=c78787c ] PROTON-2507 Fix test issue that can lead to CI failure > AMQP Test Peer can select the wrong handle for attach response > -- > > Key: PROTON-2507 > URL: https://issues.apache.org/jira/browse/PROTON-2507 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M4 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M5 > > > In some test scenarios the test peer will select an invalid handle for the > attach response leading to an error from the proton engine that the response > carries a handle that is already in use. This most often occurs in tests > that have delayed responses intermixed with other activity and can lead to > intermittent test failures. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-2276) The latest release of proton (pre-0.37.0) breaks scraper
[
https://issues.apache.org/jira/browse/DISPATCH-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497589#comment-17497589
]
Ganesh Murthy edited comment on DISPATCH-2276 at 2/24/22, 5:36 PM:
---
{noformat}
/test_04_scraper_tool/python3.6-1.cmd
test_04_scraper_tool
(system_tests_topology_disposition.TopologyDispositionTests) ... FAIL
==
FAIL: test_04_scraper_tool
(system_tests_topology_disposition.TopologyDispositionTests)
--
Traceback (most recent call last):
File
"/home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/system_tests_topology_disposition.py",
line 432, in test_04_scraper_tool
self.assertEqual(str(None), error)
AssertionError: 'None' != 'Process 4868 error: exit code 1, expected[1097
chars]'{noformat}
This is happening only on rhel 7
Unfortunately full traceback not available.
was (Author: ganeshmurthy):
{noformat}
/test_04_scraper_tool/python3.6-1.cmd
test_04_scraper_tool
(system_tests_topology_disposition.TopologyDispositionTests) ... FAIL
==
FAIL: test_04_scraper_tool
(system_tests_topology_disposition.TopologyDispositionTests)
--
Traceback (most recent call last):
File
"/home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/system_tests_topology_disposition.py",
line 432, in test_04_scraper_tool
self.assertEqual(str(None), error)
AssertionError: 'None' != 'Process 4868 error: exit code 1, expected[1097
chars]'{noformat}
Unfortunately full traceback not available.
> The latest release of proton (pre-0.37.0) breaks scraper
>
>
> Key: DISPATCH-2276
> URL: https://issues.apache.org/jira/browse/DISPATCH-2276
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ken Giusti
>Assignee: Charles E. Rolke
>Priority: Major
>
> The next version of proton changes the format of the message tracing log
> messages.
> Scraper needs to be updated to work with these new log formats.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2276) The latest release of proton (pre-0.37.0) breaks scraper
[
https://issues.apache.org/jira/browse/DISPATCH-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497589#comment-17497589
]
Ganesh Murthy commented on DISPATCH-2276:
-
{noformat}
/test_04_scraper_tool/python3.6-1.cmd
test_04_scraper_tool
(system_tests_topology_disposition.TopologyDispositionTests) ... FAIL
==
FAIL: test_04_scraper_tool
(system_tests_topology_disposition.TopologyDispositionTests)
--
Traceback (most recent call last):
File
"/home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/system_tests_topology_disposition.py",
line 432, in test_04_scraper_tool
self.assertEqual(str(None), error)
AssertionError: 'None' != 'Process 4868 error: exit code 1, expected[1097
chars]'{noformat}
Unfortunately full traceback not available.
> The latest release of proton (pre-0.37.0) breaks scraper
>
>
> Key: DISPATCH-2276
> URL: https://issues.apache.org/jira/browse/DISPATCH-2276
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ken Giusti
>Assignee: Charles E. Rolke
>Priority: Major
>
> The next version of proton changes the format of the message tracing log
> messages.
> Scraper needs to be updated to work with these new log formats.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2507) AMQP Test Peer can select the wrong handle for attach response
[ https://issues.apache.org/jira/browse/PROTON-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish resolved PROTON-2507. - Resolution: Fixed > AMQP Test Peer can select the wrong handle for attach response > -- > > Key: PROTON-2507 > URL: https://issues.apache.org/jira/browse/PROTON-2507 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M4 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M5 > > > In some test scenarios the test peer will select an invalid handle for the > attach response leading to an error from the proton engine that the response > carries a handle that is already in use. This most often occurs in tests > that have delayed responses intermixed with other activity and can lead to > intermittent test failures. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2507) AMQP Test Peer can select the wrong handle for attach response
[ https://issues.apache.org/jira/browse/PROTON-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497582#comment-17497582 ] ASF subversion and git services commented on PROTON-2507: - Commit 6e7ce3aa457cea6631fd8f0d4db94a6bcf47229f in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=6e7ce3a ] PROTON-2507 Test peer fix to actually select a free local channel > AMQP Test Peer can select the wrong handle for attach response > -- > > Key: PROTON-2507 > URL: https://issues.apache.org/jira/browse/PROTON-2507 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M4 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M5 > > > In some test scenarios the test peer will select an invalid handle for the > attach response leading to an error from the proton engine that the response > carries a handle that is already in use. This most often occurs in tests > that have delayed responses intermixed with other activity and can lead to > intermittent test failures. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2507) AMQP Test Peer can select the wrong handle for attach response
Timothy A. Bish created PROTON-2507: --- Summary: AMQP Test Peer can select the wrong handle for attach response Key: PROTON-2507 URL: https://issues.apache.org/jira/browse/PROTON-2507 Project: Qpid Proton Issue Type: Bug Components: protonj2 Affects Versions: protonj2-1.0.0-M4 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: protonj2-1.0.0-M5 In some test scenarios the test peer will select an invalid handle for the attach response leading to an error from the proton engine that the response carries a handle that is already in use. This most often occurs in tests that have delayed responses intermixed with other activity and can lead to intermittent test failures. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2335) Avoid use of tox to run the python linters
[ https://issues.apache.org/jira/browse/DISPATCH-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2335: Assignee: Ganesh Murthy > Avoid use of tox to run the python linters > -- > > Key: DISPATCH-2335 > URL: https://issues.apache.org/jira/browse/DISPATCH-2335 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tests >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > > Currently the CI uses python tox to run the python linters across all > versions of python installed on the current system. > This is overkill: the linters don't need to be re-run in virtual envs > multiple times - if there are syntax/linter bugs they'll show up with only > one run of the test. > Let's remove the use of tox here and simply invoke the linters directly from > Ctest. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2335) Avoid use of tox to run the python linters
Ken Giusti created DISPATCH-2335: Summary: Avoid use of tox to run the python linters Key: DISPATCH-2335 URL: https://issues.apache.org/jira/browse/DISPATCH-2335 Project: Qpid Dispatch Issue Type: Improvement Components: Tests Affects Versions: 1.18.0 Reporter: Ken Giusti Currently the CI uses python tox to run the python linters across all versions of python installed on the current system. This is overkill: the linters don't need to be re-run in virtual envs multiple times - if there are syntax/linter bugs they'll show up with only one run of the test. Let's remove the use of tox here and simply invoke the linters directly from Ctest. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2334) test_01_verify_attach failing in system_tests_one_router.py
[
https://issues.apache.org/jira/browse/DISPATCH-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2334.
-
Fix Version/s: 1.19.0
Resolution: Fixed
This proton commit fixed the issue - 91b480e0639a36fe0a47a638f521f92597de5a8d
> test_01_verify_attach failing in system_tests_one_router.py
> ---
>
> Key: DISPATCH-2334
> URL: https://issues.apache.org/jira/browse/DISPATCH-2334
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> 21:
> 21: ==
> 21: FAIL: test_01_verify_attach
> (system_tests_one_router.OneRouterTransactionalAttachTest)
> 21: Verify the transaction link attach is correctly forwarded to the broker
> 21: --
> 21: Traceback (most recent call last):
> 21: File
> "/home/jenkins/workspace/dispatch/dispatch-rawhide-main/source/dispatch/tests/system_tests_one_router.py",
> line 3898, in test_01_verify_attach
> 21: self.assertEqual(symbol('amqp:declare:list'),
> 21: ^
> 21: AssertionError: symbol('amqp:declare:list') != ulong(119) {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2362) c-threaderciser timed out on 32-core machine.
[ https://issues.apache.org/jira/browse/PROTON-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497391#comment-17497391 ] Robbie Gemmell commented on PROTON-2362: Yep that is why it is being resolved. Changes were made months ago, a release is occurring so these changes are locked in. Either its a new issue for new changes, or punt this issue to the next fix-version, and given the number of changes leaving it in this one seems better. > c-threaderciser timed out on 32-core machine. > - > > Key: PROTON-2362 > URL: https://issues.apache.org/jira/browse/PROTON-2362 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.33.0, proton-c-0.35.0, proton-c-0.34.0, > proton-c-0.36.0, proton-c-0.37.0 >Reporter: michael goulish >Assignee: Clifford Jansen >Priority: Major > Fix For: proton-c-0.37.0 > > Attachments: tsan_tr1.txt, tsan_tr2.txt, tsan_tr3.txt > > > Using recent master – maybe 3 days old or so – I just ran Proton's ctest, > after turning on THREADERCISER. I ran it on a box with 32 physical cores, 64 > threads. > > Test number 6 – c-threaderciser – failed with timeout after 1500 seconds. > ( 1.5e18 femtoseconds. ) > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[
https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497390#comment-17497390
]
ASF GitHub Bot commented on PROTON-2487:
DreamPearl commented on a change in pull request #355:
URL: https://github.com/apache/qpid-proton/pull/355#discussion_r813864011
##
File path: cpp/src/sender.cpp
##
@@ -70,6 +71,10 @@ tracker sender::send(const message , const binary
) {
pn_delivery_t *dlv = pn_delivery(
pn_object(),
pn_dtag((reinterpret_cast([0])), tag.size()));
+
+proton::binary tag_cp = tag;
+tracker track = make_wrapper(dlv);
+send_span(message, tag_cp, track);
Review comment:
Done, thanks!
Also, we need to type cast it into a non-const pointer .
`proton::message* message_to_send = (proton::message*)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Implement distributed tracing
> ---
>
> Key: PROTON-2487
> URL: https://issues.apache.org/jira/browse/PROTON-2487
> Project: Qpid Proton
> Issue Type: New Feature
> Components: cpp-binding
>Affects Versions: proton-c-0.37.0
>Reporter: Rakhi Kumari
>Assignee: Rakhi Kumari
>Priority: Major
> Fix For: proton-c-0.38.0
>
>
> Implement distributed tracing using opentelemetry.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
DreamPearl commented on a change in pull request #355:
URL: https://github.com/apache/qpid-proton/pull/355#discussion_r813864011
##
File path: cpp/src/sender.cpp
##
@@ -70,6 +71,10 @@ tracker sender::send(const message , const binary
) {
pn_delivery_t *dlv = pn_delivery(
pn_object(),
pn_dtag((reinterpret_cast([0])), tag.size()));
+
+proton::binary tag_cp = tag;
+tracker track = make_wrapper(dlv);
+send_span(message, tag_cp, track);
Review comment:
Done, thanks!
Also, we need to type cast it into a non-const pointer .
`proton::message* message_to_send = (proton::message*)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2487) [cpp] Implement distributed tracing
[
https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497382#comment-17497382
]
ASF GitHub Bot commented on PROTON-2487:
DreamPearl commented on a change in pull request #355:
URL: https://github.com/apache/qpid-proton/pull/355#discussion_r813856498
##
File path: cpp/src/sender.cpp
##
@@ -67,11 +68,20 @@ tracker sender::send(const message ) {
}
tracker sender::send(const message , const binary ) {
+proton::message* message_to_send = (proton::message*)
pn_delivery_t *dlv = pn_delivery(
pn_object(),
pn_dtag((reinterpret_cast([0])), tag.size()));
+proton::binary tag_cp = tag;
+tracker track = make_wrapper(dlv);
std::vector buf;
-message.encode(buf);
+proton::message message_cp;
+if (isTracingEnable()) {
+message_cp = message;
+send_span(message_cp, tag_cp, track);
+message_to_send = _cp;
+}
+message_to_send->encode(buf);
Review comment:
Also tried without using a message pointer.
```
if (isTracingEnable()) {
proton::message message_cp = message;
send_span(message_cp, tag_cp, track);
message_cp.encode(buf);
}
else
message.encode(buf);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Implement distributed tracing
> ---
>
> Key: PROTON-2487
> URL: https://issues.apache.org/jira/browse/PROTON-2487
> Project: Qpid Proton
> Issue Type: New Feature
> Components: cpp-binding
>Affects Versions: proton-c-0.37.0
>Reporter: Rakhi Kumari
>Assignee: Rakhi Kumari
>Priority: Major
> Fix For: proton-c-0.38.0
>
>
> Implement distributed tracing using opentelemetry.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry
DreamPearl commented on a change in pull request #355:
URL: https://github.com/apache/qpid-proton/pull/355#discussion_r813856498
##
File path: cpp/src/sender.cpp
##
@@ -67,11 +68,20 @@ tracker sender::send(const message ) {
}
tracker sender::send(const message , const binary ) {
+proton::message* message_to_send = (proton::message*)
pn_delivery_t *dlv = pn_delivery(
pn_object(),
pn_dtag((reinterpret_cast([0])), tag.size()));
+proton::binary tag_cp = tag;
+tracker track = make_wrapper(dlv);
std::vector buf;
-message.encode(buf);
+proton::message message_cp;
+if (isTracingEnable()) {
+message_cp = message;
+send_span(message_cp, tag_cp, track);
+message_to_send = _cp;
+}
+message_to_send->encode(buf);
Review comment:
Also tried without using a message pointer.
```
if (isTracingEnable()) {
proton::message message_cp = message;
send_span(message_cp, tag_cp, track);
message_cp.encode(buf);
}
else
message.encode(buf);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2442) 0.37.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497377#comment-17497377 ] ASF subversion and git services commented on PROTON-2442: - Commit 10519f500baf03d4653aaea58a888b8857576657 in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=10519f5 ] PROTON-2506, PROTON-2442: bump version to 0.38.0-SNAPSHOT > 0.37.0 release tasks > > > Key: PROTON-2442 > URL: https://issues.apache.org/jira/browse/PROTON-2442 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2506) 0.38.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497376#comment-17497376 ] ASF subversion and git services commented on PROTON-2506: - Commit 10519f500baf03d4653aaea58a888b8857576657 in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=10519f5 ] PROTON-2506, PROTON-2442: bump version to 0.38.0-SNAPSHOT > 0.38.0 release tasks > > > Key: PROTON-2506 > URL: https://issues.apache.org/jira/browse/PROTON-2506 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.38.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2442) 0.37.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497374#comment-17497374 ] ASF subversion and git services commented on PROTON-2442: - Commit dd86ffd178f155bcebc9c147324de336fd1351d4 in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=dd86ffd ] PROTON-2442: update version for 0.37.0-rc1 > 0.37.0 release tasks > > > Key: PROTON-2442 > URL: https://issues.apache.org/jira/browse/PROTON-2442 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2362) c-threaderciser timed out on 32-core machine.
[ https://issues.apache.org/jira/browse/PROTON-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497350#comment-17497350 ] Jiri Daněk commented on PROTON-2362: I'm not sure this is completely resolved, see my previous comment 04/Feb/22 13:14; there were no new commits linked to this issue since. Anyways, it makes sense to me to close the issue when release is being cut, since some work has been already done. If [~michaelgoulish]'s Brontonomicon has anything more to say at some point in the future, a new issue can be opened. > c-threaderciser timed out on 32-core machine. > - > > Key: PROTON-2362 > URL: https://issues.apache.org/jira/browse/PROTON-2362 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.33.0, proton-c-0.35.0, proton-c-0.34.0, > proton-c-0.36.0, proton-c-0.37.0 >Reporter: michael goulish >Assignee: Clifford Jansen >Priority: Major > Fix For: proton-c-0.37.0 > > Attachments: tsan_tr1.txt, tsan_tr2.txt, tsan_tr3.txt > > > Using recent master – maybe 3 days old or so – I just ran Proton's ctest, > after turning on THREADERCISER. I ran it on a box with 32 physical cores, 64 > threads. > > Test number 6 – c-threaderciser – failed with timeout after 1500 seconds. > ( 1.5e18 femtoseconds. ) > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2442) 0.37.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497344#comment-17497344 ] ASF subversion and git services commented on PROTON-2442: - Commit c9bb2d93ef286a5f150193171794a7fdc0f43df3 in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=c9bb2d9 ] PROTON-2442: update .so versions following review > 0.37.0 release tasks > > > Key: PROTON-2442 > URL: https://issues.apache.org/jira/browse/PROTON-2442 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2472) assert epoll.c:2519: poller_do_epoll: Assertion `!p->sched_ready_first' failed.
[
https://issues.apache.org/jira/browse/PROTON-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell resolved PROTON-2472.
Resolution: Fixed
> assert epoll.c:2519: poller_do_epoll: Assertion `!p->sched_ready_first'
> failed.
> ---
>
> Key: PROTON-2472
> URL: https://issues.apache.org/jira/browse/PROTON-2472
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.37.0
>Reporter: Ken Giusti
>Assignee: Clifford Jansen
>Priority: Major
> Fix For: proton-c-0.37.0
>
>
> Hit while running qpid-dispatch CI tests:
> https://master-jenkins-csb-entmqcl.apps.ocp4.prod.psi.redhat.com/job/dispatch/job/dispatch-rawhide-main/133/console
> Proton main @
> Revision 7c593cecb270760af7a05f854fed8078819fd4af
> Test run in Fedora Rawhide container
> {noformat}
> test 18
> Start 18: system_tests_autolinks
> 18: Test command: /usr/bin/python3.6
> "/home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_autolinks"
> 18: Test timeout computed to be: 600
> 18: test_auto_link_reattch (system_tests_autolinks.AutoLinkRetryTest) ... ok
> 18: test_01_autolink_attach (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_02_autolink_credit (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_03_autolink_sender (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_04_autolink_receiver (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_05_inter_container_transfer (system_tests_autolinks.AutolinkTest)
> ... ok
> 18: test_06_manage_autolinks (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_07_autolink_attach_with_ext_addr
> (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_08_autolink_sender_with_ext_addr
> (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_09_autolink_receiver_with_ext_addr
> (system_tests_autolinks.AutolinkTest) ... ok
> 18: test_10_autolink_attach_to_listener (system_tests_autolinks.AutolinkTest)
> ... ok
> 18: test_11_autolink_multiple_receivers_on_listener
> (system_tests_autolinks.AutolinkTest) ... ok
> 18:
> 18: Router QDR output file:
> 18:
> 18: 2022-01-07 14:37:55.326051 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 18: 2022-01-07 14:37:55.326406 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 18: qdrouterd:
> /home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/proton/c/src/proactor/epoll.c:2481:
> poller_do_epoll: Assertion `!p->sched_ready_first' failed.
> 18:
> 18:
> 18:
> 18: Router QDR output file:
> 18:
> 18: 2022-01-07 14:37:55.326051 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 18: 2022-01-07 14:37:55.326406 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 18: qdrouterd:
> /home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/proton/c/src/proactor/epoll.c:2481:
> poller_do_epoll: Assertion `!p->sched_ready_first' failed.
> 18:
> 18:
> 18:
> 18: Router QDR command file:
> 18:
> 18: qdrouterd -c test-router.conf -I
> /home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/python
> 18: pid=4172
> 18:
> 18:
> 18:
> 18: Router QDR log file tail:
> 18:
> 18: 2022-01-07 14:37:58.334748 + ROUTER_CORE (info) Auto Link Deactivated
> 'autoLink/7' on connection myListener
> (/home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/src/router_core/route_control.c:137)
> 18: 2022-01-07 14:37:58.334770 + ROUTER_CORE (info) [C30] Connection
> Closed
> (/home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/src/router_core/connections.c:1607)
> 18: 2022-01-07 14:37:58.334797 + ROUTER_CORE (trace) Core action
> 'qdr_connection_process - remove from updated list'
> (/home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 18: 2022-01-07 14:37:58.334821 + ROUTER_CORE (debug) [C29][L67][D2787]
> Delivery outcome : is accepted (0x24)
> (/home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/src/router_core/delivery.c:394)
> 18: 2022-01-07 14:37:58.334841 + ROUTER_CORE (trace) Core action
> 'qdr_connection_process - remove from updated list'
> (/home/jenkins/workspace/dispatch/dispatch-rhel8-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 18: 2022-01-07 14:37:58.334857 + ROUTER_CORE (debug) [C29][L67][D2790]
> Delivery outcome : is accepted (0x24)
>
[jira] [Updated] (PROTON-2506) 0.38.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2506: --- Fix Version/s: proton-c-0.38.0 (was: proton-c-0.37.0) > 0.38.0 release tasks > > > Key: PROTON-2506 > URL: https://issues.apache.org/jira/browse/PROTON-2506 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.38.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2506) 0.38.0 release tasks
Robbie Gemmell created PROTON-2506: -- Summary: 0.38.0 release tasks Key: PROTON-2506 URL: https://issues.apache.org/jira/browse/PROTON-2506 Project: Qpid Proton Issue Type: Task Components: proton-c, release Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: proton-c-0.37.0 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
