[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551349#comment-17551349 ] Andrew Stitcher commented on PROTON-2556: - Also and most importantly all these APIs are explicitly marked as internal in the header files and are not documented so that should strongly tell people not to use them because they aren't supported as API. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
Don't know. Depends on what the adaptors do? In any case, I now feel better about this. Hopefully skupper can be easily updated and then the privatization can be done without any of these silly CI build breakages. On Wed, Jun 8, 2022, 00:04 Andrew Stitcher (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551302#comment-17551302 > ] > > Andrew Stitcher commented on PROTON-2556: > - > > I know that skupper router compiles fine with a few trivial changes - it > doesn't use the internal data types of proton - is that something changed > when they forked from dispatch router? > > > Remove all uses of pn_string and pn_list from example code > > -- > > > > Key: PROTON-2556 > > URL: https://issues.apache.org/jira/browse/PROTON-2556 > > Project: Qpid Proton > > Issue Type: Sub-task > > Components: proton-c > >Reporter: Andrew Stitcher > >Assignee: Andrew Stitcher > >Priority: Major > > > > pn_string and pn_list are currently internal APIs and should not be used > by application programs. > > The proton library is really not in the business of providing a data > structures library! > > > > -- > This message was sent by Atlassian Jira > (v8.20.7#820007) > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551302#comment-17551302 ] Andrew Stitcher commented on PROTON-2556: - I know that skupper router compiles fine with a few trivial changes - it doesn't use the internal data types of proton - is that something changed when they forked from dispatch router? > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551301#comment-17551301 ] Jiri Daněk edited comment on PROTON-2556 at 6/7/22 9:51 PM: This is the app, https://github.com/corda/corda. Looks like they also use qpid-cpp in their experimental C++ library, https://github.com/corda/corda/blob/cd8cd60a0fd943198a87d266bd15b807eeaa20ba/experimental/cpp-serializer/src/README.md. bq. Why would you use proton for its internal data structures? There are just better libraries out there designed specially for that purpose. In C, obviously because of the notorious dependency hesitancy that all C projects suffer from. And when they decide to depend on something, they then exploit that dependency in its fullest. It takes a package manager to break that tendency, but then you end up with the npm-style proliferation of 10 line libraries in turn. The IT world has weird quirks. Maybe I should've become lawyer instead, after all :D bq. I suppose if one really wanted to use pn_string_t, pn_list_t, pn_hash_t, pn_map_t etc. then they could be separated out as a new library Dispatch apparently wants that. And it also likes the Proton Python URL class. Hiding things is probably good artitecture, but it is going to be inconvenient and maybe lead to duplication of code between the two projects? was (Author: jdanek): This is the app, https://github.com/corda/corda. Looks like they also use qpid-cpp in their experimental C++ library, https://github.com/corda/corda/blob/cd8cd60a0fd943198a87d266bd15b807eeaa20ba/experimental/cpp-serializer/src/README.md. bq. Why would you use proton for its internal data structures? There are just better libraries out there designed specially for that purpose. In C, obviously because of the notorious dependency hesitancy that all C projects suffer. And when they decide to depend on something, they then exploit that dependency in its fullest. It takes a package manager to break that tendency, but then you end up with the npm-style proliferation of 10 line libraries in turn. The IT world has weird quirks. Maybe I should've become lawyer instead, after all :D bq. I suppose if one really wanted to use pn_string_t, pn_list_t, pn_hash_t, pn_map_t etc. then they could be separated out as a new library Dispatch apparently wants that. And it also likes the Proton Python URL class. Hiding things is probably good artitecture, but it is going to be inconvenient and maybe lead to duplication of code between the two projects? > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551301#comment-17551301 ] Jiri Daněk commented on PROTON-2556: This is the app, https://github.com/corda/corda. Looks like they also use qpid-cpp in their experimental C++ library, https://github.com/corda/corda/blob/cd8cd60a0fd943198a87d266bd15b807eeaa20ba/experimental/cpp-serializer/src/README.md. bq. Why would you use proton for its internal data structures? There are just better libraries out there designed specially for that purpose. In C, obviously because of the notorious dependency hesitancy that all C projects suffer. And when they decide to depend on something, they then exploit that dependency in its fullest. It takes a package manager to break that tendency, but then you end up with the npm-style proliferation of 10 line libraries in turn. The IT world has weird quirks. Maybe I should've become lawyer instead, after all :D bq. I suppose if one really wanted to use pn_string_t, pn_list_t, pn_hash_t, pn_map_t etc. then they could be separated out as a new library Dispatch apparently wants that. And it also likes the Proton Python URL class. Hiding things is probably good artitecture, but it is going to be inconvenient and maybe lead to duplication of code between the two projects? > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[
https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551300#comment-17551300
]
Andrew Stitcher commented on PROTON-2556:
-
I suppose if one really wante to use {{pn_string_t,}} {{{}pn_list_t{}}},
{{{}pn_hash_t{}}}, {{pn_map_t}} etc. then they could be separated out as a new
library, but there really isn't a good reason to have these types anywhere in
the API itself.
> Remove all uses of pn_string and pn_list from example code
> --
>
> Key: PROTON-2556
> URL: https://issues.apache.org/jira/browse/PROTON-2556
> Project: Qpid Proton
> Issue Type: Sub-task
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>
> pn_string and pn_list are currently internal APIs and should not be used by
> application programs.
> The proton library is really not in the business of providing a data
> structures library!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[
https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551300#comment-17551300
]
Andrew Stitcher edited comment on PROTON-2556 at 6/7/22 9:24 PM:
-
I suppose if one really wanted to use {{pn_string_t,}} {{{}pn_list_t{}}},
{{{}pn_hash_t{}}}, {{pn_map_t}} etc. then they could be separated out as a new
library, but there really isn't a good reason to have these types anywhere in
the API itself.
was (Author: astitcher):
I suppose if one really wante to use {{pn_string_t,}} {{{}pn_list_t{}}},
{{{}pn_hash_t{}}}, {{pn_map_t}} etc. then they could be separated out as a new
library, but there really isn't a good reason to have these types anywhere in
the API itself.
> Remove all uses of pn_string and pn_list from example code
> --
>
> Key: PROTON-2556
> URL: https://issues.apache.org/jira/browse/PROTON-2556
> Project: Qpid Proton
> Issue Type: Sub-task
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>
> pn_string and pn_list are currently internal APIs and should not be used by
> application programs.
> The proton library is really not in the business of providing a data
> structures library!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551298#comment-17551298 ] Andrew Stitcher commented on PROTON-2556: - Honestly that sounds a bit perverse, but fortunately it's proton-j not proton-c! Using proton-c for serialization wouldn't be especially perverse as long as you wanted AMQP serialization, but doing that doesn't requires any of the internal data structures. Why would you use proton for its internal data structures? There are just better libraries out there designed specially for that purpose. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551276#comment-17551276 ] Jiri Daněk commented on PROTON-2556: [~astitcher] Well, isn't there that electronic ledger document notary application that uses Qpid Proton J as a data-structures library? Seems to me that there is some sense in this usage. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551276#comment-17551276 ] Jiri Daněk edited comment on PROTON-2556 at 6/7/22 8:21 PM: [~astitcher] Well, isn't there that electronic ledger document notary application that uses Qpid Proton J as a data-structures (and serialization) library? Seems to me that there is some sense in this usage. was (Author: jdanek): [~astitcher] Well, isn't there that electronic ledger document notary application that uses Qpid Proton J as a data-structures library? Seems to me that there is some sense in this usage. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2344) Mobile addresses out-of-sync on two routers in a network (skupper-router #473)
[ https://issues.apache.org/jira/browse/DISPATCH-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2344. -- Resolution: Fixed > Mobile addresses out-of-sync on two routers in a network (skupper-router > #473) > > > Key: DISPATCH-2344 > URL: https://issues.apache.org/jira/browse/DISPATCH-2344 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.19.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.20.0 > > > Backport fix from > [https://github.com/skupperproject/skupper-router/issues/473] > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1569: Dispatch 2344
kgiusti commented on PR #1569: URL: https://github.com/apache/qpid-dispatch/pull/1569#issuecomment-1149074110 Fix merged: https://github.com/apache/qpid-dispatch/commit/5823680afe5cbbb85bb3d0e73a50201ad52fb553 https://github.com/apache/qpid-dispatch/commit/3105751a65c1aae14bb3104745489f06654d1830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1569: Dispatch 2344
kgiusti closed pull request #1569: Dispatch 2344 URL: https://github.com/apache/qpid-dispatch/pull/1569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2344) Mobile addresses out-of-sync on two routers in a network (skupper-router #473)
[ https://issues.apache.org/jira/browse/DISPATCH-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551245#comment-17551245 ] ASF subversion and git services commented on DISPATCH-2344: --- Commit 3105751a65c1aae14bb3104745489f06654d1830 in qpid-dispatch's branch refs/heads/main from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=3105751a ] DISPATCH-2344: Fixes #473 - Reduced the severity of "unknown router" logs from ERROR to WARNING. (cherry picked from commit cd616e792a142d7b016fe6440d19ac37d728fe1f) > Mobile addresses out-of-sync on two routers in a network (skupper-router > #473) > > > Key: DISPATCH-2344 > URL: https://issues.apache.org/jira/browse/DISPATCH-2344 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.19.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.20.0 > > > Backport fix from > [https://github.com/skupperproject/skupper-router/issues/473] > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2556: Component/s: proton-c > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2556: Description: pn_string and pn_list are currently internal APIs and should not be used by application programs. The proton library is really not in the business of providing a data structures library! was: pn_string and pn_list are currently internal APIS and should not be used by application programs. The proton library is really not in the business of providing a data structures library! > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2559) Privatize most of the proton/object.h API
Andrew Stitcher created PROTON-2559: --- Summary: Privatize most of the proton/object.h API Key: PROTON-2559 URL: https://issues.apache.org/jira/browse/PROTON-2559 Project: Qpid Proton Issue Type: Sub-task Reporter: Andrew Stitcher Assignee: Andrew Stitcher -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2558) Provide an API to create pn_class_t instances
Andrew Stitcher created PROTON-2558:
---
Summary: Provide an API to create pn_class_t instances
Key: PROTON-2558
URL: https://issues.apache.org/jira/browse/PROTON-2558
Project: Qpid Proton
Issue Type: Sub-task
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
The Proton bindings (for at least Python, C++ and ruby) need to create
{{pn_class_t}} instances for various reasons. Currently the only way to do that
is to use some macros in {{proton/object.h}} which create static const
{{pn_class_t}} instances however this requires knowledge of the internals of
the struct itself which means that it cannot be changed without breaking ABI.
So shifting this to a dynamic API is necessary to hide the internals of
{{{}pn_class_t{}}}. This is very slightly less efficient but only in the
startup path so it really doesn't matter all that much!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2557) Provide an alternative API to pn_inspect
Andrew Stitcher created PROTON-2557:
---
Summary: Provide an alternative API to pn_inspect
Key: PROTON-2557
URL: https://issues.apache.org/jira/browse/PROTON-2557
Project: Qpid Proton
Issue Type: Sub-task
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
{{The pn_inspect}} API requires the use of {{pn_string_t. but this type is
really internal to Proton, so an alternative API which returns a {{const char
* is really much more suitable as well as requiring a little less
boilerplate from the application programmer.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
Andrew Stitcher created PROTON-2556: --- Summary: Remove all uses of pn_string and pn_list from example code Key: PROTON-2556 URL: https://issues.apache.org/jira/browse/PROTON-2556 Project: Qpid Proton Issue Type: Sub-task Reporter: Andrew Stitcher Assignee: Andrew Stitcher pn_string and pn_list are currently internal APIS and should not be used by application programs. The proton library is really not in the business of providing a data structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2555) Remove internal details from the proton/object.h API header file
Andrew Stitcher created PROTON-2555:
---
Summary: Remove internal details from the proton/object.h API
header file
Key: PROTON-2555
URL: https://issues.apache.org/jira/browse/PROTON-2555
Project: Qpid Proton
Issue Type: Improvement
Components: proton-c
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
Proton has long exported the details of its internal object system in the
{{proton/object.h}} header file - these details are marked as internal and many
of them are unnecessary for any application to use.
Indeed exposing some of these details means that these internal details can't
be compatibly changed between different Proton versions even though no
applications should be using these details anyway.
However even some of our examples are using these internal details.
This is a tracking issue for several more detailed items which remove the need
for nearly all of these APIs to be exported and then modifies the actual API
header file so export only those APIs that are truely needed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1573: Bump actions/cache from 2.1.6 to 3.0.4
codecov-commenter commented on PR #1573: URL: https://github.com/apache/qpid-dispatch/pull/1573#issuecomment-1148979899 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1573?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1573](https://codecov.io/gh/apache/qpid-dispatch/pull/1573?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f3d3767) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/bdd4fd4c0712815348c8e3619ec8cdd03ece1072?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bdd4fd4) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff @@ ## main#1573 +/- ## == + Coverage 85.78% 85.85% +0.07% == Files 110 110 Lines 2474524745 == + Hits2122821246 +18 + Misses 3517 3499 -18 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1573?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRhaW5lci5j) | `84.30% <0.00%> (-0.17%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (ø)` | | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.16% <0.00%> (+0.18%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.17% <0.00%> (+0.19%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `94.47% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `86.98% <0.00%> (+0.28%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `86.79% <0.00%> (+0.86%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1573/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1573?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1573?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1570: Bump actions/cache from 2.1.6 to 3.0.3
dependabot[bot] closed pull request #1570: Bump actions/cache from 2.1.6 to 3.0.3 URL: https://github.com/apache/qpid-dispatch/pull/1570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1570: Bump actions/cache from 2.1.6 to 3.0.3
dependabot[bot] commented on PR #1570: URL: https://github.com/apache/qpid-dispatch/pull/1570#issuecomment-1148937145 Superseded by #1573. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request, #1573: Bump actions/cache from 2.1.6 to 3.0.4
dependabot[bot] opened a new pull request, #1573: URL: https://github.com/apache/qpid-dispatch/pull/1573 Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 3.0.4. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.4 In this release, we have fixed the tar creation error while trying to create it with path as ~/ home folder on ubuntu-latest. v3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>actions/cache#624) v3.0.2 This release adds the support for dynamic cache size cap on GHES. v3.0.1 Added support for caching from GHES 3.5. Fixed download issue for files 2GB during restore. v3.0.0 This change adds a minimum runner version(node12 - node16), which can break users using an out-of-date/fork of the runner. This would be most commonly affecting users on GHES 3.3 or before, as those runners do not support node16 actions and they can use actions from github.com via https://docs.github.com/en/enterprise-server@3.0/admin/github-actions/managing-access-to-actions-from-githubcom/enabling-automatic-access-to-githubcom-actions-using-github-connect;>github connect or manually copying the repo to their GHES instance. Few dependencies and cache action usage examples have also been updated. v2.1.7 Support 10GB cache upload using the latest version 1.0.8 of https://www.npmjs.com/package/@actions/cache;>@actions/cache Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.0.4 Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (https://github-redirect.dependabot.com/actions/cache/issues/689;>issue) Commits https://github.com/actions/cache/commit/c3f1317a9e7b1ef106c153ac8c0f00fed3ddbc0d;>c3f1317 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/813;>#813 from actions/users/kotewar/upgrading-cache-to-v2.0.6 https://github.com/actions/cache/commit/d0a54b996cb35d7beba3674d28753ff7ccf2430c;>d0a54b9 Fixed typo https://github.com/actions/cache/commit/8c5bd0c82db6e9fd53fc132c68d5f7649d568271;>8c5bd0c Updated README file with release info https://github.com/actions/cache/commit/c9c0f735586a8329cd6973dfeb9ceaf13e033631;>c9c0f73 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/812;>#812 from actions/users/kotewar/upgrading-cache-to-v2.0.6 https://github.com/actions/cache/commit/2b6caae3c9d06fc8e6b142308e16b3c6eaaf4637;>2b6caae Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/495;>#495 from ostera/patch-1 https://github.com/actions/cache/commit/dd58d1315fbfa379835d53b0bc75d1a3420fcaf0;>dd58d13 Added release info and upgraded version https://github.com/actions/cache/commit/acace7fa1bd9ed59015a76e9de8a00ac88229033;>acace7f Merge branch 'main' into patch-1 https://github.com/actions/cache/commit/438628ac22a3596a70933e8dd4f06fe0c1550315;>438628a Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/554;>#554 from albertstill/improve-restore-key-docs https://github.com/actions/cache/commit/c296e6a08c6a639ec6e35fbfdcde61c3f6107885;>c296e6a Updated @actions/cache version in license file https://github.com/actions/cache/commit/7ed7f22ed87596cd0d1c13baca967dc49bd9dc6f;>7ed7f22 Updated actions/cache to v2.0.6 Additional commits viewable in https://github.com/actions/cache/compare/v2.1.6...v3.0.4;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop
[jira] [Commented] (QPID-8590) [Broker-J] Purge on flow to disk queue
[
https://issues.apache.org/jira/browse/QPID-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550850#comment-17550850
]
ASF GitHub Bot commented on QPID-8590:
--
dakirily opened a new pull request, #128:
URL: https://github.com/apache/qpid-broker-j/pull/128
This PR addresses JIRA QPID-8590 to improve flow-to-disk mechanism: messages
should be flowed to disk when their amount exceeds overflow limit or restored
in memory when their amount is less than overflow limit. Although performance
of purging messages from queue ( cleanQueue() operation ) is increased.
> [Broker-J] Purge on flow to disk queue
> --
>
> Key: QPID-8590
> URL: https://issues.apache.org/jira/browse/QPID-8590
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.6
>Reporter: Daniil Kirilyuk
>Priority: Minor
>
> Purging of flow to disk queues is very slow (~10messages/s).
> Steps to replicate:
> * send 10 messages to flow to disk queue with overflow count set to 10
> * initiate queue purge by REST API
> Note: When broker is stop is initiated, queue is purged much faster
> (approximatelly ~6messages/s).
> Threaddumps show following stacktraces:
> {code:java}
> qtp1722120611-7283 #7283 prio=5 os_prio=0 cpu=47303542.52ms
> elapsed=76831.32s tid=0x7fcf64097800 nid=0x3d5b runnable
> [0x7fcf3c7be000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.decrementReference(AbstractServerMessageImpl.java:136)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.access$500(AbstractServerMessageImpl.java:40)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl$Reference.release(AbstractServerMessageImpl.java:356)
> - locked 0x000600516aa0 (a
> org.apache.qpid.server.message.AbstractServerMessageImpl$Reference)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl$Reference.close(AbstractServerMessageImpl.java:363)
> at
> org.apache.qpid.server.queue.FlowToDiskOverflowPolicyHandler$Handler.flowToDisk(FlowToDiskOverflowPolicyHandler.java:135)
> at
> org.apache.qpid.server.queue.FlowToDiskOverflowPolicyHandler$Handler.flowTailToDiskIfNecessary(FlowToDiskOverflowPolicyHandler.java:105)
> at
> org.apache.qpid.server.queue.FlowToDiskOverflowPolicyHandler$Handler.checkOverflow(FlowToDiskOverflowPolicyHandler.java:68)
> at
> org.apache.qpid.server.queue.FlowToDiskOverflowPolicyHandler$Handler.access$100(FlowToDiskOverflowPolicyHandler.java:44)
> at
> org.apache.qpid.server.queue.FlowToDiskOverflowPolicyHandler.checkOverflow(FlowToDiskOverflowPolicyHandler.java:40)
> at
> org.apache.qpid.server.queue.AbstractQueue.checkCapacity(AbstractQueue.java:2117)
> at
> org.apache.qpid.server.queue.AbstractQueueEntryList.updateStatsOnStateChange(AbstractQueueEntryList.java:99)
> at
> org.apache.qpid.server.queue.OrderedQueueEntryList.updateStatsOnStateChange(OrderedQueueEntryList.java:33)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.notifyStateChange(QueueEntryImpl.java:559)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.dispose(QueueEntryImpl.java:578)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.delete(QueueEntryImpl.java:596)
> at
> org.apache.qpid.server.queue.AbstractQueue$7.postCommit(AbstractQueue.java:1836)
> at
> org.apache.qpid.server.txn.LocalTransaction.doPostTransactionActions(LocalTransaction.java:473)
> at
> org.apache.qpid.server.txn.LocalTransaction.commit(LocalTransaction.java:402)
> at
> org.apache.qpid.server.txn.LocalTransaction.commit(LocalTransaction.java:374)
> at
> org.apache.qpid.server.queue.AbstractQueue.clearQueue(AbstractQueue.java:1816)
> at
> org.apache.qpid.server.queue.StandardQueueImplWithAccessChecking.clearQueue(StandardQueueImplWithAccessChecking.java:152)
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.10/Native
> Method)
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@11.0.10/NativeMethodAccessorImpl.java:62)
> at
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.10/DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(java.base@11.0.10/Method.java:566)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodOperation.perform(ConfiguredObjectMethodOperation.java:125)
> at
> org.apache.qpid.server.management.plugin.controller.latest.LatestManagementController.invoke(LatestManagementController.java:372)
> at
> org.apache.qpid.server.management.plugin.controller.AbstractManagementController.handlePostOrPut(AbstractManagementController.java:147)
> at
>
[GitHub] [qpid-broker-j] dakirily opened a new pull request, #128: QPID-8590: [Broker-J] Purge on flow to disk queue
dakirily opened a new pull request, #128: URL: https://github.com/apache/qpid-broker-j/pull/128 This PR addresses JIRA QPID-8590 to improve flow-to-disk mechanism: messages should be flowed to disk when their amount exceeds overflow limit or restored in memory when their amount is less than overflow limit. Although performance of purging messages from queue ( cleanQueue() operation ) is increased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
