[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551784#comment-17551784 ] ASF subversion and git services commented on PROTON-2556: - Commit 447f518bf5a6c37ee765fb70f332b59148f7bf28 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=447f518bf ] PROTON-2556: Remove unnecessary active connection list from reactor-recv I suspect this was added as a workaround long ago when proton didn't properly cleanup listening connections. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2559) Privatize most of the proton/object.h API
[ https://issues.apache.org/jira/browse/PROTON-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551785#comment-17551785 ] ASF subversion and git services commented on PROTON-2559: - Commit 4641f1c3490496e8d81edaffc94c5417745adcb8 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=4641f1c34 ] PROTON-2559: Rearrange using object.h This is in preparation for removing the pn_object_t pn_class_t internals from the public API of proton. > Privatize most of the proton/object.h API > - > > Key: PROTON-2559 > URL: https://issues.apache.org/jira/browse/PROTON-2559 > Project: Qpid Proton > Issue Type: Sub-task >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2557) Provide an alternative API to pn_inspect
[ https://issues.apache.org/jira/browse/PROTON-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551781#comment-17551781 ] ASF subversion and git services commented on PROTON-2557: - Commit 839cdee1c091eacce7e2c91b6f60f205669a5521 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=839cdee1c ] PROTON-2557: Go change for introduction of pn_tostring > Provide an alternative API to pn_inspect > > > Key: PROTON-2557 > URL: https://issues.apache.org/jira/browse/PROTON-2557 > Project: Qpid Proton > Issue Type: Sub-task >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > {{The pn_inspect}} API requires the use of {{pn_string_t. but this type is > really internal to Proton, so an alternative API which returns a {{const char > * is really much more suitable as well as requiring a little less > boilerplate from the application programmer. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551779#comment-17551779 ] ASF subversion and git services commented on PROTON-2556: - Commit 0ad20092eb68e08a784a988af31dfc2be500e7f5 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=0ad20092e ] PROTON-2556: Removed gratuitous use of pn_string from reactor-send > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2557) Provide an alternative API to pn_inspect
[ https://issues.apache.org/jira/browse/PROTON-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551780#comment-17551780 ] ASF subversion and git services commented on PROTON-2557: - Commit d9ccd2923be628ac85e8a8da45090d981f0585cd in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=d9ccd2923 ] PROTON-2557: Introduce pn_tostring in place of pn_inspect Introduce and use a new API pn_tostring which produces a string representation of a Proton object in a char* string. It allocates this string with malloc and the application must free it. This replaces pn_inspect which requires the application to use the pn_string_t type purely to receive the string output. But we really don't want or need to expose this type outside the library itself. > Provide an alternative API to pn_inspect > > > Key: PROTON-2557 > URL: https://issues.apache.org/jira/browse/PROTON-2557 > Project: Qpid Proton > Issue Type: Sub-task >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > {{The pn_inspect}} API requires the use of {{pn_string_t. but this type is > really internal to Proton, so an alternative API which returns a {{const char > * is really much more suitable as well as requiring a little less > boilerplate from the application programmer. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2557) Provide an alternative API to pn_inspect
[ https://issues.apache.org/jira/browse/PROTON-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551782#comment-17551782 ] ASF subversion and git services commented on PROTON-2557: - Commit eea52fd02c66dae3ff510298dc1fa8c6cb9c8a42 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=eea52fd02 ] PROTON-2557: Ruby change for introduction of pn_tostring > Provide an alternative API to pn_inspect > > > Key: PROTON-2557 > URL: https://issues.apache.org/jira/browse/PROTON-2557 > Project: Qpid Proton > Issue Type: Sub-task >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > {{The pn_inspect}} API requires the use of {{pn_string_t. but this type is > really internal to Proton, so an alternative API which returns a {{const char > * is really much more suitable as well as requiring a little less > boilerplate from the application programmer. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2558) Provide an API to create pn_class_t instances
[ https://issues.apache.org/jira/browse/PROTON-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551783#comment-17551783 ] ASF subversion and git services commented on PROTON-2558: - Commit b18da591521709102d3957b7407706d8060796cf in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=b18da5915 ] PROTON-2558: Add make class operation to hide class details The new operation is used by the bindings to create proton objects without needing to know the details of the pn_class_t struct. > Provide an API to create pn_class_t instances > - > > Key: PROTON-2558 > URL: https://issues.apache.org/jira/browse/PROTON-2558 > Project: Qpid Proton > Issue Type: Sub-task >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > The Proton bindings (for at least Python, C++ and ruby) need to create > {{pn_class_t}} instances for various reasons. Currently the only way to do > that is to use some macros in {{proton/object.h}} which create static const > {{pn_class_t}} instances however this requires knowledge of the internals of > the struct itself which means that it cannot be changed without breaking ABI. > So shifting this to a dynamic API is necessary to hide the internals of > {{{}pn_class_t{}}}. This is very slightly less efficient but only in the > startup path so it really doesn't matter all that much! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2560) running tests can fail on system with only .Net 6 installed
[ https://issues.apache.org/jira/browse/PROTON-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551769#comment-17551769 ] ASF subversion and git services commented on PROTON-2560: - Commit b18b73702c015fea1833bd597cacb912a2064207 in qpid-proton-dotnet's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-proton-dotnet.git;h=b18b737 ] PROTON-2560 Allow tests and examples builds to roll forward by default Allows the executable outputs of the tests and examples projects to roll forward to the next major release of .NET framework to allow for builds to find the installed framework > running tests can fail on system with only .Net 6 installed > --- > > Key: PROTON-2560 > URL: https://issues.apache.org/jira/browse/PROTON-2560 > Project: Qpid Proton > Issue Type: Test > Components: proton-dotnet >Affects Versions: proton-dotnet-1.0.0-M1 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Minor > Fix For: proton-dotnet-1.0.0-M2 > > Attachments: dotnet-build.diff > > > Running the tests can fail on system with only .Net 6 installed. This seems > to be expected due to the build targeting 5.0.0, along with the default > 'rollforward' policy handling being 'Minor', per > [https://docs.microsoft.com/en-us/dotnet/core/versions/selection#framework-dependent-apps-roll-forward.] > This was observed on a Fedora 36 install, where running "./build.sh test" > showed that the initial build completed, but then the test steps failed as > only a 6.0.x install was found, e.g: > {quote} Starting test execution, please wait... > Testhost process exited with error: It was not possible to find any > compatible framework version > The framework 'Microsoft.NETCore.App', version '5.0.0' (x64) was not found. > - The following frameworks were found: > 6.0.5 at [/usr/lib64/dotnet/shared/Microsoft.NETCore.App] > You can resolve the problem by installing the specified framework and/or SDK. > The specified framework can be found at: > - > [https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App_version=5.0.0=x64=fedora.36-x64] > . Please check the diagnostic logs for more information.{quote} > It was possible to pass properties to the dotnet build/test command to make > the existing 1.0.0-M1 tests run successfully otherwise unaltered on F36, e.g: > {noformat} > dotnet build /property:DefaultUnitTestTargetFrameworks=net6.0 > /property:DefaultExeTargetFrameworks=net6.0 > dotnet test /property:DefaultUnitTestTargetFrameworks=net6.0 > /property:DefaultExeTargetFrameworks=net6.0 > {noformat} > It was also possible to get the tests running by updating them to add > "LatestMajor" property config to the .csproj files > (e.g see attached diff). -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1576: Bump actions/download-artifact from 2 to 3
codecov-commenter commented on PR #1576: URL: https://github.com/apache/qpid-dispatch/pull/1576#issuecomment-1150255268 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1576?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1576](https://codecov.io/gh/apache/qpid-dispatch/pull/1576?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fcfcfcb) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/3105751a65c1aae14bb3104745489f06654d1830?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3105751) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main#1576 +/- ## === Coverage 85.83% 85.84% === Files 110 110 Lines 2474624746 === + Hits2124121242+1 + Misses 3505 3504-1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1576?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `85.93% <0.00%> (-0.44%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.07% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `86.98% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1576/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.43% <0.00%> (+0.94%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1576?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1576?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [3105751...fcfcfcb](https://codecov.io/gh/apache/qpid-dispatch/pull/1576?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1574: Bump actions/setup-python from 2 to 4
codecov-commenter commented on PR #1574: URL: https://github.com/apache/qpid-dispatch/pull/1574#issuecomment-1150217434 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1574?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1574](https://codecov.io/gh/apache/qpid-dispatch/pull/1574?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (12d0891) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/3105751a65c1aae14bb3104745489f06654d1830?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3105751) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff @@ ## main#1574 +/- ## == + Coverage 85.83% 85.90% +0.07% == Files 110 110 Lines 2474624746 == + Hits2124121259 +18 + Misses 3505 3487 -18 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1574?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.17% <0.00%> (ø)` | | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRhaW5lci5j) | `84.46% <0.00%> (+0.16%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `94.47% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `86.58% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `87.36% <0.00%> (+0.47%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.43% <0.00%> (+0.94%)` | :arrow_up: | | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1574/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `89.76% <0.00%> (+1.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1574?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1574?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [3105751...12d0891](https://codecov.io/gh/apache/qpid-dispatch/pull/1574?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git
[jira] [Updated] (PROTON-2560) running tests can fail on system with only .Net 6 installed
[ https://issues.apache.org/jira/browse/PROTON-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2560: --- Priority: Minor (was: Major) > running tests can fail on system with only .Net 6 installed > --- > > Key: PROTON-2560 > URL: https://issues.apache.org/jira/browse/PROTON-2560 > Project: Qpid Proton > Issue Type: Test > Components: proton-dotnet >Affects Versions: proton-dotnet-1.0.0-M1 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Minor > Fix For: proton-dotnet-1.0.0-M2 > > Attachments: dotnet-build.diff > > > Running the tests can fail on system with only .Net 6 installed. This seems > to be expected due to the build targeting 5.0.0, along with the default > 'rollforward' policy handling being 'Minor', per > [https://docs.microsoft.com/en-us/dotnet/core/versions/selection#framework-dependent-apps-roll-forward.] > This was observed on a Fedora 36 install, where running "./build.sh test" > showed that the initial build completed, but then the test steps failed as > only a 6.0.x install was found, e.g: > {quote} Starting test execution, please wait... > Testhost process exited with error: It was not possible to find any > compatible framework version > The framework 'Microsoft.NETCore.App', version '5.0.0' (x64) was not found. > - The following frameworks were found: > 6.0.5 at [/usr/lib64/dotnet/shared/Microsoft.NETCore.App] > You can resolve the problem by installing the specified framework and/or SDK. > The specified framework can be found at: > - > [https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App_version=5.0.0=x64=fedora.36-x64] > . Please check the diagnostic logs for more information.{quote} > It was possible to pass properties to the dotnet build/test command to make > the existing 1.0.0-M1 tests run successfully otherwise unaltered on F36, e.g: > {noformat} > dotnet build /property:DefaultUnitTestTargetFrameworks=net6.0 > /property:DefaultExeTargetFrameworks=net6.0 > dotnet test /property:DefaultUnitTestTargetFrameworks=net6.0 > /property:DefaultExeTargetFrameworks=net6.0 > {noformat} > It was also possible to get the tests running by updating them to add > "LatestMajor" property config to the .csproj files > (e.g see attached diff). -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2560) running tests can fail on system with only .Net 6 installed
Robbie Gemmell created PROTON-2560: -- Summary: running tests can fail on system with only .Net 6 installed Key: PROTON-2560 URL: https://issues.apache.org/jira/browse/PROTON-2560 Project: Qpid Proton Issue Type: Test Components: proton-dotnet Affects Versions: proton-dotnet-1.0.0-M1 Reporter: Robbie Gemmell Assignee: Timothy A. Bish Fix For: proton-dotnet-1.0.0-M2 Attachments: dotnet-build.diff Running the tests can fail on system with only .Net 6 installed. This seems to be expected due to the build targeting 5.0.0, along with the default 'rollforward' policy handling being 'Minor', per [https://docs.microsoft.com/en-us/dotnet/core/versions/selection#framework-dependent-apps-roll-forward.] This was observed on a Fedora 36 install, where running "./build.sh test" showed that the initial build completed, but then the test steps failed as only a 6.0.x install was found, e.g: {quote} Starting test execution, please wait... Testhost process exited with error: It was not possible to find any compatible framework version The framework 'Microsoft.NETCore.App', version '5.0.0' (x64) was not found. - The following frameworks were found: 6.0.5 at [/usr/lib64/dotnet/shared/Microsoft.NETCore.App] You can resolve the problem by installing the specified framework and/or SDK. The specified framework can be found at: - [https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App_version=5.0.0=x64=fedora.36-x64] . Please check the diagnostic logs for more information.{quote} It was possible to pass properties to the dotnet build/test command to make the existing 1.0.0-M1 tests run successfully otherwise unaltered on F36, e.g: {noformat} dotnet build /property:DefaultUnitTestTargetFrameworks=net6.0 /property:DefaultExeTargetFrameworks=net6.0 dotnet test /property:DefaultUnitTestTargetFrameworks=net6.0 /property:DefaultExeTargetFrameworks=net6.0 {noformat} It was also possible to get the tests running by updating them to add "LatestMajor" property config to the .csproj files (e.g see attached diff). -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request, #1576: Bump actions/download-artifact from 2 to 3
dependabot[bot] opened a new pull request, #1576: URL: https://github.com/apache/qpid-dispatch/pull/1576 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. Release notes Sourced from https://github.com/actions/download-artifact/releases;>actions/download-artifact's releases. v3.0.0 What's Changed Update default runtime to node16 (https://github-redirect.dependabot.com/actions/download-artifact/pull/134;>actions/download-artifact#134) Update package-lock.json file version to 2 (https://github-redirect.dependabot.com/actions/download-artifact/pull/136;>actions/download-artifact#136) Breaking Changes With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12. v2.1.0 Download Artifact Improved output logging Fixed issue where downloading all artifacts could cause display percentages to be over 100% Various small bug fixes improvements v2.0.10 Retry on HTTP 500 responses from the service v2.0.9 Fixes to proxy related issues v2.0.8 Improvements to retryability if an error is encountered during artifact download v2.0.7 download-artifact Improved download retry-ability if a partial download is encountered v2.0.6 Update actions/core NPM package that is used internally v2.0.5 Add Third Party License Information v2.0.4 Use the latest version of the @actions/artifact NPM package v2.0.3 Misc improvements v2.0.2 Support for tilde expansion v2.0.1 Download path output Improved logging Commits https://github.com/actions/download-artifact/commit/fb598a63ae348fa914e94cd0ff38f362e927b741;>fb598a6 Merge pull request https://github-redirect.dependabot.com/actions/download-artifact/issues/136;>#136 from actions/jtamsut/update-lockfile-version https://github.com/actions/download-artifact/commit/a4a09c5d7eb5932e0e6c4e77a434738189a24f1b;>a4a09c5 regenerate index.js https://github.com/actions/download-artifact/commit/9acf51df7946118a04918663acc5d955f49de177;>9acf51d regenerate package lock https://github.com/actions/download-artifact/commit/882107232564f8bc8c5083706e009246f11aa871;>8821072 upgrade artifact version https://github.com/actions/download-artifact/commit/b8bbd3b64f298f12cfabf7d85ee4e716714eae3b;>b8bbd3b regenerate lockfile https://github.com/actions/download-artifact/commit/6ee3d963e5a7ed7dac02925e126c37e459c36aa6;>6ee3d96 revert artifact version https://github.com/actions/download-artifact/commit/d4793f4e27ec52069836c96d310f815ffa48176c;>d4793f4 update docs for v3 https://github.com/actions/download-artifact/commit/2d338d2145c33c497f1f4f574ca1eb88e1061a8e;>2d338d2 upgrade package to v3 https://github.com/actions/download-artifact/commit/360d0830b5796c983178d8073e39063e8d32bc46;>360d083 update dependency on artifact lib https://github.com/actions/download-artifact/commit/d9b73cccacd09ac21cc34b82578e6cbb1b4e2539;>d9b73cc update lock file Additional commits viewable in https://github.com/actions/download-artifact/compare/v2...v3;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/download-artifact=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an
[GitHub] [qpid-dispatch] ganeshmurthy merged pull request #1573: Bump actions/cache from 2.1.6 to 3.0.4
ganeshmurthy merged PR #1573: URL: https://github.com/apache/qpid-dispatch/pull/1573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1562: Bump browserslist from 4.20.0 to 4.20.3 in /console/react
dependabot[bot] commented on PR #1562: URL: https://github.com/apache/qpid-dispatch/pull/1562#issuecomment-1150175488 Superseded by #1575. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request, #1575: Bump browserslist from 4.20.0 to 4.20.4 in /console/react
dependabot[bot] opened a new pull request, #1575: URL: https://github.com/apache/qpid-dispatch/pull/1575 Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.20.0 to 4.20.4. Changelog Sourced from https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md;>browserslist's changelog. 4.20.4 Fix Opera in mobileToDesktop (by Pig Fang). 4.20.3 Add Baidu to dead browsers (by Igor Lukanin). 4.20.2 Fixed package.funding URL format. 4.20.1 Fixed package.funding. Fixed docs (by Michael Lohmann). 4.20 Added last 2 node versions and last 2 node major versions (by https://github.com/g-plane;>@g-plane). 4.19.3 Updated Firefox ESR (by Christophe Coevoet). 4.19.2 Fixed --help output. 4.19.1 Fixed throwOnMissing types (by Øyvind Saltvik). 4.19 Added queries grammar definition (by Pig Fang). Added throwOnMissing option (by Øyvind Saltvik). Fixed null data ignoring in 50% in CN (byPig Fang). Fixed data parsing in in my stats (by Sun Xiaoran). Fixed yarn.lock support with integrity (by Alexey Berezin). Fixed Yarn Berry error message in --update-db. 4.18.1 Fixed case inventiveness for cover queries (by Pig Fang). Fixed since 1970 query for null in release date (by Pig Fang). 4.18 Added --ignore-unknown-versions CLI option (by Pig Fang). 4.17.6 Fixed sharable config resolution (by Adaline Valentina Simonian). 4.17.5 Fixed --update-db for some pnpm cases. 4.17.4 Reduced package size. 4.17.3 ... (truncated) Commits https://github.com/browserslist/browserslist/commit/6ed5f04825aa7b662e224fb36668f2f60f8d4e0e;>6ed5f04 Release 4.20.4 version https://github.com/browserslist/browserslist/commit/cb135600866e19b9b4f3eeccf1fa7ec8e20439b7;>cb13560 Update dependencies https://github.com/browserslist/browserslist/commit/46bda3a1ed6266453a80dff6a9887b38d18650b2;>46bda3a exclude unreleased versions if mobileToDesktop enabled (https://github-redirect.dependabot.com/browserslist/browserslist/issues/697;>#697) https://github.com/browserslist/browserslist/commit/4b4e28a3df5fc5e397602a8f8602d74dcc6f8747;>4b4e28a Try to fix CI https://github.com/browserslist/browserslist/commit/8139500b7596a809663f3ba4a96da19d0fcda5de;>8139500 Update dependencies https://github.com/browserslist/browserslist/commit/80307e42ac56c27f5d3e8857487734f8bc56a544;>80307e4 Update dependencies https://github.com/browserslist/browserslist/commit/ee11be9c94b6a28c4a2fa0838b95e11ce6e643c1;>ee11be9 Mark Baidu browser as dead in README (https://github-redirect.dependabot.com/browserslist/browserslist/issues/689;>#689) https://github.com/browserslist/browserslist/commit/fdb14125623487d28d3247997ab643947d2ba6ce;>fdb1412 Release 4.20.3 version https://github.com/browserslist/browserslist/commit/dc48cfe1e154dab2e106aec27fba7cd5db076875;>dc48cfe Mark Baidu browser as dead (https://github-redirect.dependabot.com/browserslist/browserslist/issues/688;>#688) https://github.com/browserslist/browserslist/commit/cf8a51c944cfc5c1dd2952ff6e0bc6daca2d05bf;>cf8a51c Update CI and dependencies Additional commits viewable in https://github.com/browserslist/browserslist/compare/4.20.0...4.20.4;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=browserslist=npm_and_yarn=4.20.0=4.20.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) -
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1562: Bump browserslist from 4.20.0 to 4.20.3 in /console/react
dependabot[bot] closed pull request #1562: Bump browserslist from 4.20.0 to 4.20.3 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1551: Bump actions/setup-python from 2 to 3.1.1
dependabot[bot] closed pull request #1551: Bump actions/setup-python from 2 to 3.1.1 URL: https://github.com/apache/qpid-dispatch/pull/1551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1551: Bump actions/setup-python from 2 to 3.1.1
dependabot[bot] commented on PR #1551: URL: https://github.com/apache/qpid-dispatch/pull/1551#issuecomment-1150170595 Superseded by #1574. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request, #1574: Bump actions/setup-python from 2 to 4
dependabot[bot] opened a new pull request, #1574: URL: https://github.com/apache/qpid-dispatch/pull/1574 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 4. Release notes Sourced from https://github.com/actions/setup-python/releases;>actions/setup-python's releases. v4.0.0 What's Changed Support for python-version-file input: https://github-redirect.dependabot.com/actions/setup-python/issues/336;>#336 Example of usage: - uses: actions/setup-python@v4 with: python-version-file: '.python-version' # Read python version from a file - run: python my_script.py There is no default python version for this setup-python major version, the action requires to specify either python-version input or python-version-file input. If the python-version input is not specified the action will try to read required version from file from python-version-file input. Use pypyX.Y for PyPy python-version input: https://github-redirect.dependabot.com/actions/setup-python/issues/349;>#349 Example of usage: - uses: actions/setup-python@v4 with: python-version: 'pypy3.9' # pypy-X.Y kept for backward compatibility - run: python my_script.py RUNNER_TOOL_CACHE environment variable is equal AGENT_TOOLSDIRECTORY: https://github-redirect.dependabot.com/actions/setup-python/issues/338;>#338 Bugfix: create missing pypyX.Y symlinks: https://github-redirect.dependabot.com/actions/setup-python/issues/347;>#347 PKG_CONFIG_PATH environment variable: https://github-redirect.dependabot.com/actions/setup-python/issues/400;>#400 Added python-path output: https://github-redirect.dependabot.com/actions/setup-python/issues/405;>#405 python-path output contains Python executable path. Updated zeit/ncc to vercel/ncc package: https://github-redirect.dependabot.com/actions/setup-python/issues/393;>#393 Bugfix: fixed output for prerelease version of poetry: https://github-redirect.dependabot.com/actions/setup-python/issues/409;>#409 Made pythonLocation environment variable consistent for Python and PyPy: https://github-redirect.dependabot.com/actions/setup-python/issues/418;>#418 Bugfix for 3.x-dev syntax: https://github-redirect.dependabot.com/actions/setup-python/issues/417;>#417 Other improvements: https://github-redirect.dependabot.com/actions/setup-python/issues/318;>#318 https://github-redirect.dependabot.com/actions/setup-python/issues/396;>#396 https://github-redirect.dependabot.com/actions/setup-python/issues/384;>#384 https://github-redirect.dependabot.com/actions/setup-python/issues/387;>#387 https://github-redirect.dependabot.com/actions/setup-python/issues/388;>#388 Update actions/cache version to 2.0.2 In scope of this release we updated actions/cache package as the new version contains fixes related to GHES 3.5 (https://github-redirect.dependabot.com/actions/setup-python/pull/382;>actions/setup-python#382) Add cache-hit output and fix python-version output for PyPy This release introduces new output cache-hit (https://github-redirect.dependabot.com/actions/setup-python/pull/373;>actions/setup-python#373) and fix python-version output for PyPy (https://github-redirect.dependabot.com/actions/setup-python/pull/365;>actions/setup-python#365) The cache-hit output contains boolean value indicating that an exact match was found for the key. It shows that the action uses already existing cache or not. The output is available only if cache is enabled. ... (truncated) Commits https://github.com/actions/setup-python/commit/d09bd5e6005b175076f227b13d9730d56e9dcfcb;>d09bd5e fix: 3.x-dev can install a 3.y version (https://github-redirect.dependabot.com/actions/setup-python/issues/417;>#417) https://github.com/actions/setup-python/commit/f72db171abf897c3f4cea0427d5af95fa57fb1bc;>f72db17 Made env.var pythonLocation consistent for Python and PyPy (https://github-redirect.dependabot.com/actions/setup-python/issues/418;>#418) https://github.com/actions/setup-python/commit/53e15292cd6a522cb460037b6f031eadbd6f6920;>53e1529 add support for python-version-file (https://github-redirect.dependabot.com/actions/setup-python/issues/336;>#336) https://github.com/actions/setup-python/commit/3f82819745be54edd3bd8a83639605e58826bfe9;>3f82819 Fix output for prerelease version of poetry (https://github-redirect.dependabot.com/actions/setup-python/issues/409;>#409) https://github.com/actions/setup-python/commit/397252c5825684a4ffed92b79e0d840c618c0a93;>397252c Update zeit/ncc to vercel/ncc (https://github-redirect.dependabot.com/actions/setup-python/issues/393;>#393) https://github.com/actions/setup-python/commit/de977ad1321ff211fd43f0f232a4d8851726d4bb;>de977ad Merge pull request https://github-redirect.dependabot.com/actions/setup-python/issues/412;>#412 from
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551621#comment-17551621 ] Ken Giusti commented on PROTON-2556: Any use of internal proton APIs by skupper-router or qpid-dispatch is a bug and needs to be resolved in those projects. That said I was under the impression that proton-internal APIs used the pni_* prefix - is that not the case? Ideally if these internal apis are available via the public headers (c/include/proton) they should be moved to an internal header file or use conditional compilation to prevent use by outside project (just my $0.02 USD) > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551488#comment-17551488 ] Jiri Daněk commented on PROTON-2556: bq. I know that skupper router compiles fine with a few trivial changes - it doesn't use the internal data types of proton - is that something changed when they forked from dispatch router? Don't know. Depends on what the adaptors do? bq. Also and most importantly all these APIs are explicitly marked as internal in the header files and are not documented so that should strongly tell people not to use them because they aren't supported as API. In any case, I now feel better about this. Hopefully skupper can be easily updated and then the privatization can be done without any of these silly CI build breakages. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org