[jira] [Commented] (DISPATCH-2339) Update console to React 18 and react-scripts 5
[ https://issues.apache.org/jira/browse/DISPATCH-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635030#comment-17635030 ] ASF GitHub Bot commented on DISPATCH-2339: -- bartoval commented on PR #1560: URL: https://github.com/apache/qpid-dispatch/pull/1560#issuecomment-1317767608 @jiridanek the rhea libs is updated to the version 3.0.1. We can remove this modification and add ```import rhea from "rhea";``` in the connection.js file. Let me know if you want to update the code here or in case i can create a new PR? > Update console to React 18 and react-scripts 5 > -- > > Key: DISPATCH-2339 > URL: https://issues.apache.org/jira/browse/DISPATCH-2339 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.19.0 >Reporter: Jiri Daněk >Priority: Major > Fix For: 1.20.0 > > > {noformat} > $ npx react-scripts start > (node:836641) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] > DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use > the 'setupMiddlewares' option. > (Use `node --trace-deprecation ...` to show where the warning was created) > (node:836641) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] > DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please > use the 'setupMiddlewares' option. > Starting the development server... > Failed to compile. > Module not found: Error: Can't resolve 'os' in > '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib' > BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core > modules by default. > This is no longer the case. Verify if you need this module and configure a > polyfill for it. > If you want to include a polyfill, you need to: > - add a fallback 'resolve.fallback: { "os": > require.resolve("os-browserify/browser") }' > - install 'os-browserify' > If you don't want to include a polyfill, you can use an empty module like > this: > resolve.fallback: { "os": false } > ERROR in ./node_modules/rhea/lib/connection.js 36:9-22 > Module not found: Error: Can't resolve 'os' in > '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib' > BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core > modules by default. > This is no longer the case. Verify if you need this module and configure a > polyfill for it. > If you want to include a polyfill, you need to: > - add a fallback 'resolve.fallback: { "os": > require.resolve("os-browserify/browser") }' > - install 'os-browserify' > If you don't want to include a polyfill, you can use an empty module like > this: > resolve.fallback: { "os": false } > ERROR in ./node_modules/rhea/lib/connection.js 38:11-26 > Module not found: Error: Can't resolve 'path' in > '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib' > BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core > modules by default. > This is no longer the case. Verify if you need this module and configure a > polyfill for it. > If you want to include a polyfill, you need to: > - add a fallback 'resolve.fallback: { "path": > require.resolve("path-browserify") }' > - install 'path-browserify' > If you don't want to include a polyfill, you can use an empty module like > this: > resolve.fallback: { "path": false } > webpack compiled with 2 errors > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bartoval commented on pull request #1560: DISPATCH-2339: Update react-scripts to 5; add CRACO to reapply polyfills
bartoval commented on PR #1560: URL: https://github.com/apache/qpid-dispatch/pull/1560#issuecomment-1317767608 @jiridanek the rhea libs is updated to the version 3.0.1. We can remove this modification and add ```import rhea from "rhea";``` in the connection.js file. Let me know if you want to update the code here or in case i can create a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1599: Bump typescript from 4.6.2 to 4.8.4 in /console/react
dependabot[bot] commented on PR #1599: URL: https://github.com/apache/qpid-dispatch/pull/1599#issuecomment-1317365234 Superseded by #1607. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1599: Bump typescript from 4.6.2 to 4.8.4 in /console/react
dependabot[bot] closed pull request #1599: Bump typescript from 4.6.2 to 4.8.4 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request, #1607: Bump typescript from 4.6.2 to 4.9.3 in /console/react
dependabot[bot] opened a new pull request, #1607: URL: https://github.com/apache/qpid-dispatch/pull/1607 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.2 to 4.9.3. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases";>typescript's releases. TypeScript 4.8.4 For release notes, check out the https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/";>release announcement. For the complete list of fixed issues, check out the https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.0%22+";>fixed issues query for Typescript 4.8.0 (Beta). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.1%22+";>fixed issues query for Typescript 4.8.1 (RC). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.2%22+";>fixed issues query for Typescript 4.8.2 (Stable). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.3%22+";>fixed issues query for Typescript 4.8.3 (Stable). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.4%22+";>fixed issues query for Typescript 4.8.4 (Stable). Downloads are available on: https://www.npmjs.com/package/typescript";>npm https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-484";>Visual Studio 2022/2019 (https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017";>Select new version in project options) https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild";>NuGet package TypeScript 4.8.3 For release notes, check out the https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/";>release announcement. For the complete list of fixed issues, check out the https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.0%22+";>fixed issues query for Typescript 4.8.0 (Beta). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.1%22+";>fixed issues query for Typescript 4.8.1 (RC). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.2%22+";>fixed issues query for Typescript 4.8.2 (Stable). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.3%22+";>fixed issues query for Typescript 4.8.3 (Stable). Downloads are available on: https://www.npmjs.com/package/typescript";>npm https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-483";>Visual Studio 2022/2019 (https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017";>Select new version in project options) https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild";>NuGet package TypeScript 4.8 For release notes, check out the https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/";>release announcement. For the complete list of fixed issues, check out the https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.0%22+";>fixed issues query for Typescript 4.8.0 (Beta). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.1%22+";>fixed issues query for Typescript 4.8.1 (RC). https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.8.2%22+";>fixed issues query for Typescript 4.8.1 (Stable). Downloads are available on: https://www.npmjs.com/package/typescript";>npm https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-48";>Visual Studio 2022/2019 (https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017";>Select new version in project options) https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild";>NuGet package TypeScript 4.8 RC For release notes, check out the https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-rc/";>release announcement. ... (truncated) Commits See full diff in https://github.com/Microsoft/TypeScript/commits";>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=typescript&package-manager=npm_and_yarn&previous-version=4.6.2&new-version=4.9.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on i