[jira] [Commented] (QPID-8636) [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS)
[ https://issues.apache.org/jira/browse/QPID-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712823#comment-17712823 ] Jiri Daněk commented on QPID-8636: -- Linux docker images don't run on Windows in GitHub actions, whoops! > [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS) > - > > Key: QPID-8636 > URL: https://issues.apache.org/jira/browse/QPID-8636 > Project: Qpid > Issue Type: Task > Components: Python Client >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: qpid-python-1.38.0 > > > * (?) linters should run in separate jobs, on Python 2 and Python 3, OS does > not matter, so use Ubuntu > * (?) Windows should be tested, use Python 2 and Python 3.8 so that there is > not too many jobs > * (?) it might make sense to add macOS, it should "just work", maybe add only > Python 3.8 (when that works reasonably well) > Keeping in mind that testing qpid-cpp and qpid-j in docker takes time, and > docker might run even slower on Windows and macOS. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8636) [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS)
[ https://issues.apache.org/jira/browse/QPID-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved QPID-8636. -- Resolution: Fixed I'm not going to add macOS this time, because there is already enough work with Windows as it is. > [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS) > - > > Key: QPID-8636 > URL: https://issues.apache.org/jira/browse/QPID-8636 > Project: Qpid > Issue Type: Task > Components: Python Client >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: qpid-python-1.38.0 > > > * (?) linters should run in separate jobs, on Python 2 and Python 3, OS does > not matter, so use Ubuntu > * (?) Windows should be tested, use Python 2 and Python 3.8 so that there is > not too many jobs > * (?) it might make sense to add macOS, it should "just work", maybe add only > Python 3.8 (when that works reasonably well) > Keeping in mind that testing qpid-cpp and qpid-j in docker takes time, and > docker might run even slower on Windows and macOS. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8636) [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS)
[ https://issues.apache.org/jira/browse/QPID-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated QPID-8636: - Fix Version/s: qpid-python-1.38.0 > [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS) > - > > Key: QPID-8636 > URL: https://issues.apache.org/jira/browse/QPID-8636 > Project: Qpid > Issue Type: Task > Components: Python Client >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: qpid-python-1.38.0 > > > * (?) linters should run in separate jobs, on Python 2 and Python 3, OS does > not matter, so use Ubuntu > * (?) Windows should be tested, use Python 2 and Python 3.8 so that there is > not too many jobs > * (?) it might make sense to add macOS, it should "just work", maybe add only > Python 3.8 (when that works reasonably well) > Keeping in mind that testing qpid-cpp and qpid-j in docker takes time, and > docker might run even slower on Windows and macOS. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8636) [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS)
[ https://issues.apache.org/jira/browse/QPID-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712819#comment-17712819 ] ASF GitHub Bot commented on QPID-8636: -- jiridanek merged PR #22: URL: https://github.com/apache/qpid-python/pull/22 > [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS) > - > > Key: QPID-8636 > URL: https://issues.apache.org/jira/browse/QPID-8636 > Project: Qpid > Issue Type: Task > Components: Python Client >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > * (?) linters should run in separate jobs, on Python 2 and Python 3, OS does > not matter, so use Ubuntu > * (?) Windows should be tested, use Python 2 and Python 3.8 so that there is > not too many jobs > * (?) it might make sense to add macOS, it should "just work", maybe add only > Python 3.8 (when that works reasonably well) > Keeping in mind that testing qpid-cpp and qpid-j in docker takes time, and > docker might run even slower on Windows and macOS. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8636) [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS)
[ https://issues.apache.org/jira/browse/QPID-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712820#comment-17712820 ] ASF subversion and git services commented on QPID-8636: --- Commit 0bac85c96b19732964ef9ca893cbb7bbac5b7695 in qpid-python's branch refs/heads/main from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-python.git;h=0bac85c ] QPID-8636: separate out lint, qpid-cpp, and qpid-j ci jobs, add windows job for the ci (#22) > [qpid python] Reorganize CI jobs (separate lint, add Windows and maybe macOS) > - > > Key: QPID-8636 > URL: https://issues.apache.org/jira/browse/QPID-8636 > Project: Qpid > Issue Type: Task > Components: Python Client >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > * (?) linters should run in separate jobs, on Python 2 and Python 3, OS does > not matter, so use Ubuntu > * (?) Windows should be tested, use Python 2 and Python 3.8 so that there is > not too many jobs > * (?) it might make sense to add macOS, it should "just work", maybe add only > Python 3.8 (when that works reasonably well) > Keeping in mind that testing qpid-cpp and qpid-j in docker takes time, and > docker might run even slower on Windows and macOS. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-python] jiridanek merged pull request #22: QPID-8636: separate out lint, qpid-cpp, and qpid-j ci jobs, add windows job for the ci
jiridanek merged PR #22: URL: https://github.com/apache/qpid-python/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4015) qpid.packer.Packer implements abstract methods incorrectly.
[ https://issues.apache.org/jira/browse/QPID-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712811#comment-17712811 ] Jiri Daněk commented on QPID-4015: -- I agree with this, but adding a metaclass is inconvenient when python 2/3 compatibility is desired. I intend to wait and see what comes in the future. > qpid.packer.Packer implements abstract methods incorrectly. > --- > > Key: QPID-4015 > URL: https://issues.apache.org/jira/browse/QPID-4015 > Project: Qpid > Issue Type: Improvement > Components: Python Client >Reporter: Tim Sally >Priority: Minor > Labels: patch > Attachments: > 0001-Use-abstract-base-class-to-implement-qpid.packer.Pac.patch > > > qpid.packer.Packer implements abstract methods incorrectly. Specifically, it > uses the method suggested [here|http://norvig.com/python-iaq.html]. When an > abstract method is called, the invalid name _abstract_ results in a NameError > exception. The merits of this approach, along with the other most common > approaches, are summarized in the table below > ||MethodStops Execution||Stops Execution at Object Creation||Sensible > Exception Name|| > |_abstract_ keyword|yes|no|no| > |raise NotImplementedError|yes|no|yes| > |Abstract Base Classes|yes|yes|yes| > Using _abstract_ is not preferable because a NameError does not make > immediately clear what is going on. Raising a _NotImplementedError_ exception > is a great alternative because the exception name is logical. However, even > better is the use of Abstract Base Classes (ABCs). ABCs raise an exception at > object instantiation, whereas the other two methods do not result in an > exception until an abstract method is called. > As an example, consider qpid.codec010.Codec. It is not immediately clear this > class should not be used. And indeed, it is not used anywhere. Rather, > qpid.codec010.StringCodec is the only class in qpid.codec010 meant to be used > directly. Using an abstract base class prevents qpid.codec010.Codec objects > from being created. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7709) [qpid-cpp] Problem building on Fedora rawhide (-Werror=maybe-uninitialized in SelectorExpression.cpp)
[
https://issues.apache.org/jira/browse/QPID-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated QPID-7709:
-
Summary: [qpid-cpp] Problem building on Fedora rawhide
(-Werror=maybe-uninitialized in SelectorExpression.cpp) (was: Problem building
on Fedora rawhide)
> [qpid-cpp] Problem building on Fedora rawhide (-Werror=maybe-uninitialized in
> SelectorExpression.cpp)
> -
>
> Key: QPID-7709
> URL: https://issues.apache.org/jira/browse/QPID-7709
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-python-1.35.0
> Environment: Fedora rawhide
>Reporter: Irina Boverman
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: patch
> Fix For: qpid-cpp-1.40.0
>
> Attachments: QPID-7709-cpp-uninit.patch
>
>
> Fails to build in Fedora rawhide:
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/Selector.cpp: In member
> function 'const qpid::broker::Value
> qpid::broker::MessageSelectorEnv::specialValue(const string&) const':
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/Selector.cpp:169:11:
> error: 'v' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> v = Value();
> ~~^
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:
> In member function 'qpid::broker::Expression*
> qpid::broker::Parse::orExpression(qpid::broker::Tokeniser&)':
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> cc1plus: all warnings being treated as errors
> make[2]: *** [src/CMakeFiles/qpidbroker.dir/build.make:3234:
> src/CMakeFiles/qpidbroker.dir/qpid/broker/Selector.cpp.o] Error 1
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:
> In member function 'qpid::broker::Expression*
> qpid::broker::Parse::unaryArithExpression(qpid::broker::Tokeniser&)':
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> /builddir/build/BUILD/qpid-cpp-1.35.0/src/qpid/broker/SelectorExpression.cpp:1041:13:
> error: '*((void*)& s +17)' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> if (s[1]=='b' || s[1]=='B') {
> cc1plus: all warnings being treated as errors
> make[2]: *** [src/CMakeFiles/qpidbroker.dir/build.make:3258:
> src/CMakeFiles/qpidbroker.dir/qpid/broker/SelectorExpression.cpp.o] Error 1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7765) [qpid-cpp] Problem building on Fedora rawhide (-Werror=maybe-uninitialized, and std::auto_ptr gives deprecated-declarations warning)
[ https://issues.apache.org/jira/browse/QPID-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated QPID-7765: - Summary: [qpid-cpp] Problem building on Fedora rawhide (-Werror=maybe-uninitialized, and std::auto_ptr gives deprecated-declarations warning) (was: Problem building on Fedora rawhide) > [qpid-cpp] Problem building on Fedora rawhide (-Werror=maybe-uninitialized, > and std::auto_ptr gives deprecated-declarations warning) > > > Key: QPID-7765 > URL: https://issues.apache.org/jira/browse/QPID-7765 > Project: Qpid > Issue Type: Bug > Components: C++ Build >Affects Versions: qpid-cpp-1.36.0 > Environment: Fedora rawhide x86_64 >Reporter: Irina Boverman >Priority: Major > > [ 57%] Building CXX object > src/CMakeFiles/qpidbroker.dir/qpid/broker/TxAccept.cpp.o > cd /builddir/build/BUILD/qpid-cpp-1.36.0/src && /usr/bin/c++ > -DXQ_EFFECTIVE_BOOLEAN_VALUE_HPP -Dqpidbroker_EXPORTS > -I/builddir/build/BUILD/qpid-cpp-1.36.0/src > -I/builddir/build/BUILD/qpid-cpp-1.36.0/src/../include -I/usr/include/nss3 > -I/usr/include/nspr4 -std=c++11 -Wno-implicit-fallthrough -O2 -g -pipe -Wall > -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches > -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic > -fvisibility-inlines-hidden -Werror -pedantic -Wall -Wextra -Wno-shadow > -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long > -Wvolatile-register-var -Winvalid-pch -Wno-system-headers > -Woverloaded-virtual -Wno-error=deprecated-declarations -O2 -g -DNDEBUG -fPIC > -pthread -o CMakeFiles/qpidbroker.dir/qpid/broker/TxAccept.cpp.o -c > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/TxAccept.cpp > In file included from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/DtxBuffer.h:25:0, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/DtxManager.h:24, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/Broker.h:30, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/LinkRegistry.cpp:23: > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/TxBuffer.h:76:10: > warning: 'template class std::auto_ptr' is deprecated > [-Wdeprecated-declarations] > std::auto_ptr txContext; > ^~~~ > In file included from /usr/include/c++/7/memory:80:0, > from /usr/include/boost/config/no_tr1/memory.hpp:21, > from /usr/include/boost/smart_ptr/shared_ptr.hpp:23, > from /usr/include/boost/shared_ptr.hpp:17, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/framing/Array.h:28, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/framing/AMQP_ServerProxy.h:31, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/Bridge.h:25, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/LinkRegistry.h:27, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/LinkRegistry.cpp:21: > /usr/include/c++/7/bits/unique_ptr.h:51:28: note: declared here >template class auto_ptr; > ^~~~ > In file included from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/DtxManager.h:25:0, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/Broker.h:30, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/LinkRegistry.cpp:23: > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/DtxWorkRecord.h:59:10: > warning: 'template class std::auto_ptr' is deprecated > [-Wdeprecated-declarations] > std::auto_ptr txn; > ^~~~ > In file included from /usr/include/c++/7/memory:80:0, > from /usr/include/boost/config/no_tr1/memory.hpp:21, > from /usr/include/boost/smart_ptr/shared_ptr.hpp:23, > from /usr/include/boost/shared_ptr.hpp:17, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/framing/Array.h:28, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/framing/AMQP_ServerProxy.h:31, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/Bridge.h:25, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/LinkRegistry.h:27, > from > /builddir/build/BUILD/qpid-cpp-1.36.0/src/qpid/broker/LinkRegistry.cpp:21: > /usr/include/c++/7/bits/unique_ptr.h:51:28: note: declared here >template class auto_ptr; > ^~~~ > In file included from >
[jira] [Resolved] (QPID-8413) Python3 support in build scripts
[
https://issues.apache.org/jira/browse/QPID-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved QPID-8413.
--
Fix Version/s: qpid-cpp-1.40.0
Resolution: Fixed
> Python3 support in build scripts
>
>
> Key: QPID-8413
> URL: https://issues.apache.org/jira/browse/QPID-8413
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.40.0
> Environment: Docker build environment for Qpid,
> [https://github.com/arpa2/docker-demo/tree/11429b52b9419c7f49367abe648b3bc67613bdba/build-qpid]
> Imports gcc/g++ and Python3 from Debian stable in binary layers. Builds
> proton but not qpid-cpp-broker.
> You are welcome to "docker build ." in this directory and see it fail. It
> uses qpid-cpp-broker as a git checkout from master so you can even work in
> there :)
>Reporter: Rick van Rein
>Priority: Major
> Labels: Python3, build-failure, cmake
> Fix For: qpid-cpp-1.40.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Python 2.7 is soon loosing support and as a result we gradually abandoned it
> in the 2nd half of 2019. We have certainly not been early adopters!
> Now, building Qpid from source, I find that it still relies on this old
> version. It does not even notice though, which is not very handy in a time
> that people are migrating:
>
> {\{-- Found PythonInterp: /usr/bin/python (found suitable version "3.7.3",
> minimum required is "2.7") }}
> \{{-- Found PythonInterp: /usr/bin/python (found version "3.7.3") }}
> \{{ File "", line 1}}
> {{ from distutils.sysconfig import get_python_lib; print
> get_python_lib(False, prefix='/usr/local').replace('
> ', '/')}}
> \{{ ^}}
> {{SyntaxError: invalid syntax}}
> {{CMake Error at managementgen/CMakeLists.txt:34 (install):}}
> \{{ install DIRECTORY given no DESTINATION!}}
>
> Python3 bails out with an error, about the lack of parenthesis, but CMake
> concludes its own things. Looking silly. It does continue to one more
> similar error:
>
> {{-- Regenerating Qpid Management Framework sources}}
> \{{ File "/usr/local/src/qpid-cpp-broker.git/managementgen/qmf-gen", line
> 64}}
> \{{ print "no input files"}}
> \{{ ^}}
> {{SyntaxError: Missing parentheses in call to 'print'. Did you mean
> print("no input files")?}}
> {{CMake Error at src/CMakeLists.txt:141 (include):}}
> \{{ include could not find load
> file:}}{{/usr/local/src/qpid-cpp-broker.git/build/src/managementgen.cmake}}
> {{CMake Error at /usr/share/cmake-3.13/Modules/FindBoost.cmake:2100
> (message):}}
> \{{ Unable to find the requested Boost libraries.}}{{Unable to find the
> Boost header files. Please set BOOST_ROOT to the root}}
> \{{ directory containing Boost or BOOST_INCLUDEDIR to the directory
> containing}}
> \{{ Boost's headers.}}
> {{Call Stack (most recent call first):}}
> \{{ src/CMakeLists.txt:194 (find_package)}}
> {{CMake Error at /usr/share/cmake-3.13/Modules/FindBoost.cmake:2100
> (message):}}
> \{{ Unable to find the requested Boost libraries.}}{{Unable to find the
> Boost header files. Please set BOOST_ROOT to the root}}
> \{{ directory containing Boost or BOOST_INCLUDEDIR to the directory
> containing}}
> \{{ Boost's headers.}}
> {{Call Stack (most recent call first):}}
> \{{ src/CMakeLists.txt:208 (find_package)}}
> {{CMake Error at src/CMakeLists.txt:210 (message):}}
> \{{ Required Boost C++ libraries not found. Please install or try setting}}
> \{{ BOOST_ROOT}}
> {{-- Configuring incomplete, errors occurred!}}
>
> Again, the parenthesis of print. And again, CMake concludes its own things,
> presumably from the exit value.
>
> I don't believe I am being a Python3 pusher at this time, not anymore; last
> year it has been anounced that Python2.7 would be gone at the start of 2020.
> (I checked again and found it is now set at [April
> 2020|http://pyfound.blogspot.com/2019/12/python-2-sunset.html[],] but still
> very soon.)
> Please update Qpid accordingly, so people relying on Python3 for
> security/updates have a way to continue using/building Qpid? By now,
> everyone should at least be able to run Python3, or else that is a fair
> upgrade expectation, as it will soon be the only real Python left.
>
> Thanks!
> -Rick
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8413) Python3 support in build scripts
[
https://issues.apache.org/jira/browse/QPID-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned QPID-8413:
Assignee: Jiri Daněk
> Python3 support in build scripts
>
>
> Key: QPID-8413
> URL: https://issues.apache.org/jira/browse/QPID-8413
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.40.0
> Environment: Docker build environment for Qpid,
> [https://github.com/arpa2/docker-demo/tree/11429b52b9419c7f49367abe648b3bc67613bdba/build-qpid]
> Imports gcc/g++ and Python3 from Debian stable in binary layers. Builds
> proton but not qpid-cpp-broker.
> You are welcome to "docker build ." in this directory and see it fail. It
> uses qpid-cpp-broker as a git checkout from master so you can even work in
> there :)
>Reporter: Rick van Rein
>Assignee: Jiri Daněk
>Priority: Major
> Labels: Python3, build-failure, cmake
> Fix For: qpid-cpp-1.40.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Python 2.7 is soon loosing support and as a result we gradually abandoned it
> in the 2nd half of 2019. We have certainly not been early adopters!
> Now, building Qpid from source, I find that it still relies on this old
> version. It does not even notice though, which is not very handy in a time
> that people are migrating:
>
> {\{-- Found PythonInterp: /usr/bin/python (found suitable version "3.7.3",
> minimum required is "2.7") }}
> \{{-- Found PythonInterp: /usr/bin/python (found version "3.7.3") }}
> \{{ File "", line 1}}
> {{ from distutils.sysconfig import get_python_lib; print
> get_python_lib(False, prefix='/usr/local').replace('
> ', '/')}}
> \{{ ^}}
> {{SyntaxError: invalid syntax}}
> {{CMake Error at managementgen/CMakeLists.txt:34 (install):}}
> \{{ install DIRECTORY given no DESTINATION!}}
>
> Python3 bails out with an error, about the lack of parenthesis, but CMake
> concludes its own things. Looking silly. It does continue to one more
> similar error:
>
> {{-- Regenerating Qpid Management Framework sources}}
> \{{ File "/usr/local/src/qpid-cpp-broker.git/managementgen/qmf-gen", line
> 64}}
> \{{ print "no input files"}}
> \{{ ^}}
> {{SyntaxError: Missing parentheses in call to 'print'. Did you mean
> print("no input files")?}}
> {{CMake Error at src/CMakeLists.txt:141 (include):}}
> \{{ include could not find load
> file:}}{{/usr/local/src/qpid-cpp-broker.git/build/src/managementgen.cmake}}
> {{CMake Error at /usr/share/cmake-3.13/Modules/FindBoost.cmake:2100
> (message):}}
> \{{ Unable to find the requested Boost libraries.}}{{Unable to find the
> Boost header files. Please set BOOST_ROOT to the root}}
> \{{ directory containing Boost or BOOST_INCLUDEDIR to the directory
> containing}}
> \{{ Boost's headers.}}
> {{Call Stack (most recent call first):}}
> \{{ src/CMakeLists.txt:194 (find_package)}}
> {{CMake Error at /usr/share/cmake-3.13/Modules/FindBoost.cmake:2100
> (message):}}
> \{{ Unable to find the requested Boost libraries.}}{{Unable to find the
> Boost header files. Please set BOOST_ROOT to the root}}
> \{{ directory containing Boost or BOOST_INCLUDEDIR to the directory
> containing}}
> \{{ Boost's headers.}}
> {{Call Stack (most recent call first):}}
> \{{ src/CMakeLists.txt:208 (find_package)}}
> {{CMake Error at src/CMakeLists.txt:210 (message):}}
> \{{ Required Boost C++ libraries not found. Please install or try setting}}
> \{{ BOOST_ROOT}}
> {{-- Configuring incomplete, errors occurred!}}
>
> Again, the parenthesis of print. And again, CMake concludes its own things,
> presumably from the exit value.
>
> I don't believe I am being a Python3 pusher at this time, not anymore; last
> year it has been anounced that Python2.7 would be gone at the start of 2020.
> (I checked again and found it is now set at [April
> 2020|http://pyfound.blogspot.com/2019/12/python-2-sunset.html[],] but still
> very soon.)
> Please update Qpid accordingly, so people relying on Python3 for
> security/updates have a way to continue using/building Qpid? By now,
> everyone should at least be able to run Python3, or else that is a fair
> upgrade expectation, as it will soon be the only real Python left.
>
> Thanks!
> -Rick
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8516) Python excerpts in CMakeFiles are python2
[
https://issues.apache.org/jira/browse/QPID-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved QPID-8516.
--
Resolution: Fixed
This appears to have been resolved by the PR from @crichardson, the Python 3
GHA job is getting past CMake compilation now.
> Python excerpts in CMakeFiles are python2
> -
>
> Key: QPID-8516
> URL: https://issues.apache.org/jira/browse/QPID-8516
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.39.0
>Reporter: Chris Richardson
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> CMake fails on python3-only systems with
> {quote}-- Found PythonInterp: /usr/bin/python (found suitable version
> "3.8.8", minimum required is "2.7")
> -- Found PythonInterp: /usr/bin/python (found version "3.8.8")
> File "", line 1
> from distutils.sysconfig import get_python_lib; print get_python_lib(False,
> prefix='/usr/local').replace('\\', '/')
> ^
> SyntaxError: invalid syntax
> CMake Error at managementgen/CMakeLists.txt:34 (install):
> install DIRECTORY given no DESTINATION!
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8516) Python excerpts in CMakeFiles are python2
[
https://issues.apache.org/jira/browse/QPID-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned QPID-8516:
Assignee: Jiri Daněk (was: Chris Richardson)
> Python excerpts in CMakeFiles are python2
> -
>
> Key: QPID-8516
> URL: https://issues.apache.org/jira/browse/QPID-8516
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.39.0
>Reporter: Chris Richardson
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> CMake fails on python3-only systems with
> {quote}-- Found PythonInterp: /usr/bin/python (found suitable version
> "3.8.8", minimum required is "2.7")
> -- Found PythonInterp: /usr/bin/python (found version "3.8.8")
> File "", line 1
> from distutils.sysconfig import get_python_lib; print get_python_lib(False,
> prefix='/usr/local').replace('\\', '/')
> ^
> SyntaxError: invalid syntax
> CMake Error at managementgen/CMakeLists.txt:34 (install):
> install DIRECTORY given no DESTINATION!
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8516) Python excerpts in CMakeFiles are python2
[
https://issues.apache.org/jira/browse/QPID-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned QPID-8516:
Assignee: Chris Richardson
> Python excerpts in CMakeFiles are python2
> -
>
> Key: QPID-8516
> URL: https://issues.apache.org/jira/browse/QPID-8516
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.39.0
>Reporter: Chris Richardson
>Assignee: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> CMake fails on python3-only systems with
> {quote}-- Found PythonInterp: /usr/bin/python (found suitable version
> "3.8.8", minimum required is "2.7")
> -- Found PythonInterp: /usr/bin/python (found version "3.8.8")
> File "", line 1
> from distutils.sysconfig import get_python_lib; print get_python_lib(False,
> prefix='/usr/local').replace('\\', '/')
> ^
> SyntaxError: invalid syntax
> CMake Error at managementgen/CMakeLists.txt:34 (install):
> install DIRECTORY given no DESTINATION!
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8605) Compilation prints annoying deprecation message from Boost many times: declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated
[
https://issues.apache.org/jira/browse/QPID-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712771#comment-17712771
]
Jiri Daněk commented on QPID-8605:
--
I'm thinking of moving to the lambdas eventually, but for now, the minimally
disruptive change that gets rid of the warning is to add the global define.
> Compilation prints annoying deprecation message from Boost many times:
> declaring the Bind placeholders (_1, _2, ...) in the global namespace is
> deprecated
> --
>
> Key: QPID-8605
> URL: https://issues.apache.org/jira/browse/QPID-8605
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> https://github.com/jiridanek/qpid-cpp/actions/runs/3308231051/jobs/5460459408#step:12:104
> {noformat}
> C:\vcpkg\installed\x64-windows\include\boost/bind.hpp(41): message : The
> practice of declaring the Bind placeholders (_1, _2, ...) in the global
> namespace is deprecated. Please use + using namespace
> boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the
> current behavior. [D:\a\qpid-cpp\qpid-cpp\BLD\src\qpidcommon.vcxproj]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8605) Compilation prints annoying deprecation message from Boost many times: declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated
[
https://issues.apache.org/jira/browse/QPID-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned QPID-8605:
Assignee: Jiri Daněk
> Compilation prints annoying deprecation message from Boost many times:
> declaring the Bind placeholders (_1, _2, ...) in the global namespace is
> deprecated
> --
>
> Key: QPID-8605
> URL: https://issues.apache.org/jira/browse/QPID-8605
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> https://github.com/jiridanek/qpid-cpp/actions/runs/3308231051/jobs/5460459408#step:12:104
> {noformat}
> C:\vcpkg\installed\x64-windows\include\boost/bind.hpp(41): message : The
> practice of declaring the Bind placeholders (_1, _2, ...) in the global
> namespace is deprecated. Please use + using namespace
> boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the
> current behavior. [D:\a\qpid-cpp\qpid-cpp\BLD\src\qpidcommon.vcxproj]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8605) Compilation prints annoying deprecation message from Boost many times: declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated
[
https://issues.apache.org/jira/browse/QPID-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated QPID-8605:
-
Fix Version/s: qpid-cpp-1.40.0
> Compilation prints annoying deprecation message from Boost many times:
> declaring the Bind placeholders (_1, _2, ...) in the global namespace is
> deprecated
> --
>
> Key: QPID-8605
> URL: https://issues.apache.org/jira/browse/QPID-8605
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> https://github.com/jiridanek/qpid-cpp/actions/runs/3308231051/jobs/5460459408#step:12:104
> {noformat}
> C:\vcpkg\installed\x64-windows\include\boost/bind.hpp(41): message : The
> practice of declaring the Bind placeholders (_1, _2, ...) in the global
> namespace is deprecated. Please use + using namespace
> boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the
> current behavior. [D:\a\qpid-cpp\qpid-cpp\BLD\src\qpidcommon.vcxproj]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8609) Compilation issues on Visual Studio 2022 Windows 10
[
https://issues.apache.org/jira/browse/QPID-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712764#comment-17712764
]
Jiri Daněk commented on QPID-8609:
--
Fixed in commit
https://github.com/apache/qpid-cpp/commit/da9e2200f0e6b0e7e04ed41a015051341b3502f8
QPID-8610: add GitHub Actions workflow to build project and run ctest (#34)
> Compilation issues on Visual Studio 2022 Windows 10
> ---
>
> Key: QPID-8609
> URL: https://issues.apache.org/jira/browse/QPID-8609
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> {noformat}
> C:/PROGRA~1/MICROS~2/2022/ENTERP~1/Common7/IDE/COMMON~1/MICROS~1/CMake/CMake/bin/cmcldeps.exe
> RC
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res.d
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> "Note: including file: " "C:/Program Files/Microsoft Visual
> Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe"
> C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe -Dqpidcommon_EXPORTS -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\windows\resources -I
> C:\src\vcpkg\installed\x64-windows\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\..\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\..\include
> -DWIN32 -D_DEBUG /w44996 /D _CRT_NONSTDC_NO_WARNINGS /D NOMINMAX /D
> WIN32_LEAN_AND_MEAN /wd4244 /wd4800 /wd4355 /wd4267 /D _WIN32_WINNT=0x0502 /D
> BOOST_ALL_DYN_LINK /fo
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> {noformat}
> {noformat}
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\EXEC :
> fatal error RC1106: invalid option: -44996
> {noformat}
> Looks like it is caused by this definition in CMakeLists.txt
> {code}
> if (MSVC)
> # Chaxnge warning C4996 from level 1 to level 4. These are real and
> shouldn't
> # be completely ignored, but they're pretty well checked out and will throw
> # a run-time error if violated.
> # "warning C4996: 'std::equal': Function call with parameters that may
> # be unsafe..."
> add_definitions(/w44996)
> endif (MSVC)
> {code}
> According to latest docs, the switch to turn this off is {{/wd4996}}
> https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-170
> and that should work in Visual Studio 2015 and up, so it makes sense to me
> to change this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8609) Compilation issues on Visual Studio 2022 Windows 10
[
https://issues.apache.org/jira/browse/QPID-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated QPID-8609:
-
Affects Version/s: qpid-cpp-1.38.0
(was: qpid-cpp-1.40.0)
> Compilation issues on Visual Studio 2022 Windows 10
> ---
>
> Key: QPID-8609
> URL: https://issues.apache.org/jira/browse/QPID-8609
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.38.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> {noformat}
> C:/PROGRA~1/MICROS~2/2022/ENTERP~1/Common7/IDE/COMMON~1/MICROS~1/CMake/CMake/bin/cmcldeps.exe
> RC
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res.d
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> "Note: including file: " "C:/Program Files/Microsoft Visual
> Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe"
> C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe -Dqpidcommon_EXPORTS -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\windows\resources -I
> C:\src\vcpkg\installed\x64-windows\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\..\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\..\include
> -DWIN32 -D_DEBUG /w44996 /D _CRT_NONSTDC_NO_WARNINGS /D NOMINMAX /D
> WIN32_LEAN_AND_MEAN /wd4244 /wd4800 /wd4355 /wd4267 /D _WIN32_WINNT=0x0502 /D
> BOOST_ALL_DYN_LINK /fo
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> {noformat}
> {noformat}
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\EXEC :
> fatal error RC1106: invalid option: -44996
> {noformat}
> Looks like it is caused by this definition in CMakeLists.txt
> {code}
> if (MSVC)
> # Chaxnge warning C4996 from level 1 to level 4. These are real and
> shouldn't
> # be completely ignored, but they're pretty well checked out and will throw
> # a run-time error if violated.
> # "warning C4996: 'std::equal': Function call with parameters that may
> # be unsafe..."
> add_definitions(/w44996)
> endif (MSVC)
> {code}
> According to latest docs, the switch to turn this off is {{/wd4996}}
> https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-170
> and that should work in Visual Studio 2015 and up, so it makes sense to me
> to change this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8609) Compilation issues on Visual Studio 2022 Windows 10
[
https://issues.apache.org/jira/browse/QPID-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved QPID-8609.
--
Resolution: Fixed
> Compilation issues on Visual Studio 2022 Windows 10
> ---
>
> Key: QPID-8609
> URL: https://issues.apache.org/jira/browse/QPID-8609
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> {noformat}
> C:/PROGRA~1/MICROS~2/2022/ENTERP~1/Common7/IDE/COMMON~1/MICROS~1/CMake/CMake/bin/cmcldeps.exe
> RC
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res.d
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> "Note: including file: " "C:/Program Files/Microsoft Visual
> Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe"
> C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe -Dqpidcommon_EXPORTS -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\windows\resources -I
> C:\src\vcpkg\installed\x64-windows\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\..\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\..\include
> -DWIN32 -D_DEBUG /w44996 /D _CRT_NONSTDC_NO_WARNINGS /D NOMINMAX /D
> WIN32_LEAN_AND_MEAN /wd4244 /wd4800 /wd4355 /wd4267 /D _WIN32_WINNT=0x0502 /D
> BOOST_ALL_DYN_LINK /fo
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> {noformat}
> {noformat}
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\EXEC :
> fatal error RC1106: invalid option: -44996
> {noformat}
> Looks like it is caused by this definition in CMakeLists.txt
> {code}
> if (MSVC)
> # Chaxnge warning C4996 from level 1 to level 4. These are real and
> shouldn't
> # be completely ignored, but they're pretty well checked out and will throw
> # a run-time error if violated.
> # "warning C4996: 'std::equal': Function call with parameters that may
> # be unsafe..."
> add_definitions(/w44996)
> endif (MSVC)
> {code}
> According to latest docs, the switch to turn this off is {{/wd4996}}
> https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-170
> and that should work in Visual Studio 2015 and up, so it makes sense to me
> to change this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8609) Compilation issues on Visual Studio 2022 Windows 10
[
https://issues.apache.org/jira/browse/QPID-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated QPID-8609:
-
Fix Version/s: qpid-cpp-1.40.0
> Compilation issues on Visual Studio 2022 Windows 10
> ---
>
> Key: QPID-8609
> URL: https://issues.apache.org/jira/browse/QPID-8609
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> {noformat}
> C:/PROGRA~1/MICROS~2/2022/ENTERP~1/Common7/IDE/COMMON~1/MICROS~1/CMake/CMake/bin/cmcldeps.exe
> RC
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res.d
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> "Note: including file: " "C:/Program Files/Microsoft Visual
> Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe"
> C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe -Dqpidcommon_EXPORTS -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\windows\resources -I
> C:\src\vcpkg\installed\x64-windows\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\..\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\..\include
> -DWIN32 -D_DEBUG /w44996 /D _CRT_NONSTDC_NO_WARNINGS /D NOMINMAX /D
> WIN32_LEAN_AND_MEAN /wd4244 /wd4800 /wd4355 /wd4267 /D _WIN32_WINNT=0x0502 /D
> BOOST_ALL_DYN_LINK /fo
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> {noformat}
> {noformat}
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\EXEC :
> fatal error RC1106: invalid option: -44996
> {noformat}
> Looks like it is caused by this definition in CMakeLists.txt
> {code}
> if (MSVC)
> # Chaxnge warning C4996 from level 1 to level 4. These are real and
> shouldn't
> # be completely ignored, but they're pretty well checked out and will throw
> # a run-time error if violated.
> # "warning C4996: 'std::equal': Function call with parameters that may
> # be unsafe..."
> add_definitions(/w44996)
> endif (MSVC)
> {code}
> According to latest docs, the switch to turn this off is {{/wd4996}}
> https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-170
> and that should work in Visual Studio 2015 and up, so it makes sense to me
> to change this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8609) Compilation issues on Visual Studio 2022 Windows 10
[
https://issues.apache.org/jira/browse/QPID-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned QPID-8609:
Assignee: Jiri Daněk
> Compilation issues on Visual Studio 2022 Windows 10
> ---
>
> Key: QPID-8609
> URL: https://issues.apache.org/jira/browse/QPID-8609
> Project: Qpid
> Issue Type: Bug
> Components: C++ Build
>Affects Versions: qpid-cpp-1.40.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: qpid-cpp-1.40.0
>
>
> {noformat}
> C:/PROGRA~1/MICROS~2/2022/ENTERP~1/Common7/IDE/COMMON~1/MICROS~1/CMake/CMake/bin/cmcldeps.exe
> RC
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res.d
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> "Note: including file: " "C:/Program Files/Microsoft Visual
> Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe"
> C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe -Dqpidcommon_EXPORTS -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\windows\resources -I
> C:\src\vcpkg\installed\x64-windows\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\src\..\include -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src -I
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\..\include
> -DWIN32 -D_DEBUG /w44996 /D _CRT_NONSTDC_NO_WARNINGS /D NOMINMAX /D
> WIN32_LEAN_AND_MEAN /wd4244 /wd4800 /wd4355 /wd4267 /D _WIN32_WINNT=0x0502 /D
> BOOST_ALL_DYN_LINK /fo
> src\CMakeFiles\qpidcommon.dir\windows\resources\qpidcommon-resource.rc.res
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\src\windows\resources\qpidcommon-resource.rc
> {noformat}
> {noformat}
> C:\Users\jdanek\Source\Repos\jiridanek\qpid-cpp\out\build\x64-Debug\EXEC :
> fatal error RC1106: invalid option: -44996
> {noformat}
> Looks like it is caused by this definition in CMakeLists.txt
> {code}
> if (MSVC)
> # Chaxnge warning C4996 from level 1 to level 4. These are real and
> shouldn't
> # be completely ignored, but they're pretty well checked out and will throw
> # a run-time error if violated.
> # "warning C4996: 'std::equal': Function call with parameters that may
> # be unsafe..."
> add_definitions(/w44996)
> endif (MSVC)
> {code}
> According to latest docs, the switch to turn this off is {{/wd4996}}
> https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-170
> and that should work in Visual Studio 2015 and up, so it makes sense to me
> to change this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
