[GitHub] [qpid-proton] gemmellr merged pull request #399: Remove 'continue' workaround for otel buiild
gemmellr merged PR #399: URL: https://github.com/apache/qpid-proton/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on a diff in pull request #398: Fix build for jaeger to otlp tracing changes
DreamPearl commented on code in PR #398: URL: https://github.com/apache/qpid-proton/pull/398#discussion_r1210538531 ## ci/otel.sh: ## @@ -38,6 +38,6 @@ mkdir build cd build cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_TESTING=OFF -DWITH_OTLP=ON -DWITH_OTLP_HTTP=ON -DWITH_OTLP_GRPC=OFF Review Comment: Just to follow up here: Looks like we can't remove any of the flags for now, as it is leading to otel build failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on pull request #399: Fix WITH_OTLP warnings
DreamPearl commented on PR #399: URL: https://github.com/apache/qpid-proton/pull/399#issuecomment-156872 Ah yes. Then we need all three flags to make it work (I have also tried removing only -WITH_OTLP and keeping others, otel build is still failing). I guess, we have to ignore the warning for now and come back to it later. And sure, I will remove the Andrew's earlier workaround so that we can see the otel build failure if it's there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #399: Fix WITH_OTLP warnings
gemmellr commented on PR #399: URL: https://github.com/apache/qpid-proton/pull/399#issuecomment-1568702111 Unexpectedly, this seemingly causes an error during the otel build, which passed before but fails now. It didnt fail the overall job due to Andrews prior 'commit before otel was released' workaround escaping the error from the build script. We should probably remove that so failures there cause the job to fail. > /usr/bin/ld: cannot find -lopentelemetry_exporter_otlp_http: No such file or directory collect2: error: ld returned 1 exit status gmake[2]: *** [examples/otlp/CMakeFiles/example_otlp_http.dir/build.make:101: examples/otlp/example_otlp_http] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:892: examples/otlp/CMakeFiles/example_otlp_http.dir/all] Error 2 gmake: *** [Makefile:136: all] Error 2 Couldn't build Opentelemetry, continuing... https://github.com/apache/qpid-proton/actions/runs/5121570439/jobs/9211136276?pr=399#step:10:292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2741) [protonj2] Update project test dependencies to latest
Timothy A. Bish created PROTON-2741: --- Summary: [protonj2] Update project test dependencies to latest Key: PROTON-2741 URL: https://issues.apache.org/jira/browse/PROTON-2741 Project: Qpid Proton Issue Type: Task Components: protonj2 Affects Versions: protonj2-1.0.0-M15 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: protonj2-1.0.0-M16 Update test dependencies to latest versions -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2740) [protonj2] Update Netty to latest release
[ https://issues.apache.org/jira/browse/PROTON-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727547#comment-17727547 ] ASF subversion and git services commented on PROTON-2740: - Commit ebfcf55361e65eb33d2f488614a761bfa92369ed in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=ebfcf553 ] PROTON-2740 Update to netty 4.1.93.Final > [protonj2] Update Netty to latest release > - > > Key: PROTON-2740 > URL: https://issues.apache.org/jira/browse/PROTON-2740 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M15 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: protonj2-1.0.0-M16 > > > Update to Netty latest release -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2740) [protonj2] Update Netty to latest release
Timothy A. Bish created PROTON-2740: --- Summary: [protonj2] Update Netty to latest release Key: PROTON-2740 URL: https://issues.apache.org/jira/browse/PROTON-2740 Project: Qpid Proton Issue Type: Task Components: protonj2 Affects Versions: protonj2-1.0.0-M15 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: protonj2-1.0.0-M16 Update to Netty latest release -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on a diff in pull request #398: Fix build for jaeger to otlp tracing changes
DreamPearl commented on code in PR #398: URL: https://github.com/apache/qpid-proton/pull/398#discussion_r1210203808 ## ci/otel.sh: ## @@ -38,6 +38,6 @@ mkdir build cd build cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_TESTING=OFF -DWITH_OTLP=ON -DWITH_OTLP_HTTP=ON -DWITH_OTLP_GRPC=OFF Review Comment: Yeah, (it seems) only WITH_OTLP_HTTP is good to go. We can remove the rest. Done https://github.com/apache/qpid-proton/pull/399. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl opened a new pull request, #399: Fix WITH_OTLP warnings
DreamPearl opened a new pull request, #399: URL: https://github.com/apache/qpid-proton/pull/399 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on a diff in pull request #398: Fix build for jaeger to otlp tracing changes
DreamPearl commented on code in PR #398: URL: https://github.com/apache/qpid-proton/pull/398#discussion_r1210203808 ## ci/otel.sh: ## @@ -38,6 +38,6 @@ mkdir build cd build cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_TESTING=OFF -DWITH_OTLP=ON -DWITH_OTLP_HTTP=ON -DWITH_OTLP_GRPC=OFF Review Comment: Yeah, (it seems) only WITH_OTLP_HTTP is good to go. We can remove the rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr merged pull request #398: Fix build for jaeger to otlp tracing changes
gemmellr merged PR #398: URL: https://github.com/apache/qpid-proton/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on a diff in pull request #398: Fix build for jaeger to otlp tracing changes
gemmellr commented on code in PR #398: URL: https://github.com/apache/qpid-proton/pull/398#discussion_r1210174600 ## ci/otel.sh: ## @@ -38,6 +38,6 @@ mkdir build cd build cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_TESTING=OFF -DWITH_OTLP=ON -DWITH_OTLP_HTTP=ON -DWITH_OTLP_GRPC=OFF Review Comment: Its setting WITH_OTLP, and also setting both WITH_OTLP_HTTP + WITH_OTLP_GRPC...the warnings seems like the latter two are replacement options, so can we just remove the first one now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
