[jira] [Commented] (QPID-8666) [Broker-J] Broker plugin jdbc-provider-bone replacement
[
https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813699#comment-17813699
]
ASF GitHub Bot commented on QPID-8666:
--
gemmellr commented on code in PR #238:
URL: https://github.com/apache/qpid-broker-j/pull/238#discussion_r1476106471
##
broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java:
##
@@ -121,9 +124,10 @@ public void
testUpgradeVirtualHostWithJDBCStoreAndHikariCPPool()
"qpid.jdbcstore.varBinaryType", "myvarbinary",
"qpid.jdbcstore.blobType", "myblob",
"qpid.jdbcstore.useBytesForBlob", true,
-"qpid.jdbcstore.hikaricp.maximumPoolSize", 7,
-"qpid.jdbcstore.hikaricp.minimumIdle", 6);
-final Map expectedAttributes =
Map.of("connectionPoolType", "HIKARICP",
+"qpid.jdbcstore.bonecp.maxConnectionsPerPartition", 7,
+"qpid.jdbcstore.bonecp.minConnectionsPerPartition", 6,
+"qpid.jdbcstore.bonecp.partitionCount", 2);
+final Map expectedAttributes =
Map.of("connectionPoolType", "BONECP",
Review Comment:
Doesnt the fact these bits of the output didnt change (now restored to their
previous/original values), even though the updater is meant to be handling
transition from bonecp to hikaricp pool, suggest that not everything that
should be upgraded is being so?
EDIT: so this test is checking for "VirtualHostNode" context, whereas the
updater is only covering "VirtualHost" context entries, which seems likely to
explain things. Given both can apparently separately be using JDBC and thus
pooling (even if I dont see a point for the node) it feels like both should be
covered.
EDIT2: Actually, can the broker have this context config as well? to be
defined in one place and inherited by the rest if they use it and not override?
> [Broker-J] Broker plugin jdbc-provider-bone replacement
> ---
>
> Key: QPID-8666
> URL: https://issues.apache.org/jira/browse/QPID-8666
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-9.1.0
>Reporter: Daniil Kirilyuk
>Priority: Major
> Fix For: qpid-java-broker-9.2.0
>
>
> Broker plugin jdbc-provider-bone relies on JDBC connection pooling library
> bonecp, which is no longer developed or updated. The [github project
> page|https://github.com/wwadge/bonecp] states:
> "BoneCP is a Java JDBC connection pool implementation that is tuned for high
> performance by minimizing lock contention to give greater throughput for your
> applications. It beats older connection pools such as C3P0 and DBCP but
> should now be considered deprecated in favour of HikariCP".
> Plugin jdbc-provider-bone should be replaced with the new one
> jdbc-provider-hikaricp based on
> [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both
> libraries use Apache-2.0 license.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [PR] QPID-8666: [Broker-J] Broker plugin jdbc-provider-bone replacement [qpid-broker-j]
gemmellr commented on code in PR #238:
URL: https://github.com/apache/qpid-broker-j/pull/238#discussion_r1476106471
##
broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java:
##
@@ -121,9 +124,10 @@ public void
testUpgradeVirtualHostWithJDBCStoreAndHikariCPPool()
"qpid.jdbcstore.varBinaryType", "myvarbinary",
"qpid.jdbcstore.blobType", "myblob",
"qpid.jdbcstore.useBytesForBlob", true,
-"qpid.jdbcstore.hikaricp.maximumPoolSize", 7,
-"qpid.jdbcstore.hikaricp.minimumIdle", 6);
-final Map expectedAttributes =
Map.of("connectionPoolType", "HIKARICP",
+"qpid.jdbcstore.bonecp.maxConnectionsPerPartition", 7,
+"qpid.jdbcstore.bonecp.minConnectionsPerPartition", 6,
+"qpid.jdbcstore.bonecp.partitionCount", 2);
+final Map expectedAttributes =
Map.of("connectionPoolType", "BONECP",
Review Comment:
Doesnt the fact these bits of the output didnt change (now restored to their
previous/original values), even though the updater is meant to be handling
transition from bonecp to hikaricp pool, suggest that not everything that
should be upgraded is being so?
EDIT: so this test is checking for "VirtualHostNode" context, whereas the
updater is only covering "VirtualHost" context entries, which seems likely to
explain things. Given both can apparently separately be using JDBC and thus
pooling (even if I dont see a point for the node) it feels like both should be
covered.
EDIT2: Actually, can the broker have this context config as well? to be
defined in one place and inherited by the rest if they use it and not override?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8666) [Broker-J] Broker plugin jdbc-provider-bone replacement
[ https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813563#comment-17813563 ] ASF subversion and git services commented on QPID-8666: --- Commit dae78d991f42c2ca2b85f9e365762bf98bf5e10f in qpid-broker-j's branch refs/heads/main from Tomas Vavricka [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=dae78d991f ] QPID-8666: [Broker-J] Moved BROKER constant to BrokerStoreUpgraderAndRecoverer > [Broker-J] Broker plugin jdbc-provider-bone replacement > --- > > Key: QPID-8666 > URL: https://issues.apache.org/jira/browse/QPID-8666 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-9.1.0 >Reporter: Daniil Kirilyuk >Priority: Major > Fix For: qpid-java-broker-9.2.0 > > > Broker plugin jdbc-provider-bone relies on JDBC connection pooling library > bonecp, which is no longer developed or updated. The [github project > page|https://github.com/wwadge/bonecp] states: > "BoneCP is a Java JDBC connection pool implementation that is tuned for high > performance by minimizing lock contention to give greater throughput for your > applications. It beats older connection pools such as C3P0 and DBCP but > should now be considered deprecated in favour of HikariCP". > Plugin jdbc-provider-bone should be replaced with the new one > jdbc-provider-hikaricp based on > [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both > libraries use Apache-2.0 license. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8666) [Broker-J] Broker plugin jdbc-provider-bone replacement
[ https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813549#comment-17813549 ] ASF GitHub Bot commented on QPID-8666: -- vavrtom merged PR #238: URL: https://github.com/apache/qpid-broker-j/pull/238 > [Broker-J] Broker plugin jdbc-provider-bone replacement > --- > > Key: QPID-8666 > URL: https://issues.apache.org/jira/browse/QPID-8666 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-9.1.0 >Reporter: Daniil Kirilyuk >Priority: Major > Fix For: qpid-java-broker-9.2.0 > > > Broker plugin jdbc-provider-bone relies on JDBC connection pooling library > bonecp, which is no longer developed or updated. The [github project > page|https://github.com/wwadge/bonecp] states: > "BoneCP is a Java JDBC connection pool implementation that is tuned for high > performance by minimizing lock contention to give greater throughput for your > applications. It beats older connection pools such as C3P0 and DBCP but > should now be considered deprecated in favour of HikariCP". > Plugin jdbc-provider-bone should be replaced with the new one > jdbc-provider-hikaricp based on > [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both > libraries use Apache-2.0 license. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8666) [Broker-J] Broker plugin jdbc-provider-bone replacement
[ https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813550#comment-17813550 ] ASF subversion and git services commented on QPID-8666: --- Commit f154ea9628b81402f0adcb68c059871aeb1b2738 in qpid-broker-j's branch refs/heads/main from Daniil Kirilyuk [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=f154ea9628 ] QPID-8666: [Broker-J] Broker plugin jdbc-provider-bone replacement (#238) * QPID-8666: [Broker-J] Broker plugin jdbc-provider-bone replacement * QPID-8666: [Broker-J] Used new constants across BrokerStoreUpgraderAndRecoverer.java * QPID-8666: [Broker-J] Used new constants across VirtualHostStoreUpgraderAndRecoverer.java - Co-authored-by: vavrtom > [Broker-J] Broker plugin jdbc-provider-bone replacement > --- > > Key: QPID-8666 > URL: https://issues.apache.org/jira/browse/QPID-8666 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-9.1.0 >Reporter: Daniil Kirilyuk >Priority: Major > Fix For: qpid-java-broker-9.2.0 > > > Broker plugin jdbc-provider-bone relies on JDBC connection pooling library > bonecp, which is no longer developed or updated. The [github project > page|https://github.com/wwadge/bonecp] states: > "BoneCP is a Java JDBC connection pool implementation that is tuned for high > performance by minimizing lock contention to give greater throughput for your > applications. It beats older connection pools such as C3P0 and DBCP but > should now be considered deprecated in favour of HikariCP". > Plugin jdbc-provider-bone should be replaced with the new one > jdbc-provider-hikaricp based on > [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both > libraries use Apache-2.0 license. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [PR] QPID-8666: [Broker-J] Broker plugin jdbc-provider-bone replacement [qpid-broker-j]
vavrtom merged PR #238: URL: https://github.com/apache/qpid-broker-j/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
