[jira] [Commented] (QPID-7616) VirtualHostNode name is not expanded before creating thread
[
https://issues.apache.org/jira/browse/QPID-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029811#comment-16029811
]
James Howe commented on QPID-7616:
--
Like this, if I recall correctly.
https://stackoverflow.com/a/41552549/476716
> VirtualHostNode name is not expanded before creating thread
> ---
>
> Key: QPID-7616
> URL: https://issues.apache.org/jira/browse/QPID-7616
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.1.1
>Reporter: James Howe
>Priority: Trivial
>
> This results in, for example, a thread named
> {{VirtualHostNode-$\{qpid.vhost\}-Config}}. Other threads have expanded the
> parameter, e.g. {{virtualhost-default-receiver-pool-0}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-6468) [0-8..0-91] Use basic.nack for releasing messages back to the Broker for delivery elsewhere
[
https://issues.apache.org/jira/browse/QPID-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830303#comment-15830303
]
James Howe edited comment on QPID-6468 at 1/19/17 5:34 PM:
---
Just to note that the current implementation violates 0-9-1.
In particular, the {{requeue}} bit of {{basic.reject}} is ignored and the
message will always be requeued unless maximum delivery count is exceeded.
{quote}
If requeue is true, the server will attempt to requeue the message. If requeue
is false or the requeue attempt fails the messages are discarded or
dead-lettered.
The server MUST NOT deliver the message to the same client within the context
of the current channel. The recommended strategy is to attempt to deliver the
message to an alternative consumer, and if that is not possible, to move the
message to a dead-letter queue. The server MAY use more sophisticated tracking
to hold the message on the queue and redeliver it to the same client at a later
stage.
{quote}
I think the second paragraph is violated by most implementations though,
because it's stupid.
was (Author: jameshowe):
Just to note that the current implementation violates 0-9-1.
In particular, the {{requeue}} bit of {{basic.reject}} is ignored and the
message will always be requeued unless maximum delivery count is exceeded.
{quote}
> [0-8..0-91] Use basic.nack for releasing messages back to the Broker for
> delivery elsewhere
> ---
>
> Key: QPID-6468
> URL: https://issues.apache.org/jira/browse/QPID-6468
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
>Reporter: Keith Wall
>
> The Java Broker/Client historically has abused AMQP [0-8..0-91] basic.reject
> to release messages back to the Broker if the client no longer intends to
> deliver them to the application (for example, the closing of a consumer
> requires that messages that were optimistically prefetched now must be made
> available for delivery elsewhere and must be released to the Broker). This
> was never the intended use for basic.reject.
> QPID-6164 introduced (the Rabbit specific) AMQP extension basic.nack to allow
> for synchronous publishing. We can make use of the same mechanism (as do
> Rabbit) for implementing message release on consuming side too.
> This would tidy up lots of ugly code around the DLQ support within the Java
> Broker, and allow the Qpid components to interop better with the Rabbit
> components.
> Compatibility between older versions would need to be retained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6468) [0-8..0-91] Use basic.nack for releasing messages back to the Broker for delivery elsewhere
[
https://issues.apache.org/jira/browse/QPID-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830303#comment-15830303
]
James Howe commented on QPID-6468:
--
Just to note that the current implementation violates 0-9-1.
In particular, the {{requeue}} bit of {{basic.reject}} is ignored and the
message will always be requeued unless maximum delivery count is exceeded.
{quote}
> [0-8..0-91] Use basic.nack for releasing messages back to the Broker for
> delivery elsewhere
> ---
>
> Key: QPID-6468
> URL: https://issues.apache.org/jira/browse/QPID-6468
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
>Reporter: Keith Wall
>
> The Java Broker/Client historically has abused AMQP [0-8..0-91] basic.reject
> to release messages back to the Broker if the client no longer intends to
> deliver them to the application (for example, the closing of a consumer
> requires that messages that were optimistically prefetched now must be made
> available for delivery elsewhere and must be released to the Broker). This
> was never the intended use for basic.reject.
> QPID-6164 introduced (the Rabbit specific) AMQP extension basic.nack to allow
> for synchronous publishing. We can make use of the same mechanism (as do
> Rabbit) for implementing message release on consuming side too.
> This would tidy up lots of ugly code around the DLQ support within the Java
> Broker, and allow the Qpid components to interop better with the Rabbit
> components.
> Compatibility between older versions would need to be retained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7616) VirtualHostNode name is not expanded before creating thread
James Howe created QPID-7616:
Summary: VirtualHostNode name is not expanded before creating
thread
Key: QPID-7616
URL: https://issues.apache.org/jira/browse/QPID-7616
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: qpid-java-6.1.1
Reporter: James Howe
Priority: Trivial
This results in, for example, a thread named
{{VirtualHostNode-${qpid.vhost}-Config}}. Other threads have expanded the
parameter, e.g. {{virtualhost-default-receiver-pool-0}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7616) VirtualHostNode name is not expanded before creating thread
[
https://issues.apache.org/jira/browse/QPID-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Howe updated QPID-7616:
-
Description: This results in, for example, a thread named
{{VirtualHostNode-$\{qpid.vhost\}-Config}}. Other threads have expanded the
parameter, e.g. {{virtualhost-default-receiver-pool-0}}. (was: This results
in, for example, a thread named {{VirtualHostNode-${qpid.vhost}-Config}}. Other
threads have expanded the parameter, e.g.
{{virtualhost-default-receiver-pool-0}}.)
> VirtualHostNode name is not expanded before creating thread
> ---
>
> Key: QPID-7616
> URL: https://issues.apache.org/jira/browse/QPID-7616
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.1.1
>Reporter: James Howe
>Priority: Trivial
>
> This results in, for example, a thread named
> {{VirtualHostNode-$\{qpid.vhost\}-Config}}. Other threads have expanded the
> parameter, e.g. {{virtualhost-default-receiver-pool-0}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7615) Cannot set number of selectors equal to pool size
James Howe created QPID-7615: Summary: Cannot set number of selectors equal to pool size Key: QPID-7615 URL: https://issues.apache.org/jira/browse/QPID-7615 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: qpid-java-6.1.1 Reporter: James Howe Priority: Minor For both Port and VirtualHost, the number of selectors is required to be strictly less than the pool size. In particular, this means a pool size of 1 is not possible, as would be desired for a minimal embedded/test configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7614) VirtualHost does not automatically scale the number of selectors
James Howe created QPID-7614:
Summary: VirtualHost does not automatically scale the number of
selectors
Key: QPID-7614
URL: https://issues.apache.org/jira/browse/QPID-7614
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Affects Versions: qpid-java-6.1.1
Reporter: James Howe
Priority: Minor
Unlike Port, you have to manually set the number of selectors on a VirtualHost,
rather than it defaulting to {{max(1, poolSize/8)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7613) Port configuration has incorrect error message
James Howe created QPID-7613:
Summary: Port configuration has incorrect error message
Key: QPID-7613
URL: https://issues.apache.org/jira/browse/QPID-7613
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: qpid-java-6.1.1
Reporter: James Howe
Priority: Minor
If you try to configure a Port with number of selectors greater than the pool
size, the error messages says
{quote}
Number of Selectors {} on Port AMQP must be greater than the thread pool size
{}.
{quote}
Should be "less than".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
