[GitHub] qpid-proton-j pull request #14: PROTON-1911: Improve performance of EncoderI...
Github user ctron closed the pull request at: https://github.com/apache/qpid-proton-j/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #14: PROTON-1911: Improve performance of EncoderI...
GitHub user ctron opened a pull request: https://github.com/apache/qpid-proton-j/pull/14 PROTON-1911: Improve performance of EncoderImpl#writeRaw(String) This change uses a small thread local buffer to gather data locally before sending it in bigger chunks to the buffer. This keeps the memory consumption low and doesn't put more stress on the garbage collector. But improves the performance of the method by factor 4. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ctron/qpid-proton-j feture/fix_string_perf_1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton-j/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit bdb202b4acc447ed5385d9712e6ba949cc84e34c Author: Jens Reimann Date: 2018-08-07T15:29:02Z PROTON-1911: Improve performance of EncoderImpl#writeRaw(String) This change uses a small thread local buffer to gather data locally before sending it in bigger chunks to the buffer. This keeps the memory consumption low and doesn't put more stress on the garbage collector. But improves the performance of the method by factor 4. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms issue #8: QPIDJMS-298 Add coverage report uploading to codecov.io i...
Github user ctron commented on the issue: https://github.com/apache/qpid-jms/pull/8 It indeed works fine. There is one caveat when converting Jacoco exec files to XML. Only classes of the local module will be reported in the XML files. So when you have a module A which gets tested by module B, then classes from module A will be missing in the XML report of module B, although they are in the exec file of module B. However there is a maven plugin for fixing that: https://ctron.github.io/jacoco-extras/xml-mojo.html ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms issue #4: QPIDJMS-164: Provide OSGi metadata for qpid-jms-client
Github user ctron commented on the issue: https://github.com/apache/qpid-jms/pull/4 Ok. Done. I did change the title of the PR anyway, just as a note to myself. I also just saw that it actually targets javax.jms version 2. Is there a chance to get this change also for JMS version 1.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms issue #4: Provide OSGi metadata for qpid-jms-client
Github user ctron commented on the issue: https://github.com/apache/qpid-jms/pull/4 Sure. I will do that tomorrow. Thanks for that quick review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms pull request #4: Provide OSGi metadata for qpid-jms-client
GitHub user ctron opened a pull request: https://github.com/apache/qpid-jms/pull/4 Provide OSGi metadata for qpid-jms-client This change adds the maven-bundle-plugin to the parent project and activates it in the qpid-jms-client project, generating OSGi meta data for the project. The Bundle-SymbolicName is overridden to "org.apache.qpid.jms.client". The DynamicPackage-Import header is set to "*" since the JMS client can actually create instances from all kind of classes. The final MANIFEST.MF no longer contains the following entries though: ``` Implementation-Title: QpidJMS Client Implementation-Version: 0.20.0-SNAPSHOT Implementation-Vendor-Id: org.apache.qpid Implementation-Vendor: The Apache Software Foundation Specification-Vendor: The Apache Software Foundation Specification-Title: QpidJMS Client Specification-Version: 0.20.0-SNAPSHOT ``` Signed-off-by: Jens Reimann <jreim...@redhat.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/ctron/qpid-jms feature/osgi_1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-jms/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit 721cd6db4c9a138b0f9578869a1f3d1d718119b0 Author: Jens Reimann <jreim...@redhat.com> Date: 2016-09-19T15:30:28Z Provide OSGi metadata for qpid-jms-client This change adds the maven-bundle-plugin to the parent project and activates it in the qpid-jms-client project, generating OSGi meta data for the project. The Bundle-SymbolicName is overridden to "org.apache.qpid.jms.client". The DynamicPackage-Import header is set to "*" since the JMS client can actually create instances from all kind of classes. Signed-off-by: Jens Reimann <jreim...@redhat.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
