[GitHub] qpid-dispatch pull request #425: DISPATCH-1213 - Prevent stalling of presett...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/425 DISPATCH-1213 - Prevent stalling of presettled large message senders ⦠â¦by calling the AMQP_rx_handler which start emptying proton buffers again You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/425.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #425 commit e8124dced7a70f6126f643959cac4603dcae0fbb Author: Ganesh Murthy Date: 2018-12-06T20:00:30Z DISPATCH-1213 - Prevent stalling of presettled large message senders by calling the AMQP_rx_handler which start emptying proton buffers again --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #420: DISPATCH-1177 - Added new option -e to qdstat. Thi...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/420 Should it say "Router is Standalone or Edge - No Router List". --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #420: DISPATCH-1177 - Added new option -e to qdst...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/420 DISPATCH-1177 - Added new option -e to qdstat. This will show only th⦠â¦e edge connections and show which of those connections is active You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1177-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/420.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #420 commit 0e4cd7253671aff01c7815390e8f89b1a7bfa59f Author: Ganesh Murthy Date: 2018-11-13T17:12:38Z DISPATCH-1177 - Added new option -e to qdstat. This will show only the edge connections and show which of those connections is active --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #419: Added new option -e to qdstat. This will sh...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/419 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #419: Added new option -e to qdstat. This will sh...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/419 Added new option -e to qdstat. This will show only the edge connectio⦠â¦ns and show which of those connections is active You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1177 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/419.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #419 commit 5fc50c0a99c3c014640e184c92b561fd2bb8efe6 Author: Ganesh Murthy Date: 2018-11-13T17:12:38Z Added new option -e to qdstat. This will show only the edge connections and show which of those connections is active --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
GitHub user ganeshmurthy reopened a pull request: https://github.com/apache/qpid-dispatch/pull/416 DISPATCH-1176 - Do not continue processing settled streaming deliveri⦠â¦es when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit f3d2de1b747b4d60210f72ee7b9da93db3c151e3 Author: Ganesh Murthy Date: 2018-11-08T18:34:38Z DISPATCH-1176 - Do not continue processing settled streaming deliveries when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/416 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/416 DISPATCH-1176 - Do not continue processing settled streaming deliveri⦠â¦es when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit f3d2de1b747b4d60210f72ee7b9da93db3c151e3 Author: Ganesh Murthy Date: 2018-11-08T18:34:38Z DISPATCH-1176 - Do not continue processing settled streaming deliveries when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #410: DISPATCH-1160 - Added edge address tracking...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/410 DISPATCH-1160 - Added edge address tracking module to interior router You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch EDGE-ADDR-TRACKING Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #410 commit cf5f9b7f958fa88ca747b4ec29a1cf2b0932aa33 Author: Ganesh Murthy Date: 2018-10-18T15:46:42Z DISPATCH-1160 - Added edge address tracking module to interior router --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #390: DISPATCH-1110 - Added code to synchronously...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/390 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #390: DISPATCH-1110 - Added code to synchronously...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/390 DISPATCH-1110 - Added code to synchronously call AMQP-rx_handler to p⦠â¦ull in all data from the proton buffers at once. Also introduced link level flag to continue receiving without boundaries upon link detach arrival You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/390.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #390 commit 568aad33dc89e621bdfc7168dcc433137b3a6bc9 Author: Ganesh Murthy Date: 2018-10-10T17:29:41Z DISPATCH-1110 - Added code to synchronously call AMQP-rx_handler to pull in all data from the proton buffers at once. Also introduced link level flag to continue receiving without boundaries upon link detach arrival --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #389: DISPATCH-1130 Expose link priority
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/389 @ErnieAllen This change looks good. As part of this PR, can you also please add a test to system_tests_qdstat to verify that the correct link priority is showing up? Thanks. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #376: DISPATCH-1081 - Update doc for multicast delivery ...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/376 I will merge this shortly, thanks. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #383: DISPATCH-1129 - Moved call to forwarding mu...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/383 DISPATCH-1129 - Moved call to forwarding multicast messages to end of⦠⦠forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1129-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #383 commit 67a210c93d9097999158b06c5b61a8726a2bdd0d Author: Ganesh Murthy Date: 2018-09-24T17:06:47Z DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #382: DISPATCH-1129 - Moved call to forwarding mu...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/382 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #382: DISPATCH-1129 - Moved call to forwarding mu...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/382 DISPATCH-1129 - Moved call to forwarding multicast messages to end of⦠⦠forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch AARON-PROBLEM Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/382.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #382 commit 00edc49fec82aaabcf4d3bfc65e24ed0b73d1d62 Author: Ganesh Murthy Date: 2018-09-24T17:06:47Z DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #375: DISPATCH 1096 - store priority in links
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/375 I applied this PR to the latest master code and I ran the multi-tenancy tests and I saw a router crash. The backtrace is similar to the earlier one. Here it is (gdb) bt #0 0x7f09f3a7c660 in raise () from /lib64/libc.so.6 #1 0x7f09f3a7dc41 in abort () from /lib64/libc.so.6 #2 0x7f09f3a74f7a in __assert_fail_base () from /lib64/libc.so.6 #3 0x7f09f3a74ff2 in __assert_fail () from /lib64/libc.so.6 #4 0x7f09f4f49244 in qdr_del_link_ref (ref_list=0x7f09dc025880, link=0x17ed4a0, cls=1) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:441 #5 0x7f09f4f3a8b4 in qdr_link_cleanup_CT (core=0x1728780, conn=0x7f09dc0257e0, link=0x17ed4a0) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:853 #6 0x7f09f4f3d866 in qdr_link_inbound_detach_CT (core=0x1728780, action=0x7f09dc1598e0, discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1939 #7 0x7f09f4f4a038 in router_core_thread (arg=0x1728780) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:83 #8 0x7f09f487950b in start_thread () from /lib64/libpthread.so.0 #9 0x7f09f3b3d16f in clone () from /lib64/libc.so.6 (gdb) --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #376: DISPATCH-1081 - Update doc for multicast delivery ...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/376 This looks good to me. @ted-ross can you please give a quick glance and if you think it is good, I will commit. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/371 Fixed "Draim" to "Drain". Thanks for testing. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #371: DISPATCH-1090 - Draim excess credit if ther...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/371 DISPATCH-1090 - Draim excess credit if there are no receivers You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1090-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 18fbf5b9ad73069bf00f09da537c34511aa6b2f0 Author: Ganesh Murthy Date: 2018-08-28T19:09:16Z DISPATCH-1090 - Draim excess credit if there are no receivers --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #368: DISPATCH-1090 - Draim excess credit if ther...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/368 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #370: DISPATCH-1112 - Additional fix. Modified qd...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/370 DISPATCH-1112 - Additional fix. Modified qdr_link_process_deliveries(⦠â¦) to not continue processing deliveries if detach has been received on that link You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1112-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit 3df8e6c32aa31b23e2a8829abeeb18b00d639fb4 Author: Ganesh Murthy Date: 2018-09-03T14:29:55Z DISPATCH-1112 - Additional fix. Modified qdr_link_process_deliveries() to not continue processing deliveries if detach has been received on that link --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #368: DISPATCH-1090 - Draim excess credit if ther...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/368 DISPATCH-1090 - Draim excess credit if there are no receivers You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1090 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #368 commit 9fdad1343085fca23ac42223d1fe3c4e0c757b4f Author: Ganesh Murthy Date: 2018-08-28T19:09:16Z DISPATCH-1090 - Draim excess credit if there are no receivers --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #359: DISPATCH-1100: add auto delete linkRoutes
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/359#discussion_r212737548
--- Diff: src/router_core/route_control.c ---
@@ -189,37 +189,40 @@ static void qdr_link_route_activate_CT(qdr_core_t
*core, qdr_link_route_t *lr, q
// activation for this address, notify the router module of the added
address.
//
if (lr->addr) {
+lr->active_ct += 1;
qdr_add_connection_ref(>addr->conns, conn);
-if (DEQ_SIZE(lr->addr->conns) == 1) {
+if (lr->active_ct == 1) {
address = qdr_link_route_pattern_to_address(lr->pattern,
lr->dir);
qd_log(core->log, QD_LOG_TRACE, "Activating link route pattern
[%s]", address);
qdr_post_mobile_added_CT(core, address);
free(address);
}
}
-
-lr->active = true;
}
+// note that this function may free the qdr_link_route_t
static void qdr_link_route_deactivate_CT(qdr_core_t *core,
qdr_link_route_t *lr, qdr_connection_t *conn)
{
qdr_route_log_CT(core, "Link Route Deactivated", lr->name,
lr->identity, conn);
//
// Deactivate the address(es) for link-routed destinations.
//
-if (lr->addr) {
-qdr_del_connection_ref(>addr->conns, conn);
-if (DEQ_IS_EMPTY(lr->addr->conns)) {
+if (lr->addr && qdr_del_connection_ref(>addr->conns, conn)) {
+assert(lr->active_ct > 0);
+lr->active_ct -= 1;
+if (lr->active_ct == 0) {
char *address = qdr_link_route_pattern_to_address(lr->pattern,
lr->dir);
qd_log(core->log, QD_LOG_TRACE, "Deactivating link route
pattern [%s]", address);
--- End diff --
Should this log message say "Deleting" instead of "Deactivating" ?
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #366: DISPATCH-1103 - Added code to retry failed ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/366 DISPATCH-1103 - Added code to retry failed auto links using the core ⦠â¦timeer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1103-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #366 commit f8064a0d0b5a5e9d0db0d176dc6dcf6d1b726b11 Author: Ganesh Murthy Date: 2018-08-14T15:21:30Z DISPATCH-1103 - Added code to retry failed auto links using the core timeer API commit 64fe506f3b7ad14d446212cf6f05de84171a64b4 Author: Ganesh Murthy Date: 2018-08-24T17:04:33Z DISPATCH-1103 - Added doc for functions --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #363: Dispatch 1103
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/363 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #363: Dispatch 1103
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/363 Dispatch 1103 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1103 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #363 commit 98156cb32eb7a2d5e40f0a898adc662e83669523 Author: Ganesh Murthy Date: 2018-08-13T15:46:52Z DISPATCH-1099 - Added core timer API commit a6d1c8727704616bde4575d77e8b537420598151 Author: Ganesh Murthy Date: 2018-08-14T15:21:30Z DISPATCH-1103 - Added code to retry failed auto links using the core timeer API --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #362: DISPATCH-1099 - Added core timer API
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/362 DISPATCH-1099 - Added core timer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1099-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 98156cb32eb7a2d5e40f0a898adc662e83669523 Author: Ganesh Murthy Date: 2018-08-13T15:46:52Z DISPATCH-1099 - Added core timer API --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #357: DISPATCH-1099 - Added plumbing that sends t...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/357 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #357: DISPATCH-1099 - Added plumbing that sends ticks in...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/357 It adds one action record into the action list every one second. That should not bring down the performance but I will try using quiver and see what I get --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #357: DISPATCH-1099 - Added plumbing that sends ticks in...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/357 Sorry, also depends on the number of outstanding timers. At this time, we plan to add timers for retrying autoLinks only. I will add a bunch of autoLinks that need to be retried and see how it impacts performance. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #357: DISPATCH-1099 - Added plumbing that sends t...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/357 DISPATCH-1099 - Added plumbing that sends ticks into the core You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1099-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/357.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #357 commit e6a04c338bca921290e2f774b82cf8302220c185 Author: Ganesh Murthy Date: 2018-08-09T17:26:03Z DISPATCH-1099 - Added plumbing that sends ticks into the core --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #356: DISPATCH-1099 - Added plumbing that sends t...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/356 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #356: DISPATCH-1099 - Added plumbing that sends t...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/356 DISPATCH-1099 - Added plumbing that sends ticks into the core You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1099 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit da111fb70b02399be4dc2a7f0d41084873ce9229 Author: Ganesh Murthy Date: 2018-08-09T17:26:03Z DISPATCH-1099 - Added plumbing that sends ticks into the core --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #354: DISPATCH-1097 - Added code to fix issues re...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/354 DISPATCH-1097 - Added code to fix issues reported by Coverity You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1097 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/354.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #354 commit 61b2e96bc62d1d750ba15580a5b69dc1c36c67d8 Author: Ganesh Murthy Date: 2018-08-07T01:36:01Z DISPATCH-1097 - Added code to fix issues reported by Coverity --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #353: DISPATCH-1094 - Moved the creation and writ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/353 DISPATCH-1094 - Moved the creation and writing of log file inside a l⦠â¦ock so that the order is preserved You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1094 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/353.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #353 commit 9fc97ae7d6ecedbd7880a7e2c1bfa8c934abe350 Author: Ganesh Murthy Date: 2018-08-06T18:16:28Z DISPATCH-1094 - Moved the creation and writing of log file inside a lock so that the order is preserved --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #350: DISPATCH-1093 - Prevent additional connecti...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/350 DISPATCH-1093 - Prevent additional connections from being created fro⦠â¦m connectors when calling qd_connection_manager_start You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1093 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/350.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #350 commit 1f806aba46bb0ddcd49b098dbaae134143955e21 Author: Ganesh Murthy Date: 2018-08-01T20:33:11Z DISPATCH-1093 - Prevent additional connections from being created from connectors when calling qd_connection_manager_start --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #348: DISPATCH-1008 - Back out previous change th...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/348 DISPATCH-1008 - Back out previous change that was storing every failo⦠â¦ver url obtained from every connection. Modified the code to wipe out the failover urls obtained from the previous connection if the current connection returned an empty list for failover urls You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1008-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #348 commit 8d12f277c8cb120731ba956da791d8828692702a Author: Ganesh Murthy Date: 2018-07-12T18:56:10Z DISPATCH-1008 - Back out previous change that was storing every failover url obtained from every connection. Modified the code to wipe out the failover urls obtained from the previous connection if the current connection returned an empty list for failover urls --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #347: DISPATCH-1087 - Modified shebang line in so...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/347 DISPATCH-1087 - Modified shebang line in some files to put in the cor⦠â¦rect version of Python You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1087-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #347 commit 30ff7ff1d54b8f280b36f76dc8c340cb4c88567b Author: Ganesh Murthy Date: 2018-07-25T15:38:40Z DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #346: DISPATCH-1087 - Modified shebang line in so...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/346 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #346: DISPATCH-1087 - Modified shebang line in so...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/346 DISPATCH-1087 - Modified shebang line in some files to put in the cor⦠â¦rect version of Python You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1087 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit 82f3834cff17072ec5fef44fa1032cf72bd2ba54 Author: Ganesh Murthy Date: 2018-07-25T15:38:40Z DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #341: DISPATCH-1008 - Back out previous change th...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/341 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #345: DISPATCH-1085 - Modified AMQP_link_detach_h...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/345 DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the re⦠â¦maining bytes in the message buffers before responding to detaches You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1085 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 3d19ec903881ec2b66b9b014f0f037a67ea40952 Author: Ganesh Murthy Date: 2018-07-23T19:21:44Z DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the remaining bytes in the message buffers before responding to detaches --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #344: DISPATCH-1069 - Delayed freeing of links an...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/344 DISPATCH-1069 - Delayed freeing of links and sessions until after the⦠⦠the processing of the event batch is complete You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1069 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit f48d981202fbb5d781f2b32125fbe61af1a82fdc Author: Ganesh Murthy Date: 2018-07-18T19:43:39Z DISPATCH-1069 - Delayed freeing of links and sessions until after the the processing of the event batch is complete --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #341: DISPATCH-1008 - Back out previous change th...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/341 DISPATCH-1008 - Back out previous change that was storing every failo⦠â¦ver url obtained from every connection. Modified the code to wipe out the failover urls obtained from the previous connection if the current connection returned an empty list for failover urls You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1008-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #341 commit b3f4f2a8197f000538c25311ef481cb4b1ffd51a Author: Ganesh Murthy Date: 2018-07-12T18:56:10Z DISPATCH-1008 - Back out previous change that was storing every failover url obtained from every connection. Modified the code to wipe out the failover urls obtained from the previous connection if the current connection returned an empty list for failover urls --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #328: DISPATCH-1045 - Release the delivery only a...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/328#discussion_r198613623
--- Diff: src/router_node.c ---
@@ -312,12 +307,30 @@ static void AMQP_rx_handler(void* context, qd_link_t
*link)
pn_link_name(pn_link));
}
+//
+// The entire message has been received and we are ready to
consume the delivery by calling pn_link_advance().
+//
+pn_link_advance(pn_link);
+
+//
+// The entire message has been received but this message needs to
be discarded
+//
+if (qd_message_is_discard(msg)) {
+pn_delivery_update(pnd, qdr_delivery_disposition(delivery));
--- End diff --
Agreed. I have pushed up a new commit to remedy your comment. Please take a
quick look. Thanks.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #327: DISPATCH-1041 - Add tests to validate each ...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/327 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #328: DISPATCH-1045 - Release the delivery only a...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/328 DISPATCH-1045 - Release the delivery only after the entire message ha⦠â¦s been received You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1045 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/328.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #328 commit e40858d7da687e427d624409ba60cb27c1fe0550 Author: Ganesh Murthy Date: 2018-06-22T20:01:51Z DISPATCH-1045 - Release the delivery only after the entire message has been received --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/327 Good catch. Not sure how I missed that. I will add anew test for acceptedDeliveries and will let you know --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #325: DISPATCH-1037 - Prevented deleting listener...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/325 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #325: DISPATCH-1037 - Prevented deleting listener...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/325 DISPATCH-1037 - Prevented deleting listener with http: yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/325.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #325 commit 8276d91bfff40446f1a3e45a275ff0298331c569 Author: Ganesh Murthy Date: 2018-06-13T18:50:56Z DISPATCH-1037 - Prevented deleting listener with http: yes --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #322: DISPATCH-1008 - Original connection informa...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/322 DISPATCH-1008 - Original connection information is preserved in the f⦠â¦ailover list and a connection is attempted via round robin when the router fails over You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1008-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 commit 1d72de1edffee463d221c5d2a0d552ae26c3a28d Author: Ganesh Murthy Date: 2018-05-25T19:07:44Z DISPATCH-1008 - Original connection information is preserved in the failover list and a connection is attempted via round robin when the router fails over --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #310: DISPATCH-1008 - Original connection informa...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/310 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #316: DISPATCH-1021 - Introduced a more flag in t...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/316#discussion_r193836829
--- Diff: src/router_core/transfer.c ---
@@ -1237,7 +1246,7 @@ void qdr_drain_inbound_undelivered_CT(qdr_core_t
*core, qdr_link_t *link, qdr_ad
qdr_delivery_t *dlv = DEQ_HEAD(deliveries);
while (dlv) {
DEQ_REMOVE_HEAD(deliveries);
-qdr_link_forward_CT(core, link, dlv, addr);
+qdr_link_forward_CT(core, link, dlv, addr, 0);
--- End diff --
will do. thanks.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #318: DISPATCH-1023 - Added a multicast bit on th...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/318 DISPATCH-1023 - Added a multicast bit on the qdr_delivery_t object to⦠⦠use in places where owning_addr is not available. Also added code to free multi frame non-multicast presettled messages. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1023-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/318.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #318 commit 3a41b1b6fe64a5c3c1ef040a70dfc8c49f9b42d9 Author: Ganesh Murthy Date: 2018-06-04T20:02:10Z DISPATCH-1023 - Added a multicast bit on the qdr_delivery_t object to use in places where owning_addr is not available. Also added code to free multi frame non-multicast presettled messages. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #314: DISPATCH-1023 - Added a multicast bit on th...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/314 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #316: DISPATCH-1021 - Introduced a more flag in t...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/316 DISPATCH-1021 - Introduced a more flag in the action so every action ⦠â¦can accurately know if there is more data to come in the message You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1021-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/316.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #316 commit 989f2ac9288d857de644369b991b2a183ad26fb3 Author: Ganesh Murthy Date: 2018-06-04T19:36:56Z DISPATCH-1021 - Introduced a more flag in the action so every action can accurately know if there is more data to come in the message --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #313: DISPATCH-1021 - Introduced a more flag in t...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/313 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #314: DISPATCH-1023 - Added a multicast bit on th...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/314 DISPATCH-1023 - Added a multicast bit on the qdr_delivery_t object to⦠⦠use in places where owning_addr is not available You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1023 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/314.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #314 commit 5fe7e53c4e026f4dab662a79fe572e6ad674be9f Author: Ganesh Murthy Date: 2018-06-04T20:02:10Z DISPATCH-1023 - Added a multicast bit on the qdr_delivery_t object to use in places where owning_addr is not available --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #313: DISPATCH-1021 - Introduced a more flag in t...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/313 DISPATCH-1021 - Introduced a more flag in the action so every action ⦠â¦can accurately know if there is more data to come in the message You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1021 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/313.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #313 commit 32a0b1e2965b4373306f8557f9afbd295d565f4c Author: Ganesh Murthy Date: 2018-06-04T19:36:56Z DISPATCH-1021 - Introduced a more flag in the action so every action can accurately know if there is more data to come in the message --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #292: DISPATCH-963 - Added test name to creation ...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/292 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #310: DISPATCH-1008 - Original connection informa...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/310 DISPATCH-1008 - Original connection information is preserved in the f⦠â¦ailover list and a connection is attempted via round robin when the router fails over You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1008 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #310 commit 48c36134e406dfddc396a9f624f61b9e8781fa13 Author: Ganesh Murthy Date: 2018-05-25T19:07:44Z DISPATCH-1008 - Original connection information is preserved in the failover list and a connection is attempted via round robin when the router fails over --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #287: NO-JIRA - Removed sleep and introduced a ti...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/287 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/303 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Github user ganeshmurthy commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/303#discussion_r187373563 --- Diff: src/router_core/connections.c --- @@ -473,7 +474,8 @@ void qdr_link_second_attach(qdr_link_t *link, qdr_terminus_t *source, qdr_termin action->args.connection.link = link; action->args.connection.source = source; action->args.connection.target = target; -qdr_action_enqueue(link->core, action); +if (link) --- End diff -- I added the null check in AMQP_link_attach_handler and in qdr_link_second_attach() just to be doubly sure. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/303 DISPATCH-994 - Added null checks on links/connections before enqueing⦠⦠actions or calling action inseting functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-994 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #303 commit ea4b67fdc1ccd2dfc52f096308174d3c26fba993 Author: Ganesh Murthy <gmurthy@...> Date: 2018-05-10T14:20:50Z DISPATCH-994 - Added null checks on links/connections before enqueing actions or calling action inseting functions --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #299: DISPATCH-927 - System test for fix. Makes s...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/299 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #299: DISPATCH-927 - System test for fix. Makes s...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/299 DISPATCH-927 - System test for fix. Makes sure both detaches are echo⦠â¦ed back You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-927 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/299.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #299 commit a8eb40384750ca2bd4e1fe4e0144507d0859e7fb Author: Ganesh Murthy <gmurthy@...> Date: 2018-05-04T19:16:43Z DISPATCH-927 - System test for fix. Makes sure both detaches are echoed back --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #295: DISPATCH-933 - Undo changes made because th...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/295 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #295: DISPATCH-933 - Undo changes made because th...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/295 DISPATCH-933 - Undo changes made because this JIRA. RouterStats os no⦠â¦w gone relaced with the old Router entity. This change has been backed out because of backward compat issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-933-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/295.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #295 commit 328be727c8bd6c5a625d2e6d2dbba81cef6ee36b Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-26T14:44:57Z DISPATCH-933 - Undo changes made because this JIRA. RouterStats os now gone relaced with the old Router entity. This change has been backed out because of backward compat issues --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #292: DISPATCH-963 - Added test name to creation ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/292 DISPATCH-963 - Added test name to creation of senders and receivers t⦠â¦o make the names unique You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch ADDRESS-CONFIG-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/292.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #292 commit ca84e0dab3381a7f36f38c5c4a51b2e03525c174 Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-24T18:02:31Z DISPATCH-963 - Added test name to creation of senders and receivers to make the names unique --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #291: Dispatch 963
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/291 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #291: Dispatch 963
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/291 Dispatch 963 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-963 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/291.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #291 commit 902bf0ec77dac60f292d741032a5b0448f03d796 Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-24T13:40:36Z DISPATCH-963 - Made sure receiver and sender names are unique. Also closed all senders and receivers before closing connections commit a9df0dd3314c40d2ec545d3f16dd245a3ba4bd0c Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-24T13:50:36Z DISPATCH-963 - Made sender names universally unique --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #287: NO-JIRA - Removed sleep and introduced a ti...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/287 NO-JIRA - Removed sleep and introduced a timer to test connector fail⦠â¦over urls You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch SYSTEM-TESTS-HANDLE-FAILOVER-FIX Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #287 commit 557f579d6fd4ab94b2d050c4895faa058759fbdd Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-13T17:36:35Z NO-JIRA - Removed sleep and introduced a timer to test connector failover urls --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #285: DISPATCH-154 - Added new tests to validate unresol...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/285 test_unresolvable_host fails for me locally. [gmurthy@localhost build]$ /usr/bin/python "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-x" "unit2" "-v" "system_tests_bad_configuration" test_qdmanage_query (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok test_unresolvable_host (system_tests_bad_configuration.RouterTestBadConfiguration) ... FAIL == FAIL: test_unresolvable_host (system_tests_bad_configuration.RouterTestBadConfiguration) -- Traceback (most recent call last): File "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_bad_configuration.py", line 81, in test_unresolvable_host self.assertGreater(len(errors_caught), 0) AssertionError: 0 not greater than 0 -- Ran 2 tests in 3.094s FAILED (failures=1) [gmurthy@localhost build]$ This is what I see when the router starts up 2018-04-10 19:47:17.416339 -0400 CONN_MGR (info) Configured Connector: unresolvable.host.name:amqp proto=any, role=normal --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #265: DISPATCH-937 - Introduce the validate flag ...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/265 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #280: DISPATCH-952 - Outgoing links initiated by ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/280 DISPATCH-952 - Outgoing links initiated by the router will share a si⦠â¦ngle session You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-952-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/280.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #280 commit d37b0eb092e617c2986393022bd7b0f245547498 Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-04T20:15:31Z DISPATCH-952 - Outgoing links initiated by the router will share a single session --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #279: Dispatch 952 1
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/279 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #279: Dispatch 952 1
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/279#discussion_r179512687
--- Diff: src/container.c ---
@@ -756,8 +756,16 @@ qd_link_t *qd_link(qd_node_t *node, qd_connection_t
*conn, qd_direction_t dir, c
sys_mutex_lock(node->container->lock);
DEQ_INSERT_TAIL(node->container->links, link);
sys_mutex_unlock(node->container->lock);
-link->pn_sess = pn_session(qd_connection_pn(conn));
-pn_session_set_incoming_capacity(link->pn_sess, cf->incoming_capacity);
+
+bool open_session = false;
+
+if (!conn->pn_sess) {
+open_session = true;
--- End diff --
Good point. I removed it. That flag is *gone*
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #279: Dispatch 952 1
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/279 Dispatch 952 1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-952-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/279.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #279 commit 0af196b921412e58a2d16af96b5ee98c4d49b8a9 Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-04T20:15:31Z DISPATCH-952 - Outgoing links initiated by the router will share a single session commit 0bd1673386bc3f7c8cdb81921635b325b0b82b2a Author: Ganesh Murthy <gmurthy@...> Date: 2018-04-04T20:19:56Z DISPATCH-952 - Removed printf statements --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #274: DISPATCH-952 - Limit number of sessions to ...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/274 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #274: DISPATCH-952 - Limit number of sessions to one on ...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/274 @ted-ross do you agree with @alanconway comments ? If yes, I will make single session the default. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #274: DISPATCH-952 - Limit number of sessions to ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/274 DISPATCH-952 - Limit number of sessions to one on a route-container c⦠â¦onnection. All links created will be created in this one session You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-952 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #274 commit e8a17fef999ffe21733bb834cb4349cb835289ba Author: Ganesh Murthy <gmurthy@...> Date: 2018-03-29T19:12:00Z DISPATCH-952 - Limit number of sessions to one on a route-container connection. All links created will be created in this one session --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/270 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/270#discussion_r176223364
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,107 @@
"description": "Time in seconds after which link state
is declared stale if no RA is received.",
"create": true
},
-"addrCount": {
-"type": "integer",
-"description":"Number of addresses known to the
router.",
-"graph": true
-},
-"linkCount": {
+"workerThreads": {
"type": "integer",
-"description":"Number of links attached to the router
node.",
-"graph": true
+"default": 4,
+"description": "The number of threads that will be
created to process message traffic and other application work (timers, non-amqp
file descriptors, etc.) .",
+"create": true
},
-"nodeCount": {
-"type": "integer",
-"description":"Number of known peer router nodes.",
-"graph": true
+"debugDump": {
+"type": "path",
+"description": "The absolute path to the location for
the debug dump file. The router writes debug-level information to this file if
the logger is not available.",
+"create": true
},
-"linkRouteCount": {
-"type": "integer",
-"description":"Number of link routes attached to the
router node.",
-"graph": true
+"saslConfigPath": {
+"type": "path",
+"description": "Absolute path to the SASL
configuration file.",
+"required": false,
+"create": true
},
-"autoLinkCount": {
-"type": "integer",
-"description":"Number of auto links attached to the
router node.",
-"graph": true
+"saslConfigName": {
+"type": "string",
+"description": "Name of the SASL configuration. This
string + '.conf' is the name of the configuration file.",
+"default": "qdrouterd",
+"required": false,
+"create": true
},
-"connectionCount": {
-"type": "integer",
-"description":"Number of open connections to the
router node.",
-"graph": true
+"allowResumableLinkRoute": {
+"type": "boolean",
+"description": "Whether links can be routed where
timeout is non-zero or expiry-policy is not link-detach",
+"create": true,
+"required": false,
+"default": true
+},
+"allowUnsettledMulticast": {
+"type": "boolean",
+"description": "If true, allow senders to send
unsettled deliveries to multicast addresses. These deliveries shall be settled
by the ingress router. If false, unsettled deliveries to multicast addresses
shall be rejected.",
+"create": true,
+"required": false,
+"default": false
},
-
+"defaultDistribution": {
+"type": ["multicast", "closest", "balanced",
"unavailable"],
+"description": "
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/270 DISPATCH-933 - Created new RouterStats entity. Moved some attributes ⦠â¦from Router entity to RouterStats. Router entity is not handled by the Python management agent and the RouterStats entity is handled by the C management agent You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-933-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/270.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #270 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/263 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #265: DISPATCH-937 - Introduce the validate flag ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/265 DISPATCH-937 - Introduce the validate flag at the entity level to be ⦠â¦able to avoid validation on already validated entities. This will help avoid unnecessary calls to validate. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-937-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/265.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #265 commit 6b298414c4466165f23b8f030db0d173892e2b8d Author: Ganesh Murthy <gmurthy@...> Date: 2018-03-02T20:01:26Z DISPATCH-937 - Introduce the validate flag at the entity level to be able to avoid validation on already validated entities. This will help avoid unnecessary calls to validate. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172352976
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state
is declared stale if no RA is received.",
"create": true
},
-"addrCount": {
-"type": "integer",
-"description":"Number of addresses known to the
router.",
-"graph": true
-},
-"linkCount": {
+"workerThreads": {
"type": "integer",
-"description":"Number of links attached to the router
node.",
-"graph": true
+"default": 4,
+"description": "The number of threads that will be
created to process message traffic and other application work (timers, non-amqp
file descriptors, etc.) .",
+"create": true
},
-"nodeCount": {
-"type": "integer",
-"description":"Number of known peer router nodes.",
-"graph": true
+"debugDump": {
+"type": "path",
+"description": "A file to dump debugging information
that can't be logged normally.",
--- End diff --
I was wrong about the debug dump file. It is not a process dump. It seems
to be used only in alloc_pool.c
This is a file to which debug information is written when the logger has
not yet started or has already been shutdown. When the loggers are not
available, the router writes to this file.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172309974
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state
is declared stale if no RA is received.",
"create": true
},
-"addrCount": {
-"type": "integer",
-"description":"Number of addresses known to the
router.",
-"graph": true
-},
-"linkCount": {
+"workerThreads": {
"type": "integer",
-"description":"Number of links attached to the router
node.",
-"graph": true
+"default": 4,
+"description": "The number of threads that will be
created to process message traffic and other application work (timers, non-amqp
file descriptors, etc.) .",
+"create": true
},
-"nodeCount": {
-"type": "integer",
-"description":"Number of known peer router nodes.",
-"graph": true
+"debugDump": {
+"type": "path",
+"description": "A file to dump debugging information
that can't be logged normally.",
--- End diff --
debug dumps are the copies of the contents of the computer's memory. When
the router crashes, it will dump all its memory content into the debug dump
file. which is stored in the hard disk. This file is useful for technical
support people/programmers.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/263 DISPATCH-933 - Created new RouterStats entity. Moved some attributes ⦠â¦from Router entity to RouterStats. Router entity is not handled by the Python management agent and the RouterStats entity is handled by the C management agent You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-933 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit 14339b3339f5ebbd57eb6e5e55204b16771b969f Author: Ganesh Murthy <gmurthy@...> Date: 2018-02-28T18:58:10Z DISPATCH-933 - Created new RouterStats entity. Moved some attributes from Router entity to RouterStats. Router entity is not handled by the Python management agent and the RouterStats entity is handled by the C management agent --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/262#discussion_r171011913
--- Diff: console/config/schema.json ---
@@ -1273,6 +1273,10 @@
"type": "map",
"description": "A map where each key is a user group name and
the value is a map of the corresponding settings for that group."
},
+"hostname": {
--- End diff --
yes, agreed
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #261: DISPATCH-918 - Initial modifications to Python sch...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/261 Specifying the "dir" attribute only will generate a warning that will tell you that you are using a deprecated attribute. The warning will look something like this - 2018-02-27 11:34:41.138705 -0500 AGENT (warning) Attribute 'dir' of entity 'linkRoute' has been deprecated. Use 'direction' instead The router will still start If both 'dir' and 'direction' attributes are specified, the router will display the following error and fail to start - 2018-02-27 11:36:54.911916 -0500 MAIN (critical) Router start-up failed: Python: Exception: Cannot load configuration file test.conf: org.apache.qpid.dispatch.router.config.linkRoute: Both 'dir' and 'direction' cannot be specified for entity 'linkRoute' --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/262#discussion_r170751787
--- Diff: console/config/schema.json ---
@@ -1273,6 +1273,10 @@
"type": "map",
"description": "A map where each key is a user group name and
the value is a map of the corresponding settings for that group."
},
+"hostname": {
--- End diff --
Could this use the deprecationName attribute from my earlier PR -
https://github.com/apache/qpid-dispatch/pull/261/files#diff-981a10a2c9cab3708f003b402e7f8be4R1060
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #261: DISPATCH-918 - Initial modifications to Pyt...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/261#discussion_r170619984
--- Diff: tests/system_tests_autolinks.py ---
@@ -53,17 +53,18 @@ def setUpClass(cls):
#
# Create a pair of default auto-links for 'node.1'
#
-('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'dir': 'in'}),
-('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'dir': 'out'}),
+('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'direction': 'in'}),
+('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'direction': 'out'}),
#
# Create a pair of auto-links on non-default phases for
container-to-container transfers
#
-('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2',
'dir': 'in', 'phase': '4'}),
-('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3',
'dir': 'out', 'phase': '4'}),
+('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2',
'direction': 'in', 'phase': '4'}),
+('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3',
'direction': 'out', 'phase': '4'}),
#
# Create a pair of auto-links with a different external address
+# Leave the direction as dir to test backward compatibility.
--- End diff --
No there is not such a test. Thanks for pointing that out. I will add such
a test to this PR shortly.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #261: DISPATCH-918 - Initial modifications to Pyt...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/261 DISPATCH-918 - Initial modifications to Python schema code to introd⦠â¦uce and use the deprecationName attribute. Also modified dir to direction in linkRoute and autoLink and they use the deprecationName attribute You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-918-DEPNAME Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/261.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #261 commit 0a9e962161c94725aa1a5b906dec95715b7987d7 Author: Ganesh Murthy <gmurthy@...> Date: 2018-02-23T18:10:13Z DISPATCH-918 - Initial modifications to Python schema code to introduce and use the deprecationName attribute. Also modified dir to direction in linkRoute and autoLink and they use the deprecationName attribute --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts
Github user ganeshmurthy commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/254#discussion_r168192351 --- Diff: src/router_node.c --- @@ -33,7 +33,6 @@ const char *QD_ROUTER_NODE_TYPE = "router.node"; const char *QD_ROUTER_ADDRESS_TYPE = "router.address"; const char *QD_ROUTER_LINK_TYPE = "router.link"; -const char *CORE_AGENT_ADDRESS = "$management"; --- End diff -- You are correct. This is not related to the PR. I saw that this was not being used anywhere, so I removed it. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/254 DISPATCH-911 - Added global delivery counts You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-911-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/254.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #254 commit adea1d9908ee6699b493e6d27d3fae81b7468516 Author: Ganesh Murthy <gmurthy@...> Date: 2018-01-26T18:12:12Z DISPATCH-911 - Added global delivery counts --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #247: DISPATCH-911 - Added global delivery counts
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/247 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/252#discussion_r165093678
--- Diff: tests/system_tests_dynamic_link_routes.py ---
@@ -0,0 +1,349 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+import unittest, os, json
+from subprocess import PIPE, STDOUT
+from proton import Message, PENDING, ACCEPTED, REJECTED, RELEASED,
SSLDomain, SSLUnavailable, Timeout, symbol
+from system_test import TestCase, Qdrouterd, main_module, DIR, Process
+from proton.handlers import MessagingHandler
+from proton.reactor import Container, DynamicNodeProperties
+
+# PROTON-828:
+try:
+from proton import MODIFIED
+except ImportError:
+from proton import PN_STATUS_MODIFIED as MODIFIED
+
+
+class RouterTest(TestCase):
+
+inter_router_port = None
+
+@classmethod
+def setUpClass(cls):
+"""Start a router"""
+super(RouterTest, cls).setUpClass()
+
+def router(name, connection):
+
+config = [
+('router', {'mode': 'interior', 'id': name}),
+('listener', {'port': cls.tester.get_port(),
'stripAnnotations': 'no'}),
+('listener', {'port': cls.tester.get_port(),
'stripAnnotations': 'no', 'multiTenant': 'yes'}),
+('listener', {'port': cls.tester.get_port(),
'stripAnnotations': 'no', 'role': 'route-container'}),
+('address', {'prefix': 'closest', 'distribution':
'closest'}),
+('address', {'prefix': 'spread', 'distribution':
'balanced'}),
+('address', {'prefix': 'multicast', 'distribution':
'multicast'}),
+connection
+]
+
+config = Qdrouterd.Config(config)
+
+cls.routers.append(cls.tester.qdrouterd(name, config,
wait=True))
+
+cls.routers = []
+
+inter_router_port = cls.tester.get_port()
+
+router('A', ('listener', {'role': 'inter-router', 'port':
inter_router_port}))
+router('B', ('connector', {'name': 'connectorToA', 'role':
'inter-router', 'port': inter_router_port, 'verifyHostName': 'no'}))
+
+cls.routers[0].wait_router_connected('B')
+cls.routers[1].wait_router_connected('A')
+
+
+def test_01_single_incoming_prefix(self):
+test = DynamicLinkRouteTest(self.routers[0].addresses[0],
+self.routers[0].addresses[0],
+self.routers[1].addresses[0],
+
{symbol('qd.link-route-patterns'):[u'linkRoute.prefix.#', symbol('in')]},
+[u'ClinkRoute.prefix'])
+test.run()
+self.assertEqual(None, test.error)
+
+
+def test_02_single_outgoing_prefix(self):
+test = DynamicLinkRouteTest(self.routers[0].addresses[0],
+self.routers[0].addresses[0],
+self.routers[1].addresses[0],
+
{symbol('qd.link-route-patterns'):[u'linkRoute.prefix.#', symbol('out')]},
+[u'DlinkRoute.prefix'])
+test.run()
+self.assertEqual(None, test.error)
+
+
+def test_03_single_inout_prefix(self):
+test = DynamicLinkRouteTest(self.routers[0].addresses[0],
+self.routers[0].addresses[0],
+self.routers[1].addresses[0],
+
{symbol('qd.link-route-patterns'):[u'linkRoute.prefix.#', symbol('inout')]},
+[u'ClinkRoute.prefix',
u'DlinkRoute.prefix'])
+test.run()
+self.assertEqual(None, test.error)
+
+
+def test_04_single_incoming_pattern(self):
+
