[GitHub] qpid-dispatch pull request #424: DISPATCH-1187: add options to log in UTC an...
Github user grs closed the pull request at: https://github.com/apache/qpid-dispatch/pull/424 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #424: DISPATCH-1187: add options to log in UTC an...
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/424 DISPATCH-1187: add options to log in UTC and to give control over the⦠⦠precise format of the date/time logged You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1187 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 544a7bed719b18407bbf55038b3997dfea55cd5d Author: Gordon Sim Date: 2018-12-04T18:01:58Z DISPATCH-1187: add options to log in UTC and to give control over the precise format of the date/time logged --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #418: DISPATCH-1181: add hint about treatment to ...
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/418 DISPATCH-1181: add hint about treatment to MAU ...and use that on receipt if there is no locally defined treatment You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch mau-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/418.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #418 commit 29abeccc911f7d06e3937203e9a605093a1e146f Author: Gordon Sim Date: 2018-11-09T22:43:10Z DISPATCH-1181: add hint about treatment to MAU and use that on receipt if there is no locally defined treatment --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #373: DISPATCH-1117: suggested doc fixes
Github user grs closed the pull request at: https://github.com/apache/qpid-dispatch/pull/373 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...
Github user grs closed the pull request at: https://github.com/apache/qpid-proton/pull/150 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #150: PROTON-1888: allow configuration of connection detai...
Github user grs commented on the issue: https://github.com/apache/qpid-proton/pull/150 Rebased and updated to align with commit for PROTON-1935 for c++ --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #372: DISPATCH-1116: prevent module being updated on log...
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/372 @ganeshmurthy @ted-ross does this look ok? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #373: DISPATCH-1117: suggested doc fixes
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/373 @bhardesty does this look ok? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #373: DISPATCH-1117: suggested doc fixes
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/373 DISPATCH-1117: suggested doc fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1117 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit 792dfa80156bf22ae2c7a87c08c8206f0508fab1 Author: Gordon Sim Date: 2018-09-06T19:45:38Z DISPATCH-1117: suggested doc fixes --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #372: DISPATCH-1116: prevent module being updated...
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/372 DISPATCH-1116: prevent module being updated on log instances You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1116 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #372 commit 6c34481438d6c268d3e8debd238e8d5131ff7be1 Author: Gordon Sim Date: 2018-09-06T19:12:04Z DISPATCH-1116: prevent module being updated on log instances --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #357: DISPATCH-1099 - Added plumbing that sends ticks in...
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/357 Possibly silly question, but is there any performance impact to this? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #357: DISPATCH-1099 - Added plumbing that sends t...
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/357#discussion_r209165667 --- Diff: src/router_core/core_timer.c --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "router_core_private.h" + + +void qdr_timner_schedule(qdr_core_t *core, qdr_timer_cb_t callback, void *timer_context, int timer_delay) --- End diff -- s/timner/timer/ ? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...
GitHub user grs opened a pull request: https://github.com/apache/qpid-proton/pull/150 PROTON-1888: allow configuration of connection details from a config ⦠â¦file The file to use can be specified using the CONNECT_CONFIG environment variable. If that is not set, it will look for a file name connect.json, first in the current directory, then in the users local configuration directory (~/.config/messaging) and then in the system config directory (/etc/messaging/) The config file is in json format and the following properties can be specified: scheme host port sasl_mechanisms user password cert_file private_key_file private_key_password ca_cert_file You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-proton default_connect_proposal Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 commit 52f0f270dc40017cdaffba4f9c5e865e2859df4d Author: Gordon Sim Date: 2018-05-16T15:54:19Z PROTON-1888: allow configuration of connection details from a config file The file to use can be specified using the CONNECT_CONFIG environment variable. If that is not set, it will look for a file name connect.json, first in the current directory, then in the users local configuration directory (~/.config/messaging) and then in the system config directory (/etc/messaging/) The config file is in json format and the following properties can be specified: scheme host port sasl_mechanisms user password cert_file private_key_file private_key_password ca_cert_file --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/303#discussion_r187367734 --- Diff: src/router_core/connections.c --- @@ -473,7 +474,8 @@ void qdr_link_second_attach(qdr_link_t *link, qdr_terminus_t *source, qdr_termin action->args.connection.link = link; action->args.connection.source = source; action->args.connection.target = target; -qdr_action_enqueue(link->core, action); +if (link) --- End diff -- I wonder if the test might be better done in AMQP_link_attach_handler in router_node.c? That is the only place that calls the method, and is the one that retrieves the null context. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #293: DISPATCH-977: Add transaction coordinator s...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/293#discussion_r184128463
--- Diff: doc/new-book/routing.adoc ---
@@ -575,6 +575,20 @@ connector {
For information about additional attributes, see
link:{qdrouterdConfManPageUrl}#_connector[connector] in the `qdrouterd.conf`
man page.
--
+. If you want clients to send local transactions to the broker, create a
link route for the transaction coordinator:
--- End diff --
One thing I think needs to be clear is that routing the coordinator really
only works if there is only one broker with which any transactional
interactions are undertaken.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #293: DISPATCH-977: Add transaction coordinator s...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/293#discussion_r184127780
--- Diff: doc/new-book/routing.adoc ---
@@ -575,6 +575,20 @@ connector {
For information about additional attributes, see
link:{qdrouterdConfManPageUrl}#_connector[connector] in the `qdrouterd.conf`
man page.
--
+. If you want clients to send local transactions to the broker, create a
link route for the transaction coordinator:
++
+--
+[options="nowrap",subs="+quotes"]
+
+linkRoute {
+prefix: $coordinator <1>
+connection: __CONNECTOR_NAME__
+direction: in
+}
+
+<1> The `$coordinator` prefix designates this link route as a transaction
coordinator. When the client opens a transacted session, the transactional
state is propagated along this link route to the broker.
--- End diff --
The coordinator link is used for declaring and completing (committing or
rolling back) the transactions. In the AMQP spec, the term 'transactional
state' is used to tie the publication and consumption of messages to a given
transaction, and is part of the transfer or disposition - loosely the message
or its acknowledgement - which do not go over the coordinator link.
Perhaps it would be less (potentially) confusing to change from 'the
transactional state is propagated along this link route to the broker' to
'requests to start or end a transaction are propagated along this link route to
the broker.' ??
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-cpp issue #12: WIP - A batch of C++ updates
Github user grs commented on the issue: https://github.com/apache/qpid-cpp/pull/12 Looks good to me --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #188: DISPATCH-775: provide a plugin that will de...
Github user grs closed the pull request at: https://github.com/apache/qpid-dispatch/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #188: DISPATCH-775: provide a plugin that will de...
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/188 DISPATCH-775: provide a plugin that will delegate sasl authentication⦠⦠to a specified authentication service You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-775 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/188.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #188 commit dae2cfa8689e2f309e1763bd2b0afeb9db09d926 Author: Gordon Sim <g...@redhat.com> Date: 2017-08-14T15:59:32Z DISPATCH-775: provide a plugin that will delegate sasl authentication to a specified authentication service --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #185: DISPATCH-803 - The following changes were m...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/185#discussion_r132281323
--- Diff: src/router_core/transfer.c ---
@@ -634,6 +634,23 @@ static void qdr_link_forward_CT(qdr_core_t *core,
qdr_link_t *link, qdr_delivery
addr->deliveries_ingress++;
link->total_deliveries++;
}
+//
+// There is no address that we can send this delivery to, which means
the addr was not found in our hastable. This
+// can be because there were no receivers or because the address was
not defined in the config file.
+// If the treatment for such addresses is set to be forbidden, we send
back a rejected disposition and detach the link
+//
+else if (core->qd->treatment == QD_TREATMENT_LINK_FORBIDDEN) {
+dlv->disposition = PN_REJECTED;
+dlv->error = qdr_error("qd:forbidden", "Sending deliveries to this
address is forbidden");
--- End diff --
Or perhaps even better would be amqp:not-found, since we are really saying
that this is not a recognised address?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #185: DISPATCH-803 - The following changes were m...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/185#discussion_r132280889
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -504,6 +504,13 @@
"deprecated": true,
"description": "(DEPRECATED) This value is no longer
used in the router.",
"create": true
+},
+"defaultDistribution": {
+"type": ["multicast", "closest", "balanced",
"forbidden"],
+"description": "Default forwarding treatment for any
address without a specified treatment. multicast - one copy of each message
delivered to all subscribers; closest - messages delivered to only the closest
subscriber; balanced - messages delivered to one subscriber with load balanced
across subscribers; linkBalanced - for link-routing, link attaches balanced
across destinations; forbidden - this address is forbidden, link attaches to an
address of forbidden distribution will be rejected.",
--- End diff --
linkBalanced should be removed from the comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #106: Added command line parameters for configure URL and ...
Github user grs commented on the issue: https://github.com/apache/qpid-proton/pull/106 One minor issue: this doesn't work at present with the defaults. It seems to be because urlparse requires a scheme. You can use Url from proton e.g. as in sync_client.py. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #99: DISPATCH-500 - Fixed code to use qdr_field_t to pas...
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/99 Is this for DISPATCH-502? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #96: Use atomic ops for ref_counts
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/96#discussion_r75930357 --- Diff: src/connection_manager.c --- @@ -254,9 +252,8 @@ qd_config_ssl_profile_t *qd_dispatch_configure_ssl_profile(qd_dispatch_t *qd, qd ssl_profile->ssl_trusted_certificates = qd_entity_opt_string(entity, "trustedCerts", 0); CHECK(); ssl_profile->ssl_uid_format = qd_entity_opt_string(entity, "uidFormat", 0); CHECK(); ssl_profile->ssl_display_name_file = qd_entity_opt_string(entity, "displayNameFile", 0); CHECK(); -sys_mutex_lock(qd->connection_manager->ssl_profile_lock); -ssl_profile->ref_count = 0; -sys_mutex_unlock(qd->connection_manager->ssl_profile_lock); + +__sync_and_and_fetch(_profile->ref_count, 0); --- End diff -- Ah, I get it now! Sorry for the noise! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #96: Use atomic ops for ref_counts
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/96#discussion_r75927487 --- Diff: src/connection_manager.c --- @@ -254,9 +252,8 @@ qd_config_ssl_profile_t *qd_dispatch_configure_ssl_profile(qd_dispatch_t *qd, qd ssl_profile->ssl_trusted_certificates = qd_entity_opt_string(entity, "trustedCerts", 0); CHECK(); ssl_profile->ssl_uid_format = qd_entity_opt_string(entity, "uidFormat", 0); CHECK(); ssl_profile->ssl_display_name_file = qd_entity_opt_string(entity, "displayNameFile", 0); CHECK(); -sys_mutex_lock(qd->connection_manager->ssl_profile_lock); -ssl_profile->ref_count = 0; -sys_mutex_unlock(qd->connection_manager->ssl_profile_lock); + +__sync_and_and_fetch(_profile->ref_count, 0); --- End diff -- Typo? Should this be __sync_add_and_fetch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid issue #10: feat(disposition): respect messageAnnotation mods in modifie...
Github user grs commented on the issue: https://github.com/apache/qpid/pull/10 Thanks again Matt! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/10#discussion_r68769620 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size) pn_link_send(link, data, size); } +void OutgoingFromQueue::maybeMergeMessageAnnotations(const Record ) --- End diff -- Minor, subjective point on the method name: 'maybe' sounds vague, perhaps mergeAnnotationsIfRequired? or checkAndMergeAnnotations? Change looks good though, thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid issue #9: feat(disposition): support undeliverable-here in modified out...
Github user grs commented on the issue: https://github.com/apache/qpid/pull/9 @mbroadst this is now committed. I somehow messed up the intended merge commit (I think perhaps on git svn rebase), so I'm afraid I neither marked the JIRA for this (https://issues.apache.org/jira/browse/QPID-7324) nor kept your name in the commit log. Thanks very much for the contribution though! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid issue #9: feat(disposition): support undeliverable-here in modified out...
Github user grs commented on the issue: https://github.com/apache/qpid/pull/9 Actually, I've confirmed a patch isn't necessary. I can use your PR branch. I'll give this a test today and all going well merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #:
Github user grs commented on the pull request: https://github.com/apache/qpid/commit/7b8a91375dc0528e2c15686ab71c3647ac3e2f96#commitcomment-18005323 In qpid/cpp/src/qpid/broker/Queue.h: In qpid/cpp/src/qpid/broker/Queue.h on line 538: should be fixed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid/pull/9#discussion_r68367813
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker,
const std::string& source,
void OutgoingFromQueue::init()
{
+// observe queue for changes to track undeliverable messages
+
queue->getObservers().add(boost::shared_ptr(shared_from_this()));
+
--- End diff --
Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid/pull/9#discussion_r68322398
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker,
const std::string& source,
void OutgoingFromQueue::init()
{
+// observe queue for changes to track undeliverable messages
+
queue->getObservers().add(boost::shared_ptr(shared_from_this()));
+
--- End diff --
Either of those works. One other point is that we need to deregister the
observer when the consumer ends.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid/pull/9#discussion_r68322267
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t*
delivery)
if (preAcquires()) {
//TODO: handle message-annotations
if
(pn_disposition_is_undeliverable(pn_delivery_remote(delivery))) {
-//treat undeliverable here as rejection
-queue->reject(r.cursor);
-} else {
-queue->release(r.cursor,
pn_disposition_is_failed(pn_delivery_remote(delivery)));
+undeliverableMessages.add(r.msg.getSequence());
}
+
+queue->release(r.cursor,
pn_disposition_is_failed(pn_delivery_remote(delivery)));
--- End diff --
That's a fair point. It wouldn't actually be a regression. Let's leave any
queue options as a separate concern for now then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid/pull/9#discussion_r68299958
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t*
delivery)
if (preAcquires()) {
//TODO: handle message-annotations
if
(pn_disposition_is_undeliverable(pn_delivery_remote(delivery))) {
-//treat undeliverable here as rejection
-queue->reject(r.cursor);
-} else {
-queue->release(r.cursor,
pn_disposition_is_failed(pn_delivery_remote(delivery)));
+undeliverableMessages.add(r.msg.getSequence());
}
+
+queue->release(r.cursor,
pn_disposition_is_failed(pn_delivery_remote(delivery)));
--- End diff --
One issue here is that the message will remain on the queue, even if there
are no other consumers. In some cases that may be what you want, in others
though it could cause a problem.
What would you think of having a queue level setting that dictated whether
consumers should reject or track undelivered? Ideally we would then have reject
as the default for now for backwards compatibility, but the behaviour you
desire could be enabled when creating the queue? Alternatively we could even
make the default a broker level option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid/pull/9#discussion_r68299289
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker,
const std::string& source,
void OutgoingFromQueue::init()
{
+// observe queue for changes to track undeliverable messages
+
queue->getObservers().add(boost::shared_ptr(shared_from_this()));
+
--- End diff --
If possible, I'd really like to make the tracking lazy, only activating if
actually requested/needed, and only then registering the queue observer and
tracking the messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #83: DISPATCH-401 - Verified host name by default...
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/83#discussion_r68114603
--- Diff: python/qpid_dispatch_internal/tools/command.py ---
@@ -83,6 +83,11 @@ def connection_options(options, title="Connection
Options"):
help="Trusted Certificate Authority Database file
(PEM Format)")
group.add_option("--ssl-password", action="store", type="string",
metavar="PASSWORD",
help="Certificate password, will be prompted if not
specifed.")
+group.add_option("--no-verify-host-name", action="store_true",
default=False,
--- End diff --
Maybe add 'ssl' to the option also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
