[GitHub] qpid-jms pull request #18: QPIDJMS-375: Added transport.ws.authorizationHead...

2018-04-05 Thread mibo 
GitHub user mibo opened a pull request:

https://github.com/apache/qpid-jms/pull/18

QPIDJMS-375: Added transport.ws.authorizationHeader option

As described in the JIRA item: 
https://issues.apache.org/jira/browse/QPIDJMS-375

According tests will follow (however the {{NettyWsTransportTest}} and 
{{NettyEchoServer}} seems to fit not perfect for my test case).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mibo/qpid-jms QPIDJMS-375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-jms/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit 7c7703204209f2fef5cbbeda59f732a2983db7ba
Author: mibo 
Date:   2018-04-06T03:31:19Z

QPIDJMS-375: Added transport.ws.authorizationHeader option




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms issue #17: QPIDJMS-374: Use getRawQuery to avoid double encoding

2018-04-04 Thread mibo 
Github user mibo commented on the issue:

https://github.com/apache/qpid-jms/pull/17
  
Changed to use `PropertyUtil.parseQuery(remoteURI)` and added tests.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms issue #17: QPIDJMS-374: Use getRawQuery to avoid double encoding

2018-04-01 Thread mibo 
Github user mibo commented on the issue:

https://github.com/apache/qpid-jms/pull/17
  
I agree that using `PropertyUtil.parseQuery(remoteURI)` would be better 
(which then does the `PropertyUtil.parseQuery(uri.getRawQuery())` call after a 
[null 
check](https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/util/PropertyUtil.java#L189)).
I will change it and add the currently missing (JUnit) tests.
But I think we can agree that using 
`PropertyUtil.parseQuery(remoteURI.getQuery())` is a bug.

Btw. I oriented the fix by the 
[TransportFactory](https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportFactory.java#L51).


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #17: QPIDJMS-374: Use getRawQuery to avoid double enco...

2018-03-28 Thread mibo 
GitHub user mibo opened a pull request:

https://github.com/apache/qpid-jms/pull/17

QPIDJMS-374: Use getRawQuery to avoid double encoding



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mibo/qpid-jms master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-jms/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit b89a1e8cebcde65575aee1bd0dbe3c2cce01ccee
Author: mibo 
Date:   2018-03-29T06:52:29Z

QPIDJMS-374: Use getRawQuery to avoid double encoding




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org