[GitHub] qpid-dispatch pull request #253: Enhanced link-statistics

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/253


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #253: Enhanced link-statistics

[bhardesty]

Github user bhardesty commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/253#discussion_r170986612
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -1325,6 +1329,10 @@
 "lastTopoChange": {
  "description": "Timestamp showing the most recent 
change to this node's neighborhood.",
  "type": "integer"
+},
+"index": {
+"description": "Index number for this router node used 
in statistics histograms.  This index is specific to this router.",
--- End diff --

Minor suggestion for the description:

> The index number used in statistics histograms for this router node. This 
index is specific to this router.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #253: Enhanced link-statistics

[bhardesty]

Github user bhardesty commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/253#discussion_r170986013
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -1207,6 +1207,10 @@
 "type": "integer",
 "graph": true,
 "description": "The total number of modified 
deliveries."
+},
+"ingressHistogram": {
+"type": "list",
+"description": "For outgoing links on normal 
connections.  This is a histogram with a value per interior router node.  The 
value is a count of settled deliveries on this link that ingressed the network 
at the specific interior router."
--- End diff --

Suggestion for the description:

> For outgoing links on normal connections, this histogram shows the number 
of settled deliveries on the link that ingressed the network at each interior 
router node.

Also, what constitutes a "normal" connection? Does that need to be defined?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #253: Enhanced link-statistics

[ted-ross]

GitHub user ted-ross opened a pull request:

https://github.com/apache/qpid-dispatch/pull/253

Enhanced link-statistics

This pull request contains a code change that adds the following contents 
to the management entities in the router:
- An index number has been added to the router.node entity to facilitate 
mapping histogram slots to router identities.
- A new attribute in the 'link' entity called 'ingressHistogram'.  This 
attribute is valid only for outgoing links on normal connections.  It contains 
an array of numbers that indicate the number of deliveries that arrived on each 
ingress router in the network.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ted-ross/qpid-dispatch tross-link-stats

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit 98720da4674f15524b4b64b8b0fc892f64e53ad0
Author: Ted Ross 
Date:   2018-02-09T15:52:31Z

Added index number to the router.node entity.  This will be needed to map 
histogram slots to router identities.

commit f3fe1e290a75cce3ad1168b64afcc0011fd9a3dd
Author: Ted Ross 
Date:   2018-02-09T21:54:02Z

Added functioning ingress histogram for endpoint out-links.
Still needed:
  - Tests
  - Removal of the older mechanism for determing ingress router in 
multicast forwarder




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org