[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

[ChugR]

Github user ChugR closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/262


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

[ChugR]

Github user ChugR commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/262#discussion_r171073403
  
--- Diff: console/config/schema.json ---
@@ -1273,6 +1273,10 @@
   "type": "map", 
   "description": "A map where each key is a user group name and 
the value is a map of the corresponding settings for that group."
 }, 
+"hostname": {
+  "type": "string", 
+  "description": "The vhost name."
+}, 
--- End diff --

will do. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

[ganeshmurthy]

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/262#discussion_r171011913
  
--- Diff: console/config/schema.json ---
@@ -1273,6 +1273,10 @@
   "type": "map", 
   "description": "A map where each key is a user group name and 
the value is a map of the corresponding settings for that group."
 }, 
+"hostname": {
--- End diff --

yes, agreed


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

[ChugR]

Github user ChugR commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/262#discussion_r170987746
  
--- Diff: console/config/schema.json ---
@@ -1273,6 +1273,10 @@
   "type": "map", 
   "description": "A map where each key is a user group name and 
the value is a map of the corresponding settings for that group."
 }, 
+"hostname": {
--- End diff --

Can't be used until you check it in...


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

[ganeshmurthy]

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/262#discussion_r170751787
  
--- Diff: console/config/schema.json ---
@@ -1273,6 +1273,10 @@
   "type": "map", 
   "description": "A map where each key is a user group name and 
the value is a map of the corresponding settings for that group."
 }, 
+"hostname": {
--- End diff --

Could this use the deprecationName attribute from my earlier PR - 
https://github.com/apache/qpid-dispatch/pull/261/files#diff-981a10a2c9cab3708f003b402e7f8be4R1060


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

[ChugR]

GitHub user ChugR opened a pull request:

https://github.com/apache/qpid-dispatch/pull/262

Crolke 918 vhost hostname



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChugR/qpid-dispatch crolke-918-vhost-hostname

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 09fd276746da848774a2c9314a4ea7fa7924545a
Author: Chuck Rolke 
Date:   2018-02-26T21:25:54Z

DISPATCH-918: policy vhost 'id' renamed to 'hostname'

commit 2078ab98da45d65a33a3613cac6e4c50261b1d6e
Author: Chuck Rolke 
Date:   2018-02-26T21:32:35Z

DISPATCH-918: fix self test description




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org