[GitHub] qpid-dispatch pull request #318: DISPATCH-1023 - Added a multicast bit on th...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/318 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #318: DISPATCH-1023 - Added a multicast bit on th...
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/318#discussion_r193834441
--- Diff: src/router_core/transfer.c ---
@@ -1162,7 +1164,7 @@ static void qdr_deliver_continue_CT(qdr_core_t *core,
qdr_action_t *action, bool
}
// This is a multicast delivery
-if (qdr_is_addr_treatment_multicast(in_dlv->link->owning_addr)) {
+if (qdr_is_addr_treatment_multicast(in_dlv->link->owning_addr) ||
in_dlv->multicast || in_dlv->settled) {
--- End diff --
If the latter is handling for multi-frame unicasts, then the comment above
is no longer accurate.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #318: DISPATCH-1023 - Added a multicast bit on th...
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/318#discussion_r193833973
--- Diff: src/router_core/transfer.c ---
@@ -1162,7 +1164,7 @@ static void qdr_deliver_continue_CT(qdr_core_t *core,
qdr_action_t *action, bool
}
// This is a multicast delivery
-if (qdr_is_addr_treatment_multicast(in_dlv->link->owning_addr)) {
+if (qdr_is_addr_treatment_multicast(in_dlv->link->owning_addr) ||
in_dlv->multicast || in_dlv->settled) {
--- End diff --
Why did you keep the call to qdr_is_addr_treatment_multicast here? Isn't
it always true that the in_dlv->multicast flag will be initialized
appropriately in qdr_link_forward_CT?
Also, why did you add the in_dlv->settled condition? That is new/changed
functionality.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #318: DISPATCH-1023 - Added a multicast bit on th...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/318 DISPATCH-1023 - Added a multicast bit on the qdr_delivery_t object to⦠⦠use in places where owning_addr is not available. Also added code to free multi frame non-multicast presettled messages. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1023-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/318.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #318 commit 3a41b1b6fe64a5c3c1ef040a70dfc8c49f9b42d9 Author: Ganesh Murthy Date: 2018-06-04T20:02:10Z DISPATCH-1023 - Added a multicast bit on the qdr_delivery_t object to use in places where owning_addr is not available. Also added code to free multi frame non-multicast presettled messages. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
