[GitHub] qpid-jms issue #19: Save allocation of new promise on each writeAndFlush

2018-07-10 Thread tabish121 
Github user tabish121 commented on the issue:

https://github.com/apache/qpid-jms/pull/19
  
I spent some time reviewing netty code and getting a handle on how this 
would change the current behavior.  From what I can see this should be safe to 
apply.  The tests all pass from a local checkout as well.  I'd recommend 
creating a JIRA and updating the PR with the JIRA issue to link up the work 
done here.  


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms issue #19: Save allocation of new promise on each writeAndFlush

2018-07-03 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/qpid-jms/pull/19
  
The main source of this optimization is coming from 
http://normanmaurer.me/presentations/2014-facebook-eng-netty/slides.html#8.0


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms issue #19: Save allocation of new promise on each writeAndFlush

2018-07-03 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/qpid-jms/pull/19
  
@tabish121 @gemmellr  I have rebased it in order to make this PR compatible 
with the last version :+1: 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org