[jira] [Comment Edited] (PROTON-1862) idle timeout not working on linux
[ https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803083#comment-16803083 ] Rabih Mourad edited comment on PROTON-1862 at 3/27/19 5:14 PM: --- We block the receiver container with a sleep to simulate a hanging on the server side after the connection is established. The client (sender) does not sleep therefore after the idle timeout is expired it should fail and on linux it is not. But as Ali said in his last comments. The issue is that the server (receiver) is calling the on_connection_open and the on_session_open callbacks before the real amqp connection is established. Therefore there is no idle timeout yet. Therefore the fix might be to call those call backs after the real connection is established on the wire. The regression was introduced in the version 0.18.1 was (Author: rabih.promail): We block the receiver container with a sleep to simulate a hanging on the server side after the connection is established. The client (sender) does not sleep therefore after the idle timeout is expired it should fail and on linux it is not. But as Ali said in his last comments. The issue is that the server (receiver) is calling the on_connection_open and the on_session_open callbacks before the real amqp connection is established. Therefore there is no idle timeout yet. Therefore the fix might be to call those call backs after the real connection is established on the wire. > idle timeout not working on linux > -- > > Key: PROTON-1862 > URL: https://issues.apache.org/jira/browse/PROTON-1862 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.22.0 >Reporter: Jeremy >Priority: Critical > Labels: reproducer > Attachments: proton_1862_tests.txt, test_case.cpp > > > We faced an issue with the idle timeout on linux. On windows, it seems to > work. > In our proton feature test suite, we test the idle timeout feature by doing a > sleep in the method on_session_open. > This should trigger a connection timeout. It works on windows, and it used to > work with proton v0.16.0 on windows and linux. > Removing the sleep from the on_session_open and putting it in > on_connection_open, yields the same result. > See attached file to reproduce. > Machines: > * Windows machine > ** OS: Windows 7 > ** Compiler: MSVC 2013 Version 12 Update 5 > * Linux machine > ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago) > ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1862) Idle timeout not working on Linux
[ https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627391#comment-16627391 ] Ali Hadi edited comment on PROTON-1862 at 9/26/18 8:51 AM: --- Hello, We analysed this issue and we noticed that in the on_connection_open or on_session_open of the receiver, the connection with the server is not yet established and this is why the idle-timeout does not expire. Moving the sleep in the on_message causes the idle time-out to always expires. Therefore the problem is that the proton container on Linux is calling on_connection_open before the remote peer opened the connection, unlike stated in the documentation in messaging_handler.hpp. I will test it on the latest proton version. We must think of changing the issue title. Regards, Ali was (Author: alihadi): Hello, We analysed this issue and the behavior of the test is normal. In fact, in the on_connection_open or on_session_open of the receiver, the connection with the server is not yet established and this is why the idle-timeout does not expire. Moving the sleep in the on_message causes the idle time-out to always expires. That being said, the difference in behavior of windows is still an issue that needs to addressed. Regards, Ali > Idle timeout not working on Linux > - > > Key: PROTON-1862 > URL: https://issues.apache.org/jira/browse/PROTON-1862 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.22.0 >Reporter: Jeremy >Priority: Critical > Labels: reproducer > Attachments: proton_1862_tests.txt, test_case.cpp > > > We faced an issue with the idle timeout on linux. On windows, it seems to > work. > In our proton feature test suite, we test the idle timeout feature by doing a > sleep in the method on_session_open. > This should trigger a connection timeout. It works on windows, and it used to > work with proton v0.16.0 on windows and linux. > Removing the sleep from the on_session_open and putting it in > on_connection_open, yields the same result. > See attached file to reproduce. > Machines: > * Windows machine > ** OS: Windows 7 > ** Compiler: MSVC 2013 Version 12 Update 5 > * Linux machine > ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago) > ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1862) Idle timeout not working on Linux
[ https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524842#comment-16524842 ] Jeremy edited comment on PROTON-1862 at 6/27/18 9:50 AM: - Any updates as to when can this issue be addressed? I can work on a patch, however, I need your validation before, on whether or not this is indeed a regression. was (Author: jeremy.aouad): Any updates as to when can this issue be addressed? I can work on a patch, however, I need your validation before if this is indeed a regression. > Idle timeout not working on Linux > - > > Key: PROTON-1862 > URL: https://issues.apache.org/jira/browse/PROTON-1862 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.22.0 >Reporter: Jeremy >Priority: Critical > Labels: reproducer > Attachments: test_case.cpp > > > We faced an issue with the idle timeout on linux. On windows, it seems to > work. > In our proton feature test suite, we test the idle timeout feature by doing a > sleep in the method on_session_open. > This should trigger a connection timeout. It works on windows, and it used to > work with proton v0.16.0 on windows and linux. > Removing the sleep from the on_session_open and putting it in > on_connection_open, yields the same result. > See attached file to reproduce. > Machines: > * Windows machine > ** OS: Windows 7 > ** Compiler: MSVC 2013 Version 12 Update 5 > * Linux machine > ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago) > ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
