[
https://issues.apache.org/jira/browse/QPID-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173234#comment-16173234
]
Lorenz Quack edited comment on QPID-7772 at 9/20/17 2:49 PM:
-------------------------------------------------------------
I have a couple of comments with regards to the changes made in this JIRA:
* The columns of statistics grids are not resizable.
* The position of the "Edit & Delete" Bar is a bit surprising. It is tucked
under the statistics panel if present and under the attributes panel otherwise.
Is this by coincidence or what was the reasoning to put it there? I was okay
with it being under the attributes since all configured objects have attributes
but now it just seems arbitrary and inconsistent. That is ignoring the
additional oddity that is the Broker tab which seems to follow different design
yet again.
* Shouldn't all ConfiguredObjects that have statistics also have a statistics
panel? AMQP Ports and BrokerLoggers are two examples that fall into this
category.
* -Exchange stats seem to not work. ("inbound" is just showing 0s even though
messages are flowing)-
* There seem to be at least two UI bugs (Firefox 55.0.2 on Linux):
** Collapse a statisitics panel, switch tab, switch back, reopen the statistics
panel and the grid headers won't show until next update.
** UI bug: The right column in the Attributes panel of the following tabs
starts on the second row (these are the ones modified under this JIRA with the
exception of Connection which does not seem to be affected): VH, Queue, Port,
Exchange
* The minus.svg has an {{id="plus"}} which seems... counter-intuitive
was (Author: lorenz.quack):
I have a couple of comments with regards to the changes made in this JIRA:
* The columns of statistics grids are not resizable.
* The position of the "Edit & Delete" Bar is a bit surprising. It is tucked
under the statistics panel if present and under the attributes panel otherwise.
Is this by coincidence or what was the reasoning to put it there? I was okay
with it being under the attributes since all configured objects have attributes
but now it just seems arbitrary and inconsistent. That is ignoring the
additional oddity that is the Broker tab which seems to follow different design
yet again.
* Shouldn't all ConfiguredObjects that have statistics also have a statistics
panel? AMQP Ports and BrokerLoggers are two examples that fall into this
category.
* Exchange stats seem to not work. ("inbound" is just showing 0s even though
messages are flowing)
* There seem to be at least two UI bugs (Firefox 55.0.2 on Linux):
** Collapse a statisitics panel, switch tab, switch back, reopen the statistics
panel and the grid headers won't show until next update.
** UI bug: The right column in the Attributes panel of the following tabs
starts on the second row (these are the ones modified under this JIRA with the
exception of Connection which does not seem to be affected): VH, Queue, Port,
Exchange
* The minus.svg has an {{id="plus"}} which seems... counter-intuitive
> Add statistics panel to view tabs within the Web Management Console
> -------------------------------------------------------------------
>
> Key: QPID-7772
> URL: https://issues.apache.org/jira/browse/QPID-7772
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
>
> Configured Objects within the Broker's object model already carry many useful
> statistics. Only a fraction of these are currently presented on the WMC and
> this means that most users are aware of their existence.
> Each view tab should have an expandable panel that provides the available
> statistics. The contents of the statistics panel should be entirely driven
> from the object's metadata. If the statistics panel is opened, the
> statistics should be updated automatically to the same refresh cycle of the
> request of the UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
