[jira] [Commented] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost
[
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525674#comment-16525674
]
ASF subversion and git services commented on DISPATCH-1020:
---
Commit 723b73585bec70f009f5409bf29cd1edceaa167d in qpid-dispatch's branch
refs/heads/master from Gordon Sim
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=723b735 ]
DISPATCH-1020: set close on link lost based on whether terminus would survive
disconnect
> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Currently, Dispatch responds to the loss of an underlying connection to a
> peer by detaching the links established over that connection in the following
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29)
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would
> be an improvement to the dispatch's behaviour if those links were detached
> with {{closed=true}}. This would aid the timely clean-up of resources
> elsewhere in the AMQP network.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost
[
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517595#comment-16517595
]
Gordon Sim commented on DISPATCH-1020:
--
One possibility proposed here: https://reviews.apache.org/r/67661/
> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Currently, Dispatch responds to the loss of an underlying connection to a
> peer by detaching the links established over that connection in the following
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29)
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would
> be an improvement to the dispatch's behaviour if those links were detached
> with {{closed=true}}. This would aid the timely clean-up of resources
> elsewhere in the AMQP network.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost
[
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501882#comment-16501882
]
Gordon Sim commented on DISPATCH-1020:
--
One complication is the recent change to share a session between all link
routes. The default terminus-expiry-policy in both source and target is
session-end, meaning I think that the correct behaviour on receiving the detach
with closed=false for a link in which an explicit terminus-expiry-policy was
not requested, would be to keep the terminus state until the shared session
ended. That probably isn't what is usually wanted.
One option might be to explicitly set the terminus-expiry-policy before
propagating it to the broker. Not sure if that is any better than just issuing
the closed=true in the case that the terminus does not survive connection loss.
> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Currently, Dispatch responds to the loss of an underlying connection to a
> peer by detaching the links established over that connection in the following
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29)
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would
> be an improvement to the dispatch's behaviour if those links were detached
> with {{closed=true}}. This would aid the timely clean-up of resources
> elsewhere in the AMQP network.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost
[
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495442#comment-16495442
]
Robbie Gemmell commented on DISPATCH-1020:
--
I believe Dispatch behaves this way due to prior discussions where it was noted
the reverse behaviour was occurring (as it was sending closed=true all the
time). It seems simpler to use closed=false all the time rather than have the
codebase track the terminus settings and hope it gets it right everywhere.
> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> Currently, Dispatch responds to the loss of an underlying connection to a
> peer by detaching the links established over that connection in the following
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29)
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would
> be an improvement to the dispatch's behaviour if those links were detached
> with {{closed=true}}. This would aid the timely clean-up of resources
> elsewhere in the AMQP network.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
