[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551784#comment-17551784 ] ASF subversion and git services commented on PROTON-2556: - Commit 447f518bf5a6c37ee765fb70f332b59148f7bf28 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=447f518bf ] PROTON-2556: Remove unnecessary active connection list from reactor-recv I suspect this was added as a workaround long ago when proton didn't properly cleanup listening connections. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551779#comment-17551779 ] ASF subversion and git services commented on PROTON-2556: - Commit 0ad20092eb68e08a784a988af31dfc2be500e7f5 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=0ad20092e ] PROTON-2556: Removed gratuitous use of pn_string from reactor-send > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551621#comment-17551621 ] Ken Giusti commented on PROTON-2556: Any use of internal proton APIs by skupper-router or qpid-dispatch is a bug and needs to be resolved in those projects. That said I was under the impression that proton-internal APIs used the pni_* prefix - is that not the case? Ideally if these internal apis are available via the public headers (c/include/proton) they should be moved to an internal header file or use conditional compilation to prevent use by outside project (just my $0.02 USD) > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551488#comment-17551488 ] Jiri Daněk commented on PROTON-2556: bq. I know that skupper router compiles fine with a few trivial changes - it doesn't use the internal data types of proton - is that something changed when they forked from dispatch router? Don't know. Depends on what the adaptors do? bq. Also and most importantly all these APIs are explicitly marked as internal in the header files and are not documented so that should strongly tell people not to use them because they aren't supported as API. In any case, I now feel better about this. Hopefully skupper can be easily updated and then the privatization can be done without any of these silly CI build breakages. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551349#comment-17551349 ] Andrew Stitcher commented on PROTON-2556: - Also and most importantly all these APIs are explicitly marked as internal in the header files and are not documented so that should strongly tell people not to use them because they aren't supported as API. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
Don't know. Depends on what the adaptors do? In any case, I now feel better about this. Hopefully skupper can be easily updated and then the privatization can be done without any of these silly CI build breakages. On Wed, Jun 8, 2022, 00:04 Andrew Stitcher (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551302#comment-17551302 > ] > > Andrew Stitcher commented on PROTON-2556: > - > > I know that skupper router compiles fine with a few trivial changes - it > doesn't use the internal data types of proton - is that something changed > when they forked from dispatch router? > > > Remove all uses of pn_string and pn_list from example code > > -- > > > > Key: PROTON-2556 > > URL: https://issues.apache.org/jira/browse/PROTON-2556 > > Project: Qpid Proton > > Issue Type: Sub-task > > Components: proton-c > >Reporter: Andrew Stitcher > >Assignee: Andrew Stitcher > >Priority: Major > > > > pn_string and pn_list are currently internal APIs and should not be used > by application programs. > > The proton library is really not in the business of providing a data > structures library! > > > > -- > This message was sent by Atlassian Jira > (v8.20.7#820007) > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551302#comment-17551302 ] Andrew Stitcher commented on PROTON-2556: - I know that skupper router compiles fine with a few trivial changes - it doesn't use the internal data types of proton - is that something changed when they forked from dispatch router? > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551301#comment-17551301 ] Jiri Daněk commented on PROTON-2556: This is the app, https://github.com/corda/corda. Looks like they also use qpid-cpp in their experimental C++ library, https://github.com/corda/corda/blob/cd8cd60a0fd943198a87d266bd15b807eeaa20ba/experimental/cpp-serializer/src/README.md. bq. Why would you use proton for its internal data structures? There are just better libraries out there designed specially for that purpose. In C, obviously because of the notorious dependency hesitancy that all C projects suffer. And when they decide to depend on something, they then exploit that dependency in its fullest. It takes a package manager to break that tendency, but then you end up with the npm-style proliferation of 10 line libraries in turn. The IT world has weird quirks. Maybe I should've become lawyer instead, after all :D bq. I suppose if one really wanted to use pn_string_t, pn_list_t, pn_hash_t, pn_map_t etc. then they could be separated out as a new library Dispatch apparently wants that. And it also likes the Proton Python URL class. Hiding things is probably good artitecture, but it is going to be inconvenient and maybe lead to duplication of code between the two projects? > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[
https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551300#comment-17551300
]
Andrew Stitcher commented on PROTON-2556:
-
I suppose if one really wante to use {{pn_string_t,}} {{{}pn_list_t{}}},
{{{}pn_hash_t{}}}, {{pn_map_t}} etc. then they could be separated out as a new
library, but there really isn't a good reason to have these types anywhere in
the API itself.
> Remove all uses of pn_string and pn_list from example code
> --
>
> Key: PROTON-2556
> URL: https://issues.apache.org/jira/browse/PROTON-2556
> Project: Qpid Proton
> Issue Type: Sub-task
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>
> pn_string and pn_list are currently internal APIs and should not be used by
> application programs.
> The proton library is really not in the business of providing a data
> structures library!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551298#comment-17551298 ] Andrew Stitcher commented on PROTON-2556: - Honestly that sounds a bit perverse, but fortunately it's proton-j not proton-c! Using proton-c for serialization wouldn't be especially perverse as long as you wanted AMQP serialization, but doing that doesn't requires any of the internal data structures. Why would you use proton for its internal data structures? There are just better libraries out there designed specially for that purpose. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2556) Remove all uses of pn_string and pn_list from example code
[ https://issues.apache.org/jira/browse/PROTON-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551276#comment-17551276 ] Jiri Daněk commented on PROTON-2556: [~astitcher] Well, isn't there that electronic ledger document notary application that uses Qpid Proton J as a data-structures library? Seems to me that there is some sense in this usage. > Remove all uses of pn_string and pn_list from example code > -- > > Key: PROTON-2556 > URL: https://issues.apache.org/jira/browse/PROTON-2556 > Project: Qpid Proton > Issue Type: Sub-task > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_string and pn_list are currently internal APIs and should not be used by > application programs. > The proton library is really not in the business of providing a data > structures library! -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
