[jira] [Commented] (PROTON-2622) TLS OpenSSL library: ensure capacity values match given capacity
[ https://issues.apache.org/jira/browse/PROTON-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626732#comment-17626732 ] ASF GitHub Bot commented on PROTON-2622: astitcher commented on PR #380: URL: https://github.com/apache/qpid-proton/pull/380#issuecomment-1297469062 Merged > TLS OpenSSL library: ensure capacity values match given capacity > > > Key: PROTON-2622 > URL: https://issues.apache.org/jira/browse/PROTON-2622 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Affects Versions: proton-c-0.38.0 >Reporter: Ken Giusti >Assignee: Clifford Jansen >Priority: Major > > pn_tls_get_encrypt/decrypt_input_buffer_capacity() unconditionally return > the number of empty buffer slots. > However pn_tls_give_encrypt/decrypt_input_buffers() checks the state of the > tls session and can take zero buffers even though get capacity returned > 0. > In this case the application will have to "unwind" any buffer > allocation/setup work it did expecting there was capacity available. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2622) TLS OpenSSL library: ensure capacity values match given capacity
[ https://issues.apache.org/jira/browse/PROTON-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626733#comment-17626733 ] ASF GitHub Bot commented on PROTON-2622: astitcher closed pull request #380: PROTON-2622: ensure the input_buffer_capacity API returns 0 on error URL: https://github.com/apache/qpid-proton/pull/380 > TLS OpenSSL library: ensure capacity values match given capacity > > > Key: PROTON-2622 > URL: https://issues.apache.org/jira/browse/PROTON-2622 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Affects Versions: proton-c-0.38.0 >Reporter: Ken Giusti >Assignee: Clifford Jansen >Priority: Major > > pn_tls_get_encrypt/decrypt_input_buffer_capacity() unconditionally return > the number of empty buffer slots. > However pn_tls_give_encrypt/decrypt_input_buffers() checks the state of the > tls session and can take zero buffers even though get capacity returned > 0. > In this case the application will have to "unwind" any buffer > allocation/setup work it did expecting there was capacity available. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2622) TLS OpenSSL library: ensure capacity values match given capacity
[ https://issues.apache.org/jira/browse/PROTON-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625071#comment-17625071 ] ASF GitHub Bot commented on PROTON-2622: astitcher commented on PR #380: URL: https://github.com/apache/qpid-proton/pull/380#issuecomment-1293442577 This looks good to me, but I think @cliffjansen needs to review it. > TLS OpenSSL library: ensure capacity values match given capacity > > > Key: PROTON-2622 > URL: https://issues.apache.org/jira/browse/PROTON-2622 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Affects Versions: proton-c-0.38.0 >Reporter: Ken Giusti >Assignee: Clifford Jansen >Priority: Major > > pn_tls_get_encrypt/decrypt_input_buffer_capacity() unconditionally return > the number of empty buffer slots. > However pn_tls_give_encrypt/decrypt_input_buffers() checks the state of the > tls session and can take zero buffers even though get capacity returned > 0. > In this case the application will have to "unwind" any buffer > allocation/setup work it did expecting there was capacity available. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2622) TLS OpenSSL library: ensure capacity values match given capacity
[ https://issues.apache.org/jira/browse/PROTON-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624699#comment-17624699 ] ASF subversion and git services commented on PROTON-2622: - Commit 2e8c767a3bf2d2488a9edeac854243dcfe37068d in qpid-proton's branch refs/heads/main from Clifford Jansen [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=2e8c767a3 ] PROTON-2622: tls library - ensure capacity values match given capacity > TLS OpenSSL library: ensure capacity values match given capacity > > > Key: PROTON-2622 > URL: https://issues.apache.org/jira/browse/PROTON-2622 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Affects Versions: proton-c-0.38.0 >Reporter: Ken Giusti >Assignee: Clifford Jansen >Priority: Major > > pn_tls_get_encrypt/decrypt_input_buffer_capacity() unconditionally return > the number of empty buffer slots. > However pn_tls_give_encrypt/decrypt_input_buffers() checks the state of the > tls session and can take zero buffers even though get capacity returned > 0. > In this case the application will have to "unwind" any buffer > allocation/setup work it did expecting there was capacity available. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2622) TLS OpenSSL library: ensure capacity values match given capacity
[ https://issues.apache.org/jira/browse/PROTON-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616106#comment-17616106 ] ASF GitHub Bot commented on PROTON-2622: codecov-commenter commented on PR #380: URL: https://github.com/apache/qpid-proton/pull/380#issuecomment-127593 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/380?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#380](https://codecov.io/gh/apache/qpid-proton/pull/380?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ec30be8) into [main](https://codecov.io/gh/apache/qpid-proton/commit/bee4fea2cdcb14ed0055a77dcce4fd5f9718e3ce?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bee4fea) will **decrease** coverage by `1.21%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff @@ ## main #380 +/- ## == - Coverage 88.34% 87.13% -1.22% == Files 47 47 Lines2394 2394 == - Hits 2115 2086 -29 - Misses279 308 +29 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/380?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/core/delivery.rb](https://codecov.io/gh/apache/qpid-proton/pull/380/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9kZWxpdmVyeS5yYg==) | `57.57% <0.00%> (-36.37%)` | :arrow_down: | | [ruby/lib/core/tracker.rb](https://codecov.io/gh/apache/qpid-proton/pull/380/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS90cmFja2VyLnJi) | `55.55% <0.00%> (-33.34%)` | :arrow_down: | | [ruby/lib/handler/messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/380/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfYWRhcHRlci5yYg==) | `89.85% <0.00%> (-7.25%)` | :arrow_down: | | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/380/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `92.17% <0.00%> (-3.92%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > TLS OpenSSL library: ensure capacity values match given capacity > > > Key: PROTON-2622 > URL: https://issues.apache.org/jira/browse/PROTON-2622 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Affects Versions: proton-c-0.38.0 >Reporter: Ken Giusti >Assignee: Clifford Jansen >Priority: Major > > pn_tls_get_encrypt/decrypt_input_buffer_capacity() unconditionally return > the number of empty buffer slots. > However pn_tls_give_encrypt/decrypt_input_buffers() checks the state of the > tls session and can take zero buffers even though get capacity returned > 0. > In this case the application will have to "unwind" any buffer > allocation/setup work it did expecting there was capacity available. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2622) TLS OpenSSL library: ensure capacity values match given capacity
[ https://issues.apache.org/jira/browse/PROTON-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616059#comment-17616059 ] Ken Giusti commented on PROTON-2622: Pull Request https://github.com/apache/qpid-proton/pull/380 > TLS OpenSSL library: ensure capacity values match given capacity > > > Key: PROTON-2622 > URL: https://issues.apache.org/jira/browse/PROTON-2622 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Affects Versions: proton-c-0.38.0 >Reporter: Ken Giusti >Priority: Major > > pn_tls_get_encrypt/decrypt_input_buffer_capacity() unconditionally return > the number of empty buffer slots. > However pn_tls_give_encrypt/decrypt_input_buffers() checks the state of the > tls session and can take zero buffers even though get capacity returned > 0. > In this case the application will have to "unwind" any buffer > allocation/setup work it did expecting there was capacity available. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
