[jira] [Commented] (QPID-3295) Under some conditions autoconf incorrectly detects that gcc doesn't support -Werror
[ https://issues.apache.org/jira/browse/QPID-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045588#comment-13045588 ] Andrew Stitcher commented on QPID-3295: --- Configure.ac uses the gl_COMPILER_FLAGS macro to test whether the compiler accepts a particular flag. However the program it uses to test compile has an unused variable in it. The program is: int main() { int x; ; return 0; } when compiled with -Wall -Werror this program reports an error and so autoconf thinks that -Werror isn't a valid flags for gcc Under some conditions autoconf incorrectly detects that gcc doesn't support -Werror --- Key: QPID-3295 URL: https://issues.apache.org/jira/browse/QPID-3295 Project: Qpid Issue Type: Bug Affects Versions: 0.8, 0.10 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Labels: autoconf, gcc If CFLAGS or CXXFLAGS contains -Wall when running configure, autoconf incorrectly detects that gcc doesn't support -Werror This is problematic because it is an important aspect of our policy that there should be no compiler warnings, and this bug stops this being enforced. Notably, the fedora package build has this issue and has been shipping with some unnoticed warnings for a while. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3295) Under some conditions autoconf incorrectly detects that gcc doesn't support -Werror
[ https://issues.apache.org/jira/browse/QPID-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045589#comment-13045589 ] Andrew Stitcher commented on QPID-3295: --- Since -Werror has been supported in every gcc version since at least 2.95 I think it's safe to enable -Werror unconditionally if the compiler is gcc. Under some conditions autoconf incorrectly detects that gcc doesn't support -Werror --- Key: QPID-3295 URL: https://issues.apache.org/jira/browse/QPID-3295 Project: Qpid Issue Type: Bug Affects Versions: 0.8, 0.10 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Labels: autoconf, gcc If CFLAGS or CXXFLAGS contains -Wall when running configure, autoconf incorrectly detects that gcc doesn't support -Werror This is problematic because it is an important aspect of our policy that there should be no compiler warnings, and this bug stops this being enforced. Notably, the fedora package build has this issue and has been shipping with some unnoticed warnings for a while. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org