[jira] [Commented] (QPID-3363) broker allows unbind on default exchange
[ https://issues.apache.org/jira/browse/QPID-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081565#comment-13081565 ] jirapos...@reviews.apache.org commented on QPID-3363: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/ --- Review request for Alan Conway and Kim van der Riet. Summary --- Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors. This addresses bug QPID-3363. https://issues.apache.org/jira/browse/QPID-3363 Diffs - /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 /trunk/qpid/cpp/src/tests/federation_sys.py 1155286 Diff: https://reviews.apache.org/r/1403/diff Testing --- New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes. Thanks, Gordon broker allows unbind on default exchange Key: QPID-3363 URL: https://issues.apache.org/jira/browse/QPID-3363 Project: Qpid Issue Type: Bug Affects Versions: 0.10, 0.12 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.13 Rule 'default-access' states The default exchange MUST NOT be accessible to the client except by specifying an empty exchange name in a content publish command (such as message.transfer). That is, the server must not let clients explicitly bind, unbind, delete, or make any other reference to this exchange. However qpid-config unbind my-queue my-queue will delete the binding preventing the queue from being directly accessed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3363) broker allows unbind on default exchange
[ https://issues.apache.org/jira/browse/QPID-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081573#comment-13081573 ] jirapos...@reviews.apache.org commented on QPID-3363: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/ --- (Updated 2011-08-09 11:34:40.107450) Review request for Alan Conway and Kim van der Riet. Changes --- Added new tests to the patch for review. Summary --- Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors. This addresses bug QPID-3363. https://issues.apache.org/jira/browse/QPID-3363 Diffs (updated) - /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 /trunk/qpid/cpp/src/tests/federation_sys.py 1155286 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/exchange.py 1155286 Diff: https://reviews.apache.org/r/1403/diff Testing --- New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes. Thanks, Gordon broker allows unbind on default exchange Key: QPID-3363 URL: https://issues.apache.org/jira/browse/QPID-3363 Project: Qpid Issue Type: Bug Affects Versions: 0.10, 0.12 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.13 Rule 'default-access' states The default exchange MUST NOT be accessible to the client except by specifying an empty exchange name in a content publish command (such as message.transfer). That is, the server must not let clients explicitly bind, unbind, delete, or make any other reference to this exchange. However qpid-config unbind my-queue my-queue will delete the binding preventing the queue from being directly accessed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3363) broker allows unbind on default exchange
[ https://issues.apache.org/jira/browse/QPID-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081596#comment-13081596 ] jirapos...@reviews.apache.org commented on QPID-3363: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/#review1341 --- Ship it! - Alan On 2011-08-09 11:34:40, Gordon Sim wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1403/ bq. --- bq. bq. (Updated 2011-08-09 11:34:40) bq. bq. bq. Review request for Alan Conway and Kim van der Riet. bq. bq. bq. Summary bq. --- bq. bq. Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors. bq. bq. bq. This addresses bug QPID-3363. bq. https://issues.apache.org/jira/browse/QPID-3363 bq. bq. bq. Diffs bq. - bq. bq./trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 bq./trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 bq./trunk/qpid/cpp/src/tests/federation_sys.py 1155286 bq./trunk/qpid/tests/src/py/qpid_tests/broker_0_10/exchange.py 1155286 bq. bq. Diff: https://reviews.apache.org/r/1403/diff bq. bq. bq. Testing bq. --- bq. bq. New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes. bq. bq. bq. Thanks, bq. bq. Gordon bq. bq. broker allows unbind on default exchange Key: QPID-3363 URL: https://issues.apache.org/jira/browse/QPID-3363 Project: Qpid Issue Type: Bug Affects Versions: 0.10, 0.12 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.13 Rule 'default-access' states The default exchange MUST NOT be accessible to the client except by specifying an empty exchange name in a content publish command (such as message.transfer). That is, the server must not let clients explicitly bind, unbind, delete, or make any other reference to this exchange. However qpid-config unbind my-queue my-queue will delete the binding preventing the queue from being directly accessed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
