[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
[ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505400#comment-13505400 ] Justin Ross commented on QPID-4468: --- Reviewed by Rob. Approve for 0.20. [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry Key: QPID-4468 URL: https://issues.apache.org/jira/browse/QPID-4468 Project: Qpid Issue Type: Improvement Components: Java Client Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.20, 0.21 On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level. Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused. It will be restored as an ovveride of ssl option in the brokerlist entries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
[ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505796#comment-13505796 ] Robbie Gemmell commented on QPID-4468: -- Now merged to the 0.20 release branch. [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry Key: QPID-4468 URL: https://issues.apache.org/jira/browse/QPID-4468 Project: Qpid Issue Type: Improvement Components: Java Client Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.20, 0.21 On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level. Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused. It will be restored as an ovveride of ssl option in the brokerlist entries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
[ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503503#comment-13503503 ] Robbie Gemmell commented on QPID-4468: -- Change made in http://svn.apache.org/viewvc?rev=1413364view=rev [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry Key: QPID-4468 URL: https://issues.apache.org/jira/browse/QPID-4468 Project: Qpid Issue Type: Improvement Components: Java Client Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.21 On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level. Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused. It will be restored as an ovveride of ssl option in the brokerlist entries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
[ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503512#comment-13503512 ] Robbie Gemmell commented on QPID-4468: -- I did consider doing it that way, but it was looking a little messy (the ConnectionSettings cant convey a lack of SSL option, so you then need to start looking at the BrokerDetails object as well, or switch ConnectionSettings to a Boolean to allow conveying null and add a Boolean getter instead of the boolean isUseSSL) and as you say it smacks of misconfiguration a little (I also considered throwing an Exception because of that). As its not really intended to be used together with the brokerlist option, but rather instead of it, in the end I decided just to document the overriding nature and leave it at that. [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry Key: QPID-4468 URL: https://issues.apache.org/jira/browse/QPID-4468 Project: Qpid Issue Type: Improvement Components: Java Client Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.21 On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level. Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused. It will be restored as an ovveride of ssl option in the brokerlist entries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
