[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)
[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688048#comment-13688048 ] ASF subversion and git services commented on QPID-4854: --- Commit 1494645 from [~gsim] [ https://svn.apache.org/r1494645 ] QPID-4854: signal connection establishment for broker initiated connections also max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway) -- Key: QPID-4854 URL: https://issues.apache.org/jira/browse/QPID-4854 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Andrew Stitcher Fix For: 0.23 It has assumptions based on 0-10 (and a particular pattern for 0-10 at that) built into the underlying transport code (which should be protocol agnostic). As AMQP 1.0 makes it much simpler and more likely for less synchronous handshaking, the '3 reads' magic doesn't work and causes 1.0 connections to be terminated incorrectly. Either the original solution needs to be reimplemented or it needs to be possible to disable it for use with 1.0. See QPID-4021 and QPID-2518. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)
[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676174#comment-13676174 ] ASF subversion and git services commented on QPID-4854: --- Commit 1489986 from [~astitcher] [ https://svn.apache.org/r1489986 ] QPID-4854: Removed use of intrusive_ptr::reset to work with older boost versions max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway) -- Key: QPID-4854 URL: https://issues.apache.org/jira/browse/QPID-4854 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Andrew Stitcher Fix For: 0.23 It has assumptions based on 0-10 (and a particular pattern for 0-10 at that) built into the underlying transport code (which should be protocol agnostic). As AMQP 1.0 makes it much simpler and more likely for less synchronous handshaking, the '3 reads' magic doesn't work and causes 1.0 connections to be terminated incorrectly. Either the original solution needs to be reimplemented or it needs to be possible to disable it for use with 1.0. See QPID-4021 and QPID-2518. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)
[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674438#comment-13674438 ] ASF subversion and git services commented on QPID-4854: --- Commit 1489458 from [~astitcher] [ https://svn.apache.org/r1489458 ] QPID-4854: Make the protocol negotiation timeout actually relate to the protocol negotiation! max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway) -- Key: QPID-4854 URL: https://issues.apache.org/jira/browse/QPID-4854 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Andrew Stitcher Fix For: Future It has assumptions based on 0-10 (and a particular pattern for 0-10 at that) built into the underlying transport code (which should be protocol agnostic). As AMQP 1.0 makes it much simpler and more likely for less synchronous handshaking, the '3 reads' magic doesn't work and causes 1.0 connections to be terminated incorrectly. Either the original solution needs to be reimplemented or it needs to be possible to disable it for use with 1.0. See QPID-4021 and QPID-2518. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)
[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1367#comment-1367 ] Andrew Stitcher commented on QPID-4854: --- Gordon's comment above made me think of an approach similar to his but adding a new hook into the OutputControl interface to tell the lower layer when to consider the connection fully established and so abort the potential timeout. This change is dependent on one of the cleanups in QPID-4905 which stops extra unnecessary classes from implementing the OutputControl interface and stops this change from affecting seemingly irrelevant code. max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway) -- Key: QPID-4854 URL: https://issues.apache.org/jira/browse/QPID-4854 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Andrew Stitcher Fix For: Future It has assumptions based on 0-10 (and a particular pattern for 0-10 at that) built into the underlying transport code (which should be protocol agnostic). As AMQP 1.0 makes it much simpler and more likely for less synchronous handshaking, the '3 reads' magic doesn't work and causes 1.0 connections to be terminated incorrectly. Either the original solution needs to be reimplemented or it needs to be possible to disable it for use with 1.0. See QPID-4021 and QPID-2518. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)
[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674657#comment-13674657 ] ASF subversion and git services commented on QPID-4854: --- Commit 1489545 from [~astitcher] [ https://svn.apache.org/r1489545 ] QPID-4854: Removed code now unused since this change max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway) -- Key: QPID-4854 URL: https://issues.apache.org/jira/browse/QPID-4854 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Andrew Stitcher Fix For: 0.23 It has assumptions based on 0-10 (and a particular pattern for 0-10 at that) built into the underlying transport code (which should be protocol agnostic). As AMQP 1.0 makes it much simpler and more likely for less synchronous handshaking, the '3 reads' magic doesn't work and causes 1.0 connections to be terminated incorrectly. Either the original solution needs to be reimplemented or it needs to be possible to disable it for use with 1.0. See QPID-4021 and QPID-2518. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
