[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688035#comment-13688035 ] ASF subversion and git services commented on QPID-4905: --- Commit 1494640 from [~astitcher] [ https://svn.apache.org/r1494640 ] QPID-4905: Stopped broker::Broker needing to refer to broker::Connection - Also removed ConnectionToken which didn't add anything over OwnershipToken C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688034#comment-13688034 ] ASF subversion and git services commented on QPID-4905: --- Commit 1494639 from [~astitcher] [ https://svn.apache.org/r1494639 ] QPID-4905: Tidy up broker::Connection - Clean up code for accounting for sent frames - merged Connection and ConnectionState into Connection C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688183#comment-13688183 ] ASF subversion and git services commented on QPID-4905: --- Commit 1494700 from [~astitcher] [ https://svn.apache.org/r1494700 ] QPID-4905: Add needed virtual destructor missed earlier C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: 0.23 There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679823#comment-13679823 ] ASF subversion and git services commented on QPID-4905: --- Commit 1491584 from [~astitcher] [ https://svn.apache.org/r1491584 ] QPID-4905: Remove unused Connection ErrorListener interface - was only used by removed cluster support C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679819#comment-13679819 ] ASF subversion and git services commented on QPID-4905: --- Commit 1491580 from [~astitcher] [ https://svn.apache.org/r1491580 ] QPID-4905: Tidy-up remove OutputHandler and directly use FrameHandler C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679818#comment-13679818 ] ASF subversion and git services commented on QPID-4905: --- Commit 1491579 from [~astitcher] [ https://svn.apache.org/r1491579 ] QPID-4905: Remove unused members in Connector interface C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679821#comment-13679821 ] ASF subversion and git services commented on QPID-4905: --- Commit 1491582 from [~astitcher] [ https://svn.apache.org/r1491582 ] QPID-4905: Remove unused function C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679824#comment-13679824 ] ASF subversion and git services commented on QPID-4905: --- Commit 1491585 from [~astitcher] [ https://svn.apache.org/r1491585 ] QPID-4905: Removed TimeoutHandler interface as it was really unused C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674437#comment-13674437 ] ASF subversion and git services commented on QPID-4905: --- Commit 1489457 from [~astitcher] [ https://svn.apache.org/r1489457 ] QPID-4905: Tidy up - Remove unused function getBuffered() of ConnectionOutputHandler - Stop SessionContext and AggregateOutput from needlessly implementing the OutputControl interface C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674466#comment-13674466 ] Andrew Stitcher commented on QPID-4905: --- client::Connector interface has 2 unused members: getShutdownHandler() getOutputHandler() C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674469#comment-13674469 ] Andrew Stitcher commented on QPID-4905: --- framing::OutputHandler has a comment: bq. // TODO aconway 2007-08-29: Replace with FrameHandler. and indeed the only function of the OutputHandler class is to change send() in the child classes into handle() in the parent class so we can remove OutputHandler completely and rename send()-handle(). C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674472#comment-13674472 ] Andrew Stitcher commented on QPID-4905: --- the federationLink bool member of broker::ConnectionState is only ever set and never queried or otherwise used, so can be removed. C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674478#comment-13674478 ] Andrew Stitcher commented on QPID-4905: --- In broker::ConnectionState setOutputHandler() in never used. C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674479#comment-13674479 ] Andrew Stitcher commented on QPID-4905: --- In broker::Connection eachSessionHandler() is never used. C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674482#comment-13674482 ] Andrew Stitcher commented on QPID-4905: --- In broker::Connection, broker::ConnectionHandler, broker::SessionHandler the errorListener mechanism seems unnecessary as it is not used by anyone. I assume that old cluster used it but now no one does. C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674484#comment-13674484 ] Andrew Stitcher commented on QPID-4905: --- The interface sys::Timeout is not really used as an interface in itself anymore. The member idleOut() is never called anywhere. The member idleIn() is called once as part of a timer callback, however this time callback can just as easily call the actual implementing class as it is in the same file anyway. C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674488#comment-13674488 ] Andrew Stitcher commented on QPID-4905: --- Separating broker::Connection and broker::ConnectionState seems arbitrary and makes some of the code awkward. Unifying these classes seems to make the code simpler. C++ Broker/common code needs tidying up of obsolete/unused code --- Key: QPID-4905 URL: https://issues.apache.org/jira/browse/QPID-4905 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Reporter: Andrew Stitcher Assignee: Andrew Stitcher There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix). In the name of easier code maintenance we should remove it. I will detail some of the things I have found as comments to this JIRA, if they attract sufficient comment they can be broken out as subtasks to this issue. Most of these issues are small and involve unused member functions or unused/potentially unused interfaces or interfaces implemented unnecessarily. Much of this is still the fallout of removing the old cluster work which added hook (and hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain, but are unused anywhere. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
