[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391257#comment-14391257 ] Scott Nicol commented on QPID-5870: --- Can you mark this as affect java client version 0.28 and fixed in 0.30. Closing a topic consumer should delete its exclusive auto-delete queue -- Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid Issue Type: Bug Reporter: Rajith Attapattu Attachments: QPID-5870.part2.patch, QPID-5870.patch When a topic consumer is closed, the subscription queue needs to be closed as well. Currently this queue is only deleted when the session is closed (due to being marked auto-deleted). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055304#comment-14055304 ] Rajith Attapattu commented on QPID-5870: but I wonder what happens around e.g. DurableSubscriptions, are they handled appropriately? Needs some tests. The testDurableSubscription in AddressBasedDestination test verifies this change. If you run the test without part2 of the patch is fails. Closing a topic consumer should delete its exclusive auto-delete queue -- Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid Issue Type: Bug Reporter: Rajith Attapattu Attachments: QPID-5870.part2.patch, QPID-5870.patch When a topic consumer is closed, the subscription queue needs to be closed as well. Currently this queue is only deleted when the session is closed (due to being marked auto-deleted). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055652#comment-14055652 ] ASF subversion and git services commented on QPID-5870: --- Commit 1608971 from [~rajith] in branch 'qpid/trunk' [ https://svn.apache.org/r1608971 ] QPID-5870 A Consumer is now marked if it's using a durable subscription. The topic subscription queue is now deleted when the subscription ends unless it's marked as a durable-topic-subscription. Closing a topic consumer should delete its exclusive auto-delete queue -- Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid Issue Type: Bug Reporter: Rajith Attapattu Attachments: QPID-5870.part2.patch, QPID-5870.patch When a topic consumer is closed, the subscription queue needs to be closed as well. Currently this queue is only deleted when the session is closed (due to being marked auto-deleted). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052427#comment-14052427 ] Robbie Gemmell commented on QPID-5870: -- Seconding Keiths request for more detail. Most of the patch seems to be extracting parameters and adding another method, the key bit seems to be always calling 'deleteSubscriptionQueue' rather than only do so if the Address string said to delete always/receiver. I see that checks to ensure that it is a 'topic address', but I wonder what happens around e.g. DurableSubscriptions, are they handled appropriately? Needs some tests. Closing a topic consumer should delete its exclusive auto-delete queue -- Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid Issue Type: Bug Reporter: Rajith Attapattu Attachments: QPID-5870.patch When a topic consumer is closed, the subscription queue needs to be closed as well. Currently this queue is only deleted when the session is closed (due to being marked auto-deleted). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052523#comment-14052523 ] Rajith Attapattu commented on QPID-5870: Again I apologize for not providing enough context. Yes the key change here is deleteSubscriptionQueue is always being called. This is to bring the JMS client inline with the address spec. This is something requested by customers and IMO it is the correct behavior as well. The delete directive should only apply for node properties (like the exchange or queue being created). The subscription queue should not exist beyond the subscription except in the case of durable subscriptions. I will make sure the durable subscriptions aren't affected. Closing a topic consumer should delete its exclusive auto-delete queue -- Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid Issue Type: Bug Reporter: Rajith Attapattu Attachments: QPID-5870.patch When a topic consumer is closed, the subscription queue needs to be closed as well. Currently this queue is only deleted when the session is closed (due to being marked auto-deleted). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051910#comment-14051910 ] Keith Wall commented on QPID-5870: -- Hi Rajith, I'm curious about the background to this defect - please could you add some detail. When you make the assertion 'when a topic consumer is closed, the subscription queue needs to be closed as well' where does this come from? Is this a 0-10 spec? A defect in the support for ADDR address format? cheers Keith. Closing a topic consumer should delete its exclusive auto-delete queue -- Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid Issue Type: Bug Reporter: Rajith Attapattu Attachments: QPID-5870.patch When a topic consumer is closed, the subscription queue needs to be closed as well. Currently this queue is only deleted when the session is closed (due to being marked auto-deleted). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
