[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210960#comment-16210960 ] Keith Wall commented on QPID-7799: -- Additional look okay to me. > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209483#comment-16209483 ] Alex Rudyy commented on QPID-7799: -- Keith, Changes in [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=51764e7 ] and [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4cfa7c3 ] look good to me. However, I implemented some minor fixes and improvements in [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=cec1954 ] and [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=06a3072 ]. Additionally, I modified configuration store upgraders (for broker abd VH) in [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=d253bea ] to upgrade the statistics settings from 6.1 to 7.0. Please, review > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209359#comment-16209359 ] ASF subversion and git services commented on QPID-7799: --- Commit cec195436a4547cff7c652d4689faf902942b818 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=cec1954 ] QPID-7799: [Java Broker] Fix typos and improve documentation for statistics reporting > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209362#comment-16209362 ] ASF subversion and git services commented on QPID-7799: --- Commit d253bea18fb976ec7868e12e1867698211a51afb in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=d253bea ] QPID-7799: [Java Broker] Modify broker and virtual host store upgraders to add statistics related context variables and logging rules > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209361#comment-16209361 ] ASF subversion and git services commented on QPID-7799: --- Commit 06a30729357dce56da9c27c0aa252eed1b7388df in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=06a3072 ] QPID-7799: [Java Broker] Remove duplicate code > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205481#comment-16205481 ] ASF subversion and git services commented on QPID-7799: --- Commit 4cfa7c30f149cd4e8fbc02b267e15859699bcfce in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4cfa7c3 ] QPID-7799: [Statistics Reporting] Have the statistic reporting task traverse associated children (i.e. connections associated with virtualhosts) too. > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205101#comment-16205101 ] Keith Wall commented on QPID-7799: -- Changes at 538c917, d8e033a and 51764e7 look reasonable to me. > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205100#comment-16205100 ] ASF subversion and git services commented on QPID-7799: --- Commit 51764e7349a01dbbaf7f1af610d8db660d75e2cf in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=51764e7 ] QPID-7799: [Statistics Reporting] [Documentation] Add statistics reporting documentation > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201794#comment-16201794 ] ASF subversion and git services commented on QPID-7799: --- Commit d8e033abc5a228fa5e4de18ec7e4a6aa700dc2bf in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=d8e033a ] QPID-7799: [Java Broker] Introduce operation to set and remove individual context variable > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201709#comment-16201709 ] ASF subversion and git services commented on QPID-7799: --- Commit 538c917e6c3252e9c6f482e783007c031b2a56d1 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=538c917 ] QPID-7799: [Java Broker] Replace StatisticsCounters with AtomicLongs and remove statistics reset functionality > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200093#comment-16200093
]
Alex Rudyy commented on QPID-7799:
--
After discussion with Keith we agreed to base the solution for periodic dump of
statistics on context variables as implemented by Keith rather than on approach
suggested by me where an introduction of separate fields to keep the statistics
settings would be required. If end-user will find the implementation difficult
to use we can refactor and improve the statistics reporting in the future
versions of Qpid Broker.
Additionally we agreed to implement the following changes in order to finish
the task:
* add configured object operations to set individual context variable and
remove it ({{ConfiguredObject#putContextVariable(String name, Object
value)}},({{ConfiguredObject#removeContextVariable(String name)}} ). They can
be used to enable/disable statistics reporting.
* add documentation about statistics reporting and how to build expressions for
statistics reporting context variables.
* remove statistic reset functionality
* replace {{StatisticsCounter}} with {{AtomicLong}}
The latter will remove the current functionality for evaluation and reporting
of rate, peak value, etc. However, the end users can do it themselves by
periodically calling existing REST API, accumulating the statistics data and
performing evaluation using accumulated statistics data.
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
> group, the configuration applied to objects belonging to a virtualhost must
> survive a mastership change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199159#comment-16199159
]
Keith Wall commented on QPID-7799:
--
Hi Alex
Thanks for the feedback.
The implementation (notedly the decision to drive from a context variables) was
driven by two of the requirements stated in the JIRA description above:
# the ability to produce statistics for either all objects of a *given
category* or a *single object instance*. The target object might be ephemeral
(i.e. non-durable).The use cases I have in mind are, say, the ability to
turn on logging for a single existing connection (non-durable), or a single
queue (durable or non) for diagnostic purposes, without turning on logging for
all connections or all queues.
# the ability to enable/disable/reconfigure statistics logging at runtime,
without restarting the Broker or Virtualhosts.
I assume your idea is to have a {{statisticLogging}} attribute on Broker and
Virtualhost with structured content specifying what statistics need to be
logged for their pat of the tree. This doesn't work well for ephemerals object
like connections or non-durable queues. It would be weird to record references
to ephemeral objects in the attribute. What would be responsible for
cleaning up the dangling references? It was this problem that drove me to
the context variables based implementation.
I did consider exposing the object's statisticsReportPattern as a attribute on
the object itself. However, the need to turn on statistics logging for, say all
queues,. would mean the attribute would have needed special behaviour and be
unlike other attributes. For instance, say I wanted to turn on statistics
logging for all queues. How would the existing queues get the new
configuration? This would require special casing so is unappealing.
>...segregated formatting...
I suppose this is a matter of taste. I wanted the user to be in control of the
log format string so they could make it as verbose or terse as they like and
chose between raw values or human readable strings.
> StatisticsReportingTask looks for the settings in the context every time
The alternative is to somehow listen to the entire tree for context variable
changes and update local reference. I think that statistic reporting period
will be typically be minutes. I don't think the cost of the context variable
access is a concern.
> Statistics logging requires pre-created logging rule for logger
> qpid.statistics.*"
I think automatically adding and removing a rule would be surprising to the
user.
> Additionally, the implementation only allows to enable reporting per category
> basis.
No, that is not correct. See test
org.apache.qpid.server.stats.StatisticsReportingTest#testVirtualHostStatistics
which illustrates turning the stats reporting on for an existing object.
> I am not sure about replacing StatisticsCounter with AtomicLongs as that
> might create a problem with updating statistics from multiple threads
Why would there be threading concerns? We are currently only using
StatisticsCounter for its ability to count deliveries/bytes etc. Underneath, it
is calculating peak and rates, but we never expose this information. I think
we need these features, so it looks to me like StatisticsCounter could be
mechanically swapped for a AtomicLong.
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
> group, the configuration applied to objects belonging to a virtualhost must
> survive a mastership change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198721#comment-16198721
]
Alex Rudyy commented on QPID-7799:
--
Here my review comments
* The usage of context variables ( there names and values used in implemented
functionality to dump of statistics into logs) are inconsistent with the rest
of the broker
** {{qpid..statisticsReportPattern}} - the name should indicate
that it is for logging of the statistics into the logs.
** the above includes the category class in the name. Would it be preferable to
specify the category in the value and serialize the categories and their
patterns as map? IMHO, using map would be consistent with other broker code.
Though, editing of the map serialized as json string would be difficult for the
end user, thus, introduction of a separate managed attribute having type either
List or Map would be more advantageous. Another argument for introduction of
the separate attribute would be a state of our context editor - locating
statistics settings there could be a challenging task :) A third argument
against using context variables is that context variables represent the
settings which should not be really used by the end user or used in exceptional
situations. Statistics logging settings do not belong to this category.
** segregated formatting looks unusual. It also overlaps with the statistics
units. It seems that formatting should be simply represented as boolean flag;
if set, the output is provided in human readable format and units to display
should be taken from the statistics declaration.
* StatisticsReportingTask looks for the settings in the context every time.
IMHO, the settings can be detected in the constructor and re-used in the
invocation of the task. When settings are changed the task can be recreated.
Using dedicated attributes for statistics logging would simplify the task
creation.
* Statistics logging requires pre-created logging rule for logger
qpid.statistics.*". Potentially, rule can be added automatically and removed
automatically on adding and removing statistics settings.
* Additionally, the implementation only allows to enable reporting per category
basis. If only statistics for certain queues is required, more changes would be
needed for implementation. IMHO, the more flexible solution could be
implemented using
** sperate statistic settings attribute
** the value can include multiple statistic criteria allowing to specify the
statistic names to report, whether human readable formatting is required,
category or a name of the object to report statistics for. For example,
{code:javascript}
"statisticsLogging" : [
{
category: "Connection",
statistics: ["lastIoTime", "bytesIn", "bytesOut", "messagesIn",
"messagesOut"],
humanReadeble: true
},
{
name: "myQueue",
category: "Queue",
statistics: ["queueDepthBytes", "queueDepthMessages"],
humanReadeble: true
}
]
{code}
or
{code:javascript}
"statisticsLogging" : {
{
"Connection": { humanReadable: true, statistics: ["lastIoTime",
"bytesIn", "bytesOut", "messagesIn", "messagesOut"], name="*"},
"Queue": { humanReadable: true, statistics: ["queueDepthBytes",
"queueDepthMessages"], name: "myQueue"}
}
{code}
Alternately, where conditions similar for query where conditions can be
introduced to report statistics.
* I am not sure about replacing StatisticsCounter with AtomicLongs as that
might create a problem with updating statistics from multiple threads. For
example, updating of virtual host inbound and outbound statistics would need to
be synchronized somehow.
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
> group, the configuration applied to objects belonging to a virtualhost must
> survive a mastership change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197644#comment-16197644 ] ASF subversion and git services commented on QPID-7799: --- Commit c6290661fd0211f38e2fc318c7ac61b00d8047fa in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c629066 ] QPID-7799: [Java Broker] Improve statistics reporting * Allows any configured object model statistic to be reported. * Reported statistics configured by the user using a format string * Statistic reporting driven from both the Broker and Virtualhost level * Enableable and configurable at runtime without the need to restart the Broker or the Virtualhost. * Statistic reporting can be enabled dynamically at runtime without restarting Broker or > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187167#comment-16187167
]
Keith Wall commented on QPID-7799:
--
Patch is now reviewable.
It gives the Broker and Virtualhost the responsibility for periodically writing
user-specific model statistics to the log. Statistic reporting can be enabled
dynamically without the need for a Broker or Virtualhost restart. The
statistics that are reported are also modifiable on the fly.
The user controls the reported statistics using a context variable named in the
following form {{qpid..statisticsReportPattern}} which, as
normal, can come from the environment, the object itself or an ancestor. This
approach gives the flexibility for statistic reporting to be enabled category
class wide (e.g. all queues) or for a single object instance. The context
value is free text with placeholders to interpolate statistic values e.g.
{{messagesIn=$\{messagesIn\}}}. There's provision for
datetime/duration/byteunit formatting to help the readability of the report
{{bytessIn=$\{bytesIn:bytevalue\}}}. {{ancestor}} references can be used to
interpolate object names into the statistics lines to add object and parent
names.
There are some parts missing from the patch. I want to hear comments first:
# Currently when setting a context variable from the REST API, the user is
required to PUT an object's context map. This runs the risk that the user will
accidentally lose an unrelated context value whilst trying to apply a statistic
context variable. We should add ConfiuredObject managed operations to allow a
context variable to be put/got/removed.
# Broker#resetStatistics should either be refactored so all statistics are
reset and have an analogous method on Virtualhost, or we should kill the
feature. I'm in favour of the latter.
# I killed {{statisticsReportingResetEnabled}} already but haven't added a
upgrader to remove the attribute value.
# This patch makes {{StatisticsCounter}} unnecessary. It should be replaced
with a simple AtomicLongs.
# Docs
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
> group, the configuration applied to objects belonging to a virtualhost must
> survive a mastership change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
