[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2019-12-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996593#comment-16996593
 ] 

ASF GitHub Bot commented on QPID-8187:
--

chrisrichardson77 commented on pull request #17: QPID-8187 Allow incompatible 
function casts for SASL compatibility (GCC 8 onwards)
URL: https://github.com/apache/qpid-cpp/pull/17
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Assignee: Justin Ross
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-10-21 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658402#comment-16658402
 ] 

ASF GitHub Bot commented on QPID-8187:
--

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/17
  
My mistake.  It's actually committed at 
https://github.com/apache/qpid-cpp/commit/706b5f3fb2fd4bb89ef8268575a8592b7b66272e


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Assignee: Justin Ross
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-10-21 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658399#comment-16658399
 ] 

ASF GitHub Bot commented on QPID-8187:
--

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/17
  
@chrisrichardson77 , this one is on master at


https://github.com/apache/qpid-cpp/commit/8b09d246f2529ea59809cac743e55af3920b4895

Would you close the PR?


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Assignee: Justin Ross
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-13 Thread Justin Ross (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473588#comment-16473588
 ] 

Justin Ross commented on QPID-8187:
---

I've applied Chris's fix.  I'll leave this open for now in case we can find a 
way to avoid the warning altogether.

> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Assignee: Justin Ross
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473538#comment-16473538
 ] 

ASF subversion and git services commented on QPID-8187:
---

Commit 706b5f3fb2fd4bb89ef8268575a8592b7b66272e in qpid-cpp's branch 
refs/heads/master from [~crichardson]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=706b5f3 ]

QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 
onwards)


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473537#comment-16473537
 ] 

ASF subversion and git services commented on QPID-8187:
---

Commit 2b462eb330fc863d12e6135933627addcbe1275b in qpid-cpp's branch 
refs/heads/master from [~crichardson]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=2b462eb ]

QPID-8187 CMakeLists.txt indent corrections


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470431#comment-16470431
 ] 

ASF GitHub Bot commented on QPID-8187:
--

GitHub user chrisrichardson77 opened a pull request:

https://github.com/apache/qpid-cpp/pull/17

QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 
onwards)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fourceu/qpid-cpp QPID-8187

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit e80a52e674d9692dae2fdfcdb3843a572251f792
Author: Chris Richardson 
Date:   2018-05-10T14:07:38Z

QPID-8187 CMakeLists.txt indent corrections

commit bed1f29ebe52924da7e8fb62cd7a839104565c9d
Author: Chris Richardson 
Date:   2018-05-10T14:08:12Z

QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 
onwards)




> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470423#comment-16470423
 ] 

ASF GitHub Bot commented on QPID-8187:
--

Github user chrisrichardson77 closed the pull request at:

https://github.com/apache/qpid-cpp/pull/16


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470421#comment-16470421
 ] 

ASF GitHub Bot commented on QPID-8187:
--

GitHub user chrisrichardson77 opened a pull request:

https://github.com/apache/qpid-cpp/pull/16

QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 
onwards)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fourceu/qpid-cpp QPID-8187

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit e80a52e674d9692dae2fdfcdb3843a572251f792
Author: Chris Richardson 
Date:   2018-05-10T14:07:38Z

QPID-8187 CMakeLists.txt indent corrections

commit 1d713e60643d4557b46e235e7293350d072f6132
Author: Chris Richardson 
Date:   2018-05-10T14:08:12Z

QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 
onwards)




> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470336#comment-16470336
 ] 

ASF GitHub Bot commented on QPID-8187:
--

Github user chrisrichardson77 commented on the issue:

https://github.com/apache/qpid-cpp/pull/15
  
-1, fails on older compiler versions.


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470335#comment-16470335
 ] 

ASF GitHub Bot commented on QPID-8187:
--

Github user chrisrichardson77 closed the pull request at:

https://github.com/apache/qpid-cpp/pull/15


> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8187) Incompatible callback function pointer casts fail to build on GCC 8

2018-05-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470334#comment-16470334
 ] 

ASF GitHub Bot commented on QPID-8187:
--

GitHub user chrisrichardson77 opened a pull request:

https://github.com/apache/qpid-cpp/pull/15

QPID-8187 Allow incompatible function casts for SASL compatibility



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fourceu/qpid-cpp QPID-8187

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit f5ec513d3a14e202bbeef867f58948df0d71d498
Author: Chris Richardson 
Date:   2018-05-10T12:35:21Z

QPID-8187 Allow incompatible function casts for SASL compatibility




> Incompatible callback function pointer casts fail to build on GCC 8
> ---
>
> Key: QPID-8187
> URL: https://issues.apache.org/jira/browse/QPID-8187
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> {quote}[ 22%] Building CXX object 
> src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In 
> constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const 
> string&, const string&, int, int, bool)’:
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: 
> error: cast between incompatible function types from ‘int (*)(void*, int, 
> const char**, unsigned int*)’ to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~~
>  /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: 
> error: cast between incompatible function types from ‘int (*)(sasl_conn_t*, 
> void*, int, sasl_secret_t**)’
> Unknown macro: \{aka ‘int (*)(sasl_conn*, void*, int, sasl_secret**)’}
> to ‘int (*)()’ [-Werror=cast-function-type]
>  callbacks[i].proc = (CallbackProc*) 
>  ^~ 
> {quote}
> Given the constrains of the SASL library interface, the only obvious solution 
> for this I can think of is to add "-Wno-error=cast-function-type" to the 
> compiler settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org