[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402864#comment-17402864
]
Alex Rudyy commented on QPID-8523:
--
The JIRA is de-scoped from version 8.0.6
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: qpid-java-broker-8.0.7
>
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363568#comment-17363568
]
Robbie Gemmell commented on QPID-8523:
--
Ok. I resolved it since the initial report was actually resolved, but feel free
to repurpose for considering the other aspect later.
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: qpid-java-broker-8.0.6
>
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363550#comment-17363550
]
Alex Rudyy commented on QPID-8523:
--
Hi [~robbie],
Thanks for a prompt reply about the change and providing hints how to reproduce
the issue. We will look into a proper fix for the reported behaviour. For now,
I would like to de-scope this JIRA from 8.0.5 release. We will try to implement
the fix in next 8.0.6 release.
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363503#comment-17363503
]
Robbie Gemmell commented on QPID-8523:
--
The changes resolve the initially observed issue, though functionally things
remain about the same as before, since this just lets things proceed long
enough for it to be seen the broker actually kills the session itself.
With the client no longer fouling on the invalid attach encoding and killing
the connection on its own, some subsequent activity was then revealed. The
client pipelined a flow of credit with the receiver attach, and the broker then
tears down the session itself after the link refusal to non-existing address
with an errant link error. Its perhaps slightly debatable that this is what the
spec says to do since it discusses it separate to link refusal. The general
behaviour it is what all the proton-c based clients clients have done for a
decade though and I probably don't see that changing given how they work (and
now the ProtonJ2 imperative client does the same and was used to discover this
issue, it could perhaps change more easily). Functionality, I think it might be
nicer for the broker to ignore a flow in this case given its the brokers
decision to send anything which it clearly wont and clients will know that when
they eventually receive the attach+detach and send their own detach, so tearing
down the session in this case mostly just seems to make things more awkward.
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363469#comment-17363469
]
ASF subversion and git services commented on QPID-8523:
---
Commit e04f933c2fe223624b9921d00f11e4e8bb6a74d1 in qpid-broker-j's branch
refs/heads/8.0.x from Dedeepya T
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=e04f933 ]
QPID-8523:[Broker-J] Set initial-delivery-count in a response attach when
destination is not found
This closes #92
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363470#comment-17363470
]
ASF subversion and git services commented on QPID-8523:
---
Commit 32df27b195cc6398161d82b1398a858e4a8d2045 in qpid-broker-j's branch
refs/heads/8.0.x from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=32df27b ]
QPID-8523:[Broker-J] Set initial-delivery-count in a response attach only when
role is a sender
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363468#comment-17363468
]
ASF GitHub Bot commented on QPID-8523:
--
asfgit closed pull request #92:
URL: https://github.com/apache/qpid-broker-j/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363466#comment-17363466
]
ASF subversion and git services commented on QPID-8523:
---
Commit e561dcdd236e8d30de2e2138831798512776bfce in qpid-broker-j's branch
refs/heads/main from Dedeepya T
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=e561dcd ]
QPID-8523:[Broker-J] Set initial-delivery-count in a response attach when
destination is not found
This closes #92
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363467#comment-17363467
]
ASF subversion and git services commented on QPID-8523:
---
Commit 3f44105f80ac52e493d028c0cc43d861c55add62 in qpid-broker-j's branch
refs/heads/main from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=3f44105 ]
QPID-8523:[Broker-J] Set initial-delivery-count in a response attach only when
role is a sender
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362949#comment-17362949
]
ASF GitHub Bot commented on QPID-8523:
--
Dedeepya-T opened a new pull request #92:
URL: https://github.com/apache/qpid-broker-j/pull/92
Set initial delivery count to zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
