[jira] [Commented] (QPID-8657) [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state

2023-12-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796084#comment-17796084
 ] 

ASF GitHub Bot commented on QPID-8657:
--

vavrtom merged PR #229:
URL: https://github.com/apache/qpid-broker-j/pull/229




> [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal 
> state
> ---
>
> Key: QPID-8657
> URL: https://issues.apache.org/jira/browse/QPID-8657
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-9.0.0
>Reporter: Kyrre
>Priority: Minor
> Fix For: qpid-java-broker-9.1.1
>
> Attachments: aclRequest.json, qpidErrorLog.txt, resultingAcl.json
>
>
> When POSTing an ACL rule with unknown attributes to the Qpid HTTP management 
> API, the server responds with HTTP 422, Unprocessable Entity. This is 
> somewhat OK, however, I think maybe a 400 Bad Request would be more 
> appropriate.
> But after the post, the broker is somehow left in a bad internal state, as 
> the returned Json is incomplete and unparseable.
> Example POST in [^aclRequest.json]
> Qpid log from the incident [^qpidErrorLog.txt]
> Returned Json from subsequent GET [^resultingAcl.json]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8657) [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state

2023-12-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796085#comment-17796085
 ] 

ASF subversion and git services commented on QPID-8657:
---

Commit 1bc24137d82338a6137c42a97ef13df3bdd1b5d3 in qpid-broker-j's branch 
refs/heads/main from Daniil Kirilyuk
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=1bc24137d8 ]

QPID-8657: [Broker-J] ACL - Posting unknown attributes leaves broker in bad 
internal state (#229)

* QPID-8657: [Broker-J] ACL - Posting unknown attributes leaves broker in bad 
internal state

* Updated formatting of RuleBasedVirtualHostAccessControlProviderImplTest.java

-

Co-authored-by: vavrtom 

> [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal 
> state
> ---
>
> Key: QPID-8657
> URL: https://issues.apache.org/jira/browse/QPID-8657
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-9.0.0
>Reporter: Kyrre
>Priority: Minor
> Fix For: qpid-java-broker-9.1.1
>
> Attachments: aclRequest.json, qpidErrorLog.txt, resultingAcl.json
>
>
> When POSTing an ACL rule with unknown attributes to the Qpid HTTP management 
> API, the server responds with HTTP 422, Unprocessable Entity. This is 
> somewhat OK, however, I think maybe a 400 Bad Request would be more 
> appropriate.
> But after the post, the broker is somehow left in a bad internal state, as 
> the returned Json is incomplete and unparseable.
> Example POST in [^aclRequest.json]
> Qpid log from the incident [^qpidErrorLog.txt]
> Returned Json from subsequent GET [^resultingAcl.json]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8657) [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/QPID-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793279#comment-17793279
 ] 

ASF GitHub Bot commented on QPID-8657:
--

dakirily opened a new pull request, #229:
URL: https://github.com/apache/qpid-broker-j/pull/229

   This PR addresses 
[QPID-8657](https://issues.apache.org/jira/browse/QPID-8657), fixing an issue 
with missing validation of ACL attributes




> [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal 
> state
> ---
>
> Key: QPID-8657
> URL: https://issues.apache.org/jira/browse/QPID-8657
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-9.0.0
>Reporter: Kyrre
>Priority: Minor
> Attachments: aclRequest.json, qpidErrorLog.txt, resultingAcl.json
>
>
> When POSTing an ACL rule with unknown attributes to the Qpid HTTP management 
> API, the server responds with HTTP 422, Unprocessable Entity. This is 
> somewhat OK, however, I think maybe a 400 Bad Request would be more 
> appropriate.
> But after the post, the broker is somehow left in a bad internal state, as 
> the returned Json is incomplete and unparseable.
> Example POST in [^aclRequest.json]
> Qpid log from the incident [^qpidErrorLog.txt]
> Returned Json from subsequent GET [^resultingAcl.json]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org