[jira] [Commented] (QPIDJMS-485) AmqpJmsBytesMessageFacade does not copy the content-type
[ https://issues.apache.org/jira/browse/QPIDJMS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035540#comment-17035540 ] ASF GitHub Bot commented on QPIDJMS-485: gemmellr commented on issue #34: QPIDJMS-485: copy of AMQP bytes message includes the content type URL: https://github.com/apache/qpid-jms/pull/34#issuecomment-585324499 I have made a different change via https://github.com/apache/qpid-jms/commit/a39599e376c82421e3e200188f46d3a652c4f63d to cover this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > AmqpJmsBytesMessageFacade does not copy the content-type > > > Key: QPIDJMS-485 > URL: https://issues.apache.org/jira/browse/QPIDJMS-485 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Jens Kordowski >Priority: Major > > AmqpJmsBytesMessageFacade hardcodes the content-type during the > copy-operation to application/octet-stream > > Proposal to copy the content-type as well (in the AmqpJmsMessageFacade) and > fall-back to application/octet-stream if no content-type was set > > I don't see any reason, why the content-type is not copied as well -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-485) AmqpJmsBytesMessageFacade does not copy the content-type
[ https://issues.apache.org/jira/browse/QPIDJMS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035525#comment-17035525 ] ASF subversion and git services commented on QPIDJMS-485: - Commit a39599e376c82421e3e200188f46d3a652c4f63d in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=a39599e ] QPIDJMS-485: move bytes message facade content-type handling to onSend, have copy simply copy > AmqpJmsBytesMessageFacade does not copy the content-type > > > Key: QPIDJMS-485 > URL: https://issues.apache.org/jira/browse/QPIDJMS-485 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Jens Kordowski >Priority: Major > > AmqpJmsBytesMessageFacade hardcodes the content-type during the > copy-operation to application/octet-stream > > Proposal to copy the content-type as well (in the AmqpJmsMessageFacade) and > fall-back to application/octet-stream if no content-type was set > > I don't see any reason, why the content-type is not copied as well -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-485) AmqpJmsBytesMessageFacade does not copy the content-type
[ https://issues.apache.org/jira/browse/QPIDJMS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020161#comment-17020161 ] ASF GitHub Bot commented on QPIDJMS-485: jenskordowski commented on pull request #34: QPIDJMS-485: copy of AMQP bytes message includes the content type URL: https://github.com/apache/qpid-jms/pull/34 copy method of AmqpJmsBytesMessageFacade copies the content-type, if existing and falls back to application/octet-stream if not existing (as before) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > AmqpJmsBytesMessageFacade does not copy the content-type > > > Key: QPIDJMS-485 > URL: https://issues.apache.org/jira/browse/QPIDJMS-485 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Jens Kordowski >Priority: Major > > AmqpJmsBytesMessageFacade hardcodes the content-type during the > copy-operation to application/octet-stream > > Proposal to copy the content-type as well (in the AmqpJmsMessageFacade) and > fall-back to application/octet-stream if no content-type was set > > I don't see any reason, why the content-type is not copied as well -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
