[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests
[ https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003629#comment-13003629 ] Robbie Gemmell commented on QPID-3125: -- Have you tried running 'ant report' after running the tests? Admitedly it isnt module-level as with your patch, but I actually find that preferable since it means you dont need to look in several different places to find the results. The seprate target doesnt force generation of the report files, which is useful if you dont actually want to generate them (I hardly ever do). Add junitreport task for readability in Java unit tests --- Key: QPID-3125 URL: https://issues.apache.org/jira/browse/QPID-3125 Project: Qpid Issue Type: Improvement Components: Java Tests Affects Versions: 0.11 Environment: All platforms. Area of functionality is Java based unit tests. Reporter: Weston M. Price Priority: Trivial Fix For: 0.11 Attachments: module.patch Original Estimate: 1h Remaining Estimate: 1h Currently when running the unit tests there is no real convenient way to see what has failed and why. The attached patch makes a modification to the module.xml file for the java tests to allow junit to print a report after the testsuite is run to output the results in html format. The results are placed into build/results/module-name/report/html where module name is one of client, common, systests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests
[ https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003633#comment-13003633 ] Rajith Attapattu commented on QPID-3125: I'd agree with Robbie. I would also prefer a separate target for report generation. I also prefer the current report format where I can see at a glance the failures, rather than having to go into each module. Add junitreport task for readability in Java unit tests --- Key: QPID-3125 URL: https://issues.apache.org/jira/browse/QPID-3125 Project: Qpid Issue Type: Improvement Components: Java Tests Affects Versions: 0.11 Environment: All platforms. Area of functionality is Java based unit tests. Reporter: Weston M. Price Priority: Trivial Fix For: 0.11 Attachments: module.patch Original Estimate: 1h Remaining Estimate: 1h Currently when running the unit tests there is no real convenient way to see what has failed and why. The attached patch makes a modification to the module.xml file for the java tests to allow junit to print a report after the testsuite is run to output the results in html format. The results are placed into build/results/module-name/report/html where module name is one of client, common, systests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests
[ https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003631#comment-13003631 ] Weston M. Price commented on QPID-3125: --- Yep, it certainly does. Agreed, I think this is a better approach as well. The only reason for the patch was the split between modules but I agree, it probably doesn't warrant a separate task. Add junitreport task for readability in Java unit tests --- Key: QPID-3125 URL: https://issues.apache.org/jira/browse/QPID-3125 Project: Qpid Issue Type: Improvement Components: Java Tests Affects Versions: 0.11 Environment: All platforms. Area of functionality is Java based unit tests. Reporter: Weston M. Price Priority: Trivial Fix For: 0.11 Attachments: module.patch Original Estimate: 1h Remaining Estimate: 1h Currently when running the unit tests there is no real convenient way to see what has failed and why. The attached patch makes a modification to the module.xml file for the java tests to allow junit to print a report after the testsuite is run to output the results in html format. The results are placed into build/results/module-name/report/html where module name is one of client, common, systests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests
[ https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003644#comment-13003644 ] Robbie Gemmell commented on QPID-3125: -- Whilst both myself and Rajith prefer the full set of results, that isnt to say we cant have both; I only object to the forced generation of results, I wouldnt actually be bothered by having e.g. 'report-module' as a new module-level build target that generated the alternative style results upon demand. To do that you would just need to add a module.xml level target and then use an iterator style target in build.xml (like most of the targets in the build system do) instead of adding it to the test task like your current patch. Add junitreport task for readability in Java unit tests --- Key: QPID-3125 URL: https://issues.apache.org/jira/browse/QPID-3125 Project: Qpid Issue Type: Improvement Components: Java Tests Affects Versions: 0.11 Environment: All platforms. Area of functionality is Java based unit tests. Reporter: Weston M. Price Priority: Trivial Fix For: 0.11 Attachments: module.patch Original Estimate: 1h Remaining Estimate: 1h Currently when running the unit tests there is no real convenient way to see what has failed and why. The attached patch makes a modification to the module.xml file for the java tests to allow junit to print a report after the testsuite is run to output the results in html format. The results are placed into build/results/module-name/report/html where module name is one of client, common, systests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests
[ https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003687#comment-13003687 ] Robbie Gemmell commented on QPID-3125: -- Just a couple small niggles: for clarity the new build.xml target should also just be 'report-module' so it aligns with the new module.xml task, and the line at module.xml ~L390 should not be removed. If you update the patch I'll commit it in the morning. Add junitreport task for readability in Java unit tests --- Key: QPID-3125 URL: https://issues.apache.org/jira/browse/QPID-3125 Project: Qpid Issue Type: Improvement Components: Java Tests Affects Versions: 0.11 Environment: All platforms. Area of functionality is Java based unit tests. Reporter: Weston M. Price Assignee: Robbie Gemmell Priority: Trivial Fix For: 0.11 Attachments: module.patch, report-module.patch Original Estimate: 1h Remaining Estimate: 1h Currently when running the unit tests there is no real convenient way to see what has failed and why. The attached patch makes a modification to the module.xml file for the java tests to allow junit to print a report after the testsuite is run to output the results in html format. The results are placed into build/results/module-name/report/html where module name is one of client, common, systests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests
[ https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003698#comment-13003698 ] Weston M. Price commented on QPID-3125: --- Thanks Robbie for both the guidance as well as looking at the patch. I am attaching the updated version. Add junitreport task for readability in Java unit tests --- Key: QPID-3125 URL: https://issues.apache.org/jira/browse/QPID-3125 Project: Qpid Issue Type: Improvement Components: Java Tests Affects Versions: 0.11 Environment: All platforms. Area of functionality is Java based unit tests. Reporter: Weston M. Price Assignee: Robbie Gemmell Priority: Trivial Fix For: 0.11 Attachments: module.patch, report-module.patch Original Estimate: 1h Remaining Estimate: 1h Currently when running the unit tests there is no real convenient way to see what has failed and why. The attached patch makes a modification to the module.xml file for the java tests to allow junit to print a report after the testsuite is run to output the results in html format. The results are placed into build/results/module-name/report/html where module name is one of client, common, systests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
