[jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
[ https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Huston updated QPID-2519: --- Attachment: QPID-2519.diff Patch against the point the trunk was branched; would replace orignal patch. I'll add this to the review site as well. Allow Windows Broker to run as a Service Key: QPID-2519 URL: https://issues.apache.org/jira/browse/QPID-2519 Project: Qpid Issue Type: New Feature Components: C++ Broker Environment: Windows Reporter: Kerry Bonin Assignee: Steve Huston Fix For: Future Attachments: QPID-2519.diff, broker_as_service_Qpid_Logging.patch, broker_as_service_r921371.patch The Windows version of the C++ Broker should have the ability to run as a Windows Service, to correspond with the ability of the *nix version to run as a daemon, as this is a common requirement for critical software infrastructure elements of enterprise class software on the Windows platform. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
[ https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Huston updated QPID-2519: --- Environment: Windows Fix Version/s: Future Assignee: Steve Huston Assigning this to me, but it's as time permits. If anyone has interest/time in moving this along quicker, please let me know and we'll coordinate a hand-off. Allow Windows Broker to run as a Service Key: QPID-2519 URL: https://issues.apache.org/jira/browse/QPID-2519 Project: Qpid Issue Type: New Feature Components: C++ Broker Environment: Windows Reporter: Kerry Bonin Assignee: Steve Huston Fix For: Future Attachments: broker_as_service_Qpid_Logging.patch, broker_as_service_r921371.patch The Windows version of the C++ Broker should have the ability to run as a Windows Service, to correspond with the ability of the *nix version to run as a daemon, as this is a common requirement for critical software infrastructure elements of enterprise class software on the Windows platform. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
Hi Kerry, Today i was able to reproduce the 1053 error on a windows server 2008 machine with the latest source version from 0.8 release branch. It seems like that qpid needs a windows profile. How to reproduce: 1) Create a new windows user with service rights. 2) Start qpid as service - won't start with error 1053 3) Login with the new created service account - windows profile will be created 4) Start qpid as service - success Br, Daniel From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Freitag, 19. November 2010 13:11 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service That is an old Windows broker problem - it tries to create its log at that location, if the process doesn't have permission it fails. You have to specify a location it has permission to create the log at, and I believe there is an option to disable logging. On Fri, Nov 19, 2010 at 4:48 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Today I merged my uploaded patch into the 0.8 rc branch on my local machine and tested it. Seems like that the account name issue is somehow solved. It's working for me fine. There is one issue: If no data-dir is provided the broker won't start. If you enable log to file you'll find the following entry: 2010-11-19 11:47:25 critical Unexpected error: Can't create directory: \TEMP\QPIDD.DATA From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Donnerstag, 18. November 2010 22:16 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service (although I do still need to look at the account name issue too, as I'd like to run it as NetworkService...) On Thu, Nov 18, 2010 at 2:31 PM, Kerry Bonin kerrybo...@gmail.commailto:kerrybo...@gmail.com wrote: I haven't returned to it yet, was rather busy, although it would be nice to get it into 0.8, especially if the only pending issue is code and logging style. I'll look for a reformatter, but we're shipping code using this patch, so I know it works well... On Thu, Nov 18, 2010 at 1:33 PM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Hi , Do you have further updates for this jira? Maybe we should try to force it to be commited for the next release Br, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Donnerstag, 30. September 2010 19:33 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Where I left off was trying to figure out why it ran fine using the default LocalService account, but if I tried telling it to run as LocalService it would fail. On Thu, Sep 30, 2010 at 9:29 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Why do you think it had to do with the service name string? -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 20:10 To: dev@qpid.apache.orgmailto:dev@qpid.apache.org Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service If you don't specify an account to run under, then it defaults (via SCM) to LocalService. If I try and specify LocalService then it I get that error, which led me to suspect it had to do with the service name string. On Mon, Sep 27, 2010 at 1:06 PM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: I tried it out to run it as LocalService but if I try to start the broker with service.mmc I 'll get the message: Windows could not start the qpidd service on Local Computer. Error 1053: The service did not respond to the start or control request in a timely fashion. There is also not qpid broker process running. Lg, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 19:18 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service By default I believe it runs as LocalService. I added support for the SCM API to allow specification of an alternative user, but when I tested it I couldn't get it to work as NetworkService. I suspect that was only because I wasn't specifying the user in the string format that SCM expected (something like {hostname}/{account name}), but I got distracted after playing for a few mins and haven't returned yet. On Mon, Sep 27, 2010 at 11:55 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Hi, Just a small question: Currently it's only possible for me to run the qpid-broker service under some user credentials which are not built in service users like: LocalSystem or NetworkService If we want to start the broker as LocalSystem it won't start with error 1503. Can you answer me why? We have tried
RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
Extension: On Server 2008 it seems like that if you don't login into the machine only a temp profile will be created during service startup. On Win7 a full userprofile is generated during start up. -Original Message- From: Daniel Sack [mailto:daniel.s...@techtalk.at] Sent: Donnerstag, 25. November 2010 13:14 To: Kerry Bonin Cc: dev@qpid.apache.org Subject: RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Hi Kerry, Today i was able to reproduce the 1053 error on a windows server 2008 machine with the latest source version from 0.8 release branch. It seems like that qpid needs a windows profile. How to reproduce: 1) Create a new windows user with service rights. 2) Start qpid as service - won't start with error 1053 3) Login with the new created service account - windows profile will be created 4) Start qpid as service - success Br, Daniel From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Freitag, 19. November 2010 13:11 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service That is an old Windows broker problem - it tries to create its log at that location, if the process doesn't have permission it fails. You have to specify a location it has permission to create the log at, and I believe there is an option to disable logging. On Fri, Nov 19, 2010 at 4:48 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Today I merged my uploaded patch into the 0.8 rc branch on my local machine and tested it. Seems like that the account name issue is somehow solved. It's working for me fine. There is one issue: If no data-dir is provided the broker won't start. If you enable log to file you'll find the following entry: 2010-11-19 11:47:25 critical Unexpected error: Can't create directory: \TEMP\QPIDD.DATA From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Donnerstag, 18. November 2010 22:16 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service (although I do still need to look at the account name issue too, as I'd like to run it as NetworkService...) On Thu, Nov 18, 2010 at 2:31 PM, Kerry Bonin kerrybo...@gmail.commailto:kerrybo...@gmail.com wrote: I haven't returned to it yet, was rather busy, although it would be nice to get it into 0.8, especially if the only pending issue is code and logging style. I'll look for a reformatter, but we're shipping code using this patch, so I know it works well... On Thu, Nov 18, 2010 at 1:33 PM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Hi , Do you have further updates for this jira? Maybe we should try to force it to be commited for the next release Br, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Donnerstag, 30. September 2010 19:33 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Where I left off was trying to figure out why it ran fine using the default LocalService account, but if I tried telling it to run as LocalService it would fail. On Thu, Sep 30, 2010 at 9:29 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Why do you think it had to do with the service name string? -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 20:10 To: dev@qpid.apache.orgmailto:dev@qpid.apache.org Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service If you don't specify an account to run under, then it defaults (via SCM) to LocalService. If I try and specify LocalService then it I get that error, which led me to suspect it had to do with the service name string. On Mon, Sep 27, 2010 at 1:06 PM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: I tried it out to run it as LocalService but if I try to start the broker with service.mmc I 'll get the message: Windows could not start the qpidd service on Local Computer. Error 1053: The service did not respond to the start or control request in a timely fashion. There is also not qpid broker process running. Lg, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 19:18 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service By default I believe it runs as LocalService. I added support for the SCM API to allow specification of an alternative user, but when I tested it I couldn't get it to work as NetworkService. I suspect that was only because I wasn't specifying the user in the string format that SCM expected (something like {hostname}/{account name}), but I got distracted after playing for a few mins and haven't
RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
Further Information: It seems like that the problem relies in the SslProtocolFactory implementation. So if the service account cannot access the cert storage, the service will crash with error 1053 (no access). Br, Daniel -Original Message- From: Daniel Sack [mailto:daniel.s...@techtalk.at] Sent: Donnerstag, 25. November 2010 13:18 To: dev@qpid.apache.org; Kerry Bonin Subject: RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Extension: On Server 2008 it seems like that if you don't login into the machine only a temp profile will be created during service startup. On Win7 a full userprofile is generated during start up. -Original Message- From: Daniel Sack [mailto:daniel.s...@techtalk.at] Sent: Donnerstag, 25. November 2010 13:14 To: Kerry Bonin Cc: dev@qpid.apache.org Subject: RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Hi Kerry, Today i was able to reproduce the 1053 error on a windows server 2008 machine with the latest source version from 0.8 release branch. It seems like that qpid needs a windows profile. How to reproduce: 1) Create a new windows user with service rights. 2) Start qpid as service - won't start with error 1053 3) Login with the new created service account - windows profile will be created 4) Start qpid as service - success Br, Daniel From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Freitag, 19. November 2010 13:11 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service That is an old Windows broker problem - it tries to create its log at that location, if the process doesn't have permission it fails. You have to specify a location it has permission to create the log at, and I believe there is an option to disable logging. On Fri, Nov 19, 2010 at 4:48 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Today I merged my uploaded patch into the 0.8 rc branch on my local machine and tested it. Seems like that the account name issue is somehow solved. It's working for me fine. There is one issue: If no data-dir is provided the broker won't start. If you enable log to file you'll find the following entry: 2010-11-19 11:47:25 critical Unexpected error: Can't create directory: \TEMP\QPIDD.DATA From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Donnerstag, 18. November 2010 22:16 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service (although I do still need to look at the account name issue too, as I'd like to run it as NetworkService...) On Thu, Nov 18, 2010 at 2:31 PM, Kerry Bonin kerrybo...@gmail.commailto:kerrybo...@gmail.com wrote: I haven't returned to it yet, was rather busy, although it would be nice to get it into 0.8, especially if the only pending issue is code and logging style. I'll look for a reformatter, but we're shipping code using this patch, so I know it works well... On Thu, Nov 18, 2010 at 1:33 PM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Hi , Do you have further updates for this jira? Maybe we should try to force it to be commited for the next release Br, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Donnerstag, 30. September 2010 19:33 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Where I left off was trying to figure out why it ran fine using the default LocalService account, but if I tried telling it to run as LocalService it would fail. On Thu, Sep 30, 2010 at 9:29 AM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: Why do you think it had to do with the service name string? -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 20:10 To: dev@qpid.apache.orgmailto:dev@qpid.apache.org Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service If you don't specify an account to run under, then it defaults (via SCM) to LocalService. If I try and specify LocalService then it I get that error, which led me to suspect it had to do with the service name string. On Mon, Sep 27, 2010 at 1:06 PM, Daniel Sack daniel.s...@techtalk.atmailto:daniel.s...@techtalk.at wrote: I tried it out to run it as LocalService but if I try to start the broker with service.mmc I 'll get the message: Windows could not start the qpidd service on Local Computer. Error 1053: The service did not respond to the start or control request in a timely fashion. There is also not qpid broker process running. Lg, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.commailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 19:18 To: Daniel Sack Subject: Re: [jira] Updated
Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
Thanks for working on this cleanup, I've been a bit swamped and haven't had time to return to change the style or fix the logging. For what its worth, we've been using this in a major product release in system test for a few months, zero issues on the service to date... On Mon, Sep 27, 2010 at 11:40 AM, Daniel Sack (JIRA) qpid-...@incubator.apache.org wrote: [ https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sack updated QPID-2519: -- Attachment: broker_as_service_Qpid_Logging.patch Hi, Scince we need this patch for our production system, I tried to implement parts of the comments 1. Please reformat according to Qpid coding style (http://qpid.apache.org/qpid-c-documentation.html) - no tabs, consistent brace style - didn't have the time for it 2. There's a global WinService in QpiddBroker.cpp - what's that for? - Responsible for all the daemon stuff which is needed for the windows platform. 3. Lots of printfs and no Qpid logging statements, and no exception throwing on error. Please review these and probably should be throwing on errors; outputs should probably be using logging to be redirected as the user specified. - triedto fix this Allow Windows Broker to run as a Service Key: QPID-2519 URL: https://issues.apache.org/jira/browse/QPID-2519 Project: Qpid Issue Type: New Feature Components: C++ Broker Reporter: Kerry Bonin Attachments: broker_as_service_Qpid_Logging.patch, broker_as_service_r921371.patch The Windows version of the C++ Broker should have the ability to run as a Windows Service, to correspond with the ability of the *nix version to run as a daemon, as this is a common requirement for critical software infrastructure elements of enterprise class software on the Windows platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
RE: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
I tried it out to run it as LocalService but if I try to start the broker with service.mmc I 'll get the message: Windows could not start the qpidd service on Local Computer. Error 1053: The service did not respond to the start or control request in a timely fashion. There is also not qpid broker process running. Lg, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 19:18 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service By default I believe it runs as LocalService. I added support for the SCM API to allow specification of an alternative user, but when I tested it I couldn't get it to work as NetworkService. I suspect that was only because I wasn't specifying the user in the string format that SCM expected (something like {hostname}/{account name}), but I got distracted after playing for a few mins and haven't returned yet. On Mon, Sep 27, 2010 at 11:55 AM, Daniel Sack daniel.s...@techtalk.at wrote: Hi, Just a small question: Currently it's only possible for me to run the qpid-broker service under some user credentials which are not built in service users like: LocalSystem or NetworkService If we want to start the broker as LocalSystem it won't start with error 1503. Can you answer me why? We have tried to use xyntservice (http://www.codeproject.com/KB/system/xyntservice.aspx) which was not really working with qpid 0.6 cpp broker. It' always crashed somewhere in kernel.dll with some corrupted heap, ... But we were able to run the broker as Local System account, maybe is the problem why the broker crashes, I don't know. Br, Daniel Sack -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 18:43 To: dev@qpid.apache.org Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Thanks for working on this cleanup, I've been a bit swamped and haven't had time to return to change the style or fix the logging. For what its worth, we've been using this in a major product release in system test for a few months, zero issues on the service to date... On Mon, Sep 27, 2010 at 11:40 AM, Daniel Sack (JIRA) qpid-...@incubator.apache.org wrote: [ https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.ji r a.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sack updated QPID-2519: -- Attachment: broker_as_service_Qpid_Logging.patch Hi, Scince we need this patch for our production system, I tried to implement parts of the comments 1. Please reformat according to Qpid coding style (http://qpid.apache.org/qpid-c-documentation.html) - no tabs, consistent brace style - didn't have the time for it 2. There's a global WinService in QpiddBroker.cpp - what's that for? - Responsible for all the daemon stuff which is needed for the windows platform. 3. Lots of printfs and no Qpid logging statements, and no exception throwing on error. Please review these and probably should be throwing on errors; outputs should probably be using logging to be redirected as the user specified. - triedto fix this Allow Windows Broker to run as a Service Key: QPID-2519 URL: https://issues.apache.org/jira/browse/QPID-2519 Project: Qpid Issue Type: New Feature Components: C++ Broker Reporter: Kerry Bonin Attachments: broker_as_service_Qpid_Logging.patch, broker_as_service_r921371.patch The Windows version of the C++ Broker should have the ability to run as a Windows Service, to correspond with the ability of the *nix version to run as a daemon, as this is a common requirement for critical software infrastructure elements of enterprise class software on the Windows platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service
If you don't specify an account to run under, then it defaults (via SCM) to LocalService. If I try and specify LocalService then it I get that error, which led me to suspect it had to do with the service name string. On Mon, Sep 27, 2010 at 1:06 PM, Daniel Sack daniel.s...@techtalk.at wrote: I tried it out to run it as LocalService but if I try to start the broker with service.mmc I 'll get the message: Windows could not start the qpidd service on Local Computer. Error 1053: The service did not respond to the start or control request in a timely fashion. There is also not qpid broker process running. Lg, Daniel -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 19:18 To: Daniel Sack Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service By default I believe it runs as LocalService. I added support for the SCM API to allow specification of an alternative user, but when I tested it I couldn't get it to work as NetworkService. I suspect that was only because I wasn't specifying the user in the string format that SCM expected (something like {hostname}/{account name}), but I got distracted after playing for a few mins and haven't returned yet. On Mon, Sep 27, 2010 at 11:55 AM, Daniel Sack daniel.s...@techtalk.at wrote: Hi, Just a small question: Currently it's only possible for me to run the qpid-broker service under some user credentials which are not built in service users like: LocalSystem or NetworkService If we want to start the broker as LocalSystem it won't start with error 1503. Can you answer me why? We have tried to use xyntservice (http://www.codeproject.com/KB/system/xyntservice.aspx) which was not really working with qpid 0.6 cpp broker. It' always crashed somewhere in kernel.dll with some corrupted heap, ... But we were able to run the broker as Local System account, maybe is the problem why the broker crashes, I don't know. Br, Daniel Sack -Original Message- From: Kerry Bonin [mailto:kerrybo...@gmail.com] Sent: Montag, 27. September 2010 18:43 To: dev@qpid.apache.org Subject: Re: [jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service Thanks for working on this cleanup, I've been a bit swamped and haven't had time to return to change the style or fix the logging. For what its worth, we've been using this in a major product release in system test for a few months, zero issues on the service to date... On Mon, Sep 27, 2010 at 11:40 AM, Daniel Sack (JIRA) qpid-...@incubator.apache.org wrote: [ https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.ji r a.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sack updated QPID-2519: -- Attachment: broker_as_service_Qpid_Logging.patch Hi, Scince we need this patch for our production system, I tried to implement parts of the comments 1. Please reformat according to Qpid coding style (http://qpid.apache.org/qpid-c-documentation.html) - no tabs, consistent brace style - didn't have the time for it 2. There's a global WinService in QpiddBroker.cpp - what's that for? - Responsible for all the daemon stuff which is needed for the windows platform. 3. Lots of printfs and no Qpid logging statements, and no exception throwing on error. Please review these and probably should be throwing on errors; outputs should probably be using logging to be redirected as the user specified. - triedto fix this Allow Windows Broker to run as a Service Key: QPID-2519 URL: https://issues.apache.org/jira/browse/QPID-2519 Project: Qpid Issue Type: New Feature Components: C++ Broker Reporter: Kerry Bonin Attachments: broker_as_service_Qpid_Logging.patch, broker_as_service_r921371.patch The Windows version of the C++ Broker should have the ability to run as a Windows Service, to correspond with the ability of the *nix version to run as a daemon, as this is a common requirement for critical software infrastructure elements of enterprise class software on the Windows platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact