Re: svn commit: r904566 - /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java

2010-02-01 Thread Martin Ritchie 
Rajith,

Can we have some tests to validate the these new SASL connections?

Cheers

Martin

On 29 January 2010 17:30,  raj...@apache.org wrote:
 Author: rajith
 Date: Fri Jan 29 17:30:39 2010
 New Revision: 904566

 URL: http://svn.apache.org/viewvc?rev=904566view=rev
 Log:
 Corrected a mistake I made in rev904375

 Modified:
    
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java

 Modified: 
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java
 URL: 
 http://svn.apache.org/viewvc/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java?rev=904566r1=904565r2=904566view=diff
 ==
 --- 
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java
  (original)
 +++ 
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java
  Fri Jan 29 17:30:39 2010
 @@ -72,7 +72,7 @@
     {
         Connection conn = connection();

 -        if (conn.getConnectionSettings() != null 
 +        if (conn.getConnectionSettings() != null 
             conn.getConnectionSettings().isUseSASLEncryption())
         {
             sender = new SASLSender(sender);
 @@ -87,7 +87,7 @@

     public ReceiverByteBuffer receiver(Connection conn)
     {
 -        if (conn.getConnectionSettings() != null 
 +        if (conn.getConnectionSettings() != null 
             conn.getConnectionSettings().isUseSASLEncryption())
         {
             SASLReceiver receiver = new SASLReceiver(new InputHandler(new 
 Assembler(conn)));



 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:commits-subscr...@qpid.apache.org





-- 
Martin Ritchie

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: svn commit: r904566 - /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java

2010-02-01 Thread Rajith Attapattu 
As mentioned in the original commit message, the SASL encryption is
not fully functional.
I committed the code in the hopes of working with the developers of
the c++ broker to diagnose the issue.
There is no harm due to it being inactive unless explicitly enabled.

As for tests, as soon as the issue is resolved, I will be adding a new
test profile similar to the SSL profile.

Rajith

On Mon, Feb 1, 2010 at 1:47 PM, Martin Ritchie ritch...@apache.org wrote:
 Rajith,

 Can we have some tests to validate the these new SASL connections?

 Cheers

 Martin

 On 29 January 2010 17:30,  raj...@apache.org wrote:
 Author: rajith
 Date: Fri Jan 29 17:30:39 2010
 New Revision: 904566

 URL: http://svn.apache.org/viewvc?rev=904566view=rev
 Log:
 Corrected a mistake I made in rev904375

 Modified:
    
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java

 Modified: 
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java
 URL: 
 http://svn.apache.org/viewvc/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java?rev=904566r1=904565r2=904566view=diff
 ==
 --- 
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java
  (original)
 +++ 
 qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/ConnectionBinding.java
  Fri Jan 29 17:30:39 2010
 @@ -72,7 +72,7 @@
     {
         Connection conn = connection();

 -        if (conn.getConnectionSettings() != null 
 +        if (conn.getConnectionSettings() != null 
             conn.getConnectionSettings().isUseSASLEncryption())
         {
             sender = new SASLSender(sender);
 @@ -87,7 +87,7 @@

     public ReceiverByteBuffer receiver(Connection conn)
     {
 -        if (conn.getConnectionSettings() != null 
 +        if (conn.getConnectionSettings() != null 
             conn.getConnectionSettings().isUseSASLEncryption())
         {
             SASLReceiver receiver = new SASLReceiver(new InputHandler(new 
 Assembler(conn)));



 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:commits-subscr...@qpid.apache.org





 --
 Martin Ritchie

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org





-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org