Re: Request for inclusion into the 0.22 branch
FWIW, while I'd like to see the additional testing done first I'd much rather the second change went into RC1 without the test changes than leave it the way it is on the 0.22 branch just now following the original change. Robbie On 27 Mar 2013 21:31, Justin Ross justin.r...@gmail.com wrote: Hi, Rajith. I read the jira comments, and it looks like a little more work is required before we put it on the release branch (the testing for the jndi case). On Wed, Mar 27, 2013 at 12:04 PM, Rajith Attapattu rajit...@gmail.com wrote: Sorry I forgot to include the JIRA in the email. Please see https://issues.apache.org/jira/browse/QPID-3769 for context. Rajith On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu rajit...@gmail.com wrote: Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Request for inclusion into the 0.22 branch
Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Request for inclusion into the 0.22 branch
Sorry I forgot to include the JIRA in the email. Please see https://issues.apache.org/jira/browse/QPID-3769 for context. Rajith On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu rajit...@gmail.com wrote: Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Request for inclusion into the 0.22 branch
Hi, Rajith. I read the jira comments, and it looks like a little more work is required before we put it on the release branch (the testing for the jndi case). On Wed, Mar 27, 2013 at 12:04 PM, Rajith Attapattu rajit...@gmail.com wrote: Sorry I forgot to include the JIRA in the email. Please see https://issues.apache.org/jira/browse/QPID-3769 for context. Rajith On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu rajit...@gmail.com wrote: Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Request for inclusion into the 0.22 branch
On Wed, Mar 27, 2013 at 5:31 PM, Justin Ross justin.r...@gmail.com wrote: Hi, Rajith. I read the jira comments, and it looks like a little more work is required before we put it on the release branch (the testing for the jndi case). Indeed, this review request is for the whole package :P I will email with the commit URL once the tests are committed. I'm sorting through something else at the moment. Rajith On Wed, Mar 27, 2013 at 12:04 PM, Rajith Attapattu rajit...@gmail.com wrote: Sorry I forgot to include the JIRA in the email. Please see https://issues.apache.org/jira/browse/QPID-3769 for context. Rajith On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu rajit...@gmail.com wrote: Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
