---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17451/#review32990
---
Ship it!
This looks fine to me. Having controls and limits on these settings provides
the same benefits as those controlling file size/count. The names are ok
- Chug Rolke
On Jan. 28, 2014, 10:04 a.m., Pavel Moravec wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17451/
---
(Updated Jan. 28, 2014, 10:04 a.m.)
Review request for qpid, Chug Rolke and Gordon Sim.
Bugs: https://issues.apache.org/jira/browse/QPID-5519
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5519
Repository: qpid
Description
---
Adding ACL queue create properties paging, pages[lower|upper]limit and
pagefactor[lower|upper]limit. See QPID-5519 for purpose of those parameters.
Please review especially if:
- you think pages / pagesfactor properties should / shall not be included
- naming/syntax used is fine (like pageslowerlimit or so)
Diffs
-
/trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1561994
/trunk/qpid/cpp/src/qpid/acl/AclValidator.cpp 1561994
/trunk/qpid/cpp/src/qpid/broker/AclModule.h 1561994
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1561994
Diff: https://reviews.apache.org/r/17451/diff/
Testing
---
Several tests run, verifying all the added properties.
Thanks,
Pavel Moravec
